140905 2015-01-26 15:09:25 -0800 Add match_constness<Reference, T> helper struct 2015-01-30 15:32:02 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez andersca benjamin cmarcelo commit-queue darin kling oldest_to_newest 1064278 0 cdumez 2015-01-26 15:09:25 -0800 Add match_constness<Reference, T> helper struct to simplify downcast<>() a bit. The purpose of this helper is to update T's constness to match Reference's. 1064279 1 245379 cdumez 2015-01-26 15:10:38 -0800 Created attachment 245379 Patch 1064790 2 cdumez 2015-01-27 20:38:33 -0800 ping review? 1065673 3 245379 benjamin 2015-01-30 15:28:53 -0800 Comment on attachment 245379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245379&action=review > Source/WTF/wtf/TypeCasts.h:72 > + typedef typename std::conditional<std::is_const<Reference>::value, typename std::add_const<T>::type, typename std::remove_const<T>::type>::type type; The last type should be Type. 1065675 4 245379 cdumez 2015-01-30 15:31:21 -0800 Comment on attachment 245379 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245379&action=review >> Source/WTF/wtf/TypeCasts.h:72 >> + typedef typename std::conditional<std::is_const<Reference>::value, typename std::add_const<T>::type, typename std::remove_const<T>::type>::type type; > > The last type should be Type. I kinda like the consistency with STL here. 1065676 5 245379 cdumez 2015-01-30 15:31:57 -0800 Comment on attachment 245379 Patch Clearing flags on attachment: 245379 Committed r179416: <http://trac.webkit.org/changeset/179416> 1065677 6 cdumez 2015-01-30 15:32:02 -0800 All reviewed patches have been landed. Closing bug. 245379 2015-01-26 15:10:38 -0800 2015-01-30 15:31:57 -0800 Patch bug-140905-20150126151041.patch text/plain 2832 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY4Yjk1OTcyOTgyMzliMmNmODYyYzU2 MjZhMzFmMjJlZjg4NDYzNzMuLjg1MGI2NjhjNzk4NTFhN2Q3Y2Q4NGJkYmNjNWE2MGIyMDMwZDQ5 NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDEtMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbWF0Y2hfY29uc3RuZXNzPFJlZmVyZW5jZSwgVD4g aGVscGVyIHN0cnVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQwOTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIG1hdGNoX2NvbnN0bmVzczxSZWZlcmVuY2UsIFQ+IGhlbHBlciBzdHJ1Y3QgdG8g c2ltcGxpZnkgZG93bmNhc3Q8PigpCisgICAgICAgIGEgYml0LiBUaGUgcHVycG9zZSBvZiB0aGlz IGhlbHBlciBpcyB0byB1cGRhdGUgVCdzIGNvbnN0bmVzcyB0byBtYXRjaAorICAgICAgICBSZWZl cmVuY2Uncy4KKworICAgICAgICAqIHd0Zi9UeXBlQ2FzdHMuaDoKKyAgICAgICAgKFdURjo6ZG93 bmNhc3QpOgorCiAyMDE1LTAxLTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgUHJvdmlkZSBpbXBsZW1lbnRhdGlvbiBmb3IgV1RGOjpEZWZhdWx0SGFzaDxib29s PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVHlwZUNhc3RzLmggYi9Tb3VyY2UvV1RGL3d0 Zi9UeXBlQ2FzdHMuaAppbmRleCBjMGFiOTI1NjQwYjM1ZTJkN2FjODk4MDFhMzczZTNhMmIxMWYw N2M3Li5hMmQ0NzJlNTk4MWZmMzI3YmIxY2RjZGExNzYyYjM1MjNlZjAyYjAwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9UeXBlQ2FzdHMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9UeXBlQ2Fz dHMuaApAQCAtNjYsMTkgKzY2LDI2IEBAIGlubGluZSBib29sIGlzKEFyZ1R5cGUqIHNvdXJjZSkK ICAgICByZXR1cm4gc291cmNlICYmIFR5cGVDYXN0VHJhaXRzPGNvbnN0IEV4cGVjdGVkVHlwZSwg Y29uc3QgQXJnVHlwZT46OmlzT2ZUeXBlKCpzb3VyY2UpOwogfQogCisvLyBVcGRhdGUgVCdzIGNv bnN0bmVzcyB0byBtYXRjaCBSZWZlcmVuY2Uncy4KK3RlbXBsYXRlIDx0eXBlbmFtZSBSZWZlcmVu Y2UsIHR5cGVuYW1lIFQ+CitzdHJ1Y3QgbWF0Y2hfY29uc3RuZXNzIHsKKyAgICB0eXBlZGVmIHR5 cGVuYW1lIHN0ZDo6Y29uZGl0aW9uYWw8c3RkOjppc19jb25zdDxSZWZlcmVuY2U+Ojp2YWx1ZSwg dHlwZW5hbWUgc3RkOjphZGRfY29uc3Q8VD46OnR5cGUsIHR5cGVuYW1lIHN0ZDo6cmVtb3ZlX2Nv bnN0PFQ+Ojp0eXBlPjo6dHlwZSB0eXBlOworfTsKKwogLy8gU2FmZSBkb3duY2FzdGluZyBmdW5j dGlvbnMuCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUYXJnZXQsIHR5cGVuYW1lIFNvdXJjZT4KLWlubGlu ZSB0eXBlbmFtZSBzdGQ6OmNvbmRpdGlvbmFsPHN0ZDo6aXNfY29uc3Q8U291cmNlPjo6dmFsdWUs IGNvbnN0IFRhcmdldCYsIFRhcmdldCY+Ojp0eXBlIGRvd25jYXN0KFNvdXJjZSYgc291cmNlKQor aW5saW5lIHR5cGVuYW1lIG1hdGNoX2NvbnN0bmVzczxTb3VyY2UsIFRhcmdldD46OnR5cGUmIGRv d25jYXN0KFNvdXJjZSYgc291cmNlKQogewogICAgIHN0YXRpY19hc3NlcnQoIXN0ZDo6aXNfYmFz ZV9vZjxUYXJnZXQsIFNvdXJjZT46OnZhbHVlLCAiVW5uZWNlc3NhcnkgY2FzdCIpOwogICAgIEFT U0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGlzPFRhcmdldD4oc291cmNlKSk7Ci0gICAg cmV0dXJuIHN0YXRpY19jYXN0PHR5cGVuYW1lIHN0ZDo6Y29uZGl0aW9uYWw8c3RkOjppc19jb25z dDxTb3VyY2U+Ojp2YWx1ZSwgY29uc3QgVGFyZ2V0JiwgVGFyZ2V0Jj46OnR5cGU+KHNvdXJjZSk7 CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PHR5cGVuYW1lIG1hdGNoX2NvbnN0bmVzczxTb3VyY2Us IFRhcmdldD46OnR5cGUmPihzb3VyY2UpOwogfQotdGVtcGxhdGU8dHlwZW5hbWUgVGFyZ2V0LCB0 eXBlbmFtZSBTb3VyY2U+IGlubGluZSB0eXBlbmFtZSBzdGQ6OmNvbmRpdGlvbmFsPHN0ZDo6aXNf Y29uc3Q8U291cmNlPjo6dmFsdWUsIGNvbnN0IFRhcmdldCosIFRhcmdldCo+Ojp0eXBlIGRvd25j YXN0KFNvdXJjZSogc291cmNlKQordGVtcGxhdGU8dHlwZW5hbWUgVGFyZ2V0LCB0eXBlbmFtZSBT b3VyY2U+CitpbmxpbmUgdHlwZW5hbWUgbWF0Y2hfY29uc3RuZXNzPFNvdXJjZSwgVGFyZ2V0Pjo6 dHlwZSogZG93bmNhc3QoU291cmNlKiBzb3VyY2UpCiB7CiAgICAgc3RhdGljX2Fzc2VydCghc3Rk Ojppc19iYXNlX29mPFRhcmdldCwgU291cmNlPjo6dmFsdWUsICJVbm5lY2Vzc2FyeSBjYXN0Iik7 CiAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIXNvdXJjZSB8fCBpczxUYXJn ZXQ+KCpzb3VyY2UpKTsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dHlwZW5hbWUgc3RkOjpjb25k aXRpb25hbDxzdGQ6OmlzX2NvbnN0PFNvdXJjZT46OnZhbHVlLCBjb25zdCBUYXJnZXQqLCBUYXJn ZXQqPjo6dHlwZT4oc291cmNlKTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dHlwZW5hbWUgbWF0 Y2hfY29uc3RuZXNzPFNvdXJjZSwgVGFyZ2V0Pjo6dHlwZSo+KHNvdXJjZSk7CiB9CiAKIC8vIEFk ZCBzdXBwb3J0IGZvciB0eXBlIGNoZWNraW5nIC8gY2FzdGluZyB1c2luZyBpczw+KCkgLyBkb3du Y2FzdDw+KCkgaGVscGVycyBmb3IgYSBzcGVjaWZpYyBjbGFzcy4K