140903 2015-01-26 14:41:17 -0800 Modernize some constructors of the CSS JIT 2015-01-27 12:47:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1064266 0 benjamin 2015-01-26 14:41:17 -0800 Modernize some constructors of the CSS JIT 1064269 1 245376 benjamin 2015-01-26 14:43:33 -0800 Created attachment 245376 Patch 1064380 2 245376 darin 2015-01-26 20:19:30 -0800 Comment on attachment 245376 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245376&action=review > Source/WebCore/cssjit/SelectorCompiler.cpp:155 > + BacktrackingAction traversalBacktrackingAction = BacktrackingAction::NoBacktracking; I’ve been using the { } syntax for these instead of the = syntax. I wonder if we should chose one over the other for the project as a whole. 1064616 3 245376 benjamin 2015-01-27 12:46:32 -0800 Comment on attachment 245376 Patch Clearing flags on attachment: 245376 Committed r179204: <http://trac.webkit.org/changeset/179204> 1064617 4 benjamin 2015-01-27 12:46:37 -0800 All reviewed patches have been landed. Closing bug. 1064618 5 benjamin 2015-01-27 12:47:22 -0800 (In reply to comment #2) > Comment on attachment 245376 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245376&action=review > > > Source/WebCore/cssjit/SelectorCompiler.cpp:155 > > + BacktrackingAction traversalBacktrackingAction = BacktrackingAction::NoBacktracking; > > I’ve been using the { } syntax for these instead of the = syntax. I wonder > if we should chose one over the other for the project as a whole. Yep, we should. 245376 2015-01-26 14:43:33 -0800 2015-01-27 12:46:32 -0800 Patch bug-140903-20150126144336.patch text/plain 5646 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RiMDUxYTliYTZmODc2 YWZmMjJkN2Y0YWM3OTUzMWI3MWE2YjMzNi4uZDI0NmVhYTY5NTlmMmY2NDljNzllZWQ4ODNmOTI0 MzAxMzlmMjM3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTI2ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybml6ZSBz b21lIGNvbnN0cnVjdG9ycyBvZiB0aGUgQ1NTIEpJVAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwOTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVHdvIGNvbnN0cnVjdG9ycyB3ZXJlIHN0aWxsIHVzaW5n IHRoZSBvbGQgc3R5bGUuCisKKyAgICAgICAgKiBjc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNvbXBpbGVyOjpTZWxlY3RvckZyYWdtZW50OjpT ZWxlY3RvckZyYWdtZW50KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ29t cGlsZXI6OlRhZ05hbWVQYXR0ZXJuOjpUYWdOYW1lUGF0dGVybik6IERlbGV0ZWQuCisKIDIwMTUt MDEtMjYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFBsdWcg bGVhayBpbiBqc1ZhbHVlV2l0aERpY3Rpb25hcnlJbkNvbnRleHQoKS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2Nzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmNwcAppbmRleCAyMmI4NjY5NzkyZGY0MzM4MjYxODNl MTY2ZjlkOWU2YWRmZWU3MWE1Li5kMWE4NGYyMTk4OWRhNjQ3MDVlNjgzZDA4MGU4ZWQ1ZTIxOTQw ZDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuY3BwCkBAIC0x NDgsNDYgKzE0OCwyOCBAQCBzdHJ1Y3QgTnRoQ2hpbGRPZlNlbGVjdG9ySW5mbyB7CiB9OwogCiBz dHJ1Y3QgU2VsZWN0b3JGcmFnbWVudCB7Ci0gICAgU2VsZWN0b3JGcmFnbWVudCgpCi0gICAgICAg IDogdHJhdmVyc2FsQmFja3RyYWNraW5nQWN0aW9uKEJhY2t0cmFja2luZ0FjdGlvbjo6Tm9CYWNr dHJhY2tpbmcpCi0gICAgICAgICwgbWF0Y2hpbmdUYWdOYW1lQmFja3RyYWNraW5nQWN0aW9uKEJh Y2t0cmFja2luZ0FjdGlvbjo6Tm9CYWNrdHJhY2tpbmcpCi0gICAgICAgICwgbWF0Y2hpbmdQb3N0 VGFnTmFtZUJhY2t0cmFja2luZ0FjdGlvbihCYWNrdHJhY2tpbmdBY3Rpb246Ok5vQmFja3RyYWNr aW5nKQotICAgICAgICAsIGJhY2t0cmFja2luZ0ZsYWdzKDApCi0gICAgICAgICwgdGFnTmFtZU1h dGNoZWRCYWNrdHJhY2tpbmdTdGFydEhlaWdodEZyb21EZXNjZW5kYW50KGludmFsaWRIZWlnaHQp Ci0gICAgICAgICwgdGFnTmFtZU5vdE1hdGNoZWRCYWNrdHJhY2tpbmdTdGFydEhlaWdodEZyb21E ZXNjZW5kYW50KGludmFsaWRIZWlnaHQpCi0gICAgICAgICwgaGVpZ2h0RnJvbURlc2NlbmRhbnQo MCkKLSAgICAgICAgLCB0YWdOYW1lTWF0Y2hlZEJhY2t0cmFja2luZ1N0YXJ0V2lkdGhGcm9tSW5k aXJlY3RBZGphY2VudChpbnZhbGlkV2lkdGgpCi0gICAgICAgICwgdGFnTmFtZU5vdE1hdGNoZWRC YWNrdHJhY2tpbmdTdGFydFdpZHRoRnJvbUluZGlyZWN0QWRqYWNlbnQoaW52YWxpZFdpZHRoKQot ICAgICAgICAsIHdpZHRoRnJvbUluZGlyZWN0QWRqYWNlbnQoMCkKLSAgICAgICAgLCB0YWdOYW1l U2VsZWN0b3IobnVsbHB0cikKLSAgICAgICAgLCBpZChudWxscHRyKQotICAgICAgICAsIGxhbmdG aWx0ZXIobnVsbHB0cikKLSAgICAgICAgLCBwc2V1ZG9FbGVtZW50U2VsZWN0b3IobnVsbHB0cikK LSAgICAgICAgLCBvbmx5TWF0Y2hlc0xpbmtzSW5RdWlya3NNb2RlKHRydWUpCi0gICAgewotICAg IH0KICAgICBGcmFnbWVudFJlbGF0aW9uIHJlbGF0aW9uVG9MZWZ0RnJhZ21lbnQ7CiAgICAgRnJh Z21lbnRSZWxhdGlvbiByZWxhdGlvblRvUmlnaHRGcmFnbWVudDsKICAgICBGcmFnbWVudFBvc2l0 aW9uSW5Sb290RnJhZ21lbnRzIHBvc2l0aW9uSW5Sb290RnJhZ21lbnRzOwogCi0gICAgQmFja3Ry YWNraW5nQWN0aW9uIHRyYXZlcnNhbEJhY2t0cmFja2luZ0FjdGlvbjsKLSAgICBCYWNrdHJhY2tp bmdBY3Rpb24gbWF0Y2hpbmdUYWdOYW1lQmFja3RyYWNraW5nQWN0aW9uOwotICAgIEJhY2t0cmFj a2luZ0FjdGlvbiBtYXRjaGluZ1Bvc3RUYWdOYW1lQmFja3RyYWNraW5nQWN0aW9uOwotICAgIHVu c2lnbmVkIGNoYXIgYmFja3RyYWNraW5nRmxhZ3M7Ci0gICAgdW5zaWduZWQgdGFnTmFtZU1hdGNo ZWRCYWNrdHJhY2tpbmdTdGFydEhlaWdodEZyb21EZXNjZW5kYW50OwotICAgIHVuc2lnbmVkIHRh Z05hbWVOb3RNYXRjaGVkQmFja3RyYWNraW5nU3RhcnRIZWlnaHRGcm9tRGVzY2VuZGFudDsKLSAg ICB1bnNpZ25lZCBoZWlnaHRGcm9tRGVzY2VuZGFudDsKLSAgICB1bnNpZ25lZCB0YWdOYW1lTWF0 Y2hlZEJhY2t0cmFja2luZ1N0YXJ0V2lkdGhGcm9tSW5kaXJlY3RBZGphY2VudDsKLSAgICB1bnNp Z25lZCB0YWdOYW1lTm90TWF0Y2hlZEJhY2t0cmFja2luZ1N0YXJ0V2lkdGhGcm9tSW5kaXJlY3RB ZGphY2VudDsKLSAgICB1bnNpZ25lZCB3aWR0aEZyb21JbmRpcmVjdEFkamFjZW50OworICAgIEJh Y2t0cmFja2luZ0FjdGlvbiB0cmF2ZXJzYWxCYWNrdHJhY2tpbmdBY3Rpb24gPSBCYWNrdHJhY2tp bmdBY3Rpb246Ok5vQmFja3RyYWNraW5nOworICAgIEJhY2t0cmFja2luZ0FjdGlvbiBtYXRjaGlu Z1RhZ05hbWVCYWNrdHJhY2tpbmdBY3Rpb24gPSBCYWNrdHJhY2tpbmdBY3Rpb246Ok5vQmFja3Ry YWNraW5nOworICAgIEJhY2t0cmFja2luZ0FjdGlvbiBtYXRjaGluZ1Bvc3RUYWdOYW1lQmFja3Ry YWNraW5nQWN0aW9uID0gQmFja3RyYWNraW5nQWN0aW9uOjpOb0JhY2t0cmFja2luZzsKKyAgICB1 bnNpZ25lZCBjaGFyIGJhY2t0cmFja2luZ0ZsYWdzID0gMDsKKyAgICB1bnNpZ25lZCB0YWdOYW1l TWF0Y2hlZEJhY2t0cmFja2luZ1N0YXJ0SGVpZ2h0RnJvbURlc2NlbmRhbnQgPSBpbnZhbGlkSGVp Z2h0OworICAgIHVuc2lnbmVkIHRhZ05hbWVOb3RNYXRjaGVkQmFja3RyYWNraW5nU3RhcnRIZWln aHRGcm9tRGVzY2VuZGFudCA9IGludmFsaWRIZWlnaHQ7CisgICAgdW5zaWduZWQgaGVpZ2h0RnJv bURlc2NlbmRhbnQgPSAwOworICAgIHVuc2lnbmVkIHRhZ05hbWVNYXRjaGVkQmFja3RyYWNraW5n U3RhcnRXaWR0aEZyb21JbmRpcmVjdEFkamFjZW50ID0gaW52YWxpZFdpZHRoOworICAgIHVuc2ln bmVkIHRhZ05hbWVOb3RNYXRjaGVkQmFja3RyYWNraW5nU3RhcnRXaWR0aEZyb21JbmRpcmVjdEFk amFjZW50ID0gaW52YWxpZFdpZHRoOworICAgIHVuc2lnbmVkIHdpZHRoRnJvbUluZGlyZWN0QWRq YWNlbnQgPSAwOwogCiAgICAgRnVuY3Rpb25UeXBlIGFwcGVuZFVub3B0aW1pemVkUHNldWRvQ2xh c3NXaXRoQ29udGV4dChib29sICgqbWF0Y2hlcikoY29uc3QgU2VsZWN0b3JDaGVja2VyOjpDaGVj a2luZ0NvbnRleHQmKSk7CiAKICAgICAvLyBGSVhNRTogdGhlIGxhcmdlIHN0YWNrIGFsbG9jYXRp b24gY2F1c2VkIGJ5IHRoZSBpbmxpbmUgY2FwYWNpdHkgY2F1c2VzIG1lbW9yeSBpbmVmZmljaWVu Y3kuIFdlIHNob3VsZCBkdW1wCiAgICAgLy8gdGhlIG1pbi9tYXgvYXZlcmFnZSBvZiB0aGUgdmVj dG9ycyBhbmQgcGljayBiZXR0ZXIgaW5saW5lIGNhcGFjaXR5LgotICAgIGNvbnN0IENTU1NlbGVj dG9yKiB0YWdOYW1lU2VsZWN0b3I7Ci0gICAgY29uc3QgQXRvbWljU3RyaW5nKiBpZDsKLSAgICBj b25zdCBBdG9taWNTdHJpbmcqIGxhbmdGaWx0ZXI7CisgICAgY29uc3QgQ1NTU2VsZWN0b3IqIHRh Z05hbWVTZWxlY3RvciA9IG51bGxwdHI7CisgICAgY29uc3QgQXRvbWljU3RyaW5nKiBpZCA9IG51 bGxwdHI7CisgICAgY29uc3QgQXRvbWljU3RyaW5nKiBsYW5nRmlsdGVyID0gbnVsbHB0cjsKICAg ICBWZWN0b3I8Y29uc3QgQXRvbWljU3RyaW5nSW1wbCosIDg+IGNsYXNzTmFtZXM7CiAgICAgSGFz aFNldDx1bnNpZ25lZD4gcHNldWRvQ2xhc3NlczsKICAgICBWZWN0b3I8SlNDOjpGdW5jdGlvblB0 ciwgND4gdW5vcHRpbWl6ZWRQc2V1ZG9DbGFzc2VzOwpAQCAtMTk4LDcgKzE4MCw3IEBAIHN0cnVj dCBTZWxlY3RvckZyYWdtZW50IHsKICAgICBTZWxlY3Rvckxpc3Qgbm90RmlsdGVyczsKICAgICBW ZWN0b3I8U2VsZWN0b3JMaXN0PiBtYXRjaGVzRmlsdGVyczsKICAgICBWZWN0b3I8VmVjdG9yPFNl bGVjdG9yRnJhZ21lbnQ+PiBhbnlGaWx0ZXJzOwotICAgIGNvbnN0IENTU1NlbGVjdG9yKiBwc2V1 ZG9FbGVtZW50U2VsZWN0b3I7CisgICAgY29uc3QgQ1NTU2VsZWN0b3IqIHBzZXVkb0VsZW1lbnRT ZWxlY3RvciA9IG51bGxwdHI7CiAKICAgICAvLyBGb3IgcXVpcmtzIG1vZGUsIGZvbGxvdyB0aGlz OiBodHRwOi8vcXVpcmtzLnNwZWMud2hhdHdnLm9yZy8jdGhlLTphY3RpdmUtYW5kLTpob3Zlci1x dWlyawogICAgIC8vIEluIHF1aXJrcyBtb2RlLCBhIGNvbXBvdW5kIHNlbGVjdG9yICdzZWxlY3Rv cicgdGhhdCBtYXRjaGVzIHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBtdXN0IG5vdCBtYXRjaCBl bGVtZW50cyB0aGF0IHdvdWxkIG5vdCBhbHNvIG1hdGNoIHRoZSAnOmFueS1saW5rJyBzZWxlY3Rv ci4KQEAgLTIxMSw3ICsxOTMsNyBAQCBzdHJ1Y3QgU2VsZWN0b3JGcmFnbWVudCB7CiAgICAgLy8g ICAgc2VsZWN0b3IgZG9lcyBub3QgdXNlIGEgcHNldWRvLWNsYXNzIHNlbGVjdG9yIG90aGVyIHRo YW4gJzphY3RpdmUnIGFuZCAnOmhvdmVyJy4KICAgICAvLyAgICBzZWxlY3RvciBkb2VzIG5vdCB1 c2UgYSBwc2V1ZG8tZWxlbWVudCBzZWxlY3Rvci4KICAgICAvLyAgICBzZWxlY3RvciBpcyBub3Qg cGFydCBvZiBhbiBhcmd1bWVudCB0byBhIGZ1bmN0aW9uYWwgcHNldWRvLWNsYXNzIG9yIHBzZXVk by1lbGVtZW50LgotICAgIGJvb2wgb25seU1hdGNoZXNMaW5rc0luUXVpcmtzTW9kZTsKKyAgICBi b29sIG9ubHlNYXRjaGVzTGlua3NJblF1aXJrc01vZGUgPSB0cnVlOwogfTsKIAogY2xhc3MgU2Vs ZWN0b3JGcmFnbWVudExpc3QgOiBwdWJsaWMgVmVjdG9yPFNlbGVjdG9yRnJhZ21lbnQsIDQ+IHsK QEAgLTIyMywxMyArMjA1LDggQEAgcHVibGljOgogfTsKIAogc3RydWN0IFRhZ05hbWVQYXR0ZXJu IHsKLSAgICBUYWdOYW1lUGF0dGVybigpCi0gICAgICAgIDogdGFnTmFtZVNlbGVjdG9yKG51bGxw dHIpCi0gICAgICAgICwgaW52ZXJ0ZWQoZmFsc2UpCi0gICAgewotICAgIH0KLSAgICBjb25zdCBD U1NTZWxlY3RvciogdGFnTmFtZVNlbGVjdG9yOwotICAgIGJvb2wgaW52ZXJ0ZWQ7CisgICAgY29u c3QgQ1NTU2VsZWN0b3IqIHRhZ05hbWVTZWxlY3RvciA9IG51bGxwdHI7CisgICAgYm9vbCBpbnZl cnRlZCA9IGZhbHNlOwogfTsKIAogdHlwZWRlZiBKU0M6Ok1hY3JvQXNzZW1ibGVyIEFzc2VtYmxl cjsK