140894 2015-01-26 11:47:09 -0800 Don't let the CSSValuePool's font family cache grow unbounded. 2015-01-26 13:42:42 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling cdumez darin kling oldest_to_newest 1064208 0 kling 2015-01-26 11:47:09 -0800 We should restrict the font family CSSValue cache like we do for the font face one. 1064211 1 245362 kling 2015-01-26 11:49:05 -0800 Created attachment 245362 Patch 1064212 2 245362 cdumez 2015-01-26 11:51:22 -0800 Comment on attachment 245362 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245362&action=review r=me > Source/WebCore/ChangeLog:8 > + Chris pointed out that the font family cache in CSSValuePool can grow unbounded Actually Darin pointed that out to me :) 1064214 3 245364 kling 2015-01-26 11:54:54 -0800 Created attachment 245364 Patch 1064247 4 kling 2015-01-26 13:42:42 -0800 Committed r179141: <http://trac.webkit.org/changeset/179141> 245362 2015-01-26 11:49:05 -0800 2015-01-26 11:54:54 -0800 Patch bug-140894.diff text/plain 1691 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkOTVmZDFjLi4xOWEyMTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTUtMDEtMjYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIERvbid0IGxldCB0aGUgQ1NTVmFsdWVQb29sJ3MgZm9udCBmYW1pbHkgY2FjaGUgZ3JvdyB1 bmJvdW5kZWQuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDA4OTQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyaXMgcG9pbnRlZCBv dXQgdGhhdCB0aGUgZm9udCBmYW1pbHkgY2FjaGUgaW4gQ1NTVmFsdWVQb29sIGNhbiBncm93IHVu Ym91bmRlZAorICAgICAgICB1bnRpbCB3ZSBnZXQgYSBzeXN0ZW0gbWVtb3J5IHByZXNzdXJlIG5v dGlmaWNhdGlvbi4gUHV0IGEgbGltaXQgb24gaXQgbGlrZSB3ZSBkaWQKKyAgICAgICAgd2l0aCB0 aGUgZm9udCBmYWNlIGNhY2hlLgorCisgICAgICAgICogY3NzL0NTU1ZhbHVlUG9vbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDU1NWYWx1ZVBvb2w6OmNyZWF0ZUZvbnRGYW1pbHlWYWx1ZSk6CisK KzIwMTUtMDEtMjYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAg IFBsdWcgbGVhayBpbiBqc1ZhbHVlV2l0aERpY3Rpb25hcnlJbkNvbnRleHQoKS4KICAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0MDg4OT4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1ZhbHVlUG9vbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQb29s LmNwcAppbmRleCA2NjU5M2UwLi4xNWQ4NjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTVmFsdWVQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQb29s LmNwcApAQCAtMTIwLDYgKzEyMCwxMSBAQCBSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IENTU1ZhbHVl UG9vbDo6Y3JlYXRlVmFsdWUoZG91YmxlIHZhbHVlLCBDU1NQcmltaXRpdmVWYWx1ZQogCiBSZWY8 Q1NTUHJpbWl0aXZlVmFsdWU+IENTU1ZhbHVlUG9vbDo6Y3JlYXRlRm9udEZhbWlseVZhbHVlKGNv bnN0IFN0cmluZyYgZmFtaWx5TmFtZSkKIHsKKyAgICAvLyBSZW1vdmUgb25lIGVudHJ5IGF0IHJh bmRvbSBpZiB0aGUgY2FjaGUgZ3Jvd3MgdG9vIGxhcmdlLgorICAgIGNvbnN0IGludCBtYXhpbXVt Rm9udEZhbWlseUNhY2hlU2l6ZSA9IDEyODsKKyAgICBpZiAobV9mb250RmFtaWx5VmFsdWVDYWNo ZS5zaXplKCkgPj0gbWF4aW11bUZvbnRGYW1pbHlDYWNoZVNpemUpCisgICAgICAgIG1fZm9udEZh bWlseVZhbHVlQ2FjaGUucmVtb3ZlKG1fZm9udEZhbWlseVZhbHVlQ2FjaGUuYmVnaW4oKSk7CisK ICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+JiB2YWx1ZSA9IG1fZm9udEZhbWlseVZhbHVl Q2FjaGUuYWRkKGZhbWlseU5hbWUsIG51bGxwdHIpLml0ZXJhdG9yLT52YWx1ZTsKICAgICBpZiAo IXZhbHVlKQogICAgICAgICB2YWx1ZSA9IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoZmFtaWx5 TmFtZSwgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19TVFJJTkcpOwo= 245364 2015-01-26 11:54:54 -0800 2015-01-26 11:55:25 -0800 Patch bug-140894.diff text/plain 1718 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZWYzMWU2Li4zY2YzYjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTUtMDEtMjYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIERvbid0IGxldCB0aGUgQ1NTVmFsdWVQb29sJ3MgZm9udCBmYW1pbHkgY2FjaGUgZ3JvdyB1 bmJvdW5kZWQuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDA4OTQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyaXMgcG9pbnRlZCBv dXQgdGhhdCB0aGUgZm9udCBmYW1pbHkgY2FjaGUgaW4gQ1NTVmFsdWVQb29sIGNhbiBncm93IHVu Ym91bmRlZAorICAgICAgICB1bnRpbCB3ZSBnZXQgYSBzeXN0ZW0gbWVtb3J5IHByZXNzdXJlIG5v dGlmaWNhdGlvbi4gUHV0IGEgbGltaXQgb24gaXQgbGlrZSB3ZSBkaWQKKyAgICAgICAgd2l0aCB0 aGUgZm9udCBmYWNlIGNhY2hlLgorCisgICAgICAgICogY3NzL0NTU1ZhbHVlUG9vbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDU1NWYWx1ZVBvb2w6OmNyZWF0ZUZvbnRGYW1pbHlWYWx1ZSk6CisK IDIwMTUtMDEtMjYgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJs YWNrbGlzdCBpQm9va3MgZm9yIFdlYktpdCdzIGRlZmF1bHQgaW1tZWRpYXRlIGFjdGlvbnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZVBvb2wuY3BwIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU1ZhbHVlUG9vbC5jcHAKaW5kZXggNGEzZjJhMi4uNWM5NGIyNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlUG9vbC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU1ZhbHVlUG9vbC5jcHAKQEAgLTEyMSw2ICsxMjEsMTEgQEAgUmVmPENTU1By aW1pdGl2ZVZhbHVlPiBDU1NWYWx1ZVBvb2w6OmNyZWF0ZVZhbHVlKGRvdWJsZSB2YWx1ZSwgQ1NT UHJpbWl0aXZlVmFsdWUKIAogUmVmPENTU1ByaW1pdGl2ZVZhbHVlPiBDU1NWYWx1ZVBvb2w6OmNy ZWF0ZUZvbnRGYW1pbHlWYWx1ZShjb25zdCBTdHJpbmcmIGZhbWlseU5hbWUsIEZyb21TeXN0ZW1G b250SURPck5vdCBmcm9tU3lzdGVtRm9udElEKQogeworICAgIC8vIFJlbW92ZSBvbmUgZW50cnkg YXQgcmFuZG9tIGlmIHRoZSBjYWNoZSBncm93cyB0b28gbGFyZ2UuCisgICAgY29uc3QgaW50IG1h eGltdW1Gb250RmFtaWx5Q2FjaGVTaXplID0gMTI4OworICAgIGlmIChtX2ZvbnRGYW1pbHlWYWx1 ZUNhY2hlLnNpemUoKSA+PSBtYXhpbXVtRm9udEZhbWlseUNhY2hlU2l6ZSkKKyAgICAgICAgbV9m b250RmFtaWx5VmFsdWVDYWNoZS5yZW1vdmUobV9mb250RmFtaWx5VmFsdWVDYWNoZS5iZWdpbigp KTsKKwogICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4mIHZhbHVlID0gbV9mb250RmFtaWx5 VmFsdWVDYWNoZS5hZGQoe2ZhbWlseU5hbWUsIGZyb21TeXN0ZW1Gb250SUR9LCBudWxscHRyKS5p dGVyYXRvci0+dmFsdWU7CiAgICAgaWYgKCF2YWx1ZSkKICAgICAgICAgdmFsdWUgPSBDU1NQcmlt aXRpdmVWYWx1ZTo6Y3JlYXRlKENTU0ZvbnRGYW1pbHl7ZmFtaWx5TmFtZSwgZnJvbVN5c3RlbUZv bnRJRH0pOwo=