140891 2015-01-26 11:13:08 -0800 Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value) 2015-01-26 12:04:46 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140577 140777 1 cdumez cdumez andersca commit-queue darin kling oldest_to_newest 1064194 0 cdumez 2015-01-26 11:13:08 -0800 Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value) to make sure the argument is not unexpectedly moved when it shouldn't (like I experienced yesterday in Bug 140577). 1064195 1 245357 cdumez 2015-01-26 11:15:11 -0800 Created attachment 245357 Patch 1064200 2 cdumez 2015-01-26 11:20:07 -0800 Darin, I verified that with this patch, the moving issue from yesterday is gone if I drop the const from "CSSFontFamily* fontFamily" member. Good thing I asked Anders about it today :) 1064219 3 245357 commit-queue 2015-01-26 12:04:40 -0800 Comment on attachment 245357 Patch Clearing flags on attachment: 245357 Committed r179131: <http://trac.webkit.org/changeset/179131> 1064220 4 commit-queue 2015-01-26 12:04:46 -0800 All reviewed patches have been landed. Closing bug. 245357 2015-01-26 11:15:11 -0800 2015-01-26 12:04:40 -0800 Patch bug-140891-20150126111513.patch text/plain 3558 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWNiNmVkMmNlODY3ZjUy ZThmODQ5ZTgwMDA0ZDNmN2QxZmEyZWFiMi4uYzY3NTRiNTY1NjRjMzZjMGNlMGMwNzU0YWVlNWZj ZmM3MWIzMWU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAxLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHN0ZDo6Zm9yd2FyZCgp IGluc3RlYWQgb2YgV1RGOjptb3ZlKCkgaW4gQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShUJiYg dmFsdWUpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDA4OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV c2Ugc3RkOjpmb3J3YXJkKCkgaW5zdGVhZCBvZiBXVEY6Om1vdmUoKSBpbiBDU1NQcmltaXRpdmVW YWx1ZTo6Y3JlYXRlKFQmJiB2YWx1ZSkKKyAgICAgICAgdG8gbWFrZSBzdXJlIHRoZSBhcmd1bWVu dCBpcyBub3QgdW5leHBlY3RlZGx5IG1vdmVkIHdoZW4gaXQgc2hvdWxkbid0IChsaWtlIEkKKyAg ICAgICAgZXhwZXJpZW5jZWQgeWVzdGVyZGF5IGluIEJ1ZyAxNDA1NzcpOgorICAgICAgICA8aHR0 cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTc5MTA1PgorCisgICAgICAgICogY3NzL0NT U1ByaW1pdGl2ZVZhbHVlLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6 Y3JlYXRlKToKKyAgICAgICAgKiBjc3MvQ1NTVmFsdWVQb29sLmg6CisgICAgICAgIChXZWJDb3Jl OjpDU1NWYWx1ZVBvb2w6OmNyZWF0ZVZhbHVlKToKKwogMjAxNS0wMS0yNiAgTWljaGFlbCBDYXRh bnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gZ3RrZG9jIGRv ZXMgbm90IGFwcGVhciBpbiBEZXZIZWxwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJpbWl0aXZlVmFsdWUuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZS5oCmluZGV4IDFiNDgwZmRmNWM3ZGY3N2EzNWI3NWFlNDQ0NjNlOGZiOWEwZGY4NGIuLjUwODc0 ZWVkNGE5MDA5M2I5NzhhZGVhYWUwM2JmY2UyNmY3NDQwYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQcmltaXRpdmVWYWx1ZS5oCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSAiQ1NTVmFsdWVL ZXl3b3Jkcy5oIgogI2luY2x1ZGUgIkNvbG9yLmgiCiAjaW5jbHVkZSAiTGF5b3V0VW5pdC5oIgor I2luY2x1ZGUgPHV0aWxpdHk+CiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3 dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CkBAIC0yMzYsMTQg KzIzNyw5IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPENTU1ByaW1pdGl2ZVZhbHVlPiBjcmVh dGUoY29uc3QgTGVuZ3RoJiB2YWx1ZSwgY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlKSB7IHJldHVy biBhZG9wdFJlZigqbmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlLCBzdHlsZSkpOyB9CiAgICAg c3RhdGljIFJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlKGNvbnN0IExlbmd0aFNpemUmIHZh bHVlLCBjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQ1NT UHJpbWl0aXZlVmFsdWUodmFsdWUsIHN0eWxlKSk7IH0KIAotICAgIHRlbXBsYXRlPHR5cGVuYW1l IFQ+IHN0YXRpYyBSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZShjb25zdCBUJiB2YWx1ZSkK LSAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZh bHVlKSk7Ci0gICAgfQotCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RhdGljIFJlZjxDU1NQ cmltaXRpdmVWYWx1ZT4gY3JlYXRlKFQmJiB2YWx1ZSkKICAgICB7Ci0gICAgICAgIHJldHVybiBh ZG9wdFJlZigqbmV3IENTU1ByaW1pdGl2ZVZhbHVlKFdURjo6bW92ZSh2YWx1ZSkpKTsKKyAgICAg ICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQ1NTUHJpbWl0aXZlVmFsdWUoc3RkOjpmb3J3YXJkPFQ+ KHZhbHVlKSkpOwogICAgIH0KIAogICAgIC8vIFRoaXMgdmFsdWUgaXMgdXNlZCB0byBoYW5kbGUg cXVpcmt5IG1hcmdpbnMgaW4gcmVmbG93IHJvb3RzIChib2R5LCB0ZCwgYW5kIHRoKSBsaWtlIFdp bklFLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlUG9vbC5oIGIvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlUG9vbC5oCmluZGV4IDg2MGZiN2IyYjI1MGIwZTE2ODU2 NzgxYjhmNmMwNmQ2YjY4MGVmZjYuLmFhYzczNmNlYzQ5MTMwOTE3NzA0NmQzODJkMzUzYzFkYTAy NDMyMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZVBvb2wuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVQb29sLmgKQEAgLTMyLDYgKzMyLDcgQEAKICNp bmNsdWRlICJDU1NQcmltaXRpdmVWYWx1ZS5oIgogI2luY2x1ZGUgIkNTU1Byb3BlcnR5TmFtZXMu aCIKICNpbmNsdWRlICJDU1NWYWx1ZUtleXdvcmRzLmgiCisjaW5jbHVkZSA8dXRpbGl0eT4KICNp bmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgog I2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KQEAgLTU2LDcgKzU3LDcgQEAgcHVibGljOgogICAgIFJl ZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlVmFsdWUoY29uc3QgU3RyaW5nJiB2YWx1ZSwgQ1NT UHJpbWl0aXZlVmFsdWU6OlVuaXRUeXBlcyB0eXBlKSB7IHJldHVybiBDU1NQcmltaXRpdmVWYWx1 ZTo6Y3JlYXRlKHZhbHVlLCB0eXBlKTsgfQogICAgIFJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3Jl YXRlVmFsdWUoY29uc3QgTGVuZ3RoJiB2YWx1ZSwgY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlKSB7 IHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHZhbHVlLCBzdHlsZSk7IH0KICAgICBS ZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZVZhbHVlKGNvbnN0IExlbmd0aFNpemUmIHZhbHVl LCBjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIHsgcmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpj cmVhdGUodmFsdWUsIHN0eWxlKTsgfQotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHN0YXRpYyBS ZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZVZhbHVlKFQgdmFsdWUpIHsgcmV0dXJuIENTU1By aW1pdGl2ZVZhbHVlOjpjcmVhdGUodmFsdWUpOyB9CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4g c3RhdGljIFJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlVmFsdWUoVCYmIHZhbHVlKSB7IHJl dHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHN0ZDo6Zm9yd2FyZDxUPih2YWx1ZSkpOyB9 CiAKICAgICB2b2lkIGRyYWluKCk7CiAK