140884 2015-01-26 04:24:29 -0800 [buildbot] Fix grammar of TestWithFailureCount 2015-01-26 09:20:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140821 1 ossy ossy ap commit-queue lforschler ossy rniwa oldest_to_newest 1064132 0 ossy 2015-01-26 04:24:29 -0800 class TestWithFailureCount(shell.Test): failedTestsFormatString = "%d tests failed" output is always in plural, which is incorrect and should be fixed. 1064133 1 245340 ossy 2015-01-26 04:29:03 -0800 Created attachment 245340 Patch 1064134 2 ossy 2015-01-26 04:30:11 -0800 the idea is come from: https://bugs.webkit.org/show_bug.cgi?id=140821#c4 : "1 tests" is not good grammar. Given that one failing test is the most common failure case, I think that the error text should be nice. 1064135 3 commit-queue 2015-01-26 04:31:03 -0800 Attachment 245340 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:158: [RunLLINTCLoopTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:179: [Run32bitJSCTestsTest.test_failure] Undefined variable 'FAILURE' [pylint/E0602] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1064169 4 245340 ossy 2015-01-26 09:20:24 -0800 Comment on attachment 245340 Patch Clearing flags on attachment: 245340 Committed r179116: <http://trac.webkit.org/changeset/179116> 1064170 5 ossy 2015-01-26 09:20:33 -0800 All reviewed patches have been landed. Closing bug. 245340 2015-01-26 04:29:03 -0800 2015-01-26 09:20:24 -0800 Patch bug-140884-20150126133101.patch text/plain 6638 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzlhYzY1N2JmMjY2YzkxMTNiYTkzOGU2Nzk0M2MwNDI0 Njg2NTVjYS4uNGM2NDAyMzlkNTNjM2QzNzY0YjYwMTQ5YmI2NDZlMjBiOGFjMzMyMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE1LTAxLTI2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW2J1aWxkYm90XSBGaXggZ3JhbW1hciBvZiBUZXN0V2l0aEZhaWx1cmVDb3VudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwODg0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAo VGVzdFdpdGhGYWlsdXJlQ291bnQpOgorICAgICAgICAoVGVzdFdpdGhGYWlsdXJlQ291bnQuY29t bWFuZENvbXBsZXRlKToKKyAgICAgICAgKFRlc3RXaXRoRmFpbHVyZUNvdW50LmdldFRleHQyKToK KyAgICAgICAgKFJ1blVuaXRUZXN0cyk6CisgICAgICAgIChSdW5QeXRob25UZXN0cyk6CisgICAg ICAgIChSdW5QZXJsVGVzdHMpOgorICAgICAgICAoUnVuTExJTlRDTG9vcFRlc3RzKToKKyAgICAg ICAgKFJ1bjMyYml0SlNDVGVzdHMpOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191bml0dGVzdC5weToKKyAgICAgICAgKFJ1bkxM SU5UQ0xvb3BUZXN0c1Rlc3QudGVzdF9mYWlsdXJlKToKKyAgICAgICAgKFJ1bjMyYml0SlNDVGVz dHNUZXN0LnRlc3RfZmFpbHVyZSk6CisgICAgICAgIChSdW5Vbml0VGVzdHNUZXN0LmFzc2VydEZh aWx1cmVzKToKKwogMjAxNS0wMS0yNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+IGFuZCBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXSBndGtkb2MgZG9lcyBub3QgYXBwZWFyIGluIERldkhlbHAKZGlmZiAt LWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21h c3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9tYXN0ZXIuY2ZnCmluZGV4IDNjZmVkODUzNmMyOTc0NzkyY2ZmM2ZkMjYzOTA2Mzc5MzZiYmQ3 NTcuLmYxOGZlZDMyYzcyNjExMTVkOTE4NmZiMTM5Zjk0NjMwZTc3ZTYxYzcgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5j ZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv bWFzdGVyLmNmZwpAQCAtNjIsNyArNjIsNyBAQCBXaXRoUHJvcGVydGllcyA9IHByb3BlcnRpZXMu V2l0aFByb3BlcnRpZXMKIAogCiBjbGFzcyBUZXN0V2l0aEZhaWx1cmVDb3VudChzaGVsbC5UZXN0 KToKLSAgICBmYWlsZWRUZXN0c0Zvcm1hdFN0cmluZyA9ICIlZCB0ZXN0cyBmYWlsZWQiCisgICAg ZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgPSAiJWQgdGVzdCVzIGZhaWxlZCIKIAogICAgIGRlZiBj b3VudEZhaWx1cmVzKHNlbGYsIGNtZCk6CiAgICAgICAgIHJldHVybiAwCkBAIC03MCw2ICs3MCw3 IEBAIGNsYXNzIFRlc3RXaXRoRmFpbHVyZUNvdW50KHNoZWxsLlRlc3QpOgogICAgIGRlZiBjb21t YW5kQ29tcGxldGUoc2VsZiwgY21kKToKICAgICAgICAgc2hlbGwuVGVzdC5jb21tYW5kQ29tcGxl dGUoc2VsZiwgY21kKQogICAgICAgICBzZWxmLmZhaWxlZFRlc3RDb3VudCA9IHNlbGYuY291bnRG YWlsdXJlcyhjbWQpCisgICAgICAgIHNlbGYuZmFpbGVkVGVzdFBsdXJhbFN1ZmZpeCA9ICIiIGlm IHNlbGYuZmFpbGVkVGVzdENvdW50ID09IDEgZWxzZSAicyIKIAogICAgIGRlZiBldmFsdWF0ZUNv bW1hbmQoc2VsZiwgY21kKToKICAgICAgICAgaWYgc2VsZi5mYWlsZWRUZXN0Q291bnQ6CkBAIC04 NSw3ICs4Niw3IEBAIGNsYXNzIFRlc3RXaXRoRmFpbHVyZUNvdW50KHNoZWxsLlRlc3QpOgogCiAg ICAgZGVmIGdldFRleHQyKHNlbGYsIGNtZCwgcmVzdWx0cyk6CiAgICAgICAgIGlmIHJlc3VsdHMg IT0gU1VDQ0VTUyBhbmQgc2VsZi5mYWlsZWRUZXN0Q291bnQ6Ci0gICAgICAgICAgICByZXR1cm4g W3NlbGYuZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgJSBzZWxmLmZhaWxlZFRlc3RDb3VudF0KKyAg ICAgICAgICAgIHJldHVybiBbc2VsZi5mYWlsZWRUZXN0c0Zvcm1hdFN0cmluZyAlIChzZWxmLmZh aWxlZFRlc3RDb3VudCwgc2VsZi5mYWlsZWRUZXN0UGx1cmFsU3VmZml4KV0KIAogICAgICAgICBy ZXR1cm4gW3NlbGYubmFtZV0KIApAQCAtNDYwLDcgKzQ2MSw3IEBAIGNsYXNzIFJ1blVuaXRUZXN0 cyhUZXN0V2l0aEZhaWx1cmVDb3VudCk6CiAgICAgZGVzY3JpcHRpb24gPSBbInVuaXQgdGVzdHMg cnVubmluZyJdCiAgICAgZGVzY3JpcHRpb25Eb25lID0gWyJ1bml0LXRlc3RzIl0KICAgICBjb21t YW5kID0gWyJwZXJsIiwgIi4vVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzIiwgV2l0aFByb3Bl cnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKSwgIi0tdmVyYm9zZSJdCi0gICAgZmFpbGVkVGVz dHNGb3JtYXRTdHJpbmcgPSAiJWQgdW5pdCB0ZXN0cyBmYWlsZWQgb3IgdGltZWQgb3V0IgorICAg IGZhaWxlZFRlc3RzRm9ybWF0U3RyaW5nID0gIiVkIHVuaXQgdGVzdCVzIGZhaWxlZCBvciB0aW1l ZCBvdXQiCiAKICAgICBkZWYgc3RhcnQoc2VsZik6CiAgICAgICAgIHBsYXRmb3JtID0gc2VsZi5n ZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJykKQEAgLTQ5MCw3ICs0OTEsNyBAQCBjbGFzcyBSdW5Q eXRob25UZXN0cyhUZXN0V2l0aEZhaWx1cmVDb3VudCk6CiAgICAgZGVzY3JpcHRpb24gPSBbInB5 dGhvbi10ZXN0cyBydW5uaW5nIl0KICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbInB5dGhvbi10ZXN0 cyJdCiAgICAgY29tbWFuZCA9IFsicHl0aG9uIiwgIi4vVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtp dHB5IiwgIi0tdmVyYm9zZSJdCi0gICAgZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgPSAiJWQgcHl0 aG9uIHRlc3RzIGZhaWxlZCIKKyAgICBmYWlsZWRUZXN0c0Zvcm1hdFN0cmluZyA9ICIlZCBweXRo b24gdGVzdCVzIGZhaWxlZCIKIAogICAgIGRlZiBzdGFydChzZWxmKToKICAgICAgICAgcGxhdGZv cm0gPSBzZWxmLmdldFByb3BlcnR5KCdwbGF0Zm9ybScpCkBAIC01MjEsNyArNTIyLDcgQEAgY2xh c3MgUnVuUGVybFRlc3RzKFRlc3RXaXRoRmFpbHVyZUNvdW50KToKICAgICBkZXNjcmlwdGlvbiA9 IFsicGVybC10ZXN0cyBydW5uaW5nIl0KICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbInBlcmwtdGVz dHMiXQogICAgIGNvbW1hbmQgPSBbInBlcmwiLCAiLi9Ub29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0 cGVybCJdCi0gICAgZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgPSAiJWQgcGVybCB0ZXN0cyBmYWls ZWQiCisgICAgZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgPSAiJWQgcGVybCB0ZXN0JXMgZmFpbGVk IgogCiAgICAgZGVmIGNvdW50RmFpbHVyZXMoc2VsZiwgY21kKToKICAgICAgICAgbG9nVGV4dCA9 IGNtZC5sb2dzWydzdGRpbyddLmdldFRleHQoKQpAQCAtNTQwLDcgKzU0MSw3IEBAIGNsYXNzIFJ1 bkxMSU5UQ0xvb3BUZXN0cyhUZXN0V2l0aEZhaWx1cmVDb3VudCk6CiAgICAgZGVzY3JpcHRpb24g PSBbImNsb29wLXRlc3RzIHJ1bm5pbmciXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsiY2xvb3At dGVzdHMiXQogICAgIGNvbW1hbmQgPSBbInBlcmwiLCAiLi9Ub29scy9TY3JpcHRzL3J1bi1qYXZh c2NyaXB0Y29yZS10ZXN0cyIsICItLWNsb29wIiwgIi0tbm8tYnVpbGQiLCAiLS1uby1qc2Mtc3Ry ZXNzIiwgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKV0KLSAgICBmYWlsZWRU ZXN0c0Zvcm1hdFN0cmluZyA9ICIlZCByZWdyZXNzaW9ucyBmb3VuZC4iCisgICAgZmFpbGVkVGVz dHNGb3JtYXRTdHJpbmcgPSAiJWQgcmVncmVzc2lvbiVzIGZvdW5kLiIKIAogICAgIGRlZiBjb3Vu dEZhaWx1cmVzKHNlbGYsIGNtZCk6CiAgICAgICAgIGxvZ1RleHQgPSBjbWQubG9nc1snc3RkaW8n XS5nZXRUZXh0KCkKQEAgLTU1OSw3ICs1NjAsNyBAQCBjbGFzcyBSdW4zMmJpdEpTQ1Rlc3RzKFRl c3RXaXRoRmFpbHVyZUNvdW50KToKICAgICBkZXNjcmlwdGlvbiA9IFsiMzJiaXQtanNjLXRlc3Rz IHJ1bm5pbmciXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsiMzJiaXQtanNjLXRlc3RzIl0KICAg ICBjb21tYW5kID0gWyJwZXJsIiwgIi4vVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUt dGVzdHMiLCAiLS0zMi1iaXQiLCAiLS1uby1idWlsZCIsIFdpdGhQcm9wZXJ0aWVzKCItLSUoY29u ZmlndXJhdGlvbilzIildCi0gICAgZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgPSAiJWQgcmVncmVz c2lvbnMgZm91bmQuIgorICAgIGZhaWxlZFRlc3RzRm9ybWF0U3RyaW5nID0gIiVkIHJlZ3Jlc3Np b24lcyBmb3VuZC4iCiAKICAgICBkZWYgY291bnRGYWlsdXJlcyhzZWxmLCBjbWQpOgogICAgICAg ICBsb2dUZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCmRpZmYgLS1naXQgYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXJjZmdfdW5p dHRlc3QucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9tYXN0ZXJjZmdfdW5pdHRlc3QucHkKaW5kZXggMDQxYTA2YTYwM2YzNmYxNzEyNmIwNjYwZDYw NzdiMWVlYzZkMjZlNC4uYzY4MWE2M2UzNzg4MGI3NWM2YzQ5MTU2MzA2NzZjMjgxMjkwNzE5OCAx MDA3NTUKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191bml0dGVzdC5weQpAQCAtMTU1LDcgKzE1 NSw3IEBAIGNsYXNzIFJ1bkxMSU5UQ0xvb3BUZXN0c1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgog ICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoRkFJTFVSRSwgWyc1IHJlZ3Jlc3Npb25zIGZvdW5k LiddLCAxLCAgJyAgICA1IHJlZ3Jlc3Npb25zIGZvdW5kLicpCiAKICAgICBkZWYgdGVzdF9mYWls dXJlKHNlbGYpOgotICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoRkFJTFVSRSwgWycxIHJlZ3Jl c3Npb25zIGZvdW5kLiddLCAxLCAgJyAgICAxIHJlZ3Jlc3Npb24gZm91bmQuJykKKyAgICAgICAg c2VsZi5hc3NlcnRSZXN1bHRzKEZBSUxVUkUsIFsnMSByZWdyZXNzaW9uIGZvdW5kLiddLCAxLCAg JyAgICAxIHJlZ3Jlc3Npb24gZm91bmQuJykKIAogICAgIGRlZiB0ZXN0X25vX2ZhaWx1cmUoc2Vs Zik6CiAgICAgICAgIHNlbGYuYXNzZXJ0UmVzdWx0cyhTVUNDRVNTLCBbJ3dlYmtpdC1qc2MtY2xv b3AtdGVzdCddLCAwLCAgJyAgICAwIHJlZ3Jlc3Npb25zIGZvdW5kLicpCkBAIC0xNzYsNyArMTc2 LDcgQEAgY2xhc3MgUnVuMzJiaXRKU0NUZXN0c1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAg ICAgICBzZWxmLmFzc2VydFJlc3VsdHMoRkFJTFVSRSwgWyc1IHJlZ3Jlc3Npb25zIGZvdW5kLidd LCAxLCAgJyAgICA1IGZhaWx1cmVzIGZvdW5kLicpCiAKICAgICBkZWYgdGVzdF9mYWlsdXJlKHNl bGYpOgotICAgICAgICBzZWxmLmFzc2VydFJlc3VsdHMoRkFJTFVSRSwgWycxIHJlZ3Jlc3Npb25z IGZvdW5kLiddLCAxLCAgJyAgICAxIGZhaWx1cmUgZm91bmQuJykKKyAgICAgICAgc2VsZi5hc3Nl cnRSZXN1bHRzKEZBSUxVUkUsIFsnMSByZWdyZXNzaW9uIGZvdW5kLiddLCAxLCAgJyAgICAxIGZh aWx1cmUgZm91bmQuJykKIAogICAgIGRlZiB0ZXN0X25vX2ZhaWx1cmUoc2VsZik6CiAgICAgICAg IHNlbGYuYXNzZXJ0UmVzdWx0cyhTVUNDRVNTLCBbJ3dlYmtpdC0zMmJpdC1qc2MtdGVzdCddLCAw LCAgJyAgICAwIGZhaWx1cmVzIGZvdW5kLicpCkBAIC0xODcsNyArMTg3LDggQEAgY2xhc3MgUnVu VW5pdFRlc3RzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIGlmIGV4cGVjdGVkX2Zh aWx1cmVfY291bnQ6CiAgICAgICAgICAgICByYyA9IDEKICAgICAgICAgICAgIGV4cGVjdGVkX3Jl c3VsdHMgPSBGQUlMVVJFCi0gICAgICAgICAgICBleHBlY3RlZF90ZXh0ID0gJ3swfSB1bml0IHRl c3RzIGZhaWxlZCBvciB0aW1lZCBvdXQnLmZvcm1hdChleHBlY3RlZF9mYWlsdXJlX2NvdW50KQor ICAgICAgICAgICAgcGx1cmFsX3N1ZmZpeCA9ICIiIGlmIGV4cGVjdGVkX2ZhaWx1cmVfY291bnQg PT0gMSBlbHNlICJzIgorICAgICAgICAgICAgZXhwZWN0ZWRfdGV4dCA9ICclZCB1bml0IHRlc3Ql cyBmYWlsZWQgb3IgdGltZWQgb3V0JyAlIChleHBlY3RlZF9mYWlsdXJlX2NvdW50LCBwbHVyYWxf c3VmZml4KQogICAgICAgICBlbHNlOgogICAgICAgICAgICAgcmMgPSAwCiAgICAgICAgICAgICBl eHBlY3RlZF9yZXN1bHRzID0gU1VDQ0VTUwo=