140877 2015-01-25 22:33:44 -0800 Leaks bot shouldn't run JSC tests 2015-01-26 10:18:14 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue dburkart ggaren glenn lforschler matthew_hanson ossy oldest_to_newest 1064080 0 ap 2015-01-25 22:33:44 -0800 JSC tests take 48 minutes on leaks bot, and do not even have leaks checking enabled. I'm not quite sure why the tests are so much slower here than on other testers (the machine is weaker than others, but not by that much). In any case, there is no reason to run anything but layout tests on the leaks bot, the rest just duplicates what other testers do. 1064083 1 245327 ap 2015-01-25 22:36:44 -0800 Created attachment 245327 proposed patch 1064182 2 245327 commit-queue 2015-01-26 10:18:10 -0800 Comment on attachment 245327 proposed patch Clearing flags on attachment: 245327 Committed r179122: <http://trac.webkit.org/changeset/179122> 1064183 3 commit-queue 2015-01-26 10:18:14 -0800 All reviewed patches have been landed. Closing bug. 245327 2015-01-25 22:36:44 -0800 2015-01-26 10:18:10 -0800 proposed patch NoJSCOnLeaksQueue.txt text/plain 5241 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3OTEwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE1LTAxLTI1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIExlYWtzIGJvdCBzaG91bGRuJ3QgcnVuIEpTQyB0ZXN0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwODc3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2hhdmVzIG9mZiA0OCBtaW51 dGVzIG9mIHRpbWUuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoVGVzdExlYWtzRmFjdG9yeSk6IFNsaW0g ZG93biB0aGUgbGVha3MgcXVldWUuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXJjZmdfdW5pdHRlc3QucHk6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToKKyAgICAgICAgKElPU1NpbXVsYXRvclBvcnQucHJp bnRfbGVha3Nfc3VtbWFyeSk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5w eToKKyAgICAgICAgKE1hY1BvcnQucHJpbnRfbGVha3Nfc3VtbWFyeSk6CisgICAgICAgIERvbid0 IHllbGwgd2hlbiBsZWFrcyBhcmUgZGV0ZWN0ZWQuCisKIDIwMTUtMDEtMjUgIHBlYXZvQG91dGxv b2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW1dpbl0gQWRkIFdlYktpdCBt ZXNzYWdlIGxvb3AgaW50ZXJmYWNlLgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCShyZXZpc2lv biAxNzkwNTgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9tYXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC05MDUsMTAgKzkwNSwxNSBAQCBjbGFz cyBCdWlsZEFuZFRlc3RXZWJLaXQyRmFjdG9yeShCdWlsZEFuCiBjbGFzcyBCdWlsZEFuZE5vbkxh eW91dFRlc3RGYWN0b3J5KEJ1aWxkQW5kVGVzdEZhY3RvcnkpOgogICAgIExheW91dFRlc3RDbGFz cyA9IE5vbmUKIAotY2xhc3MgVGVzdExlYWtzRmFjdG9yeShUZXN0RmFjdG9yeSk6Ci0gICAgTGF5 b3V0VGVzdENsYXNzID0gUnVuV2ViS2l0TGVha1Rlc3RzCi0gICAgRXh0cmFjdFRlc3RSZXN1bHRz Q2xhc3MgPSBFeHRyYWN0VGVzdFJlc3VsdHNBbmRMZWFrcwotCitjbGFzcyBUZXN0TGVha3NGYWN0 b3J5KEZhY3RvcnkpOgorICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJh dGlvbiwgYXJjaGl0ZWN0dXJlcywgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCBTVk5NaXJyb3I9 Tm9uZSk6CisgICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3Vy YXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRpdGlvbmFsQXJndW1lbnRzLCBTVk5NaXJy b3IpCisgICAgICAgIHNlbGYuYWRkU3RlcChEb3dubG9hZEJ1aWx0UHJvZHVjdCgpKQorICAgICAg ICBzZWxmLmFkZFN0ZXAoRXh0cmFjdEJ1aWx0UHJvZHVjdCgpKQorICAgICAgICBzZWxmLmFkZFN0 ZXAoUnVuV2ViS2l0TGVha1Rlc3RzKGJ1aWxkSlNDVG9vbD0ocGxhdGZvcm0gIT0gJ3dpbicpKSkg IyBGSVhNRTogV2h5IGlzIGJ1aWxkSlNDVG9vbCBuZWVkZWQ/CisgICAgICAgIHNlbGYuYWRkU3Rl cChBcmNoaXZlVGVzdFJlc3VsdHMoKSkKKyAgICAgICAgc2VsZi5hZGRTdGVwKFVwbG9hZFRlc3RS ZXN1bHRzKCkpCisgICAgICAgIHNlbGYuYWRkU3RlcChFeHRyYWN0VGVzdFJlc3VsdHNBbmRMZWFr cygpKQogCiBjbGFzcyBUZXN0V2ViS2l0MkZhY3RvcnkoVGVzdEZhY3RvcnkpOgogICAgIExheW91 dFRlc3RDbGFzcyA9IFJ1bldlYktpdDJUZXN0cwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21h c3RlcmNmZ191bml0dGVzdC5weQkocmV2aXNpb24gMTc5MDU4KQorKysgVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5CSh3 b3JraW5nIGNvcHkpCkBAIC01MSwxMiArNTEsMTIgQEAgY2xhc3MgTWFzdGVyQ2ZnVGVzdCh1bml0 dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfbnJ3dF9sZWFrc19wYXJzaW5nKHNlbGYpOgog ICAgICAgICBydW5fd2Via2l0X3Rlc3RzID0gUnVuV2ViS2l0VGVzdHMoKSAgIyBweWxpbnQgaXMg Y29uZnVzZWQgYnkgdGhlIHdheSB3ZSBpbXBvcnQgdGhlIG1vZHVsZSAuLi4gcHlsaW50OiBkaXNh YmxlLW1zZz1FMDYwMgogICAgICAgICBsb2dfdGV4dCA9ICIiIgotMTI6NDQ6MjQuMjk1IDc3NzA2 IDEzOTgxIHRvdGFsIGxlYWtzIGZvdW5kIGZvciBhIHRvdGFsIG9mIDE5Nyw5MzYgYnl0ZXMhCi0x Mjo0NDoyNC4yOTUgNzc3MDYgMSB1bmlxdWUgbGVha3MgZm91bmQhCisxMjo0NDoyNC4yOTUgNzc3 MDYgMTM5ODEgdG90YWwgbGVha3MgZm91bmQgZm9yIGEgdG90YWwgb2YgMTk3LDkzNiBieXRlcy4K KzEyOjQ0OjI0LjI5NSA3NzcwNiAxIHVuaXF1ZSBsZWFrcyBmb3VuZC4KICIiIgogICAgICAgICBl eHBlY3RlZF9pbmNvcnJlY3RfbGluZXMgPSBbCi0gICAgICAgICAgICAnMTM5ODEgdG90YWwgbGVh a3MgZm91bmQgZm9yIGEgdG90YWwgb2YgMTk3LDkzNiBieXRlcyEnLAotICAgICAgICAgICAgJzEg dW5pcXVlIGxlYWtzIGZvdW5kIScsCisgICAgICAgICAgICAnMTM5ODEgdG90YWwgbGVha3MgZm91 bmQgZm9yIGEgdG90YWwgb2YgMTk3LDkzNiBieXRlcy4nLAorICAgICAgICAgICAgJzEgdW5pcXVl IGxlYWtzIGZvdW5kLicsCiAgICAgICAgIF0KICAgICAgICAgcnVuX3dlYmtpdF90ZXN0cy5fcGFy c2VSdW5XZWJLaXRUZXN0c091dHB1dChsb2dfdGV4dCkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bChydW5fd2Via2l0X3Rlc3RzLmluY29ycmVjdExheW91dExpbmVzLCBleHBlY3RlZF9pbmNvcnJl Y3RfbGluZXMpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkJKHJldmlzaW9uIDE3 OTA1OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkJKHdvcmtpbmcgY29w eSkKQEAgLTIzMCw4ICsyMzAsOCBAQCBjbGFzcyBJT1NTaW11bGF0b3JQb3J0KFBvcnQpOgogICAg ICAgICAgICAgcmV0dXJuCiAgICAgICAgIHRvdGFsX2J5dGVzX3N0cmluZywgdW5pcXVlX2xlYWtz ID0gc2VsZi5fbGVha19kZXRlY3Rvci5jb3VudF90b3RhbF9ieXRlc19hbmRfdW5pcXVlX2xlYWtz KGxlYWtzX2ZpbGVzKQogICAgICAgICB0b3RhbF9sZWFrcyA9IHNlbGYuX2xlYWtfZGV0ZWN0b3Iu Y291bnRfdG90YWxfbGVha3MobGVha3NfZmlsZXMpCi0gICAgICAgIF9sb2cuaW5mbygiJXMgdG90 YWwgbGVha3MgZm91bmQgZm9yIGEgdG90YWwgb2YgJXMhIiAlICh0b3RhbF9sZWFrcywgdG90YWxf Ynl0ZXNfc3RyaW5nKSkKLSAgICAgICAgX2xvZy5pbmZvKCIlcyB1bmlxdWUgbGVha3MgZm91bmQh IiAlIHVuaXF1ZV9sZWFrcykKKyAgICAgICAgX2xvZy5pbmZvKCIlcyB0b3RhbCBsZWFrcyBmb3Vu ZCBmb3IgYSB0b3RhbCBvZiAlcy4iICUgKHRvdGFsX2xlYWtzLCB0b3RhbF9ieXRlc19zdHJpbmcp KQorICAgICAgICBfbG9nLmluZm8oIiVzIHVuaXF1ZSBsZWFrcyBmb3VuZC4iICUgdW5pcXVlX2xl YWtzKQogCiAgICAgZGVmIF9wYXRoX3RvX3dlYmNvcmVfbGlicmFyeShzZWxmKToKICAgICAgICAg cmV0dXJuIHNlbGYuX2J1aWxkX3BhdGgoJ1dlYkNvcmUuZnJhbWV3b3JrL1ZlcnNpb25zL0EvV2Vi Q29yZScpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWMucHkJKHJldmlzaW9uIDE3OTA1 OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWMucHkJKHdvcmtpbmcgY29weSkK QEAgLTE3Miw4ICsxNzIsOCBAQCBjbGFzcyBNYWNQb3J0KEFwcGxlUG9ydCk6CiAgICAgICAgICAg ICByZXR1cm4KICAgICAgICAgdG90YWxfYnl0ZXNfc3RyaW5nLCB1bmlxdWVfbGVha3MgPSBzZWxm Ll9sZWFrX2RldGVjdG9yLmNvdW50X3RvdGFsX2J5dGVzX2FuZF91bmlxdWVfbGVha3MobGVha3Nf ZmlsZXMpCiAgICAgICAgIHRvdGFsX2xlYWtzID0gc2VsZi5fbGVha19kZXRlY3Rvci5jb3VudF90 b3RhbF9sZWFrcyhsZWFrc19maWxlcykKLSAgICAgICAgX2xvZy5pbmZvKCIlcyB0b3RhbCBsZWFr cyBmb3VuZCBmb3IgYSB0b3RhbCBvZiAlcyEiICUgKHRvdGFsX2xlYWtzLCB0b3RhbF9ieXRlc19z dHJpbmcpKQotICAgICAgICBfbG9nLmluZm8oIiVzIHVuaXF1ZSBsZWFrcyBmb3VuZCEiICUgdW5p cXVlX2xlYWtzKQorICAgICAgICBfbG9nLmluZm8oIiVzIHRvdGFsIGxlYWtzIGZvdW5kIGZvciBh IHRvdGFsIG9mICVzLiIgJSAodG90YWxfbGVha3MsIHRvdGFsX2J5dGVzX3N0cmluZykpCisgICAg ICAgIF9sb2cuaW5mbygiJXMgdW5pcXVlIGxlYWtzIGZvdW5kLiIgJSB1bmlxdWVfbGVha3MpCiAK ICAgICBkZWYgX2NoZWNrX3BvcnRfYnVpbGQoc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLmdl dF9vcHRpb24oJ25vamF2YScpIG9yIHNlbGYuX2J1aWxkX2phdmFfdGVzdF9zdXBwb3J0KCkK