140863 2015-01-25 00:50:36 -0800 Setting HTMLMarqueeElement.trueSpeed doesn't work 2015-01-25 20:05:02 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=15263 P2 Normal --- 140851 1 ap ap cdumez commit-queue esprehn+autocc gyuyoung.kim kling oldest_to_newest 1063983 0 ap 2015-01-25 00:50:36 -0800 HTMLMarqueeElement.trueSpeed is a boolean property, so setting it it to true sets an empty value. void Element::setBooleanAttribute(const QualifiedName& name, bool value) { if (value) setAttribute(name, emptyAtom); else removeAttribute(name); } But then HTMLMarqueeElement::minimumDelay() treats an empty value as false. 1064003 1 245308 ap 2015-01-25 09:53:15 -0800 Created attachment 245308 proposed fix 1064067 2 245308 commit-queue 2015-01-25 20:04:56 -0800 Comment on attachment 245308 proposed fix Clearing flags on attachment: 245308 Committed r179102: <http://trac.webkit.org/changeset/179102> 1064068 3 commit-queue 2015-01-25 20:05:02 -0800 All reviewed patches have been landed. Closing bug. 245308 2015-01-25 09:53:15 -0800 2015-01-25 20:04:56 -0800 proposed fix TrueSpeed.txt text/plain 3830 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTA4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTI1ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFNldHRpbmcgSFRNTE1hcnF1 ZWVFbGVtZW50LnRydWVTcGVlZCBkb2Vzbid0IHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDg2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvaHRtbC9tYXJxdWVlLXNldC10cnVl c3BlZWQuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MTWFycXVlZUVsZW1lbnQuY3BwOiAoV2Vi Q29yZTo6SFRNTE1hcnF1ZWVFbGVtZW50OjptaW5pbXVtRGVsYXkpOgorICAgICAgICBDaGVjayB0 aGUgYm9vbGVhbiBhdHRyaWJ1dGUgcHJvcGVybHkgLSBhbiBlbXB0eSB2YWx1ZSBpcyB0cnVlLgor CiAyMDE1LTAxLTI1ICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBMb25nIHNwaW5zIHVuZGVyIEZyYW1lOjpyYW5nZUZvclBvaW50IHdoZW4gZG9p bmcgTG9va3VwIG9uIGZlZWRseS5jb20KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1h cnF1ZWVFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN YXJxdWVlRWxlbWVudC5jcHAJKHJldmlzaW9uIDE3OTA1OCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTE1hcnF1ZWVFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEsNyArNTEsNyBA QCBSZWY8SFRNTE1hcnF1ZWVFbGVtZW50PiBIVE1MTWFycXVlZUVsZW1lCiAKIGludCBIVE1MTWFy cXVlZUVsZW1lbnQ6Om1pbmltdW1EZWxheSgpIGNvbnN0CiB7Ci0gICAgaWYgKGZhc3RHZXRBdHRy aWJ1dGUodHJ1ZXNwZWVkQXR0cikuaXNFbXB0eSgpKSB7CisgICAgaWYgKCFmYXN0SGFzQXR0cmli dXRlKHRydWVzcGVlZEF0dHIpKSB7CiAgICAgICAgIC8vIFdpbklFIHVzZXMgNjBtcyBhcyB0aGUg bWluaW11bSBkZWxheSBieSBkZWZhdWx0LgogICAgICAgICByZXR1cm4gNjA7CiAgICAgfQpJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gMTc5MDg3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDEtMjUgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgU2V0dGluZyBIVE1MTWFycXVlZUVsZW1lbnQudHJ1 ZVNwZWVkIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQwODYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVmVyaWZ5IHRoYXQgc2V0dGluZyBzY3JvbGxEZWxheSB0byBhIHZhbHVlIHVu ZGVyIDYwIGFjdHVhbGx5IHdvcmtzIHdoZW4gdHJ1ZVNwZWVkIGlzIHNldC4KKworICAgICAgICAq IGZhc3QvaHRtbC9tYXJxdWVlLXNldC10cnVlc3BlZWQtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisg ICAgICAgICogZmFzdC9odG1sL21hcnF1ZWUtc2V0LXRydWVzcGVlZC5odG1sOiBBZGRlZC4KKwog MjAxNS0wMS0yNSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIGdhcmRlbmluZyBmb3IgRUZMIHBvcnQuCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2h0bWwvbWFycXVlZS1zZXQtdHJ1ZXNwZWVkLWV4cGVjdGVkLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9odG1sL21hcnF1ZWUtc2V0LXRydWVzcGVlZC1leHBl Y3RlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9odG1sL21hcnF1ZWUt c2V0LXRydWVzcGVlZC1leHBlY3RlZC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMyBA QAorPGJvZHk+Cis8cD5WZXJpZnkgdGhhdCBzZXR0aW5nIHRydWVTcGVlZCBhdHRyaWJ1dGUgd29y a3MuPC9wPgorPGRpdj5UZXN0PC9kaXY+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0 cy9mYXN0L2h0bWwvbWFycXVlZS1zZXQtdHJ1ZXNwZWVkLWV4cGVjdGVkLmh0bWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpBZGRlZDogc3ZuOm1pbWUtdHlwZQojIyAtMCwwICsxICMjCit0ZXh0L2h0bWwKXCBObyBuZXds aW5lIGF0IGVuZCBvZiBwcm9wZXJ0eQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9odG1sL21hcnF1 ZWUtc2V0LXRydWVzcGVlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaHRt bC9tYXJxdWVlLXNldC10cnVlc3BlZWQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvaHRtbC9tYXJxdWVlLXNldC10cnVlc3BlZWQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDIzIEBACis8Ym9keT4KKzxwPlZlcmlmeSB0aGF0IHNldHRpbmcgdHJ1ZVNwZWVkIGF0 dHJpYnV0ZSB3b3Jrcy48L3A+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAg IHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworCitvbmxvYWQgPSBmdW5jdGlvbigpCit7Cisg ICAgdmFyIG1hcnF1ZWUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJtYXJxdWVlIik7CisgICAg bWFycXVlZS5pbm5lckhUTUwgPSAiVGVzdCI7CisgICAgbWFycXVlZS53aWR0aCA9ICIxMDBweCI7 CisgICAgbWFycXVlZS5iZWhhdmlvciA9ICJzbGlkZSI7CisgICAgbWFycXVlZS50cnVlU3BlZWQg PSB0cnVlOworICAgIG1hcnF1ZWUuc2Nyb2xsQW1vdW50ID0gMTAwOworICAgIG1hcnF1ZWUuc2Ny b2xsRGVsYXkgPSAxOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQobWFycXVlZSk7Cisg ICAgbWFycXVlZS5vZmZzZXRUb3A7IC8vIEZvcmNlIGxheW91dCBub3csIHNvIHRoYXQgbWFycXVl ZSAxIG1zIHRpbWVyIHN0YXJ0cyBiZWZvcmUgbm90aWZ5RG9uZSAxMCBtcyBvbmUsIGFuZCBkb2Vz bid0IHJhY2UuCisgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAg fSwgMTApOworfQorPC9zY3JpcHQ+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9m YXN0L2h0bWwvbWFycXVlZS1zZXQtdHJ1ZXNwZWVkLmh0bWwKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3Zu Om1pbWUtdHlwZQojIyAtMCwwICsxICMjCit0ZXh0L2h0bWwKXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBwcm9wZXJ0eQo=