140849 2015-01-23 16:53:40 -0800 [Win] Cursor copy constructor does not initialize scale factor 2015-01-23 22:01:59 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham bfulgham oldest_to_newest 1063817 0 bfulgham 2015-01-23 16:53:40 -0800 The following layout test is failing on [insert platform] fast/events/mouse-cursor-image-set.html Probable cause: Based on the failure, it looks like the scale factor is not getting properly initialized or reported to JS: --- /home/buildbot/slave/windows-release-tests/build/OpenSource/layout-test-results/fast/events/mouse-cursor-image-set-expected.txt +++ /home/buildbot/slave/windows-release-tests/build/OpenSource/layout-test-results/fast/events/mouse-cursor-image-set-actual.txt @@ -9,72 +9,72 @@ Checking cursors with device pixel ratio of 1 ---------------------------------------------- TEST CASE: 25x25 image at 1x -Cursor Info: type=Custom hotSpot=0,0 image=25x25 +Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=8.7643683e-34 TEST CASE: 25x25 image at 2x -Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=2 +Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=2.2420775e-44 TEST CASE: 25x25 image at 1x, 30x30 image at 2x -Cursor Info: type=Custom hotSpot=0,0 image=25x25 +Cursor Info: type=Custom hotSpot=0,0 image=25x25 scale=2.2420775e-44 [... etc. ...] 1063868 1 bfulgham 2015-01-23 20:40:01 -0800 The following tests fail due to this bug: fast/events/mouse-cursor-change.html fast/events/mouse-cursor-image-set.html fast/events/mouse-cursor-multiframecur.html fast/events/mouse-cursor-no-mousemove.html fast/events/mouse-cursor.html 1063872 2 245275 bfulgham 2015-01-23 21:21:47 -0800 Created attachment 245275 Patch 1063873 3 bfulgham 2015-01-23 21:26:42 -0800 Committed r179056: <http://trac.webkit.org/changeset/179056> 1063876 4 bfulgham 2015-01-23 22:01:59 -0800 Note: A build fix was needed for Mac: Committed r179057: <https://trac.webkit.org/changeset/179057> 245275 2015-01-23 21:21:47 -0800 2015-01-23 21:24:34 -0800 Patch bug-140849-20150123212852.patch text/plain 2057 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTA1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTIzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEN1cnNvciBjb3B5 IGNvbnN0cnVjdG9yIGRvZXMgbm90IGluaXRpYWxpemUgc2NhbGUgZmFjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA4NDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3VuZCBieSBmYXN0L2V2ZW50 cy9tb3VzZS1jdXJzb3ItaW1hZ2Utc2V0Lmh0bWwKKworICAgICAgICBNYWtlIHN1cmUgdGhlIHNj YWxlIGZhY3RvciBpcyBjYXB0dXJlZCBkdXJpbmcgY29weSBjb25zdHJ1Y3Rpb24uIEFsc28gbWFr ZSBzdXJlCisgICAgICAgIGl0IGlzIHByb3Blcmx5IGluaXRpYWxpemVkIGluIHRoZSBkZWZhdWx0 IGNvbnN0cnVjdG9yLCBzaW5jZSBpdCBpdCB1c2VkIGluIHRoZQorICAgICAgICBXaW5kb3dzIHBv cnQgZm9yIHNvbWUgZGVmYXVsdCBjdXJzb3JzLgorCisgICAgICAgICogcGxhdGZvcm0vQ3Vyc29y V2luLmg6CisgICAgICAgICogcGxhdGZvcm0vd2luL0N1cnNvcldpbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDdXJzb3I6OkN1cnNvcik6IE1ha2Ugc3VyZSBjb3B5IGNvbnN0cnVjdG9yIGNhcHR1 cmVzCisgICAgICAgIHRoZSBzY2FsZSBmYWN0b3IuCisKIDIwMTUtMDEtMjMgIEJlbmphbWluIFBv dWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHBvaW50ZXIvaG92ZXIg bWVkaWEgcXVlcmllcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Vyc29yLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ3Vyc29yLmgJKHJldmlzaW9uIDE3 OTAzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0N1cnNvci5oCSh3b3JraW5nIGNvcHkp CkBAIC0xMzMsNiArMTMzLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgLy8g VGhpcyBpcyBhbiBpbnZhbGlkIEN1cnNvciBhbmQgc2hvdWxkIG5ldmVyIGFjdHVhbGx5IGdldCB1 c2VkLgogICAgICAgICAgICAgOiBtX3R5cGUoc3RhdGljX2Nhc3Q8VHlwZT4oLTEpKQogICAgICAg ICAgICAgLCBtX3BsYXRmb3JtQ3Vyc29yKDApCisjaWYgRU5BQkxFKE1PVVNFX0NVUlNPUl9TQ0FM RSkKKyAgICAgICAgICAgICwgbV9pbWFnZVNjYWxlRmFjdG9yKDEpCisjZW5kaWYKICNlbmRpZiAv LyAhUExBVEZPUk0oSU9TKQogICAgICAgICB7CiAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9DdXJzb3JXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9DdXJzb3JXaW4uY3BwCShyZXZpc2lvbiAxNzkwMzUpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ3Vyc29yV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjcyLDYgKzI3Miw5IEBAIEN1cnNvcjo6Q3Vyc29yKGNvbnN0IEN1cnNvciYgb3RoZXIpCiAgICAg OiBtX3R5cGUob3RoZXIubV90eXBlKQogICAgICwgbV9pbWFnZShvdGhlci5tX2ltYWdlKQogICAg ICwgbV9ob3RTcG90KG90aGVyLm1faG90U3BvdCkKKyNpZiBFTkFCTEUoTU9VU0VfQ1VSU09SX1ND QUxFKQorICAgICwgbV9pbWFnZVNjYWxlRmFjdG9yKG90aGVyLm1faW1hZ2VTY2FsZUZhY3RvcikK KyNlbmRpZgogICAgICwgbV9wbGF0Zm9ybUN1cnNvcihvdGhlci5tX3BsYXRmb3JtQ3Vyc29yKQog ewogfQo=