140848 2015-01-23 16:37:51 -0800 Provide implementation for WTF::DefaultHash<bool> 2015-01-24 11:25:22 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140577 140858 1 cdumez cdumez andersca benjamin cmarcelo commit-queue koivisto mmaxfield sam oldest_to_newest 1063809 0 cdumez 2015-01-23 16:37:51 -0800 Provide implementation for WTF::DefaultHash<bool> so that we can use HashMap<std::pair<XXX, bool>> in the code base. Right now, the code has to use an integer type instead of a bool in the HashMap / HashSet to work around the issue. 1063811 1 245259 cdumez 2015-01-23 16:46:11 -0800 Created attachment 245259 Patch 1063812 2 commit-queue 2015-01-23 16:48:42 -0800 Attachment 245259 did not pass style-queue: ERROR: Source/WTF/wtf/HashFunctions.h:176: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1063906 3 245259 darin 2015-01-24 07:57:57 -0800 Comment on attachment 245259 Patch Do we really want to take a single bit and run the intHash(uint8_t) function on it? Any of these might be better, and would give the same result: inline unsigned intHash(bool key) { return key ? 0x62BAF5A0 : 0x4636B9C9; } inline unsigned intHash(bool key) { return 0x4636B9C9 + key * 0x1C843BD7; } inline unsigned intHash(bool key) { return 0x4636B9C9 + (((key << 30) - key) & 0x1C843BD7); } 1063912 4 245259 commit-queue 2015-01-24 08:28:18 -0800 Comment on attachment 245259 Patch Clearing flags on attachment: 245259 Committed r179061: <http://trac.webkit.org/changeset/179061> 1063913 5 commit-queue 2015-01-24 08:28:23 -0800 All reviewed patches have been landed. Closing bug. 245259 2015-01-23 16:46:11 -0800 2015-01-24 08:28:18 -0800 Patch bug-140848-20150123164611.patch text/plain 3609 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM0NjM3N2EyZWMyZWI4NDljYmI3YjYx MDI2ZGM0YTA4ZTlhYzlmNDYuLjAzZWYyZDZmY2E0OGRmYzBhNjVkMDRkMDRiYWJiMTcyNDY1OWJm MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDEtMjMgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBQcm92aWRlIGltcGxlbWVudGF0aW9uIGZvciBXVEY6OkRl ZmF1bHRIYXNoPGJvb2w+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDA4NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBQcm92aWRlIGltcGxlbWVudGF0aW9uIGZvciBXVEY6OkRlZmF1bHRIYXNoPGJvb2w+ IHNvIHRoYXQgd2UgY2FuIHVzZQorICAgICAgICBIYXNoTWFwPHN0ZDo6cGFpcjxYWFgsIGJvb2w+ PiBpbiB0aGUgY29kZSBiYXNlLiBSaWdodCBub3csIHdlIG5lZWQgdG8KKyAgICAgICAgdXNlIHNv bWUgaW50ZWdlciB0eXBlIHRvIHdvcmsgYXJvdW5kIHRoZSBpc3N1ZS4KKworICAgICAgICAqIHd0 Zi9IYXNoRnVuY3Rpb25zLmg6CisKIDIwMTUtMDEtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBtaXNzaW5nIG51bGwgY2hl Y2sgaW4gc29tZSBkZXJlZkdQdHIgaW1wbGVtZW50YXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E3OTU1 ZDFmMzRiYTU4ZjEzN2I2NWY3OTgwYjNhYzhhNWVkOTA0Ny4uYThjYjJiNzQyZGQ0YzU5ZDUzNjVj NTM2YTdlNmVjMjA3YmI3NmRmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAx LTIzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUHJvdmlkZSBp bXBsZW1lbnRhdGlvbiBmb3IgV1RGOjpEZWZhdWx0SGFzaDxib29sPgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwODQ4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIEhhc2hNYXA8c3RkOjpwYWlyPFVD aGFyMzIsIGJvb2w+PiB0eXBlIGluIEZvbnQuY3BwIGZvcgorICAgICAgICBDaGFyYWN0ZXJGYWxs YmFja01hcCBpbnN0ZWFkIG9mIEhhc2hNYXA8c3RkOjpwYWlyPFVDaGFyMzIsIHVuc2lnbmVkPj4u CisgICAgICAgIEl0IGJ1aWxkcyBub3cgdGhhdCBXVEY6OkRlZmF1bHRIYXNoPGJvb2w+IGlzIGRl ZmluZWQgaW4gV1RGLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGb250OjpyZW1vdmVGcm9tU3lzdGVtRmFsbGJhY2tDYWNoZSk6CisK IDIwMTUtMDEtMjMgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAg ICBIaXQgdGVzdCByZXR1cm5zIGluY29ycmVjdCByZXN1bHRzIHdoZW4gcGVyZm9ybWVkIGluIHBh Z2luYXRlZCBjb250ZW50IG92ZXIgdGhlIHBhZ2UgZ2Fwcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL0hhc2hGdW5jdGlvbnMuaCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hGdW5jdGlvbnMuaApp bmRleCAxY2ViNzA4ZjU4OGQyMDgxMzcxNDQwYmEyODNjZGM5M2VlZGI0MTE4Li5jNDA5N2FkYWZk NDhmYzg0OTIyNGVjNGFmODU5MGY3YzA0NTA2MzA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9IYXNoRnVuY3Rpb25zLmgKKysrIGIvU291cmNlL1dURi93dGYvSGFzaEZ1bmN0aW9ucy5oCkBA IC0xNzMsNiArMTczLDcgQEAgbmFtZXNwYWNlIFdURiB7CiAKICAgICAvLyBtYWtlIEludEhhc2gg dGhlIGRlZmF1bHQgaGFzaCBmdW5jdGlvbiBmb3IgbWFueSBpbnRlZ2VyIHR5cGVzCiAKKyAgICB0 ZW1wbGF0ZTw+IHN0cnVjdCBEZWZhdWx0SGFzaDxib29sPiB7IHR5cGVkZWYgSW50SGFzaDx1aW50 OF90PiBIYXNoOyB9OwogICAgIHRlbXBsYXRlPD4gc3RydWN0IERlZmF1bHRIYXNoPHNob3J0PiB7 IHR5cGVkZWYgSW50SGFzaDx1bnNpZ25lZD4gSGFzaDsgfTsKICAgICB0ZW1wbGF0ZTw+IHN0cnVj dCBEZWZhdWx0SGFzaDx1bnNpZ25lZCBzaG9ydD4geyB0eXBlZGVmIEludEhhc2g8dW5zaWduZWQ+ IEhhc2g7IH07CiAgICAgdGVtcGxhdGU8PiBzdHJ1Y3QgRGVmYXVsdEhhc2g8aW50PiB7IHR5cGVk ZWYgSW50SGFzaDx1bnNpZ25lZD4gSGFzaDsgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvRm9udC5jcHAKaW5kZXggOTc1NzExYjUxZGE1MjljZjc2NGU5YThhOTk4Y2VkNzM0OTFk OGM5Ni4uZWYwNmQzOTM3NmNiNTI2Yjc4N2Y0MDRhOWFmODJjZmMwOTBjZWFiZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAKQEAgLTM5Nyw3ICszOTcsOCBAQCBi b29sIEZvbnQ6OmFwcGx5VHJhbnNmb3JtcyhHbHlwaEJ1ZmZlckdseXBoKiBnbHlwaHMsIEdseXBo QnVmZmVyQWR2YW5jZSogYWR2YW5jZQogfQogCiAvLyBGb250cyBhcmUgbm90IHJlZidkIHRvIGF2 b2lkIGN5Y2xlcy4KLXR5cGVkZWYgSGFzaE1hcDxzdGQ6OnBhaXI8VUNoYXIzMiwgdW5zaWduZWQ+ LCBGb250Kj4gQ2hhcmFjdGVyRmFsbGJhY2tNYXA7Cit0eXBlZGVmIHN0ZDo6cGFpcjxVQ2hhcjMy LCBib29sIC8qIGlzRm9yUGxhdGZvcm1Gb250ICovPiBDaGFyYWN0ZXJGYWxsYmFja01hcEtleTsK K3R5cGVkZWYgSGFzaE1hcDxDaGFyYWN0ZXJGYWxsYmFja01hcEtleSwgRm9udCo+IENoYXJhY3Rl ckZhbGxiYWNrTWFwOwogdHlwZWRlZiBIYXNoTWFwPGNvbnN0IEZvbnQqLCBDaGFyYWN0ZXJGYWxs YmFja01hcD4gU3lzdGVtRmFsbGJhY2tDYWNoZTsKIAogc3RhdGljIFN5c3RlbUZhbGxiYWNrQ2Fj aGUmIHN5c3RlbUZhbGxiYWNrQ2FjaGUoKQpAQCAtNDQzLDcgKzQ0NCw3IEBAIHZvaWQgRm9udDo6 cmVtb3ZlRnJvbVN5c3RlbUZhbGxiYWNrQ2FjaGUoKQogICAgICAgICByZXR1cm47CiAKICAgICBm b3IgKGF1dG8mIGNoYXJhY3Rlck1hcCA6IHN5c3RlbUZhbGxiYWNrQ2FjaGUoKS52YWx1ZXMoKSkg ewotICAgICAgICBWZWN0b3I8c3RkOjpwYWlyPFVDaGFyMzIsIHVuc2lnbmVkPiwgNTEyPiB0b1Jl bW92ZTsKKyAgICAgICAgVmVjdG9yPENoYXJhY3RlckZhbGxiYWNrTWFwS2V5LCA1MTI+IHRvUmVt b3ZlOwogICAgICAgICBmb3IgKGF1dG8mIGVudHJ5IDogY2hhcmFjdGVyTWFwKSB7CiAgICAgICAg ICAgICBpZiAoZW50cnkudmFsdWUgPT0gdGhpcykKICAgICAgICAgICAgICAgICB0b1JlbW92ZS5h cHBlbmQoZW50cnkua2V5KTsK