140801 2015-01-22 16:37:42 -0800 Import fast/css/font-shorthand-line-height.html layout test from Blink 2015-01-22 20:59:50 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://src.chromium.org/viewvc/blink?view=rev&revision=184346 P2 Normal --- 140577 1 cdumez cdumez commit-queue kling koivisto oldest_to_newest 1063536 0 cdumez 2015-01-22 16:37:42 -0800 Import fast/css/font-shorthand-line-height.html layout test from Blink to get better test coverage for 'line-height' font shorthands cascades. I am working on expanding the font shorthand at parsing time (like other properties) via Bug 140577 and I want to make sure I don't break line-height in the process. 1063538 1 245184 cdumez 2015-01-22 16:40:12 -0800 Created attachment 245184 Patch 1063548 2 245184 kling 2015-01-22 17:35:11 -0800 Comment on attachment 245184 Patch Nice! 1063555 3 245184 commit-queue 2015-01-22 18:17:31 -0800 Comment on attachment 245184 Patch Clearing flags on attachment: 245184 Committed r178976: <http://trac.webkit.org/changeset/178976> 1063556 4 commit-queue 2015-01-22 18:17:39 -0800 All reviewed patches have been landed. Closing bug. 1063591 5 245184 cdumez 2015-01-22 20:59:50 -0800 Comment on attachment 245184 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245184&action=review > LayoutTests/fast/css/font-shorthand-line-height.html:27 > + shouldBe("lineHeight(system_font_2)", "'100px'"); If I understand the specification correctly (http://dev.w3.org/csswg/css-fonts/#font-prop), this is wrong: 1. "All subproperties of the ‘font’ property are first reset to their initial values. Then, those properties that are given explicit values in the ‘font’ shorthand are set to those values." 2. "system fonts may only be set as a whole; that is, the font family, size, weight, style, etc. are all set at the same time." So the line-height here should have been reset and the result should be "normal", not "100px". Chrome gives "normal" here. I will take a look to fix this but please let me know if you think I misunderstood the spec. 245184 2015-01-22 16:40:12 -0800 2015-01-22 18:17:31 -0800 Patch bug-140801-20150122164020.patch text/plain 3662 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4OTY5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzdkN2JhZjljYmJiNGNmNWZhMjMz OTRmM2FjOGJmMGFlMmI0ZjA1ZS4uNWEzNmE0MjA5NmY1YjM3MmRlY2IyMzMxMDJhNTdkNDViYzg2 ZDFjZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTIyICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wb3J0IGZhc3QvY3NzL2ZvbnQtc2hvcnRoYW5k LWxpbmUtaGVpZ2h0Lmh0bWwgbGF5b3V0IHRlc3QgZnJvbSBCbGluaworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwODAxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wb3J0IGZhc3QvY3NzL2ZvbnQtc2hv cnRoYW5kLWxpbmUtaGVpZ2h0Lmh0bWwgbGF5b3V0IHRlc3QgZnJvbSBCbGluaworICAgICAgICB0 byBnZXQgYmV0dGVyIHRlc3QgY292ZXJhZ2UgZm9yICdsaW5lLWhlaWdodCcgZm9udCBzaG9ydGhh bmRzIGNhc2NhZGVzOgorICAgICAgICBodHRwczovL3NyYy5jaHJvbWl1bS5vcmcvdmlld3ZjL2Js aW5rP3ZpZXc9cmV2JnJldmlzaW9uPTE4NDM0NgorCisgICAgICAgIEkgYW0gd29ya2luZyBvbiBl eHBhbmRpbmcgdGhlIGZvbnQgc2hvcnRoYW5kIGF0IHBhcnNpbmcgdGltZSAobGlrZQorICAgICAg ICBvdGhlciBzaG9ydGhhbmRzKSB2aWEgQnVnIDE0MDU3NyBhbmQgSSB3YW50IHRvIG1ha2Ugc3Vy ZSBJIGRvbid0IGJyZWFrCisgICAgICAgIGxpbmUtaGVpZ2h0IGluIHRoZSBwcm9jZXNzLgorCisg ICAgICAgICogZmFzdC9jc3MvZm9udC1zaG9ydGhhbmQtbGluZS1oZWlnaHQtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9mb250LXNob3J0aGFuZC1saW5lLWhlaWdodC5o dG1sOiBBZGRlZC4KKwogMjAxNS0wMS0yMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OICgxNzQ4NDcpOiBjYW4ndCB2aWV3IE5ISyhKYXBh bidzIG5hdGlvbmFsIHB1YmxpYyBicm9hZGNhc3Rpbmcgb3JnYW5pemF0aW9uKeKAmXMgbmV3cyBw YWdlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZm9udC1zaG9ydGhhbmQtbGlu ZS1oZWlnaHQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZm9udC1zaG9ydGhh bmQtbGluZS1oZWlnaHQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU5Yzc3OGY0MDRlZjE3ZWI5 MmI1MTkzMDdiNDA5NjQzNmZlZjk4OTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2Nzcy9mb250LXNob3J0aGFuZC1saW5lLWhlaWdodC1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwxNSBAQAorVGVzdCB0aGF0IGxpbmUtaGVpZ2h0IGluIGZvbnQgc2hvcnRoYW5kcyBjYXNjYWRl cyBjb3JyZWN0bHkuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGxpbmVI ZWlnaHQoc3lzdGVtX2ZvbnRfMSkgaXMgJzEwMHB4JworUEFTUyBsaW5lSGVpZ2h0KHN5c3RlbV9m b250XzIpIGlzICcxMDBweCcKK1BBU1MgbGluZUhlaWdodChzaG9ydGhhbmRfbm9ybWFsXzEpIGlz ICcxMDBweCcKK1BBU1MgbGluZUhlaWdodChzaG9ydGhhbmRfbm9ybWFsXzIpIGlzICdub3JtYWwn CitQQVNTIGxpbmVIZWlnaHQoc2hvcnRoYW5kX2xpbmVfaGVpZ2h0XzEpIGlzICcxMDBweCcKK1BB U1MgbGluZUhlaWdodChzaG9ydGhhbmRfbGluZV9oZWlnaHRfMikgaXMgJzIwMHB4JworUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvY3NzL2ZvbnQtc2hvcnRoYW5kLWxpbmUtaGVpZ2h0Lmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9mb250LXNob3J0aGFuZC1saW5lLWhlaWdodC5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjA1ZTQ3MzdiZDg1NzQ0NWI4Yjc2MDE5OGNmZDRhZmUxNjgxMWMzMmQKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9mb250LXNob3J0aGFuZC1saW5lLWhlaWdo dC5odG1sCkBAIC0wLDAgKzEsMzIgQEAKKzwhRE9DVFlQRSBodG1sPgorPHNjcmlwdCBzcmM9Ii4u Ly4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzdHlsZT4KKyAgICAjc3lzdGVt X2ZvbnRfMSB7IGZvbnQ6IGNhcHRpb247IGxpbmUtaGVpZ2h0OiAxMDBweDsgfQorICAgICNzeXN0 ZW1fZm9udF8yIHsgbGluZS1oZWlnaHQ6IDEwMHB4OyBmb250OiBjYXB0aW9uOyB9CisKKyAgICAj c2hvcnRoYW5kX25vcm1hbF8xIHsgZm9udDogMTBweCBtb25vc3BhY2U7IGxpbmUtaGVpZ2h0OiAx MDBweDsgfQorICAgICNzaG9ydGhhbmRfbm9ybWFsXzIgeyBsaW5lLWhlaWdodDogMTAwcHg7IGZv bnQ6IDEwcHggbW9ub3NwYWNlOyB9CisKKyAgICAjc2hvcnRoYW5kX2xpbmVfaGVpZ2h0XzEgeyBm b250OiAxMHB4LzIwMHB4IG1vbm9zcGFjZTsgbGluZS1oZWlnaHQ6IDEwMHB4OyB9CisgICAgI3No b3J0aGFuZF9saW5lX2hlaWdodF8yIHsgbGluZS1oZWlnaHQ6IDEwMHB4OyBmb250OiAxMHB4LzIw MHB4IG1vbm9zcGFjZTsgfQorPC9zdHlsZT4KKzxkaXYgaWQ9InN5c3RlbV9mb250XzEiPjwvZGl2 PgorPGRpdiBpZD0ic3lzdGVtX2ZvbnRfMiI+PC9kaXY+Cis8ZGl2IGlkPSJzaG9ydGhhbmRfbm9y bWFsXzEiPjwvZGl2PgorPGRpdiBpZD0ic2hvcnRoYW5kX25vcm1hbF8yIj48L2Rpdj4KKzxkaXYg aWQ9InNob3J0aGFuZF9saW5lX2hlaWdodF8xIj48L2Rpdj4KKzxkaXYgaWQ9InNob3J0aGFuZF9s aW5lX2hlaWdodF8yIj48L2Rpdj4KKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24oIlRlc3QgdGhh dCBsaW5lLWhlaWdodCBpbiBmb250IHNob3J0aGFuZHMgY2FzY2FkZXMgY29ycmVjdGx5LiIpOwor CisgICAgZnVuY3Rpb24gbGluZUhlaWdodCh0YXJnZXQpIHsKKyAgICAgICAgcmV0dXJuIGdldENv bXB1dGVkU3R5bGUodGFyZ2V0KS5saW5lSGVpZ2h0OworICAgIH0KKworICAgIHNob3VsZEJlKCJs aW5lSGVpZ2h0KHN5c3RlbV9mb250XzEpIiwgIicxMDBweCciKTsKKyAgICBzaG91bGRCZSgibGlu ZUhlaWdodChzeXN0ZW1fZm9udF8yKSIsICInMTAwcHgnIik7CisgICAgc2hvdWxkQmUoImxpbmVI ZWlnaHQoc2hvcnRoYW5kX25vcm1hbF8xKSIsICInMTAwcHgnIik7CisgICAgc2hvdWxkQmUoImxp bmVIZWlnaHQoc2hvcnRoYW5kX25vcm1hbF8yKSIsICInbm9ybWFsJyIpOworICAgIHNob3VsZEJl KCJsaW5lSGVpZ2h0KHNob3J0aGFuZF9saW5lX2hlaWdodF8xKSIsICInMTAwcHgnIik7CisgICAg c2hvdWxkQmUoImxpbmVIZWlnaHQoc2hvcnRoYW5kX2xpbmVfaGVpZ2h0XzIpIiwgIicyMDBweCci KTsKKzwvc2NyaXB0Pgo=