<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>14080</bug_id>
          
          <creation_ts>2007-06-11 17:43:38 -0700</creation_ts>
          <short_desc>Changing the hash doesn&apos;t add a history entry</short_desc>
          <delta_ts>2008-02-16 12:26:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>History</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, PlatformOnly</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Bertrand Le Roy">bleroy</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>7929</commentid>
    <comment_count>0</comment_count>
    <who name="Bertrand Le Roy">bleroy</who>
    <bug_when>2007-06-11 17:43:38 -0700</bug_when>
    <thetext>In both Firefox and Opera, setting window.location.hash to a new value creates an entry in the browser history, enabling JavaScript applications to meaningfully use the back button.
There were a number of hacks that enabled developers to emulate that behavior on older versions of Safari and Webkit, but those seem to be broken in the latest builds, including Safari 3 beta.
Safari should emulate the Firefox and Opera behavior, which is rational and easy to use.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>864</commentid>
    <comment_count>1</comment_count>
    <who name="Bertrand Le Roy">bleroy</who>
    <bug_when>2007-09-06 23:19:35 -0700</bug_when>
    <thetext>This reproes when the page is the first one that&apos;s loaded into the browser. It kind of works if another page was loaded first, but then hitting back sometimes doesn&apos;t enable the forward button, which makes history only navigatable to the past.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>865</commentid>
    <comment_count>2</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2007-09-06 23:34:35 -0700</bug_when>
    <thetext>I can&apos;t reproduce this on a current nightly for Mac. I would be highly surprised if this is different on Windows, but it&apos;s not impossible.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>855</commentid>
    <comment_count>3</comment_count>
    <who name="Bertrand Le Roy">bleroy</who>
    <bug_when>2007-09-07 00:00:09 -0700</bug_when>
    <thetext>I just downloaded the latest Windows nightly and was able to repro. Will try the Mac nightly tomorrow when I get near a Mac.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>856</commentid>
    <comment_count>4</comment_count>
      <attachid>16212</attachid>
    <who name="Bertrand Le Roy">bleroy</who>
    <bug_when>2007-09-07 00:03:47 -0700</bug_when>
    <thetext>Created attachment 16212
Here&apos;s a test page that works in Firefox and Opera

If you browse to the attached page right after opening the browser, click the button a few times, you won&apos;t be able to hit back as expected. If you navigate to something else then again to the test page and press the button a few times, you&apos;ll be able to hit back and state will be restored correctly, but forward will still be disabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>852</commentid>
    <comment_count>5</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-09-07 06:02:21 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Created an attachment (id=16212) [edit]
&gt; Here&apos;s a test page that works in Firefox and Opera
&gt; 
&gt; If you browse to the attached page right after opening the browser, click the
&gt; button a few times, you won&apos;t be able to hit back as expected. If you navigate
&gt; to something else then again to the test page and press the button a few times,
&gt; you&apos;ll be able to hit back and state will be restored correctly, but forward
&gt; will still be disabled.

Using the test page and following the instructions works for me using a local debug build of WebKit r25386 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218).

Adding PlatformOnly keyword since this appears only to be a Safari Windows issue.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>837</commentid>
    <comment_count>6</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-09-07 06:14:10 -0700</bug_when>
    <thetext>&lt;rdar://problem/5466939&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>830</commentid>
    <comment_count>7</comment_count>
    <who name="Bertrand Le Roy">bleroy</who>
    <bug_when>2007-09-07 11:39:22 -0700</bug_when>
    <thetext>I can confirm that this only affects the Windows build (but that includes the current nightly).
Everything runs smoothly on the Mac version.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70884</commentid>
    <comment_count>8</comment_count>
    <who name="Robert Blaut">webkit</who>
    <bug_when>2008-02-16 12:26:22 -0800</bug_when>
    <thetext>I&apos;ve checked the test case in the latest Webkit on Windows and it works now as expected. So the bug is FIXED</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>16212</attachid>
            <date>2007-09-07 00:03:47 -0700</date>
            <delta_ts>2007-09-07 00:03:47 -0700</delta_ts>
            <desc>Here&apos;s a test page that works in Firefox and Opera</desc>
            <filename>HistoryHash.htm</filename>
            <type>text/html</type>
            <size>1292</size>
            <attacher name="Bertrand Le Roy">bleroy</attacher>
            
              <data encoding="base64">77u/PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlv
bmFsLy9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRp
b25hbC5kdGQiPg0KDQo8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+
DQo8aGVhZD4NCiAgICA8dGl0bGU+SGFzaCBhbmQgaGlzdG9yeTwvdGl0bGU+DQogICAgPHNjcmlw
dCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPg0KICAgIHZhciBoYXNoSW5kZXggPSAwOw0KICAgIHZh
ciB0aW1lckNvb2tpZTsNCiAgICANCiAgICBmdW5jdGlvbiBvbkxvYWQoKSB7DQogICAgICAgIC8v
IHRoaXMgZG9lc24ndCBoZWxwLCBPcGVyYSBpcyBjdXJyZW50bHkgYnJva2VuOg0KICAgICAgICBp
ZiAod2luZG93Lm9wZXJhICYmIHdpbmRvdy5oaXN0b3J5KSB7DQogICAgICAgICAgICBoaXN0b3J5
Lm5hdmlnYXRpb25Nb2RlID0gJ2NvbXBhdGlibGUnOw0KICAgICAgICB9DQogICAgICAgIC8vIFNl
dC11cCB0aGUgcG9sbGluZzoNCiAgICAgICAgdGltZXJDb29raWUgPSB3aW5kb3cuc2V0VGltZW91
dChvblRpY2ssIDIwMCk7DQogICAgfQ0KICAgIA0KICAgIGZ1bmN0aW9uIG9uVGljaygpIHsNCiAg
ICAgICAgdGltZXJDb29raWUgPSBudWxsOw0KICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ
ZCgiY3VycmVudEhhc2giKS5pbm5lckhUTUwgPSAoZG9jdW1lbnQubG9jYXRpb24uaGFzaCB8fCAi
bnVsbCIpOw0KICAgICAgICB0aW1lckNvb2tpZSA9IHdpbmRvdy5zZXRUaW1lb3V0KG9uVGljaywg
MjAwKTsNCiAgICB9DQogICAgDQogICAgZnVuY3Rpb24gbWFrZU5ld0hhc2goKSB7DQogICAgICAg
IHdpbmRvdy5sb2NhdGlvbi5oYXNoID0gaGFzaEluZGV4Kys7DQogICAgfQ0KICAgIA0KICAgIGZ1
bmN0aW9uIG9uVW5sb2FkKCkgew0KICAgICAgICBpZiAodGltZXJDb29raWUpIHsNCiAgICAgICAg
ICAgIHdpbmRvdy5jbGVhclRpbWVvdXQodGltZXJDb29raWUpOw0KICAgICAgICB9DQogICAgfQ0K
ICAgIDwvc2NyaXB0Pg0KPC9oZWFkPg0KPGJvZHkgb25sb2FkPSJvbkxvYWQoKSIgb251bmxvYWQ9
Im9uVW5sb2FkKCkiPg0KICAgIDxkaXY+DQogICAgICAgIDxpbnB1dCB0eXBlPSJidXR0b24iIHZh
bHVlPSJHZW5lcmF0ZSBuZXcgaGFzaCIgb25jbGljaz0ibWFrZU5ld0hhc2goKSIgLz4NCiAgICAg
ICAgPGgxPkN1cnJlbnQgaGFzaDo8L2gxPg0KICAgICAgICA8ZGl2IGlkPSJjdXJyZW50SGFzaCI+
PC9kaXY+DQogICAgPC9kaXY+DQo8L2JvZHk+DQo8L2h0bWw+DQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>