140787 2015-01-22 14:07:31 -0800 test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports 2022-02-28 04:13:05 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140476 140637 1 ddkilzer ddkilzer ap bfulgham cgarcia commit-queue dbates ddkilzer glenn gyuyoung.kim jake.nielsen.webkit mrobinson oldest_to_newest 1063452 0 ddkilzer 2015-01-22 14:07:31 -0800 The webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses test still fails on EFL, GTK and Win ports: [1231/1425] webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses [1232/1425] webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses erred: Traceback (most recent call last): File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py", line 100, in test_ewses self._test_ews(ews_class()) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py", line 93, in _test_ews self.assert_queue_outputs(ews, expected_logs=self._default_expected_logs(ews), options=options) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/tool/commands/queuestest.py", line 100, in assert_queue_outputs self.assert_outputs(queue.begin_work_queue, "begin_work_queue", [], expected_stdout, expected_stderr, expected_exceptions, expected_logs) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/tool/commands/queuestest.py", line 66, in assert_outputs expected_logs=logs) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 93, in assert_outputs return_value = function(*args, **kwargs) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py", line 56, in begin_work_queue AbstractReviewQueue.begin_work_queue(self) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/tool/commands/queues.py", line 435, in begin_work_queue PatchProcessingQueue.begin_work_queue(self) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/tool/commands/queues.py", line 281, in begin_work_queue self._port = self._tool.port_factory.get(self._new_port_name_from_old(self.port_name, self._tool.platform)) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/port/factory.py", line 126, in get port_name = cls.determine_full_port_name(self._host, options, port_name) File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/port/ios.py", line 57, in determine_full_port_name sdk_command_output = subprocess.check_output(['/usr/bin/xcrun', '--sdk', 'iphoneos', '--show-sdk-version'], stderr=None).rstrip() File "/usr/lib/python2.7/subprocess.py", line 537, in check_output process = Popen(stdout=PIPE, *popenargs, **kwargs) File "/usr/lib/python2.7/subprocess.py", line 679, in __init__ errread, errwrite) File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory The fix is to make sure the "xcrun" command never runs on a port that doesn't have an iOS SDK installed. (The check I added earlier for running on a Mac host was apparently insufficient.) 1063453 1 ddkilzer 2015-01-22 14:10:11 -0800 Failures: EFL: <https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/19168/steps/webkitpy-test/logs/stdio> GTK: <https://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/49743/steps/webkitpy-test/logs/stdio> Win: <https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/49187/steps/webkitpy-test/logs/stdio> 1063572 2 245194 ddkilzer 2015-01-22 19:19:10 -0800 Created attachment 245194 Patch v1 (speculative fix) 1063602 3 245194 dbates 2015-01-22 22:00:35 -0800 Comment on attachment 245194 Patch v1 (speculative fix) View in context: https://bugs.webkit.org/attachment.cgi?id=245194&action=review > Tools/Scripts/webkitpy/port/ios.py:59 > - if host.platform.is_mac(): > + if os.path.isfile('/usr/bin/xcrun'): > sdk_command_output = subprocess.check_output(['/usr/bin/xcrun', '--sdk', 'iphoneos', '--show-sdk-version'], stderr=None).rstrip() > if sdk_command_output: > sdk_version = sdk_command_output OK. You may want to consider adding a FIXME comment that indicates that we check for the presence of /usr/bin/xcrun as a workaround for the unit test webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses. Maybe a better way to fix this issue is to extract the logic to query the iphoneos SDK version in IOSPort.determine_full_port_name() into a method in class PlatformInfo called iphoneSDKVersion() (or you could create a more generic function xcodeSDKVersion(sdk_name) or sdkVersion(sdk_name) that takes a string that represents that name of the SDK to lookup and returns the version of the SDK if it exists and an error value (None?) if the SDK doesn't exist). Similar to the implementation of PlatformInfo.total_bytes_memory(), PlatformInfo.iphoneSDKVersion() would call /usr/bin/xcrun --sdk iphoneos on Mac. Otherwise it would return some error value (None?). We would add an analogous method to class MockPlatformInfo that either returns a hardcoded version or None (or the value it returns could be specified by an argument passed to the constructor of MockPlatformInfo with a reasonable default value for this argument). Then we would implement IOSPort.determine_full_port_name() in terms of host.platform.iphoneSDKVersion(). 1063824 4 ddkilzer 2015-01-23 17:06:26 -0800 Committed r179046: <http://trac.webkit.org/changeset/179046> 1063862 5 ddkilzer 2015-01-23 19:51:17 -0800 (In reply to comment #4) > Committed r179046: <http://trac.webkit.org/changeset/179046> BTW, I added a FIXME comment as Dan suggested above. 245194 2015-01-22 19:19:10 -0800 2022-02-28 04:13:05 -0800 Patch v1 (speculative fix) bug-140787-20150122191918.patch text/plain 1635 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4ODY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2IxZjJlNGMxNzNlODc3NmUyYzdiYmM4Y2FlOTUxM2M4 ZWFlNTE4NS4uYjFhOThkZDFlODM1NmMzMzA5MGY5YjVmNWMyYTUxZmUyYzM0YjFiZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTAxLTIyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgdGVzdC13ZWJraXRweTogd2Via2l0cHkudG9vbC5jb21tYW5kcy5lYXJseXdhcm5pbmdz eXN0ZW1fdW5pdHRlc3QuRWFybHlXYXJuaW5nU3lzdGVtVGVzdC50ZXN0X2V3c2VzIGZhaWxzIG9u IEVGTCwgR1RLLCBXaW4gcG9ydHMKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTQwNzg3 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToKKyAgICAgICAgKElPU1BvcnQuZGV0ZXJtaW5lX2Z1 bGxfcG9ydF9uYW1lKTogSW5zdGVhZCBvZiBjaGVja2luZyB0aGUgdHlwZQorICAgICAgICBvZiB0 aGUgY3VycmVudCBob3N0LCB0ZXN0IGlmIC91c3IvYmluL3hjcnVuIGV4aXN0cyBiZWZvcmUgdHJ5 aW5nCisgICAgICAgIHRvIHVzZSBpdC4KKwogMjAxNS0wMS0yMSAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFVwZGF0ZSBjb25maWd1cmUteGNvZGUt Zm9yLWlvcy1kZXZlbG9wbWVudCB0byBjb3B5IG1pc3NpbmcgaGVhZGVycyB0byBpcGhvbmVvcyBT REsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CmluZGV4IGRjNDA3NmRmOTQyYWMzNGY2MTQw NTJjYTdiNWIyMzdkOTJkNjM4NGIuLjYyNGJmYTI0ZTAxMGE2ZmNjZTk5MDkxODgyNzU5ZmM0MzAw N2Q2ZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3MucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQpAQCAtNTMsNyArNTMsNyBAQCBj bGFzcyBJT1NQb3J0KEFwcGxlUG9ydCk6CiAgICAgZGVmIGRldGVybWluZV9mdWxsX3BvcnRfbmFt ZShjbHMsIGhvc3QsIG9wdGlvbnMsIHBvcnRfbmFtZSk6CiAgICAgICAgIGlmIHBvcnRfbmFtZSA9 PSBjbHMucG9ydF9uYW1lOgogICAgICAgICAgICAgc2RrX3ZlcnNpb24gPSAnOC4wJwotICAgICAg ICAgICAgaWYgaG9zdC5wbGF0Zm9ybS5pc19tYWMoKToKKyAgICAgICAgICAgIGlmIG9zLnBhdGgu aXNmaWxlKCcvdXNyL2Jpbi94Y3J1bicpOgogICAgICAgICAgICAgICAgIHNka19jb21tYW5kX291 dHB1dCA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KFsnL3Vzci9iaW4veGNydW4nLCAnLS1zZGsn LCAnaXBob25lb3MnLCAnLS1zaG93LXNkay12ZXJzaW9uJ10sIHN0ZGVycj1Ob25lKS5yc3RyaXAo KQogICAgICAgICAgICAgICAgIGlmIHNka19jb21tYW5kX291dHB1dDoKICAgICAgICAgICAgICAg ICAgICAgc2RrX3ZlcnNpb24gPSBzZGtfY29tbWFuZF9vdXRwdXQK