140780 2015-01-22 13:25:38 -0800 [Win] No plugin content on some sites. 2015-01-22 23:34:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen andersca bfulgham commit-queue oldest_to_newest 1063433 0 peavo 2015-01-22 13:25:38 -0800 This seems to be caused by ScriptController::createScriptInstanceForWidget() always returning null. 1063444 1 245159 peavo 2015-01-22 13:52:55 -0800 Created attachment 245159 Patch 1063484 2 bfulgham 2015-01-22 15:10:37 -0800 This may be fallout from our recent refactoring to move Plugins out of WebCore and into the WebKit library. I've currently got the Plugin tests skipped while I work through the whole set of failures. I will take a look at this soon, but maybe you will get to it sooner! :-) 1063524 3 245159 commit-queue 2015-01-22 16:18:32 -0800 Comment on attachment 245159 Patch Clearing flags on attachment: 245159 Committed r178968: <http://trac.webkit.org/changeset/178968> 1063525 4 commit-queue 2015-01-22 16:18:36 -0800 All reviewed patches have been landed. Closing bug. 1063623 5 peavo 2015-01-22 23:34:44 -0800 (In reply to comment #2) > This may be fallout from our recent refactoring to move Plugins out of > WebCore and into the WebKit library. > > I've currently got the Plugin tests skipped while I work through the whole > set of failures. I will take a look at this soon, but maybe you will get to > it sooner! :-) Thanks for reviewing! It's great that you're looking into the tests, I just noticed this during everyday browsing :) 245159 2015-01-22 13:52:55 -0800 2015-01-22 16:18:32 -0800 Patch bug-140780-20150122225246.patch text/plain 3634 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODkzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAxLTIyICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIE5vIHBsdWdp biBjb250ZW50IG9uIHNvbWUgc2l0ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDA3ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZXR1cm4gc2NyaXB0IGluc3RhbmNlIGZyb20gU2NyaXB0Q29udHJv bGxlcjo6Y3JlYXRlU2NyaXB0SW5zdGFuY2VGb3JXaWRnZXQoKSwKKyAgICAgICAgaW5zdGVhZCBv ZiBhbHdheXMgcmV0dXJuaW5nIG51bGwuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmNyZWF0 ZVNjcmlwdEluc3RhbmNlRm9yV2lkZ2V0KToKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXdC YXNlLmg6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3QmFzZTo6YmluZGluZ0luc3RhbmNl KToKKwogMjAxNS0wMS0yMiAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog ICAgICAgICBDcmFzaCBpbiBVUkw6OnByb3RvY29sKCkgYWZ0ZXIgYXBwY2FjaGUgbG9hZCBmYWls cwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxl ci5jcHAJKHJldmlzaW9uIDE3ODkzNykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Nj cmlwdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw3IEBACiAjaW5j bHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBhZ2VDb25zb2xlQ2xpZW50LmgiCiAjaW5jbHVkZSAi UGFnZUdyb3VwLmgiCisjaW5jbHVkZSAiUGx1Z2luVmlld0Jhc2UuaCIKICNpbmNsdWRlICJTY3Jp cHRTb3VyY2VDb2RlLmgiCiAjaW5jbHVkZSAiU2NyaXB0YWJsZURvY3VtZW50UGFyc2VyLmgiCiAj aW5jbHVkZSAiU2V0dGluZ3MuaCIKQEAgLTQwMyw5ICs0MDQsMTIgQEAgTlBPYmplY3QqIFNjcmlw dENvbnRyb2xsZXI6OmNyZWF0ZVNjcmlwdAogI2VuZGlmCiAKICNpZiAhUExBVEZPUk0oQ09DT0Ep Ci1QYXNzUmVmUHRyPEpTQzo6QmluZGluZ3M6Okluc3RhbmNlPiBTY3JpcHRDb250cm9sbGVyOjpj cmVhdGVTY3JpcHRJbnN0YW5jZUZvcldpZGdldChXaWRnZXQqKQorUGFzc1JlZlB0cjxKU0M6OkJp bmRpbmdzOjpJbnN0YW5jZT4gU2NyaXB0Q29udHJvbGxlcjo6Y3JlYXRlU2NyaXB0SW5zdGFuY2VG b3JXaWRnZXQoV2lkZ2V0KiB3aWRnZXQpCiB7Ci0gICAgcmV0dXJuIG51bGxwdHI7CisgICAgaWYg KCFpczxQbHVnaW5WaWV3QmFzZT4oKndpZGdldCkpCisgICAgICAgIHJldHVybiBudWxscHRyOwor CisgICAgcmV0dXJuIGRvd25jYXN0PFBsdWdpblZpZXdCYXNlPigqd2lkZ2V0KS5iaW5kaW5nSW5z dGFuY2UoKTsKIH0KICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXdCYXNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5W aWV3QmFzZS5oCShyZXZpc2lvbiAxNzg5MzYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1Bs dWdpblZpZXdCYXNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAKICNkZWZpbmUg UGx1Z2luV2lkZ2V0X2gKIAogI2luY2x1ZGUgIkF1ZGlvSGFyZHdhcmVMaXN0ZW5lci5oIgorI2lu Y2x1ZGUgIkJyaWRnZUpTQy5oIgogI2luY2x1ZGUgIlBsYXRmb3JtTGF5ZXIuaCIKICNpbmNsdWRl ICJTY3JvbGxUeXBlcy5oIgogI2luY2x1ZGUgIldpZGdldC5oIgpAQCAtNzksNiArODAsOCBAQCBw dWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0SmF2YVNjcmlwdFBhdXNlZChib29sKSB7IH0K IAorICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxKU0M6OkJpbmRpbmdzOjpJbnN0YW5jZT4gYmluZGlu Z0luc3RhbmNlKCkgeyByZXR1cm4gbnVsbHB0cjsgfQorCiBwcm90ZWN0ZWQ6CiAgICAgZXhwbGlj aXQgUGx1Z2luVmlld0Jhc2UoUGxhdGZvcm1XaWRnZXQgd2lkZ2V0ID0gMCkgOiBXaWRnZXQod2lk Z2V0KSB7IH0KIH07CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzg5MzcpCisrKyBT b3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBA QAorMjAxNS0wMS0yMiAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0BvdXRsb29rLmNvbT4KKwor ICAgICAgICBbV2luXSBObyBwbHVnaW4gY29udGVudCBvbiBzb21lIHNpdGVzLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNzgwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG92ZXJyaWRlIG1vZGlm aWVyIHRvIGJpbmRpbmdJbnN0YW5jZSBtZXRob2QuCisKKyAgICAgICAgKiBQbHVnaW5zL1BsdWdp blZpZXcuaDoKKwogMjAxNS0wMS0yMSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBbV2luXSBldmVudFNlbmRlciBkb2VzIG5vdCBzdXBwb3J0IHNjYWxlUGFn ZUJ5CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9QbHVnaW5zL1BsdWdpblZpZXcuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9QbHVnaW5zL1BsdWdpblZpZXcuaAkocmV2aXNpb24g MTc4OTM2KQorKysgU291cmNlL1dlYktpdC93aW4vUGx1Z2lucy9QbHVnaW5WaWV3LmgJKHdvcmtp bmcgY29weSkKQEAgLTEyOSw3ICsxMjksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAjaWYgRU5B QkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgICAgIE5QT2JqZWN0KiBucE9iamVjdCgpOwog I2VuZGlmCi0gICAgICAgIFBhc3NSZWZQdHI8SlNDOjpCaW5kaW5nczo6SW5zdGFuY2U+IGJpbmRp bmdJbnN0YW5jZSgpOworICAgICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8SlNDOjpCaW5kaW5nczo6 SW5zdGFuY2U+IGJpbmRpbmdJbnN0YW5jZSgpIG92ZXJyaWRlOwogCiAgICAgICAgIFBsdWdpblN0 YXR1cyBzdGF0dXMoKSBjb25zdCB7IHJldHVybiBtX3N0YXR1czsgfQogCg==