140777 2015-01-22 12:24:42 -0800 Have Counter::create() return a Ref<Counter> 2015-04-23 01:47:38 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140891 144092 1 cdumez cdumez andersca commit-queue kling koivisto oldest_to_newest 1063422 0 cdumez 2015-01-22 12:24:42 -0800 Have Counter::create() return a Ref<Counter> instead of a PassRefPtr. 1063423 1 245154 cdumez 2015-01-22 12:27:33 -0800 Created attachment 245154 Patch 1063440 2 245154 kling 2015-01-22 13:36:25 -0800 Comment on attachment 245154 Patch r=me 1063461 3 245154 commit-queue 2015-01-22 14:21:05 -0800 Comment on attachment 245154 Patch Clearing flags on attachment: 245154 Committed r178951: <http://trac.webkit.org/changeset/178951> 1063462 4 commit-queue 2015-01-22 14:21:10 -0800 All reviewed patches have been landed. Closing bug. 245154 2015-01-22 12:27:33 -0800 2015-01-22 14:21:05 -0800 Patch bug-140777-20150122122741.patch text/plain 5654 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA2NjViZDY0NmViMWQ5 NmYzMDA5ZTM5MjAyMGM4MDRjYjRkZmM3Zi4uMGYyNjBjZjYyMmI0ZmQ5YjBjN2NjM2MwZDBmYjk2 OWMzZTI2YzAzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE1LTAxLTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgSGF2ZSBDb3VudGVyOjpjcmVh dGUoKSByZXR1cm4gYSBSZWY8Q291bnRlcj4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MDc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEhhdmUgQ291bnRlcjo6Y3JlYXRlKCkgcmV0dXJuIGEgUmVmPENv dW50ZXI+IGluc3RlYWQgb2YgYSBQYXNzUmVmUHRyLgorCisgICAgICAgIFRoZSBDU1NQcmltaXRp dmVWYWx1ZSBjbGFzcyBuZWVkZWQgc29tZSB1cGRhdGVzIGFzIHdlbGwgdG8gc3VwcG9ydAorICAg ICAgICBjb25zdHJ1Y3RpbmcgYSBDU1NQcmltaXRpdmVWYWx1ZSBvYmplY3QgZnJvbSBhIFJlZjw+ LgorCisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjppbml0KToKKyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZl VmFsdWUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUpOgor ICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKToK KyAgICAgICAgKiBjc3MvQ291bnRlci5oOgorICAgICAgICAoV2ViQ29yZTo6Q291bnRlcjo6Y3Jl YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkNvdW50ZXI6OmNsb25lRm9yQ1NTT00pOgorCisyMDE1 LTAxLTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgbWFrZXBy b3AucGwgc2NyaXB0IGlzIGNhbGxlZCB0b28gbWFueSB0aW1lcyBkdXJpbmcgYnVpbGQKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDc1NgogICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTk0Njc5NDI+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlLmNwcAppbmRleCAzMTZmNmMzNGQ4MjE3MzU2YzdkYWZmMjY0YmY2MGYzNzNmYTkyMjdk Li41N2ViY2ZlMzllZWU2OWE2OTJhMzMzNjRmY2U0NzI3YWMxNzNjZjdmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKQEAgLTM3NiwxMSArMzc2LDExIEBAIHZvaWQg Q1NTUHJpbWl0aXZlVmFsdWU6OmluaXQoY29uc3QgTGVuZ3RoU2l6ZSYgbGVuZ3RoU2l6ZSwgY29u c3QgUmVuZGVyU3R5bGUqIHN0CiAgICAgbV92YWx1ZS5wYWlyID0gUGFpcjo6Y3JlYXRlKGNyZWF0 ZShsZW5ndGhTaXplLndpZHRoKCksIHN0eWxlKSwgY3JlYXRlKGxlbmd0aFNpemUuaGVpZ2h0KCks IHN0eWxlKSkubGVha1JlZigpOwogfQogCi12b2lkIENTU1ByaW1pdGl2ZVZhbHVlOjppbml0KFBh c3NSZWZQdHI8Q291bnRlcj4gYykKK3ZvaWQgQ1NTUHJpbWl0aXZlVmFsdWU6OmluaXQoUmVmPENv dW50ZXI+JiYgY291bnRlcikKIHsKICAgICBtX3ByaW1pdGl2ZVVuaXRUeXBlID0gQ1NTX0NPVU5U RVI7CiAgICAgbV9oYXNDYWNoZWRDU1NUZXh0ID0gZmFsc2U7Ci0gICAgbV92YWx1ZS5jb3VudGVy ID0gYy5sZWFrUmVmKCk7CisgICAgbV92YWx1ZS5jb3VudGVyID0gJmNvdW50ZXIubGVha1JlZigp OwogfQogCiB2b2lkIENTU1ByaW1pdGl2ZVZhbHVlOjppbml0KFBhc3NSZWZQdHI8UmVjdD4gcikK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5oIGIvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgKaW5kZXggZWRkNzYyYTA1Mjk5ZmIz MTJkZWQ1OGQ2MmJjNzcwNmI5NzE2NWY1Ny4uZWVjY2I3MzM4NzkwMjFiMTk3MWUzNWI4NmYyMGI0 ZTc5NDQ2MjZlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZh bHVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgKQEAgLTIz MiwxMSArMjMyLDE2IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPENTU1ByaW1pdGl2ZVZhbHVl PiBjcmVhdGUoY29uc3QgTGVuZ3RoJiB2YWx1ZSwgY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlKSB7 IHJldHVybiBhZG9wdFJlZigqbmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlLCBzdHlsZSkpOyB9 CiAgICAgc3RhdGljIFJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlKGNvbnN0IExlbmd0aFNp emUmIHZhbHVlLCBjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIHsgcmV0dXJuIGFkb3B0UmVmKCpu ZXcgQ1NTUHJpbWl0aXZlVmFsdWUodmFsdWUsIHN0eWxlKSk7IH0KIAotICAgIHRlbXBsYXRlPHR5 cGVuYW1lIFQ+IHN0YXRpYyBSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZShUIHZhbHVlKQor ICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHN0YXRpYyBSZWY8Q1NTUHJpbWl0aXZlVmFsdWU+IGNy ZWF0ZShjb25zdCBUJiB2YWx1ZSkKICAgICB7CiAgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3 IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlKSk7CiAgICAgfQogCisgICAgdGVtcGxhdGU8dHlwZW5h bWUgVD4gc3RhdGljIFJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gY3JlYXRlKFQmJiB2YWx1ZSkKKyAg ICB7CisgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IENTU1ByaW1pdGl2ZVZhbHVlKFdURjo6 bW92ZSh2YWx1ZSkpKTsKKyAgICB9CisKICAgICAvLyBUaGlzIHZhbHVlIGlzIHVzZWQgdG8gaGFu ZGxlIHF1aXJreSBtYXJnaW5zIGluIHJlZmxvdyByb290cyAoYm9keSwgdGQsIGFuZCB0aCkgbGlr ZSBXaW5JRS4KICAgICAvLyBUaGUgYmFzaWMgaWRlYSBpcyB0aGF0IGEgc3R5bGVzaGVldCBjYW4g dXNlIHRoZSB2YWx1ZSBfX3FlbSAoZm9yIHF1aXJreSBlbSkgaW5zdGVhZCBvZiBlbS4KICAgICAv LyBXaGVuIHRoZSBxdWlya3kgdmFsdWUgaXMgdXNlZCwgaWYgeW91J3JlIGluIHF1aXJrcyBtb2Rl LCB0aGUgbWFyZ2luIHdpbGwgY29sbGFwc2UgYXdheQpAQCAtMzc2LDEwICszODEsMTYgQEAgcHJp dmF0ZToKICAgICAgICAgaW5pdChQYXNzUmVmUHRyPFQ+KHZhbCkpOwogICAgIH0KIAotICAgIHRl bXBsYXRlPHR5cGVuYW1lIFQ+IENTU1ByaW1pdGl2ZVZhbHVlKFBhc3NSZWZQdHI8VD4gdmFsKQor ICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IENTU1ByaW1pdGl2ZVZhbHVlKFBhc3NSZWZQdHI8VD4g dmFsdWUpCisgICAgICAgIDogQ1NTVmFsdWUoUHJpbWl0aXZlQ2xhc3MpCisgICAgeworICAgICAg ICBpbml0KHZhbHVlKTsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBDU1NQcmlt aXRpdmVWYWx1ZShSZWY8VD4mJiB2YWx1ZSkKICAgICAgICAgOiBDU1NWYWx1ZShQcmltaXRpdmVD bGFzcykKICAgICB7Ci0gICAgICAgIGluaXQodmFsKTsKKyAgICAgICAgaW5pdChXVEY6Om1vdmUo dmFsdWUpKTsKICAgICB9CiAKICAgICBzdGF0aWMgdm9pZCBjcmVhdGUoaW50KTsgLy8gY29tcGls ZS10aW1lIGd1YXJkCkBAIC0zODgsNyArMzk5LDcgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgaW5p dChjb25zdCBMZW5ndGgmKTsKICAgICB2b2lkIGluaXQoY29uc3QgTGVuZ3RoU2l6ZSYsIGNvbnN0 IFJlbmRlclN0eWxlKik7Ci0gICAgdm9pZCBpbml0KFBhc3NSZWZQdHI8Q291bnRlcj4pOworICAg IHZvaWQgaW5pdChSZWY8Q291bnRlcj4mJik7CiAgICAgdm9pZCBpbml0KFBhc3NSZWZQdHI8UmVj dD4pOwogICAgIHZvaWQgaW5pdChQYXNzUmVmUHRyPFBhaXI+KTsKICAgICB2b2lkIGluaXQoUGFz c1JlZlB0cjxRdWFkPik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ291bnRlci5o IGIvU291cmNlL1dlYkNvcmUvY3NzL0NvdW50ZXIuaAppbmRleCAyMDViZjhiYmU1YWRkZTUzNTNi YmM1MWM0ZWRmMzI3MWQ3YWJkNjdmLi45OGE4YWJjZjhhYjgxODY5ZDY4YjQxNTk3NDZhYTIwZjU3 NzU4YTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ291bnRlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9Db3VudGVyLmgKQEAgLTI4LDkgKzI4LDkgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogCiBjbGFzcyBDb3VudGVyIDogcHVibGljIFJlZkNvdW50ZWQ8Q291bnRlcj4gewog cHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPENvdW50ZXI+IGNyZWF0ZShQYXNzUmVmUHRy PENTU1ByaW1pdGl2ZVZhbHVlPiBpZGVudGlmaWVyLCBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZh bHVlPiBsaXN0U3R5bGUsIFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHNlcGFyYXRvcikK KyAgICBzdGF0aWMgUmVmPENvdW50ZXI+IGNyZWF0ZShQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZh bHVlPiBpZGVudGlmaWVyLCBQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBsaXN0U3R5bGUs IFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHNlcGFyYXRvcikKICAgICB7Ci0gICAgICAg IHJldHVybiBhZG9wdFJlZihuZXcgQ291bnRlcihpZGVudGlmaWVyLCBsaXN0U3R5bGUsIHNlcGFy YXRvcikpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBDb3VudGVyKGlkZW50aWZpZXIs IGxpc3RTdHlsZSwgc2VwYXJhdG9yKSk7CiAgICAgfQogCiAgICAgU3RyaW5nIGlkZW50aWZpZXIo KSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXIgPyBtX2lkZW50aWZpZXItPmdldFN0cmluZ1Zh bHVlKCkgOiBTdHJpbmcoKTsgfQpAQCAtNTAsMTEgKzUwLDExIEBAIHB1YmxpYzoKICAgICAgICAg ICAgICYmIHNlcGFyYXRvcigpID09IG90aGVyLnNlcGFyYXRvcigpOwogICAgIH0KICAgICAKLSAg ICBQYXNzUmVmUHRyPENvdW50ZXI+IGNsb25lRm9yQ1NTT00oKSBjb25zdAorICAgIFJlZjxDb3Vu dGVyPiBjbG9uZUZvckNTU09NKCkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBjcmVhdGUo bV9pZGVudGlmaWVyID8gbV9pZGVudGlmaWVyLT5jbG9uZUZvckNTU09NKCkgOiAwCi0gICAgICAg ICAgICAsIG1fbGlzdFN0eWxlID8gbV9saXN0U3R5bGUtPmNsb25lRm9yQ1NTT00oKSA6IDAKLSAg ICAgICAgICAgICwgbV9zZXBhcmF0b3IgPyBtX3NlcGFyYXRvci0+Y2xvbmVGb3JDU1NPTSgpIDog MCk7CisgICAgICAgIHJldHVybiBjcmVhdGUobV9pZGVudGlmaWVyID8gbV9pZGVudGlmaWVyLT5j bG9uZUZvckNTU09NKCkgOiBudWxscHRyCisgICAgICAgICAgICAsIG1fbGlzdFN0eWxlID8gbV9s aXN0U3R5bGUtPmNsb25lRm9yQ1NTT00oKSA6IG51bGxwdHIKKyAgICAgICAgICAgICwgbV9zZXBh cmF0b3IgPyBtX3NlcGFyYXRvci0+Y2xvbmVGb3JDU1NPTSgpIDogbnVsbHB0cik7CiAgICAgfQog CiBwcml2YXRlOgo=