140752 2015-01-21 17:49:37 -0800 BytecodeGenerator shouldn't expose all of its member variables 2015-01-21 18:06:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140491 1 rniwa rniwa barraclough fpizlo ggaren mark.lam msaboff oldest_to_newest 1063243 0 rniwa 2015-01-21 17:49:37 -0800 Right now, all m_* members of BytecodeGenerator are public. We should make them private. 1063244 1 245103 rniwa 2015-01-21 17:52:51 -0800 Created attachment 245103 Fixes the bug 1063245 2 245103 mark.lam 2015-01-21 17:55:07 -0800 Comment on attachment 245103 Fixes the bug r=me 1063250 3 rniwa 2015-01-21 18:06:27 -0800 Committed r178882: <http://trac.webkit.org/changeset/178882> 245103 2015-01-21 17:52:51 -0800 2015-01-21 17:55:07 -0800 Fixes the bug bug-140752-20150121175259.patch text/plain 4096 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc4ODgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE1LTAxLTIxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IEJ5dGVjb2RlR2VuZXJhdG9yIHNob3VsZG4ndCBleHBvc2UgYWxsIG9mIGl0cyBtZW1iZXIgdmFy aWFibGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDA3NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCAicHJpdmF0ZToiIGFuZCByZW1vdmVkIHVudXNlZCBkYXRhIG1lbWJlcnMgYXMgZGV0ZWN0 ZWQgYnkgY2xhbmcuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3Iu Y3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3Ip OgorICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oOgorICAgICAgICAo SlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6bGFzdE9wY29kZUlEKTogQWRkZWQuIFVzZWQgaW4gQmlu YXJ5T3BOb2RlOjplbWl0Qnl0ZWNvZGUuCisgICAgICAgICogYnl0ZWNvbXBpbGVyL05vZGVzQ29k ZWdlbi5jcHA6CisgICAgICAgIChKU0M6OkJpbmFyeU9wTm9kZTo6ZW1pdEJ5dGVjb2RlKToKKwog MjAxNS0wMS0yMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IEFTU0VSVCBleHBhbmRpbmcgb2JqZWN0cyBpbiBjb25zb2xlIFBy aW1pdGl2ZUJpbmRpbmdUcmFpdHM8VD46OmFzc2VydFZhbHVlSGFzRXhwZWN0ZWRUeXBlCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVj b2RlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gMTc4NTY4KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE3Myw3ICsxNzMsNiBAQCBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IoVk0m CiAgICAgLCBtX2xvY2FsU2NvcGVEZXB0aCgwKQogICAgICwgbV9jb2RlVHlwZShHbG9iYWxDb2Rl KQogICAgICwgbV9uZXh0Q29uc3RhbnRPZmZzZXQoMCkKLSAgICAsIG1fZ2xvYmFsQ29uc3RhbnRJ bmRleCgwKQogICAgICwgbV9maXJzdExhenlGdW5jdGlvbigwKQogICAgICwgbV9sYXN0TGF6eUZ1 bmN0aW9uKDApCiAgICAgLCBtX3N0YXRpY1Byb3BlcnR5QW5hbHl6ZXIoJm1faW5zdHJ1Y3Rpb25z KQpAQCAtMjIxLDcgKzIyMCw2IEBAIEJ5dGVjb2RlR2VuZXJhdG9yOjpCeXRlY29kZUdlbmVyYXRv cihWTSYKICAgICAsIG1fbG9jYWxTY29wZURlcHRoKDApCiAgICAgLCBtX2NvZGVUeXBlKEZ1bmN0 aW9uQ29kZSkKICAgICAsIG1fbmV4dENvbnN0YW50T2Zmc2V0KDApCi0gICAgLCBtX2dsb2JhbENv bnN0YW50SW5kZXgoMCkKICAgICAsIG1fZmlyc3RMYXp5RnVuY3Rpb24oMCkKICAgICAsIG1fbGFz dExhenlGdW5jdGlvbigwKQogICAgICwgbV9zdGF0aWNQcm9wZXJ0eUFuYWx5emVyKCZtX2luc3Ry dWN0aW9ucykKQEAgLTQ2Myw3ICs0NjEsNiBAQCBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVH ZW5lcmF0b3IoVk0mCiAgICAgLCBtX2xvY2FsU2NvcGVEZXB0aCgwKQogICAgICwgbV9jb2RlVHlw ZShFdmFsQ29kZSkKICAgICAsIG1fbmV4dENvbnN0YW50T2Zmc2V0KDApCi0gICAgLCBtX2dsb2Jh bENvbnN0YW50SW5kZXgoMCkKICAgICAsIG1fZmlyc3RMYXp5RnVuY3Rpb24oMCkKICAgICAsIG1f bGFzdExhenlGdW5jdGlvbigwKQogICAgICwgbV9zdGF0aWNQcm9wZXJ0eUFuYWx5emVyKCZtX2lu c3RydWN0aW9ucykKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0 ZWNvZGVHZW5lcmF0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgJKHJldmlzaW9uIDE3ODU2OCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAkod29ya2lu ZyBjb3B5KQpAQCAtNTc2LDcgKzU3Niw5IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBib29s IGlzU3RyaWN0TW9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fY29kZUJsb2NrLT5pc1N0cmljdE1vZGUo KTsgfQogICAgICAgICAKICAgICAgICAgYm9vbCBpc0J1aWx0aW5GdW5jdGlvbigpIGNvbnN0IHsg cmV0dXJuIG1faXNCdWlsdGluRnVuY3Rpb247IH0KLSAgICAgICAgCisKKyAgICAgICAgT3Bjb2Rl SUQgbGFzdE9wY29kZUlEKCkgY29uc3QgeyByZXR1cm4gbV9sYXN0T3Bjb2RlSUQ7IH0KKwogICAg IHByaXZhdGU6CiAgICAgICAgIGZyaWVuZCBjbGFzcyBMYWJlbDsKICAgICAgICAgCkBAIC03NDEs NyArNzQzLDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHsKICAgICAgICAgICAgIHJldHVy biB3YXRjaGFibGVWYXJpYWJsZShvcGVyYW5kKSAhPSBVSU5UX01BWDsKICAgICAgICAgfQotICAg ICAgICAKKworICAgIHByaXZhdGU6CiAgICAgICAgIFZlY3RvcjxVbmxpbmtlZEluc3RydWN0aW9u LCAwLCBVbnNhZmVWZWN0b3JPdmVyZmxvdz4gbV9pbnN0cnVjdGlvbnM7CiAKICAgICAgICAgYm9v bCBtX3Nob3VsZEVtaXREZWJ1Z0hvb2tzOwpAQCAtNzg2LDkgKzc4OSw2IEBAIG5hbWVzcGFjZSBK U0MgewogCiAgICAgICAgIGludCBtX2ZpcnN0Q29uc3RhbnRJbmRleDsKICAgICAgICAgaW50IG1f bmV4dENvbnN0YW50T2Zmc2V0OwotICAgICAgICB1bnNpZ25lZCBtX2dsb2JhbENvbnN0YW50SW5k ZXg7Ci0KLSAgICAgICAgaW50IG1fZ2xvYmFsVmFyU3RvcmFnZU9mZnNldDsKIAogICAgICAgICBp bnQgbV9maXJzdExhenlGdW5jdGlvbjsKICAgICAgICAgaW50IG1fbGFzdExhenlGdW5jdGlvbjsK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVz Q29kZWdlbi5jcHAJKHJldmlzaW9uIDE3ODU2OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMyMyw3ICsx MzIzLDcgQEAgUmVnaXN0ZXJJRCogQmluYXJ5T3BOb2RlOjplbWl0Qnl0ZWNvZGUoQgogICAgIH0K IAogICAgIFJlZlB0cjxSZWdpc3RlcklEPiBzcmMxID0gZ2VuZXJhdG9yLmVtaXROb2RlRm9yTGVm dEhhbmRTaWRlKGxlZnQsIG1fcmlnaHRIYXNBc3NpZ25tZW50cywgcmlnaHQtPmlzUHVyZShnZW5l cmF0b3IpKTsKLSAgICBib29sIHdhc1R5cGVvZiA9IGdlbmVyYXRvci5tX2xhc3RPcGNvZGVJRCA9 PSBvcF90eXBlb2Y7CisgICAgYm9vbCB3YXNUeXBlb2YgPSBnZW5lcmF0b3IubGFzdE9wY29kZUlE KCkgPT0gb3BfdHlwZW9mOwogICAgIFJlZlB0cjxSZWdpc3RlcklEPiBzcmMyID0gZ2VuZXJhdG9y LmVtaXROb2RlKHJpZ2h0KTsKICAgICBnZW5lcmF0b3IuZW1pdEV4cHJlc3Npb25JbmZvKHBvc2l0 aW9uKCksIHBvc2l0aW9uKCksIHBvc2l0aW9uKCkpOwogICAgIGlmICh3YXNUeXBlb2YgJiYgKG9w Y29kZUlEID09IG9wX25lcSB8fCBvcGNvZGVJRCA9PSBvcF9uc3RyaWN0ZXEpKSB7Cg==