140746 2015-01-21 15:52:12 -0800 Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType 2015-01-21 17:03:16 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck ap commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1063219 0 joepeck 2015-01-21 15:52:12 -0800 * SUMMARY ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType. shell> run-webkit-tests --debug LayoutTests/inspector/model/remote-object-get-properties.html The objects being sent over the protocol were impure. Extra properties and incorrect property values when faking native bindings. 1063222 1 245096 joepeck 2015-01-21 15:54:55 -0800 Created attachment 245096 [PATCH] Proposed Fix 1063223 2 joepeck 2015-01-21 15:55:21 -0800 Not commit-queue yet. I'm still building with just this fix. 1063233 3 245096 commit-queue 2015-01-21 17:03:12 -0800 Comment on attachment 245096 [PATCH] Proposed Fix Clearing flags on attachment: 245096 Committed r178875: <http://trac.webkit.org/changeset/178875> 1063234 4 commit-queue 2015-01-21 17:03:16 -0800 All reviewed patches have been landed. Closing bug. 245096 2015-01-21 15:54:55 -0800 2015-01-21 17:03:12 -0800 [PATCH] Proposed Fix fix-assert.patch text/plain 4481 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiYzM0ZWY0Li5hZTI3ZDZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDEt MjEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBBU1NFUlQgZXhwYW5kaW5nIG9iamVjdHMgaW4gY29uc29sZSBQcmltaXRpdmVC aW5kaW5nVHJhaXRzPFQ+Ojphc3NlcnRWYWx1ZUhhc0V4cGVjdGVkVHlwZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNzQ2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOgor ICAgICAgICBVbnNraXAgdGhlIHRlc3Qgbm93IHRoYXQgaXMgZG9lc24ndCBBU1NFUlQgaW4gZGVi dWcgYnVpbGRzLgorCiAyMDE1LTAxLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBNYW55IGNvbXBvc2l0aW5nIHRlc3RzIGZhaWwgaW4gRHVtcFJl bmRlclRyZWUgZHVlIHRvIGNvbnRlbnRzT3BhcXVlIGRpZmZlcmVuY2UKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z CmluZGV4IDExZGI2NTguLjk4NWIyYWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNDU0LDUgKzQ1 NCwzIEBAIHdlYmtpdC5vcmcvYi8xMzk4NDAgZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVx dWVzdC1yZWN1cnNpdmUtc3luYy1ldmVudC5odG1sCiB3ZWJraXQub3JnL2IvMTQwMDQzIFsgRGVi dWcgXSBqcy9kb20vUHJvbWlzZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9i LzE0MDMwOSBjc3MzL2JhY2tncm91bmQvYmFja2dyb3VuZC1yZXBlYXQtc3BhY2UtY29udGVudC5o dG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi0KLXdlYmtpdC5vcmcvYi8xMzczMDYgaW5zcGVjdG9y L21vZGVsL3JlbW90ZS1vYmplY3QtZ2V0LXByb3BlcnRpZXMuaHRtbCBbIFNraXAgXQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKaW5kZXggOTYxMThiZS4uZTlhOWRkYyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDEtMjEgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBBU1NFUlQgZXhwYW5k aW5nIG9iamVjdHMgaW4gY29uc29sZSBQcmltaXRpdmVCaW5kaW5nVHJhaXRzPFQ+Ojphc3NlcnRW YWx1ZUhhc0V4cGVjdGVkVHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQwNzQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanM6CisgICAgICAg IERvIG5vdCBhZGQgaW1wdXJlIHByb3BlcnRpZXMgdG8gdGhlIGRlc2NyaXB0b3Igb2JqZWN0IHRo YXQgd2lsbAorICAgICAgICBldmVudHVhbGx5IGJlIHNlbnQgdG8gdGhlIGZyb250ZW5kLgorCiAy MDE1LTAxLTIxICBNYXR0aGV3IE1pcm1hbiAgPG1taXJtYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFVwZGF0ZWQgc3BsaXQgc3VjaCB0aGF0IGl0IGRvZXMgbm90IGluY2x1ZGUgdGhlIGVtcHR5IGVu ZCBvZiBpbnB1dCBzdHJpbmcgbWF0Y2guCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwppbmRleCA5M2Y5YmE5Li4yYjE1 YzEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVk U2NyaXB0U291cmNlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5q ZWN0ZWRTY3JpcHRTb3VyY2UuanMKQEAgLTQ4OCw3ICs0ODgsNyBAQCBJbmplY3RlZFNjcmlwdC5w cm90b3R5cGUgPSB7CiAgICAgICAgIGZ1bmN0aW9uIGNyZWF0ZUZha2VWYWx1ZURlc2NyaXB0b3Io bmFtZSwgZGVzY3JpcHRvciwgaXNPd25Qcm9wZXJ0eSkKICAgICAgICAgewogICAgICAgICAgICAg dHJ5IHsKLSAgICAgICAgICAgICAgICByZXR1cm4ge25hbWU6IG5hbWUsIHZhbHVlOiBvYmplY3Rb bmFtZV0sIHdyaXRhYmxlOiBkZXNjcmlwdG9yLndyaXRhYmxlLCBjb25maWd1cmFibGU6IGRlc2Ny aXB0b3IuY29uZmlndXJhYmxlLCBlbnVtZXJhYmxlOiBkZXNjcmlwdG9yLmVudW1lcmFibGV9Owor ICAgICAgICAgICAgICAgIHJldHVybiB7bmFtZTogbmFtZSwgdmFsdWU6IG9iamVjdFtuYW1lXSwg d3JpdGFibGU6IGRlc2NyaXB0b3Iud3JpdGFibGUgfHwgZmFsc2UsIGNvbmZpZ3VyYWJsZTogZGVz Y3JpcHRvci5jb25maWd1cmFibGUgfHwgZmFsc2UsIGVudW1lcmFibGU6IGRlc2NyaXB0b3IuZW51 bWVyYWJsZSB8fCBmYWxzZX07CiAgICAgICAgICAgICB9IGNhdGNoIChlKSB7CiAgICAgICAgICAg ICAgICAgdmFyIGVycm9yRGVzY3JpcHRvciA9IHtuYW1lOiBuYW1lLCB2YWx1ZTogZSwgd2FzVGhy b3duOiB0cnVlfTsKICAgICAgICAgICAgICAgICBpZiAoaXNPd25Qcm9wZXJ0eSkKQEAgLTQ5Nyw3 ICs0OTcsNyBAQCBJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9CiAg ICAgICAgIH0KIAotICAgICAgICBmdW5jdGlvbiBwcm9jZXNzRGVzY3JpcHRvcihkZXNjcmlwdG9y LCBpc093blByb3BlcnR5KQorICAgICAgICBmdW5jdGlvbiBwcm9jZXNzRGVzY3JpcHRvcihkZXNj cmlwdG9yLCBpc093blByb3BlcnR5LCBwb3NzaWJsZU5hdGl2ZUJpbmRpbmdHZXR0ZXIpCiAgICAg ICAgIHsKICAgICAgICAgICAgIC8vIE93biBwcm9wZXJ0aWVzIG9ubHkuCiAgICAgICAgICAgICBp ZiAob3duUHJvcGVydGllcykgewpAQCAtNTE0LDcgKzUxNCw3IEBAIEluamVjdGVkU2NyaXB0LnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGRlc2NyaXB0b3IuaGFzT3du UHJvcGVydHkoImdldCIpICYmIGRlc2NyaXB0b3IuZ2V0KSB7CiAgICAgICAgICAgICAgICAgICAg IC8vIEdldHRlciBwcm9wZXJ0eSBpbiB0aGUgcHJvdG90eXBlIGNoYWluLiBDcmVhdGUgYSBmYWtl IHZhbHVlIGRlc2NyaXB0b3IuCiAgICAgICAgICAgICAgICAgICAgIGRlc2NyaXB0b3JzLnB1c2go Y3JlYXRlRmFrZVZhbHVlRGVzY3JpcHRvcihkZXNjcmlwdG9yLm5hbWUsIGRlc2NyaXB0b3IsIGlz T3duUHJvcGVydHkpKTsKLSAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGRlc2NyaXB0b3IucG9z c2libGVOYXRpdmVCaW5kaW5nR2V0dGVyKSB7CisgICAgICAgICAgICAgICAgfSBlbHNlIGlmIChw b3NzaWJsZU5hdGl2ZUJpbmRpbmdHZXR0ZXIpIHsKICAgICAgICAgICAgICAgICAgICAgLy8gUG9z c2libGUgZ2V0dGVyIHByb3BlcnR5IGluIHRoZSBwcm90b3R5cGUgY2hhaW4uCiAgICAgICAgICAg ICAgICAgICAgIGRlc2NyaXB0b3JzLnB1c2goZGVzY3JpcHRvcik7CiAgICAgICAgICAgICAgICAg fQpAQCAtNTQ4LDggKzU0OCw3IEBAIEluamVjdGVkU2NyaXB0LnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgICAgICAgICAgLy8gRGV2ZWxvcGVycyBtYXkgY3JlYXRlIHN1Y2ggYSBkZXNjcmlwdG9y cywgc28gd2Ugc2hvdWxkIGJlIHJlc2lsaWVudDoKICAgICAgICAgICAgICAgICAgICAgLy8gdmFy IHggPSB7fTsgT2JqZWN0LmRlZmluZVByb3BlcnR5KHgsICJwIiwge2dldDp1bmRlZmluZWR9KTsg T2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih4LCAicCIpCiAgICAgICAgICAgICAgICAg ICAgIHZhciBmYWtlRGVzY3JpcHRvciA9IGNyZWF0ZUZha2VWYWx1ZURlc2NyaXB0b3IobmFtZSwg ZGVzY3JpcHRvciwgaXNPd25Qcm9wZXJ0eSk7Ci0gICAgICAgICAgICAgICAgICAgIGZha2VEZXNj cmlwdG9yLnBvc3NpYmxlTmF0aXZlQmluZGluZ0dldHRlciA9IHRydWU7IC8vIE5hdGl2ZSBiaW5k aW5ncy4KLSAgICAgICAgICAgICAgICAgICAgcHJvY2Vzc0Rlc2NyaXB0b3IoZmFrZURlc2NyaXB0 b3IsIGlzT3duUHJvcGVydHkpOworICAgICAgICAgICAgICAgICAgICBwcm9jZXNzRGVzY3JpcHRv cihmYWtlRGVzY3JpcHRvciwgaXNPd25Qcm9wZXJ0eSwgdHJ1ZSk7CiAgICAgICAgICAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgIH0KIAo=