140735 2015-01-21 12:00:37 -0800 [TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform 2015-02-01 03:34:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan mrobinson oldest_to_newest 1063128 0 zan 2015-01-21 12:00:37 -0800 [TexMap] Avoid unnecessary TransformationMatrix copies in GraphicsLayerTransform 1063129 1 245075 zan 2015-01-21 12:10:53 -0800 Created attachment 245075 Patch 1064791 2 245075 cdumez 2015-01-27 20:41:22 -0800 Comment on attachment 245075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review r=me % nits. > Source/WebCore/platform/graphics/GraphicsLayerTransform.h:39 > + const TransformationMatrix& combined(); Why isn't this method const? > Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40 > + const TransformationMatrix& combinedForChildren(); Ditto. 1065954 3 245075 zan 2015-02-01 02:04:12 -0800 Comment on attachment 245075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245075&action=review >> Source/WebCore/platform/graphics/GraphicsLayerTransform.h:40 >> + const TransformationMatrix& combinedForChildren(); > > Ditto. This calls combineTransformsForChildren(), which modifies m_childrenDirty and m_combinedForChildren. I prefer combinedForChildren() and combineTransformsForChildren() to be const and have m_childrenDirty and m_combinedForChildren changed to mutable. 1065957 4 zan 2015-02-01 03:34:48 -0800 Landed in r179462. http://trac.webkit.org/changeset/179462 245075 2015-01-21 12:10:53 -0800 2015-01-27 20:41:22 -0800 Patch bug-140735-20150121121308.patch text/plain 3342 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODg1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAxLTIxICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4TWFwXSBBdm9pZCB1 bm5lY2Vzc2FyeSBUcmFuc2Zvcm1hdGlvbk1hdHJpeCBjb3BpZXMgaW4gR3JhcGhpY3NMYXllclRy YW5zZm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQwNzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyVHJhbnNmb3JtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJUcmFuc2Zvcm06OmNvbWJpbmVkKTogUmV0dXJuIGEgY29u c3QgcmVmZXJlbmNlIHRvIHRoZSBtYXRyaXguCisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xh eWVyVHJhbnNmb3JtOjpjb21iaW5lZEZvckNoaWxkcmVuKTogRGl0dG8uCisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0xheWVyVHJhbnNmb3JtOjpjb21iaW5lVHJhbnNmb3Jtcyk6IEZpcnN0IGNv cHkgdGhlIHBhcmVudCB0cmFuc2Zvcm0sCisgICAgICAgIHRoZW4gYXBwbHkgdGhlIHRyYW5zbGF0 aW9uIGFuZCBtdWx0aXBsaWNhdGlvbi4gUHJldmlvdXNseSB0aGlzIGNvcGllZCB0aGUgcGFyZW50 CisgICAgICAgIHRyYW5zZm9ybSBpbnRvIGEgdGVtcG9yYXJ5IG9iamVjdCwgcGVyZm9ybWVkIHRo ZSB0cmFuc2xhdGlvbiBhbmQgbXVsdGlwbGljYXRpb24sIGFuZAorICAgICAgICBjb3BpZWQgdGhh dCB0ZW1wb3Jhcnkgb2JqZWN0IGFnYWluIHdoZW4gYXNzaWduaW5nIHRvIHRoZSBtZW1iZXIgdmFy aWFibGUuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllclRyYW5zZm9y bS5oOgorCiAyMDE1LTAxLTIwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIxNzgxODApOiBNZW1idXN0ZXIgcmVncmVzc2VkIH40JQpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllclRyYW5zZm9y bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh cGhpY3NMYXllclRyYW5zZm9ybS5jcHAJKHJldmlzaW9uIDE3ODg0OSkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJUcmFuc2Zvcm0uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC03OCwxMyArNzgsMTMgQEAgdm9pZCBHcmFwaGljc0xheWVyVHJhbnNmb3JtOjpz ZXRDaGlsZHJlbgogICAgIG1fZGlydHkgPSB0cnVlOwogfQogCi1UcmFuc2Zvcm1hdGlvbk1hdHJp eCBHcmFwaGljc0xheWVyVHJhbnNmb3JtOjpjb21iaW5lZCgpCitjb25zdCBUcmFuc2Zvcm1hdGlv bk1hdHJpeCYgR3JhcGhpY3NMYXllclRyYW5zZm9ybTo6Y29tYmluZWQoKQogewogICAgIEFTU0VS VCghbV9kaXJ0eSk7CiAgICAgcmV0dXJuIG1fY29tYmluZWQ7CiB9CiAKLVRyYW5zZm9ybWF0aW9u TWF0cml4IEdyYXBoaWNzTGF5ZXJUcmFuc2Zvcm06OmNvbWJpbmVkRm9yQ2hpbGRyZW4oKQorY29u c3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIEdyYXBoaWNzTGF5ZXJUcmFuc2Zvcm06OmNvbWJpbmVk Rm9yQ2hpbGRyZW4oKQogewogICAgIEFTU0VSVCghbV9kaXJ0eSk7CiAgICAgaWYgKG1fY2hpbGRy ZW5EaXJ0eSkKQEAgLTk2LDEwICs5NiwxMCBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJUcmFuc2Zvcm06 OmNvbWJpbmVUcmFuCiB7CiAgICAgZmxvYXQgb3JpZ2luWCA9IG1fYW5jaG9yUG9pbnQueCgpICog bV9zaXplLndpZHRoKCk7CiAgICAgZmxvYXQgb3JpZ2luWSA9IG1fYW5jaG9yUG9pbnQueSgpICog bV9zaXplLmhlaWdodCgpOwotICAgIG1fY29tYmluZWQgPQotICAgICAgICBUcmFuc2Zvcm1hdGlv bk1hdHJpeChwYXJlbnRUcmFuc2Zvcm0pCi0gICAgICAgICAgICAudHJhbnNsYXRlM2Qob3JpZ2lu WCArIG1fcG9zaXRpb24ueCgpLCBvcmlnaW5ZICsgbV9wb3NpdGlvbi55KCksIG1fYW5jaG9yUG9p bnQueigpICkKLSAgICAgICAgICAgIC5tdWx0aXBseShtX2xvY2FsKTsKKyAgICBtX2NvbWJpbmVk ID0gcGFyZW50VHJhbnNmb3JtOworICAgIG1fY29tYmluZWQKKyAgICAgICAgLnRyYW5zbGF0ZTNk KG9yaWdpblggKyBtX3Bvc2l0aW9uLngoKSwgb3JpZ2luWSArIG1fcG9zaXRpb24ueSgpLCBtX2Fu Y2hvclBvaW50LnooKSkKKyAgICAgICAgLm11bHRpcGx5KG1fbG9jYWwpOwogCiAgICAgLy8gVGhl IGNoaWxkcmVuIHRyYW5zZm9ybSB3aWxsIHRha2UgaXQgZnJvbSBoZXJlLCBpZiBpdCBnZXRzIHVz ZWQuCiAgICAgbV9jb21iaW5lZEZvckNoaWxkcmVuID0gbV9jb21iaW5lZDsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJUcmFuc2Zvcm0uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVy VHJhbnNmb3JtLmgJKHJldmlzaW9uIDE3ODg0OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJUcmFuc2Zvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMzYs OCArMzYsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRGbGF0dGVuaW5nKGJvb2wpOwogICAgIHZv aWQgc2V0TG9jYWxUcmFuc2Zvcm0oY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmKTsKICAgICB2 b2lkIHNldENoaWxkcmVuVHJhbnNmb3JtKGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4Jik7Ci0g ICAgVHJhbnNmb3JtYXRpb25NYXRyaXggY29tYmluZWQoKTsKLSAgICBUcmFuc2Zvcm1hdGlvbk1h dHJpeCBjb21iaW5lZEZvckNoaWxkcmVuKCk7CisgICAgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRy aXgmIGNvbWJpbmVkKCk7CisgICAgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIGNvbWJpbmVk Rm9yQ2hpbGRyZW4oKTsKIAogICAgIHZvaWQgY29tYmluZVRyYW5zZm9ybXMoY29uc3QgVHJhbnNm b3JtYXRpb25NYXRyaXgmIHBhcmVudFRyYW5zZm9ybSk7CiAK