140708 2015-01-20 17:28:55 -0800 Eliminate construct methods from NullGetterFunction and NullSetterFunction classes 2015-01-21 11:46:07 -0800 1 1 1 Unclassified WebKit JavaScriptCore 312.x Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 1062957 0 msaboff 2015-01-20 17:28:55 -0800 There is no need for the NullGetterFunction and NullSetterFunction classes to have a construct methods as they will never be called. 1062965 1 245037 msaboff 2015-01-20 18:02:36 -0800 Created attachment 245037 Patch 1062977 2 245037 mark.lam 2015-01-20 18:30:40 -0800 Comment on attachment 245037 Patch r=me 1063122 3 msaboff 2015-01-21 11:46:07 -0800 Committed r178855: <http://trac.webkit.org/changeset/178855> 245037 2015-01-20 18:02:36 -0800 2015-01-20 18:30:40 -0800 Patch 140708.patch text/plain 3120 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc4NzkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE1LTAxLTIwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEVsaW1pbmF0ZSBjb25zdHJ1Y3QgbWV0aG9kcyBmcm9tIE51bGxHZXR0ZXJGdW5jdGlvbiBh bmQgTnVsbFNldHRlckZ1bmN0aW9uIGNsYXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDcwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEVsaW1pbmF0ZWQgY29uc3RydWN0IG1ldGhvZHMgYW5kIGNo YW5nZSBnZXRDb25zdHJ1Y3REYXRhKCkgZm9yIGJvdGggY2xhc3NlcyB0byByZXR1cm4KKyAgICAg ICAgQ29uc3RydWN0VHlwZU5vbmUgYXMgdGhleSBjYW4gbmV2ZXIgYmUgY2FsbGVkLgorCisgICAg ICAgICogcnVudGltZS9OdWxsR2V0dGVyRnVuY3Rpb24uY3BwOgorICAgICAgICAoSlNDOjpOdWxs R2V0dGVyRnVuY3Rpb246OmdldENvbnN0cnVjdERhdGEpOgorICAgICAgICAoSlNDOjpjb25zdHJ1 Y3RSZXR1cm5VbmRlZmluZWQpOiBEZWxldGVkLgorICAgICAgICAqIHJ1bnRpbWUvTnVsbFNldHRl ckZ1bmN0aW9uLmNwcDoKKyAgICAgICAgKEpTQzo6TnVsbFNldHRlckZ1bmN0aW9uOjpnZXRDb25z dHJ1Y3REYXRhKToKKyAgICAgICAgKEpTQzo6Y29uc3RydWN0UmV0dXJuVW5kZWZpbmVkKTogRGVs ZXRlZC4KKwogMjAxNS0wMS0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsZWFudXAgUnVudGltZUFnZW50IGEgYml0Cklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdWxsR2V0dGVyRnVuY3Rpb24uY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL051bGxHZXR0ZXJG dW5jdGlvbi5jcHAJKHJldmlzaW9uIDE3ODc2MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL051bGxHZXR0ZXJGdW5jdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4LDIxICsz OCwxNSBAQCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBjYWxsCiAgICAgcmV0 dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIAotc3RhdGljIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgY29uc3RydWN0UmV0dXJuVW5kZWZpbmVkKEV4ZWNTdGF0ZSop Ci17Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKLX0KLQogQ2Fs bFR5cGUgTnVsbEdldHRlckZ1bmN0aW9uOjpnZXRDYWxsRGF0YShKU0NlbGwqLCBDYWxsRGF0YSYg Y2FsbERhdGEpCiB7CiAgICAgY2FsbERhdGEubmF0aXZlLmZ1bmN0aW9uID0gY2FsbFJldHVyblVu ZGVmaW5lZDsKICAgICByZXR1cm4gQ2FsbFR5cGVIb3N0OwogfQogCi1Db25zdHJ1Y3RUeXBlIE51 bGxHZXR0ZXJGdW5jdGlvbjo6Z2V0Q29uc3RydWN0RGF0YShKU0NlbGwqLCBDb25zdHJ1Y3REYXRh JiBjb25zdHJ1Y3REYXRhKQorQ29uc3RydWN0VHlwZSBOdWxsR2V0dGVyRnVuY3Rpb246OmdldENv bnN0cnVjdERhdGEoSlNDZWxsKiwgQ29uc3RydWN0RGF0YSYpCiB7Ci0gICAgY29uc3RydWN0RGF0 YS5uYXRpdmUuZnVuY3Rpb24gPSBjb25zdHJ1Y3RSZXR1cm5VbmRlZmluZWQ7Ci0gICAgcmV0dXJu IENvbnN0cnVjdFR5cGVIb3N0OworICAgIHJldHVybiBDb25zdHJ1Y3RUeXBlTm9uZTsKIH0KIAog fQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVsbFNldHRlckZ1bmN0aW9u LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdWxsU2V0 dGVyRnVuY3Rpb24uY3BwCShyZXZpc2lvbiAxNzg3NjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9OdWxsU2V0dGVyRnVuY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03Niwy MyArNzYsMTUgQEAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgY2FsbAogICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiB9CiAKLXN0YXRpYyBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnN0cnVjdFJldHVyblVuZGVmaW5lZChFeGVjU3Rh dGUqIGV4ZWMpCi17Ci0gICAgaWYgKGNhbGxlcklzU3RyaWN0KGV4ZWMpKQotICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKHRocm93VHlwZUVycm9yKGV4ZWMsIEFTQ0lJTGl0ZXJhbCgiU2V0 dGluZyBhIHByb3BlcnR5IHRoYXQgaGFzIG9ubHkgYSBnZXR0ZXIiKSkpOwotICAgIHJldHVybiBK U1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7Ci19Ci0KIENhbGxUeXBlIE51bGxTZXR0ZXJG dW5jdGlvbjo6Z2V0Q2FsbERhdGEoSlNDZWxsKiwgQ2FsbERhdGEmIGNhbGxEYXRhKQogewogICAg IGNhbGxEYXRhLm5hdGl2ZS5mdW5jdGlvbiA9IGNhbGxSZXR1cm5VbmRlZmluZWQ7CiAgICAgcmV0 dXJuIENhbGxUeXBlSG9zdDsKIH0KIAotQ29uc3RydWN0VHlwZSBOdWxsU2V0dGVyRnVuY3Rpb246 OmdldENvbnN0cnVjdERhdGEoSlNDZWxsKiwgQ29uc3RydWN0RGF0YSYgY29uc3RydWN0RGF0YSkK K0NvbnN0cnVjdFR5cGUgTnVsbFNldHRlckZ1bmN0aW9uOjpnZXRDb25zdHJ1Y3REYXRhKEpTQ2Vs bCosIENvbnN0cnVjdERhdGEmKQogewotICAgIGNvbnN0cnVjdERhdGEubmF0aXZlLmZ1bmN0aW9u ID0gY29uc3RydWN0UmV0dXJuVW5kZWZpbmVkOwotICAgIHJldHVybiBDb25zdHJ1Y3RUeXBlSG9z dDsKKyAgICByZXR1cm4gQ29uc3RydWN0VHlwZU5vbmU7CiB9CiAKIH0K