140706 2015-01-20 17:00:48 -0800 Web Inspector: Cleanup RuntimeAgent a bit 2015-01-20 17:54:20 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1062947 0 joepeck 2015-01-20 17:00:48 -0800 Cleanup RuntimeAgent a bit. I'm in the area, noticed some simple cleanup. 1062951 1 245036 joepeck 2015-01-20 17:04:59 -0800 Created attachment 245036 [PATCH] Proposed Fix 1062963 2 245036 commit-queue 2015-01-20 17:54:16 -0800 Comment on attachment 245036 [PATCH] Proposed Fix Clearing flags on attachment: 245036 Committed r178791: <http://trac.webkit.org/changeset/178791> 1062964 3 commit-queue 2015-01-20 17:54:20 -0800 All reviewed patches have been landed. Closing bug. 245036 2015-01-20 17:04:59 -0800 2015-01-20 17:54:16 -0800 [PATCH] Proposed Fix cleanup.patch text/plain 6268 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJiZGZlM2IuLmM2OGJiMzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTAxLTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYW51 cCBSdW50aW1lQWdlbnQgYSBiaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MDcwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0Lmg6CisgICAgICAgICogaW5z cGVjdG9yL0luc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmg6CisgICAgICAgICogaW5zcGVjdG9y L1NjcmlwdENhbGxGcmFtZS5jcHA6CisgICAgICAgICogaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0 b3JSdW50aW1lQWdlbnQuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpJbnNwZWN0b3JSdW50aW1l QWdlbnQ6OmV2YWx1YXRlKToKKyAgICAgICAgKEluc3BlY3Rvcjo6SW5zcGVjdG9yUnVudGltZUFn ZW50OjpnZXRQcm9wZXJ0aWVzKToKKyAgICAgICAgKEluc3BlY3Rvcjo6SW5zcGVjdG9yUnVudGlt ZUFnZW50OjpydW4pOgorICAgICAgICAoSW5zcGVjdG9yOjpJbnNwZWN0b3JSdW50aW1lQWdlbnQ6 OmdldFJ1bnRpbWVUeXBlc0ZvclZhcmlhYmxlc0F0T2Zmc2V0cyk6CisgICAgICAgIChJbnNwZWN0 b3I6OnJlY29tcGlsZUFsbEpTRnVuY3Rpb25zRm9yVHlwZVByb2ZpbGluZyk6CisgICAgICAgIChJ bnNwZWN0b3I6Okluc3BlY3RvclJ1bnRpbWVBZ2VudDo6c2V0VHlwZVByb2ZpbGVyRW5hYmxlZFN0 YXRlKToKKworMjAxNS0wMS0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNob3VsZCBzaG93IGR5bmFtaWMgc3BlY2lmaWNp dHkgdmFsdWVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDA2NDcKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9J bmplY3RlZFNjcmlwdC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3Rl ZFNjcmlwdC5oCmluZGV4IDY5MjM2YzguLmMzMWE2ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHQuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0LmgKQEAgLTM3LDcgKzM3LDYgQEAKICNp bmNsdWRlICJJbmplY3RlZFNjcmlwdEJhc2UuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgog I2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgotI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+ CiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgogCiBuYW1lc3BhY2UgRGVwcmVjYXRlZCB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmRE aXNwYXRjaGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luc3BlY3RvckJh Y2tlbmREaXNwYXRjaGVyLmgKaW5kZXggMjM3ZWI2ZC4uODVjNTM1OSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZERp c3BhdGNoZXIuaApAQCAtMzAsNyArMzAsNiBAQAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAKICNp bmNsdWRlICJJbnNwZWN0b3JQcm90b2NvbFR5cGVzLmgiCi0jaW5jbHVkZSA8d3RmL1Bhc3NSZWZQ dHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dU RlN0cmluZy5oPgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y L1NjcmlwdENhbGxGcmFtZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL1Nj cmlwdENhbGxGcmFtZS5jcHAKaW5kZXggMjhjMmFmNy4uOTE3YjA1NiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9TY3JpcHRDYWxsRnJhbWUuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvU2NyaXB0Q2FsbEZyYW1lLmNwcApAQCAtMzMs NyArMzMsNiBAQAogI2luY2x1ZGUgIlNjcmlwdENhbGxGcmFtZS5oIgogCiAjaW5jbHVkZSAiSW5z cGVjdG9yVmFsdWVzLmgiCi0jaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KIAogbmFtZXNwYWNl IEluc3BlY3RvciB7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvYWdlbnRzL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JSdW50aW1lQWdlbnQuY3BwCmluZGV4IGIxYTU5 OTQuLjJkYTc2NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv YWdlbnRzL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yUnVudGltZUFnZW50LmNwcApAQCAtNDYsNyAr NDYsNiBAQAogI2luY2x1ZGUgIlR5cGVQcm9maWxlci5oIgogI2luY2x1ZGUgIlR5cGVQcm9maWxl ckxvZy5oIgogI2luY2x1ZGUgIlZNRW50cnlTY29wZS5oIgotI2luY2x1ZGUgPHd0Zi9QYXNzUmVm UHRyLmg+CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBK U0M7CkBAIC0xMjksNyArMTI4LDcgQEAgdm9pZCBJbnNwZWN0b3JSdW50aW1lQWdlbnQ6OmV2YWx1 YXRlKEVycm9yU3RyaW5nJiBlcnJvclN0cmluZywgY29uc3QgU3RyaW5nJiBleHAKICAgICBpZiAo YXNCb29sKGRvTm90UGF1c2VPbkV4Y2VwdGlvbnNBbmRNdXRlQ29uc29sZSkpCiAgICAgICAgIG11 dGVDb25zb2xlKCk7CiAKLSAgICBpbmplY3RlZFNjcmlwdC5ldmFsdWF0ZShlcnJvclN0cmluZywg ZXhwcmVzc2lvbiwgb2JqZWN0R3JvdXAgPyAqb2JqZWN0R3JvdXAgOiAiIiwgYXNCb29sKGluY2x1 ZGVDb21tYW5kTGluZUFQSSksIGFzQm9vbChyZXR1cm5CeVZhbHVlKSwgYXNCb29sKGdlbmVyYXRl UHJldmlldyksICZyZXN1bHQsIHdhc1Rocm93bik7CisgICAgaW5qZWN0ZWRTY3JpcHQuZXZhbHVh dGUoZXJyb3JTdHJpbmcsIGV4cHJlc3Npb24sIG9iamVjdEdyb3VwID8gKm9iamVjdEdyb3VwIDog U3RyaW5nKCksIGFzQm9vbChpbmNsdWRlQ29tbWFuZExpbmVBUEkpLCBhc0Jvb2wocmV0dXJuQnlW YWx1ZSksIGFzQm9vbChnZW5lcmF0ZVByZXZpZXcpLCAmcmVzdWx0LCB3YXNUaHJvd24pOwogCiAg ICAgaWYgKGFzQm9vbChkb05vdFBhdXNlT25FeGNlcHRpb25zQW5kTXV0ZUNvbnNvbGUpKSB7CiAg ICAgICAgIHVubXV0ZUNvbnNvbGUoKTsKQEAgLTE3NCw3ICsxNzMsNyBAQCB2b2lkIEluc3BlY3Rv clJ1bnRpbWVBZ2VudDo6Z2V0UHJvcGVydGllcyhFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcsIGNv bnN0IFN0cmluZwogICAgIFNjcmlwdERlYnVnU2VydmVyOjpQYXVzZU9uRXhjZXB0aW9uc1N0YXRl IHByZXZpb3VzUGF1c2VPbkV4Y2VwdGlvbnNTdGF0ZSA9IHNldFBhdXNlT25FeGNlcHRpb25zU3Rh dGUobV9zY3JpcHREZWJ1Z1NlcnZlciwgU2NyaXB0RGVidWdTZXJ2ZXI6OkRvbnRQYXVzZU9uRXhj ZXB0aW9ucyk7CiAgICAgbXV0ZUNvbnNvbGUoKTsKIAotICAgIGluamVjdGVkU2NyaXB0LmdldFBy b3BlcnRpZXMoZXJyb3JTdHJpbmcsIG9iamVjdElkLCBvd25Qcm9wZXJ0aWVzID8gKm93blByb3Bl cnRpZXMgOiBmYWxzZSwgb3duQW5kR2V0dGVyUHJvcGVydGllcyA/ICpvd25BbmRHZXR0ZXJQcm9w ZXJ0aWVzIDogZmFsc2UsICZyZXN1bHQpOworICAgIGluamVjdGVkU2NyaXB0LmdldFByb3BlcnRp ZXMoZXJyb3JTdHJpbmcsIG9iamVjdElkLCBhc0Jvb2wob3duUHJvcGVydGllcyksIGFzQm9vbChv d25BbmRHZXR0ZXJQcm9wZXJ0aWVzKSwgJnJlc3VsdCk7CiAgICAgaW5qZWN0ZWRTY3JpcHQuZ2V0 SW50ZXJuYWxQcm9wZXJ0aWVzKGVycm9yU3RyaW5nLCBvYmplY3RJZCwgJmludGVybmFsUHJvcGVy dGllcyk7CiAKICAgICB1bm11dGVDb25zb2xlKCk7CkBAIC0xOTUsNiArMTk0LDcgQEAgdm9pZCBJ bnNwZWN0b3JSdW50aW1lQWdlbnQ6OnJlbGVhc2VPYmplY3RHcm91cChFcnJvclN0cmluZyYsIGNv bnN0IFN0cmluZyYgb2JqZWMKIAogdm9pZCBJbnNwZWN0b3JSdW50aW1lQWdlbnQ6OnJ1bihFcnJv clN0cmluZyYpCiB7CisgICAgLy8gRklYTUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjc2MzQ+ IFdlYiBJbnNwZWN0b3I6IHN1cHBvcnQgZGVidWdnaW5nIHdlYiB3b3JrZXJzCiB9CiAKIHZvaWQg SW5zcGVjdG9yUnVudGltZUFnZW50OjpnZXRSdW50aW1lVHlwZXNGb3JWYXJpYWJsZXNBdE9mZnNl dHMoRXJyb3JTdHJpbmcmIGVycm9yU3RyaW5nLCBjb25zdCBSZWZQdHI8SW5zcGVjdG9yOjpJbnNw ZWN0b3JBcnJheT4mJiBsb2NhdGlvbnMsIFJlZlB0cjxJbnNwZWN0b3I6OlByb3RvY29sOjpBcnJh eTxJbnNwZWN0b3I6OlByb3RvY29sOjpSdW50aW1lOjpUeXBlRGVzY3JpcHRpb24+PiYgdHlwZURl c2NyaXB0aW9ucykKQEAgLTIyNyw2ICsyMjcsNyBAQCB2b2lkIEluc3BlY3RvclJ1bnRpbWVBZ2Vu dDo6Z2V0UnVudGltZVR5cGVzRm9yVmFyaWFibGVzQXRPZmZzZXRzKEVycm9yU3RyaW5nJiBlcgog CiAgICAgICAgIGJvb2wgb2theTsKICAgICAgICAgVHlwZUxvY2F0aW9uKiB0eXBlTG9jYXRpb24g PSB2bS50eXBlUHJvZmlsZXIoKS0+ZmluZExvY2F0aW9uKGRpdm90LCBzb3VyY2VJREFzU3RyaW5n LnRvSW50UHRyU3RyaWN0KCZva2F5KSwgc3RhdGljX2Nhc3Q8VHlwZVByb2ZpbGVyU2VhcmNoRGVz Y3JpcHRvcj4oZGVzY3JpcHRvciksIHZtKTsKKyAgICAgICAgQVNTRVJUKG9rYXkpOwogCiAgICAg ICAgIFJlZlB0cjxUeXBlU2V0PiB0eXBlU2V0OwogICAgICAgICBpZiAodHlwZUxvY2F0aW9uKSB7 CkBAIC0yNzEsNyArMjcyLDcgQEAgcHVibGljOgogCiBzdGF0aWMgdm9pZCByZWNvbXBpbGVBbGxK U0Z1bmN0aW9uc0ZvclR5cGVQcm9maWxpbmcoVk0mIHZtLCBib29sIHNob3VsZEVuYWJsZVR5cGVQ cm9maWxpbmcpCiB7Ci0gICAgYm9vbCBzaG91bGRSZWNvbXBpbGVGcm9tVHlwZVByb2ZpbGVyID0g KHNob3VsZEVuYWJsZVR5cGVQcm9maWxpbmcgPyB2bS5lbmFibGVUeXBlUHJvZmlsZXIoKSA6IHZt LmRpc2FibGVUeXBlUHJvZmlsZXIoKSk7IAorICAgIGJvb2wgc2hvdWxkUmVjb21waWxlRnJvbVR5 cGVQcm9maWxlciA9IChzaG91bGRFbmFibGVUeXBlUHJvZmlsaW5nID8gdm0uZW5hYmxlVHlwZVBy b2ZpbGVyKCkgOiB2bS5kaXNhYmxlVHlwZVByb2ZpbGVyKCkpOwogICAgIGJvb2wgc2hvdWxkUmVj b21waWxlRnJvbUNvbnRyb2xGbG93UHJvZmlsZXIgPSAoc2hvdWxkRW5hYmxlVHlwZVByb2ZpbGlu ZyA/IHZtLmVuYWJsZUNvbnRyb2xGbG93UHJvZmlsZXIoKSA6IHZtLmRpc2FibGVDb250cm9sRmxv d1Byb2ZpbGVyKCkpOwogICAgIGJvb2wgbmVlZHNUb1JlY29tcGlsZSA9IHNob3VsZFJlY29tcGls ZUZyb21UeXBlUHJvZmlsZXIgfHwgc2hvdWxkUmVjb21waWxlRnJvbUNvbnRyb2xGbG93UHJvZmls ZXI7CiAKQEAgLTMxMyw3ICszMTQsNyBAQCB2b2lkIEluc3BlY3RvclJ1bnRpbWVBZ2VudDo6c2V0 VHlwZVByb2ZpbGVyRW5hYmxlZFN0YXRlKGJvb2wgc2hvdWxkRW5hYmxlVHlwZVBybwogICAgIGlm ICh2bS5lbnRyeVNjb3BlKSB7CiAgICAgICAgIHZtLmVudHJ5U2NvcGUtPnNldEVudHJ5U2NvcGVE aWRQb3BMaXN0ZW5lcih0aGlzLAogICAgICAgICAgICAgWz1dIChWTSYgdm0sIEpTR2xvYmFsT2Jq ZWN0KikgewotICAgICAgICAgICAgICAgIHJlY29tcGlsZUFsbEpTRnVuY3Rpb25zRm9yVHlwZVBy b2ZpbGluZyh2bSwgc2hvdWxkRW5hYmxlVHlwZVByb2ZpbGluZyk7IAorICAgICAgICAgICAgICAg IHJlY29tcGlsZUFsbEpTRnVuY3Rpb25zRm9yVHlwZVByb2ZpbGluZyh2bSwgc2hvdWxkRW5hYmxl VHlwZVByb2ZpbGluZyk7CiAgICAgICAgICAgICB9CiAgICAgICAgICk7CiAgICAgfSBlbHNlCg==