140700 2015-01-20 15:40:40 -0800 Identity in DFG not allocating new register. 2015-01-20 17:12:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mmirman mmirman commit-queue fpizlo ggaren mmirman oldest_to_newest 1062920 0 245029 mmirman 2015-01-20 15:40:40 -0800 Created attachment 245029 A testcase that fails due to this bug. Patch forthcoming. <rdar://problem/19339106> 1062921 1 245030 mmirman 2015-01-20 15:47:46 -0800 Created attachment 245030 Made Identity in the DFG allocate a new temp register 1062922 2 245030 fpizlo 2015-01-20 15:49:19 -0800 Comment on attachment 245030 Made Identity in the DFG allocate a new temp register This should either reenable the test that discovered this, or write a new test. It would probably be sufficient to just reenable the skipped test. This patch should include that. 1062925 3 245032 mmirman 2015-01-20 16:02:53 -0800 Created attachment 245032 Made Identity in the DFG allocate a new temp register Enabled that test case. 1062954 4 245032 commit-queue 2015-01-20 17:12:49 -0800 Comment on attachment 245032 Made Identity in the DFG allocate a new temp register Clearing flags on attachment: 245032 Committed r178788: <http://trac.webkit.org/changeset/178788> 1062955 5 commit-queue 2015-01-20 17:12:54 -0800 All reviewed patches have been landed. Closing bug. 245029 2015-01-20 15:40:40 -0800 2015-01-20 15:40:40 -0800 A testcase that fails due to this bug. invalid_array.js application/x-javascript 464 mmirman Ly8gLS1mb3JjZUlDRmFpbHVyZT10cnVlIC0tZW5hYmxlQ29uY3VycmVudEpJVD1mYWxzZSAtLXRo cmVzaG9sZEZvckpJVEFmdGVyV2FybVVwPTEwIC0tdGhyZXNob2xkRm9yT3B0aW1pemVBZnRlcldh cm1VcD0yMCAgCmZ1bmN0aW9uIFRlc3RDYXNlKGEpIHsKICAgIHRoaXMuYWN0dWFsID0gMC4xOwp9 Cgp2YXIgdGVzdGNhc2VzID0gbmV3IEFycmF5KCk7Cgpmb3IgKHZhciBpPTA7IGkgPCA0MDsgaSsr KXsKICAgIHRlc3RjYXNlc1tpXSA9IG5ldyBUZXN0Q2FzZSgpOwp9CmZ1bmN0aW9uIHRlc3QoKSB7 CiAgICBmb3IgKCB0Yz0wOyB0YyA8IHRlc3RjYXNlcy5sZW5ndGg7IHRjKysgKSB7CiAgICAgICAg dmFyIHYgPSB0ZXN0Y2FzZXNbdGNdOwogICAgICAgIHYuYWN0dWFsID0gdi5hY3R1YWw7CiAgICAg ICAgIiIgKyB0ZXN0Y2FzZXNbdGNdLmFjdHVhbDsKICAgIH0KICAgIHByaW50KCJET05FIik7Cn0K dGVzdCgpOwo= 245030 2015-01-20 15:47:46 -0800 2015-01-20 16:02:53 -0800 Made Identity in the DFG allocate a new temp register 0001-Made-Identity-in-the-DFG-allocate-a-new-temp-registe.patch text/plain 1971 mmirman ZGlmZiAtLWdpdCBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggMzU5NjVkNC4uMmVmOGJlYiAxMDA2NDQKLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wMS0yMCAgTWF0dGhldyBNaXJtYW4gIDxtbWly bWFuQGFwcGxlLmNvbT4KKworICAgICAgICBNYWRlIElkZW50aXR5IGluIHRoZSBERkcgbW92ZSBk YXRhIHRvIG5ldyByZWdpc3RlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDA3MDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE5MzM5MTA2Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RG R1NwZWN1bGF0aXZlSklUNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklU Ojpjb21waWxlKTogCisgICAgICAgIEFkZGVkIHNjcmF0Y2ggcmVnaXN0ZXJzIGZvciBJZGVudGl0 eS4gCisKIDIwMTUtMDEtMjAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNzg3NTEuCmRpZmYgLS1naXQg U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcCBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCmluZGV4IDg4ZmJhOTku LmM0MTQyODYgMTAwNjQ0Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklUNjQuY3BwCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZl SklUNjQuY3BwCkBAIC0xNzk5LDE3ICsxNzk5LDIzIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNv bXBpbGUoTm9kZSogbm9kZSkKICAgICAgICAgY2FzZSBEb3VibGVSZXBSZWFsVXNlOgogICAgICAg ICBjYXNlIERvdWJsZVJlcE1hY2hpbmVJbnRVc2U6IHsKICAgICAgICAgICAgIFNwZWN1bGF0ZURv dWJsZU9wZXJhbmQgb3AodGhpcywgbm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgZG91Ymxl UmVzdWx0KG9wLmZwcigpLCBub2RlKTsKKyAgICAgICAgICAgIEZQUlRlbXBvcmFyeSBzY3JhdGNo KHRoaXMsIG9wKTsKKyAgICAgICAgICAgIG1faml0Lm1vdmVEb3VibGUob3AuZnByKCksIHNjcmF0 Y2guZnByKCkpOworICAgICAgICAgICAgZG91YmxlUmVzdWx0KHNjcmF0Y2guZnByKCksIG5vZGUp OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBJbnQ1MlJlcFVz ZTogewogICAgICAgICAgICAgU3BlY3VsYXRlSW50NTJPcGVyYW5kIG9wKHRoaXMsIG5vZGUtPmNo aWxkMSgpKTsKLSAgICAgICAgICAgIGludDUyUmVzdWx0KG9wLmdwcigpLCBub2RlKTsKKyAgICAg ICAgICAgIEdQUlRlbXBvcmFyeSByZXN1bHQodGhpcywgUmV1c2UsIG9wKTsKKyAgICAgICAgICAg IG1faml0Lm1vdmUob3AuZ3ByKCksIHJlc3VsdC5ncHIoKSk7CisgICAgICAgICAgICBpbnQ1MlJl c3VsdChyZXN1bHQuZ3ByKCksIG5vZGUpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K ICAgICAgICAgZGVmYXVsdDogewogICAgICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgb3AodGhpcywg bm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAganNWYWx1ZVJlc3VsdChvcC5ncHIoKSwgbm9k ZSk7CisgICAgICAgICAgICBHUFJUZW1wb3JhcnkgcmVzdWx0KHRoaXMsIFJldXNlLCBvcCk7Cisg ICAgICAgICAgICBtX2ppdC5tb3ZlKG9wLmdwcigpLCByZXN1bHQuZ3ByKCkpOworICAgICAgICAg ICAganNWYWx1ZVJlc3VsdChyZXN1bHQuZ3ByKCksIG5vZGUpOwogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIH0KICAgICAgICAgfSAvLyBzd2l0Y2gK 245032 2015-01-20 16:02:53 -0800 2015-01-20 17:12:49 -0800 Made Identity in the DFG allocate a new temp register 0001-Made-Identity-in-the-DFG-allocate-a-new-temp-registe.patch text/plain 2905 mmirman ZGlmZiAtLWdpdCBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggMzU5NjVkNC4uZjY3NjExMCAxMDA2NDQKLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNS0wMS0yMCAgTWF0dGhldyBNaXJtYW4gIDxtbWly bWFuQGFwcGxlLmNvbT4KKworICAgICAgICBNYWRlIElkZW50aXR5IGluIHRoZSBERkcgYWxsb2Nh dGUgYSBuZXcgdGVtcCByZWdpc3RlciBhbmQgbW92ZSAKKyAgICAgICAgdGhlIG9sZCBkYXRhIHRv IGl0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQw NzAwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xOTMzOTEwNj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0 LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZSk6IAorICAg ICAgICBBZGRlZCBzY3JhdGNoIHJlZ2lzdGVycyBmb3IgSWRlbnRpdHkuIAorICAgICAgICAqIHRl c3RzL21vemlsbGEvbW96aWxsYS10ZXN0cy55YW1sOiBlbmFibGVkIHByZXZpb3VzbHkgZmFpbGlu ZyB0ZXN0CisKIDIwMTUtMDEtMjAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNzg3NTEuCmRpZmYgLS1n aXQgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcCBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCmluZGV4IDg4ZmJh OTkuLmM0MTQyODYgMTAwNjQ0Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1 bGF0aXZlSklUNjQuY3BwCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklUNjQuY3BwCkBAIC0xNzk5LDE3ICsxNzk5LDIzIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6 OmNvbXBpbGUoTm9kZSogbm9kZSkKICAgICAgICAgY2FzZSBEb3VibGVSZXBSZWFsVXNlOgogICAg ICAgICBjYXNlIERvdWJsZVJlcE1hY2hpbmVJbnRVc2U6IHsKICAgICAgICAgICAgIFNwZWN1bGF0 ZURvdWJsZU9wZXJhbmQgb3AodGhpcywgbm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgZG91 YmxlUmVzdWx0KG9wLmZwcigpLCBub2RlKTsKKyAgICAgICAgICAgIEZQUlRlbXBvcmFyeSBzY3Jh dGNoKHRoaXMsIG9wKTsKKyAgICAgICAgICAgIG1faml0Lm1vdmVEb3VibGUob3AuZnByKCksIHNj cmF0Y2guZnByKCkpOworICAgICAgICAgICAgZG91YmxlUmVzdWx0KHNjcmF0Y2guZnByKCksIG5v ZGUpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBJbnQ1MlJl cFVzZTogewogICAgICAgICAgICAgU3BlY3VsYXRlSW50NTJPcGVyYW5kIG9wKHRoaXMsIG5vZGUt PmNoaWxkMSgpKTsKLSAgICAgICAgICAgIGludDUyUmVzdWx0KG9wLmdwcigpLCBub2RlKTsKKyAg ICAgICAgICAgIEdQUlRlbXBvcmFyeSByZXN1bHQodGhpcywgUmV1c2UsIG9wKTsKKyAgICAgICAg ICAgIG1faml0Lm1vdmUob3AuZ3ByKCksIHJlc3VsdC5ncHIoKSk7CisgICAgICAgICAgICBpbnQ1 MlJlc3VsdChyZXN1bHQuZ3ByKCksIG5vZGUpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IH0KICAgICAgICAgZGVmYXVsdDogewogICAgICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgb3AodGhp cywgbm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAganNWYWx1ZVJlc3VsdChvcC5ncHIoKSwg bm9kZSk7CisgICAgICAgICAgICBHUFJUZW1wb3JhcnkgcmVzdWx0KHRoaXMsIFJldXNlLCBvcCk7 CisgICAgICAgICAgICBtX2ppdC5tb3ZlKG9wLmdwcigpLCByZXN1bHQuZ3ByKCkpOworICAgICAg ICAgICAganNWYWx1ZVJlc3VsdChyZXN1bHQuZ3ByKCksIG5vZGUpOwogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIH0KICAgICAgICAgfSAvLyBzd2l0Y2gKZGlmZiAtLWdpdCBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvdGVzdHMvbW96aWxsYS9tb3ppbGxhLXRlc3RzLnlhbWwgU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL21vemlsbGEvbW96aWxsYS10ZXN0cy55YW1sCmluZGV4IDg1ZDdmZGMu LmVjZWIzZjcgMTAwNjQ0Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvbW96aWxsYS9t b3ppbGxhLXRlc3RzLnlhbWwKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9tb3ppbGxh L21vemlsbGEtdGVzdHMueWFtbApAQCAtNzg5LDkgKzc4OSw4IEBACiAgIGNtZDogZGVmYXVsdFJ1 bk1vemlsbGFUZXN0IDpub3JtYWwsICIuLi9zaGVsbC5qcyIKIC0gcGF0aDogZWNtYS9MZXhpY2Fs Q29udmVudGlvbnMvNy43LjMtMi5qcwogICBjbWQ6IGRlZmF1bHRSdW5Nb3ppbGxhVGVzdCA6bm9y bWFsLCAiLi4vc2hlbGwuanMiCi0jIFRlc3QgZmFpbHMgZHVlIHRvIHJkYXI6Ly9wcm9ibGVtLzE5 MzM5MTA2Ci0jIC0gcGF0aDogZWNtYS9MZXhpY2FsQ29udmVudGlvbnMvNy43LjMuanMKLSMgICBj bWQ6IGRlZmF1bHRSdW5Nb3ppbGxhVGVzdCA6bm9ybWFsLCAiLi4vc2hlbGwuanMiCistIHBhdGg6 IGVjbWEvTGV4aWNhbENvbnZlbnRpb25zLzcuNy4zLmpzCisgIGNtZDogZGVmYXVsdFJ1bk1vemls bGFUZXN0IDpub3JtYWwsICIuLi9zaGVsbC5qcyIKIC0gcGF0aDogZWNtYS9MZXhpY2FsQ29udmVu dGlvbnMvNy43LjQuanMKICAgY21kOiBkZWZhdWx0UnVuTW96aWxsYVRlc3QgOm5vcm1hbCwgIi4u L3NoZWxsLmpzIgogLSBwYXRoOiBlY21hL0xleGljYWxDb252ZW50aW9ucy83LjguMi1uLmpzCg==