140686 2015-01-20 11:10:40 -0800 Drop width / height shorthands code from StylePropertyShorthand.* 2015-01-20 12:54:21 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue kling koivisto menard oldest_to_newest 1062806 0 cdumez 2015-01-20 11:10:40 -0800 Drop width / height shorthands code from StylePropertyShorthand.* width / height are not shorthands for min-width/max-width and min-height/max-height. Also, only matchingCustomShorthandsForLonghand() handles those shorthands, while the reverse method (indexOfShorthandForLonghand) does not. 1062811 1 245001 cdumez 2015-01-20 11:11:25 -0800 Created attachment 245001 WIP Patch 1062830 2 menard 2015-01-20 11:53:02 -0800 Not that it counts me but r+ 1062833 3 245007 cdumez 2015-01-20 11:56:26 -0800 Created attachment 245007 Patch 1062853 4 245007 commit-queue 2015-01-20 12:54:17 -0800 Comment on attachment 245007 Patch Clearing flags on attachment: 245007 Committed r178746: <http://trac.webkit.org/changeset/178746> 1062854 5 commit-queue 2015-01-20 12:54:21 -0800 All reviewed patches have been landed. Closing bug. 245001 2015-01-20 11:11:25 -0800 2015-01-20 11:56:23 -0800 WIP Patch 140686_wip.patch text/plain 2230 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmNwcAppbmRleCAy NDdjYWFkLi4wOTBkYTM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9w ZXJ0eVNob3J0aGFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlT aG9ydGhhbmQuY3BwCkBAIC04MiwyNCArODIsNiBAQCBTdHlsZVByb3BlcnR5U2hvcnRoYW5kIGFu aW1hdGlvblNob3J0aGFuZEZvclBhcnNpbmcoQ1NTUHJvcGVydHlJRCBwcm9wSWQpCiAgICAgcmV0 dXJuIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQoQ1NTUHJvcGVydHlXZWJraXRBbmltYXRpb24sIHBy ZWZpeGVkQW5pbWF0aW9uUHJvcGVydGllc0ZvclBhcnNpbmcpOwogfQogCi1TdHlsZVByb3BlcnR5 U2hvcnRoYW5kIHdpZHRoU2hvcnRoYW5kKCkKLXsKLSAgICBzdGF0aWMgY29uc3QgQ1NTUHJvcGVy dHlJRCB3aWR0aFByb3BlcnRpZXNbXSA9IHsKLSAgICAgICAgQ1NTUHJvcGVydHlNaW5XaWR0aCwK LSAgICAgICAgQ1NTUHJvcGVydHlNYXhXaWR0aAotICAgIH07Ci0gICAgcmV0dXJuIFN0eWxlUHJv cGVydHlTaG9ydGhhbmQoQ1NTUHJvcGVydHlXaWR0aCwgd2lkdGhQcm9wZXJ0aWVzKTsKLX0KLQot U3R5bGVQcm9wZXJ0eVNob3J0aGFuZCBoZWlnaHRTaG9ydGhhbmQoKQotewotICAgIHN0YXRpYyBj b25zdCBDU1NQcm9wZXJ0eUlEIGhlaWdodFByb3BlcnRpZXNbXSA9IHsKLSAgICAgICAgQ1NTUHJv cGVydHlNaW5IZWlnaHQsCi0gICAgICAgIENTU1Byb3BlcnR5TWF4SGVpZ2h0Ci0gICAgfTsKLSAg ICByZXR1cm4gU3R5bGVQcm9wZXJ0eVNob3J0aGFuZChDU1NQcm9wZXJ0eUhlaWdodCwgaGVpZ2h0 UHJvcGVydGllcyk7Ci19Ci0KIGJvb2wgaXNFeHBhbmRlZFNob3J0aGFuZChDU1NQcm9wZXJ0eUlE IGlkKQogewogICAgIC8vIFRoZSBzeXN0ZW0gZm9udHMgYnlwYXNzIHRoZSBub3JtYWwgc3R5bGUg cmVzb2x1dGlvbiBieSB1c2luZyBSZW5kZXJUaGVtZSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVQcm9wZXJ0eVNob3J0aGFuZC5oCmluZGV4IDk1NmY1NzMuLmQ1MTM2NjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmgKKysrIGIvU291cmNl L1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaApAQCAtNjMsOCArNjMsNiBAQCBw cml2YXRlOgogU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCBhbmltYXRpb25TaG9ydGhhbmRGb3JQYXJz aW5nKENTU1Byb3BlcnR5SUQpOwogU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCBib3JkZXJBYnJpZGdl ZFNob3J0aGFuZCgpOwogU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCBmb250U2hvcnRoYW5kKCk7Ci1T dHlsZVByb3BlcnR5U2hvcnRoYW5kIGhlaWdodFNob3J0aGFuZCgpOwotU3R5bGVQcm9wZXJ0eVNo b3J0aGFuZCB3aWR0aFNob3J0aGFuZCgpOwogCiAvLyBSZXR1cm5zIGVtcHR5IHZhbHVlIGlmIHRo ZSBwcm9wZXJ0eSBpcyBub3QgYSBzaG9ydGhhbmQuCiAvLyBUaGUgaW1wbGVtZW50YXRpb24gaXMg Z2VuZXJhdGVkIGluIFN0eWxlUHJvcGVydHlTaG9ydGhhbmRGdW5jdGlvbnMuY3BwLgpAQCAtODks MTIgKzg3LDYgQEAgaW5saW5lIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPiBtYXRjaGlu Z0N1c3RvbVNob3J0aGFuZHNGb3JMb25naGFuZChDU1NQcm8KICAgICBjYXNlIENTU1Byb3BlcnR5 Rm9udFdlaWdodDoKICAgICBjYXNlIENTU1Byb3BlcnR5TGluZUhlaWdodDoKICAgICAgICAgcmV0 dXJuIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRoYW5kPntmb250U2hvcnRoYW5kKCl9OwotICAg IGNhc2UgQ1NTUHJvcGVydHlNaW5XaWR0aDoKLSAgICBjYXNlIENTU1Byb3BlcnR5TWF4V2lkdGg6 Ci0gICAgICAgIHJldHVybiBWZWN0b3I8U3R5bGVQcm9wZXJ0eVNob3J0aGFuZD57d2lkdGhTaG9y dGhhbmQoKX07Ci0gICAgY2FzZSBDU1NQcm9wZXJ0eU1pbkhlaWdodDoKLSAgICBjYXNlIENTU1By b3BlcnR5TWF4SGVpZ2h0OgotICAgICAgICByZXR1cm4gVmVjdG9yPFN0eWxlUHJvcGVydHlTaG9y dGhhbmQ+e2hlaWdodFNob3J0aGFuZCgpfTsKICAgICBkZWZhdWx0OgogICAgICAgICBicmVhazsK ICAgICB9Cg== 245007 2015-01-20 11:56:26 -0800 2015-01-20 12:54:17 -0800 Patch bug-140686-20150120115633.patch text/plain 3539 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZlOWRmOTkzZDc2MjNm ZmExYjMxNDQ1YzVlMDhlODY2YzQ3OGQ3Yy4uYTBiMDc5N2Q5ZDg2MzA4ZmFjNGVjZWY4YWYzMjAx YmUzNTU5Y2VkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTAxLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCB3aWR0aCAvIGhlaWdo dCBzaG9ydGhhbmRzIGNvZGUgZnJvbSBTdHlsZVByb3BlcnR5U2hvcnRoYW5kLioKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDY4NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3Agd2lkdGggLyBoZWln aHQgc2hvcnRoYW5kcyBjb2RlIGZyb20gU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC4qLgorICAgICAg ICB3aWR0aCAvIGhlaWdodCBhcmUgbm90IHNob3J0aGFuZHMgZm9yIG1pbi13aWR0aC9tYXgtd2lk dGggYW5kCisgICAgICAgIG1pbi1oZWlnaHQvbWF4LWhlaWdodC4gQWxzbywgb25seSBtYXRjaGlu Z0N1c3RvbVNob3J0aGFuZHNGb3JMb25naGFuZCgpCisgICAgICAgIHRyZWF0cyB0aGVzZSBhcyBz aG9ydGhhbmRzLiBGb3IgZS5nLCB0aGUgcmV2ZXJzZSBtZXRob2QKKyAgICAgICAgKGluZGV4T2ZT aG9ydGhhbmRGb3JMb25naGFuZCgpKSBkb2VzIG5vdC4KKworICAgICAgICAqIGNzcy9TdHlsZVBy b3BlcnR5U2hvcnRoYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndpZHRoU2hvcnRoYW5kKTog RGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OmhlaWdodFNob3J0aGFuZCk6IERlbGV0ZWQuCisg ICAgICAgICogY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhhbmQuaDoKKyAgICAgICAgKFdlYkNvcmU6 Om1hdGNoaW5nQ3VzdG9tU2hvcnRoYW5kc0ZvckxvbmdoYW5kKToKKwogMjAxNS0wMS0yMCAgQ3Nh YmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB1bnVzZWQt cHJpdmF0ZS1maWVsZCB3YXJuaW5nIGluIEljb25FZmwuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5jcHAKaW5kZXggMjQ3Y2FhZGZlZjdhNjRiNGI4MzQx ZWNlMTM0MTVkOGY0ZThiODJmMy4uMDkwZGEzNTFjM2QyN2E2MTgzYTgyZjAwOWYxOWVkYWRjYTE2 MzZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTaG9ydGhh bmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmNw cApAQCAtODIsMjQgKzgyLDYgQEAgU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCBhbmltYXRpb25TaG9y dGhhbmRGb3JQYXJzaW5nKENTU1Byb3BlcnR5SUQgcHJvcElkKQogICAgIHJldHVybiBTdHlsZVBy b3BlcnR5U2hvcnRoYW5kKENTU1Byb3BlcnR5V2Via2l0QW5pbWF0aW9uLCBwcmVmaXhlZEFuaW1h dGlvblByb3BlcnRpZXNGb3JQYXJzaW5nKTsKIH0KIAotU3R5bGVQcm9wZXJ0eVNob3J0aGFuZCB3 aWR0aFNob3J0aGFuZCgpCi17Ci0gICAgc3RhdGljIGNvbnN0IENTU1Byb3BlcnR5SUQgd2lkdGhQ cm9wZXJ0aWVzW10gPSB7Ci0gICAgICAgIENTU1Byb3BlcnR5TWluV2lkdGgsCi0gICAgICAgIENT U1Byb3BlcnR5TWF4V2lkdGgKLSAgICB9OwotICAgIHJldHVybiBTdHlsZVByb3BlcnR5U2hvcnRo YW5kKENTU1Byb3BlcnR5V2lkdGgsIHdpZHRoUHJvcGVydGllcyk7Ci19Ci0KLVN0eWxlUHJvcGVy dHlTaG9ydGhhbmQgaGVpZ2h0U2hvcnRoYW5kKCkKLXsKLSAgICBzdGF0aWMgY29uc3QgQ1NTUHJv cGVydHlJRCBoZWlnaHRQcm9wZXJ0aWVzW10gPSB7Ci0gICAgICAgIENTU1Byb3BlcnR5TWluSGVp Z2h0LAotICAgICAgICBDU1NQcm9wZXJ0eU1heEhlaWdodAotICAgIH07Ci0gICAgcmV0dXJuIFN0 eWxlUHJvcGVydHlTaG9ydGhhbmQoQ1NTUHJvcGVydHlIZWlnaHQsIGhlaWdodFByb3BlcnRpZXMp OwotfQotCiBib29sIGlzRXhwYW5kZWRTaG9ydGhhbmQoQ1NTUHJvcGVydHlJRCBpZCkKIHsKICAg ICAvLyBUaGUgc3lzdGVtIGZvbnRzIGJ5cGFzcyB0aGUgbm9ybWFsIHN0eWxlIHJlc29sdXRpb24g YnkgdXNpbmcgUmVuZGVyVGhlbWUsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVQcm9wZXJ0eVNob3J0aGFuZC5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlT aG9ydGhhbmQuaAppbmRleCA5NTZmNTczNjEyNTI4YzViODhlZDQ5MTEzYzQ1NmRiOTFiZTczMDFm Li5kNTEzNjYxNDBiMmMyZDdkYjE4ZTQ0YjVhYzU3ZGRlMmIxYjJhNjc0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2hvcnRoYW5kLmgKQEAgLTYzLDggKzYzLDYgQEAgcHJp dmF0ZToKIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQgYW5pbWF0aW9uU2hvcnRoYW5kRm9yUGFyc2lu ZyhDU1NQcm9wZXJ0eUlEKTsKIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQgYm9yZGVyQWJyaWRnZWRT aG9ydGhhbmQoKTsKIFN0eWxlUHJvcGVydHlTaG9ydGhhbmQgZm9udFNob3J0aGFuZCgpOwotU3R5 bGVQcm9wZXJ0eVNob3J0aGFuZCBoZWlnaHRTaG9ydGhhbmQoKTsKLVN0eWxlUHJvcGVydHlTaG9y dGhhbmQgd2lkdGhTaG9ydGhhbmQoKTsKIAogLy8gUmV0dXJucyBlbXB0eSB2YWx1ZSBpZiB0aGUg cHJvcGVydHkgaXMgbm90IGEgc2hvcnRoYW5kLgogLy8gVGhlIGltcGxlbWVudGF0aW9uIGlzIGdl bmVyYXRlZCBpbiBTdHlsZVByb3BlcnR5U2hvcnRoYW5kRnVuY3Rpb25zLmNwcC4KQEAgLTg5LDEy ICs4Nyw2IEBAIGlubGluZSBWZWN0b3I8U3R5bGVQcm9wZXJ0eVNob3J0aGFuZD4gbWF0Y2hpbmdD dXN0b21TaG9ydGhhbmRzRm9yTG9uZ2hhbmQoQ1NTUHJvCiAgICAgY2FzZSBDU1NQcm9wZXJ0eUZv bnRXZWlnaHQ6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUxpbmVIZWlnaHQ6CiAgICAgICAgIHJldHVy biBWZWN0b3I8U3R5bGVQcm9wZXJ0eVNob3J0aGFuZD57Zm9udFNob3J0aGFuZCgpfTsKLSAgICBj YXNlIENTU1Byb3BlcnR5TWluV2lkdGg6Ci0gICAgY2FzZSBDU1NQcm9wZXJ0eU1heFdpZHRoOgot ICAgICAgICByZXR1cm4gVmVjdG9yPFN0eWxlUHJvcGVydHlTaG9ydGhhbmQ+e3dpZHRoU2hvcnRo YW5kKCl9OwotICAgIGNhc2UgQ1NTUHJvcGVydHlNaW5IZWlnaHQ6Ci0gICAgY2FzZSBDU1NQcm9w ZXJ0eU1heEhlaWdodDoKLSAgICAgICAgcmV0dXJuIFZlY3RvcjxTdHlsZVByb3BlcnR5U2hvcnRo YW5kPntoZWlnaHRTaG9ydGhhbmQoKX07CiAgICAgZGVmYXVsdDoKICAgICAgICAgYnJlYWs7CiAg ICAgfQo=