140671 2015-01-20 03:48:50 -0800 [gstreamer] Fix expression result unused warning in GRefPtrGStreamer.cpp 2015-01-20 08:24:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue ossy pnormand oldest_to_newest 1062696 0 ossy 2015-01-20 03:48:50 -0800 warning: ../../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:251:9: warning: expression result unused [-Wunused-value] (GstToc*)gst_mini_object_ref(((GstMiniObject*)(ptr))); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1062697 1 244982 ossy 2015-01-20 03:50:17 -0800 Created attachment 244982 Patch 1062718 2 pnormand 2015-01-20 06:53:44 -0800 Is this the only fix possible? Don't we have some macro in WTF about this? 1062720 3 ossy 2015-01-20 07:00:51 -0800 (In reply to comment #2) > Is this the only fix possible? Don't we have some macro in WTF about this? I haven't found. 1062722 4 pnormand 2015-01-20 07:07:36 -0800 Ok not sure it'd be worth adding anyway :) 1062724 5 244982 pnormand 2015-01-20 07:14:20 -0800 Comment on attachment 244982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244982&action=review > Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:251 > - gst_toc_ref(ptr); > + (void)gst_toc_ref(ptr); Actually we could return the result value here, return gst_toc_ref(ptr); 1062729 6 244991 ossy 2015-01-20 07:28:01 -0800 Created attachment 244991 Patch 1062742 7 244991 commit-queue 2015-01-20 08:24:06 -0800 Comment on attachment 244991 Patch Clearing flags on attachment: 244991 Committed r178711: <http://trac.webkit.org/changeset/178711> 1062743 8 commit-queue 2015-01-20 08:24:11 -0800 All reviewed patches have been landed. Closing bug. 244982 2015-01-20 03:50:17 -0800 2015-01-20 07:27:54 -0800 Patch bug-140671-20150120035023.patch text/plain 1304 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTMwMmVkMDE5NGM5ODc0 Y2E2MWMwZDkzN2ExNzAxYjdhMmUxZTg0Ny4uMzIxMzZjMzU2MzRiYzE3YTAxZGNlMTFkMGU1YmNh NjQ0MWE2YjczMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAxLTIwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2dzdHJlYW1lcl0g Rml4IGV4cHJlc3Npb24gcmVzdWx0IHVudXNlZCB3YXJuaW5nIGluIEdSZWZQdHJHU3RyZWFtZXIu Y3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA2 NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HUmVmUHRyR1N0cmVhbWVyLmNwcDoKKyAgICAgICAg KFdURjo6cmVmR1B0cjxHc3RUb2M+KToKKwogMjAxNS0wMS0yMCAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBEaWFnbm9zdGljTG9nZ2luZ0NsaWVudCB0byBs b2cgcGFnZSBjYWNoZSBmYWlsdXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dSZWZQdHJHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dSZWZQdHJHU3RyZWFtZXIuY3BwCmluZGV4 IGY3ZWY0NmRkODM5MGQ5NDUzNDFmZTM4MDYzMjkwM2U1YWZiNjk2ZjguLjkzYTg3ODY1NGY5MzQy ZTU4YTA3MDdhZTgyNjg2YTIzNTQxMjc3YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HUmVmUHRyR1N0cmVhbWVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1JlZlB0ckdTdHJlYW1lci5j cHAKQEAgLTI0OCw3ICsyNDgsNyBAQCB0ZW1wbGF0ZTw+IEdSZWZQdHI8R3N0VG9jPiBhZG9wdEdS ZWYoR3N0VG9jKiBwdHIpCiB0ZW1wbGF0ZTw+IEdzdFRvYyogcmVmR1B0cjxHc3RUb2M+KEdzdFRv YyogcHRyKQogewogICAgIGlmIChwdHIpCi0gICAgICAgIGdzdF90b2NfcmVmKHB0cik7CisgICAg ICAgICh2b2lkKWdzdF90b2NfcmVmKHB0cik7CiAKICAgICByZXR1cm4gcHRyOwogfQo= 244991 2015-01-20 07:28:01 -0800 2015-01-20 08:24:06 -0800 Patch bug-140671-20150120072807.patch text/plain 1375 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjhmMjA3ODA3OGE1MzUw YjU5NzAyMWZhNDcxZWYwYWY3ODEzNTJlNy4uM2YxOGJiZDEyYmM4NWI2NjMyODRmMzMzYjU0ZmUz MzEzNTdiMGZkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE1LTAxLTIwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW2dzdHJlYW1lcl0g Rml4IGV4cHJlc3Npb24gcmVzdWx0IHVudXNlZCB3YXJuaW5nIGluIEdSZWZQdHJHU3RyZWFtZXIu Y3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA2 NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HUmVmUHRyR1N0cmVhbWVyLmNwcDoKKyAgICAgICAg KFdURjo6cmVmR1B0cjxHc3RUb2M+KToKKworMjAxNS0wMS0yMCAgQ3NhYmEgT3N6dHJvZ29uw6Fj ICA8b3NzeUB3ZWJraXQub3JnPgorCiAgICAgICAgIEZpeCAncmVnaXN0ZXInIHN0b3JhZ2UgY2xh c3Mgc3BlY2lmaWVyIGlzIGRlcHJlY2F0ZWQgd2FybmluZwogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNjY5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HUmVmUHRyR1N0cmVhbWVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HUmVmUHRyR1N0cmVh bWVyLmNwcAppbmRleCBmN2VmNDZkZDgzOTBkOTQ1MzQxZmUzODA2MzI5MDNlNWFmYjY5NmY4Li5m NmRkZmEzYmJmMDhkMjU2ZjVjZGJhMzY5Y2NlZDY2ZGVlNWM4MWE2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1JlZlB0ckdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dSZWZQ dHJHU3RyZWFtZXIuY3BwCkBAIC0yNDgsNyArMjQ4LDcgQEAgdGVtcGxhdGU8PiBHUmVmUHRyPEdz dFRvYz4gYWRvcHRHUmVmKEdzdFRvYyogcHRyKQogdGVtcGxhdGU8PiBHc3RUb2MqIHJlZkdQdHI8 R3N0VG9jPihHc3RUb2MqIHB0cikKIHsKICAgICBpZiAocHRyKQotICAgICAgICBnc3RfdG9jX3Jl ZihwdHIpOworICAgICAgICByZXR1cm4gZ3N0X3RvY19yZWYocHRyKTsKIAogICAgIHJldHVybiBw dHI7CiB9Cg==