140643 2015-01-19 15:17:13 -0800 REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is offset by flipped-ness 2015-01-20 10:40:48 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin darin mitz thorton oldest_to_newest 1062517 0 bdakin 2015-01-19 15:17:13 -0800 REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is offset by flipped-ness rdar://problem/19489593 1062519 1 244930 bdakin 2015-01-19 15:19:56 -0800 Created attachment 244930 Patch 1062521 2 244930 thorton 2015-01-19 15:22:20 -0800 Comment on attachment 244930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244930&action=review > Source/WebKit/mac/WebView/WebView.mm:8575 > + if ([self isFlipped]) dot notation! 1062522 3 bdakin 2015-01-19 15:24:59 -0800 http://trac.webkit.org/changeset/178676 Thank you! 1062625 4 darin 2015-01-19 20:23:08 -0800 Wow, I had no idea we supported having the WebView be flipped! 1062797 5 bdakin 2015-01-20 10:40:48 -0800 (In reply to comment #4) > Wow, I had no idea we supported having the WebView be flipped! It was a surprise to everyone I've talked to so far! 244930 2015-01-19 15:19:56 -0800 2015-01-19 15:22:20 -0800 Patch for-review.txt text/plain 1511 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODY3NSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAxLTE5 ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MTc4MjkwKTogWWVsbG93IGhpZ2hsaWdodCBmcm9tIGNvbnRleHQgbWVudSBMb29rdXAgaW4gRGlj dGlvbmFyeSBpcyAKKyAgICAgICAgb2Zmc2V0IGJ5IGZsaXBwZWQtbmVzcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNjQzCisgICAgICAgIC1hbmQg Y29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTk0ODk1OTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB1bml2ZXJzYWxseSBm bGlwcGVkIGJlY2F1c2Ugd2UgYXNzdW1lZCB0aGF0IHRoZSByb290IHZpZXcgd2FzIGZsaXBwZWQg YW5kIHRoZSAKKyAgICAgICAgV2ViVmlldyB3YXMgbm90LiBIb3dldmVyLCBpbiBEaWN0aW9uYXJ5 LCB0aGUgV2ViVmlldyBpcyBmbGlwcGVkISBTbyB0aGlzIHBhdGNoIAorICAgICAgICBmaXhlcyB0 aGF0IGFzc3VtcHRpb24gYnkgY2hlY2tpbmcgdGhlIFdlYlZpZXfigJlzIGZsaXBwZWQtbmVzcy4K KyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgX2NvbnZl cnRSZWN0RnJvbVJvb3RWaWV3Ol0pOgorCiAyMDE1LTAxLTE5ICBDb21taXQgUXVldWUgIDxjb21t aXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MTc4NjUzLgpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24g MTc4NjU1KQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5n IGNvcHkpCkBAIC04NTcyLDYgKzg1NzIsOCBAQCAtIChOU1BvaW50KV9jb252ZXJ0UG9pbnRGcm9t Um9vdFZpZXc6KE5TCiAKIC0gKE5TUmVjdClfY29udmVydFJlY3RGcm9tUm9vdFZpZXc6KE5TUmVj dClyZWN0CiB7CisgICAgaWYgKFtzZWxmIGlzRmxpcHBlZF0pCisgICAgICAgIHJldHVybiByZWN0 OwogICAgIHJldHVybiBOU01ha2VSZWN0KHJlY3Qub3JpZ2luLngsIFtzZWxmIGJvdW5kc10uc2l6 ZS5oZWlnaHQgLSByZWN0Lm9yaWdpbi55IC0gcmVjdC5zaXplLmhlaWdodCwgcmVjdC5zaXplLndp ZHRoLCByZWN0LnNpemUuaGVpZ2h0KTsKIH0KIAo=