140619 2015-01-19 06:34:10 -0800 Clean up ViewUpdateDispatcher 2015-01-21 08:55:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan oldest_to_newest 1062352 0 zan 2015-01-19 06:34:10 -0800 Clean up ViewUpdateDispatcher 1062353 1 244901 zan 2015-01-19 06:36:17 -0800 Created attachment 244901 Patch 1062770 2 244901 darin 2015-01-20 09:24:51 -0800 Comment on attachment 244901 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244901&action=review > Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:71 > + RefPtr<ViewUpdateDispatcher> protector(this); Annoying that this can’t be Ref instead of RefPtr. 1063065 3 244901 zan 2015-01-21 08:55:41 -0800 Comment on attachment 244901 Patch Clearing flags on attachment: 244901 Committed r178824: <http://trac.webkit.org/changeset/178824> 1063066 4 zan 2015-01-21 08:55:49 -0800 All reviewed patches have been landed. Closing bug. 244901 2015-01-19 06:36:17 -0800 2015-01-21 08:55:41 -0800 Patch bug-140619-20150119063830.patch text/plain 2242 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODY0NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTE5ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBWaWV3VXBk YXRlRGlzcGF0Y2hlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQwNjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvVmlld1VwZGF0ZURpc3BhdGNoZXIuY3BwOgorICAg ICAgICAoV2ViS2l0OjpWaWV3VXBkYXRlRGlzcGF0Y2hlcjo6dmlzaWJsZUNvbnRlbnRSZWN0VXBk YXRlKToKKyAgICAgICAgUmVwbGFjZSBXVEY6OmJpbmQoKSB3aXRoIGEgQysrIGxhbWJkYS4KKyAg ICAgICAgKFdlYktpdDo6Vmlld1VwZGF0ZURpc3BhdGNoZXI6OmRpc3BhdGNoVmlzaWJsZUNvbnRl bnRSZWN0VXBkYXRlKToKKyAgICAgICAgVXNlIFdURjo6bW92ZSgpIHRvIG1vdmUgdGhlIEhhc2hN YXAgbWVtYmVyIGludG8gdGhlIGxvY2FsIHZhcmlhYmxlLgorCiAyMDE1LTAxLTE4ICBEYW5pZWwg QmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBBdHRlbXB0IHRvIGZpeCB0aGUg aU9TIGJ1aWxkIGFmdGVyIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNzg2MzE+ CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvVmlld1VwZGF0ZURpc3Bh dGNoZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9WaWV3VXBkYXRlRGlzcGF0Y2hlci5jcHAJKHJldmlzaW9uIDE3ODY0NSkKKysrIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9WaWV3VXBkYXRlRGlzcGF0Y2hlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTY3LDE5ICs2NywyMyBAQCB2b2lkIFZpZXdVcGRhdGVEaXNwYXRjaGVyOjp2 aXNpYmxlQ29udGVuCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGl0ZXJhdG9yLT52YWx1ZS52 aXNpYmxlQ29udGVudFJlY3RVcGRhdGVJbmZvID0gdmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlSW5m bzsKICAgICB9Ci0gICAgaWYgKHVwZGF0ZUxpc3RXYXNFbXB0eSkKLSAgICAgICAgUnVuTG9vcDo6 bWFpbigpLmRpc3BhdGNoKGJpbmQoJlZpZXdVcGRhdGVEaXNwYXRjaGVyOjpkaXNwYXRjaFZpc2li bGVDb250ZW50UmVjdFVwZGF0ZSwgdGhpcykpOworICAgIGlmICh1cGRhdGVMaXN0V2FzRW1wdHkp IHsKKyAgICAgICAgUmVmUHRyPFZpZXdVcGRhdGVEaXNwYXRjaGVyPiBwcm90ZWN0b3IodGhpcyk7 CisgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbcHJvdGVjdG9yXSB7CisgICAgICAg ICAgICBwcm90ZWN0b3ItPmRpc3BhdGNoVmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlKCk7CisgICAg ICAgIH0pOworICAgIH0KIH0KIAogdm9pZCBWaWV3VXBkYXRlRGlzcGF0Y2hlcjo6ZGlzcGF0Y2hW aXNpYmxlQ29udGVudFJlY3RVcGRhdGUoKQogewotICAgIEhhc2hNYXA8dWludDY0X3QsIFVwZGF0 ZURhdGE+IGxvY2FsQ29weTsKKyAgICBIYXNoTWFwPHVpbnQ2NF90LCBVcGRhdGVEYXRhPiB1cGRh dGU7CiAgICAgewogICAgICAgICBTcGluTG9ja0hvbGRlciBsb2NrZXIoJm1fZGF0YU11dGV4KTsK LSAgICAgICAgbG9jYWxDb3B5LnN3YXAobV9sYXRlc3RVcGRhdGUpOworICAgICAgICB1cGRhdGUg PSBXVEY6Om1vdmUobV9sYXRlc3RVcGRhdGUpOwogICAgIH0KIAotICAgIGZvciAoYXV0byYgc2xv dCA6IGxvY2FsQ29weSkgeworICAgIGZvciAoYXV0byYgc2xvdCA6IHVwZGF0ZSkgewogICAgICAg ICBpZiAoV2ViUGFnZSogd2ViUGFnZSA9IFdlYlByb2Nlc3M6OnNoYXJlZCgpLndlYlBhZ2Uoc2xv dC5rZXkpKQogICAgICAgICAgICAgd2ViUGFnZS0+dXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0cyhz bG90LnZhbHVlLnZpc2libGVDb250ZW50UmVjdFVwZGF0ZUluZm8sIHNsb3QudmFsdWUub2xkZXN0 VGltZXN0YW1wKTsKICAgICB9Cg==