140618 2015-01-19 05:57:31 -0800 AX: crash in accessibilityRootObjectWrapper method (WebPageAccessibilityObjectAtk.cpp) 2015-01-26 08:25:16 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fvallee webkit-unassigned cfleizach commit-queue mario oldest_to_newest 1062348 0 fvallee 2015-01-19 05:57:31 -0800 We have a scenario where webkit crashes in WebCore::AXObjectCache::rootObject() (unfortunately I have no way to reduce the crash scenario or to provide a regressin test). The stack track shows that the crash is due to AXObjectCache::rootObject() invoked with this = nullptr 0x00007fd0474eb898 in WebCore::AXObjectCache::rootObject() () from XXXXX/libwebkit2gtk-4.0.so.37 (gdb) bt #0 0x00007fd0474eb898 in WebCore::AXObjectCache::rootObject() () from XXXXX/libwebkit2gtk-4.0.so.37 #1 0x00007fd0473e998b in accessibilityRootObjectWrapper(_AtkObject*) () from XXXXX/libwebkit2gtk-4.0.so.37 #2 0x00007fd0473e9b62 in webPageAccessibilityObjectRefresh () from XXXXX/libwebkit2gtk-4.0.so.37 #3 0x00007fd047a257e0 in WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld&) () from XXXXX/libwebkit2gtk-4.0.so.37 #4 0x00007fd047a258af in WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds() () from XXXXX/libwebkit2gtk-4.0.so.37 #5 0x00007fd047a31ac2 in WebCore::FrameLoader::receivedFirstData() () from XXXXX/libwebkit2gtk-4.0.so.37 #6 0x00007fd047a0eb18 in WebCore::DocumentLoader::commitData(char const*, unsigned long) () from XXXXX/libwebkit2gtk-4.0.so.37 #7 0x00007fd04733fc6e in WebKit::WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) () from XXXXX/libwebkit2gtk-4.0.so.37 #8 0x00007fd047a0ec2f in WebCore::DocumentLoader::commitLoad(char const*, int) () from XXXXX/libwebkit2gtk-4.0.so.37 #9 0x00007fd047a8e034 in WebCore::CachedRawResource::notifyClientsDataWasReceived(char const*, unsigned int) () from XXXXX/libwebkit2gtk-4.0.so.37 #10 0x00007fd047a8e17c in WebCore::CachedRawResource::addDataBuffer(WebCore::SharedBuffer&) () from XXXXX/libwebkit2gtk-4.0.so.37 #11 0x00007fd047a57f9f in WebCore::SubresourceLoader::didReceiveDataOrBuffer(char const*, int, WTF::PassRefPtr<WebCore::SharedBuffer>, long long, WebCore::DataPayloadType) () from XXXXX/libwebkit2gtk-4.0.so.37 #12 0x00007fd047a5810a in WebCore::SubresourceLoader::didReceiveBuffer(WTF::PassRefPtr<WebCore::SharedBuffer>, long long, WebCore::DataPayloadType) () from XXXXX/libwebkit2gtk-4.0.so.37 #13 0x00007fd047a50cdf in WebCore::ResourceLoader::didReceiveBuffer(WebCore::ResourceHandle*, WTF::PassRefPtr<WebCore::SharedBuffer>, int) () from XXXXX/libwebkit2gtk-4.0.so.37 #14 0x00007fd0480f9c9b in WebCore::readCallback(_GObject*, _GAsyncResult*, void*) () from XXXXX/libwebkit2gtk-4.0.so.37 1062349 1 244900 fvallee 2015-01-19 06:10:36 -0800 Created attachment 244900 Patch 1062355 2 244900 cfleizach 2015-01-19 06:53:39 -0800 Comment on attachment 244900 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244900&action=review > Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:59 > + AccessibilityObject* coreRootObject = coreFrame.document()->axObjectCache() ? coreFrame.document()->axObjectCache()->rootObject() : 0; I think you can cache the AXObjectCache in a local variable Also use nullptr instead of 0 Can you add a test for tgus 1062356 3 cfleizach 2015-01-19 06:54:21 -0800 Tgus=this (In reply to comment #2) > Comment on attachment 244900 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244900&action=review > > > Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:59 > > + AccessibilityObject* coreRootObject = coreFrame.document()->axObjectCache() ? coreFrame.document()->axObjectCache()->rootObject() : 0; > > I think you can cache the AXObjectCache in a local variable > Also use nullptr instead of 0 > Can you add a test for tgus 1062669 4 244973 fvallee 2015-01-20 00:55:41 -0800 Created attachment 244973 Patch 1062670 5 fvallee 2015-01-20 01:00:45 -0800 Thanks for review. Patch updated with cache as a local variable and nullptr. I really wish I could add a regression test but the only case we have to reproduce the crash is using non-standard browser extensions - which are not related to / using the AXObjectCache. 1062730 6 244973 cfleizach 2015-01-20 07:29:38 -0800 Comment on attachment 244973 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244973&action=review > Source/WebKit2/ChangeLog:9 > + Can you add a comment here regarding the conditions that lead to the crash and why no test is possible 1062744 7 fvallee 2015-01-20 08:26:24 -0800 BTW I just figured out but I think the exact same change has been done in mac port ! http://trac.webkit.org/changeset/167136/trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm I will add comments in changelog and update the patch. 1063034 8 245054 fvallee 2015-01-21 02:24:04 -0800 Created attachment 245054 Patch 1064100 9 245054 cfleizach 2015-01-26 00:42:45 -0800 Comment on attachment 245054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245054&action=review > Source/WebKit2/ChangeLog:8 > + check if document()->axObjectCache() is nullptr to fix the crash Can you make these comments complete sentences. Capitalize, use periods at the end > Source/WebKit2/ChangeLog:12 > + crash occured on <http://itv.mit-xperts.com/hbbtvtest/appmanager/> indentation in this block is off. the lines do not line up 1064115 10 245333 fvallee 2015-01-26 01:38:19 -0800 Created attachment 245333 Patch 1064162 11 245333 commit-queue 2015-01-26 08:25:12 -0800 Comment on attachment 245333 Patch Clearing flags on attachment: 245333 Committed r179115: <http://trac.webkit.org/changeset/179115> 1064163 12 commit-queue 2015-01-26 08:25:16 -0800 All reviewed patches have been landed. Closing bug. 244900 2015-01-19 06:10:36 -0800 2015-01-20 00:55:34 -0800 Patch bug-140618-20150119151042.patch text/plain 1682 fvallee U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOThhYjlkZjYxYTI3YTFi YmZjYjY4YjA2ZDI3ZmE4ZjI3MTc4YjVmYy4uNWFiZDViYmMyZDU4MWYyYzI2OTRjYmM4YjljNzFi M2RmMzMxOTFmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTE5ICBGYWJp ZW4gVmFsbMOpZSAgPGZ2YWxsZWVAY29ubmVjdGVkLWxhYnMuY29tPgorCisgICAgICAgIEFYOiBj cmFzaCBpbiBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXIgbWV0aG9kIChXZWJQYWdlQWNj ZXNzaWJpbGl0eU9iamVjdEF0ay5jcHApCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDA2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBjaGVjayBpZiBkb2N1bWVudCgpLT5heE9iamVjdENhY2hlKCkgaXMg bnVsbHB0ciB0byBmaXggdGhlIGNyYXNoCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv YXRrL1dlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNwcDoKKyAgICAgICAgKGFjY2Vzc2li aWxpdHlSb290T2JqZWN0V3JhcHBlcik6CisKIDIwMTUtMDEtMTggIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEF0dGVtcHQgdG8gZml4IHRoZSBpT1MgYnVpbGQg YWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE3ODYzMT4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9hdGsvV2ViUGFnZUFjY2Vzc2li aWxpdHlPYmplY3RBdGsuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2F0 ay9XZWJQYWdlQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAKaW5kZXggYTkxZjkzMWUyODIwNzEw Yzc1ZDQ3NmM4YjFkMzZkMjNmMzg4NjY0My4uZjNlMTE3MTZlN2NhZDEyMWY3N2Y2MGZkMjQwNTUy ZjdhMWU5YTgzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L2F0ay9XZWJQYWdlQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2F0ay9XZWJQYWdlQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5j cHAKQEAgLTU2LDcgKzU2LDcgQEAgc3RhdGljIEF0a09iamVjdCogYWNjZXNzaWJpbGl0eVJvb3RP YmplY3RXcmFwcGVyKEF0a09iamVjdCogYXRrT2JqZWN0KQogICAgIGlmICghY29yZUZyYW1lLmRv Y3VtZW50KCkpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgQWNjZXNzaWJpbGl0eU9iamVjdCog Y29yZVJvb3RPYmplY3QgPSBjb3JlRnJhbWUuZG9jdW1lbnQoKS0+YXhPYmplY3RDYWNoZSgpLT5y b290T2JqZWN0KCk7CisgICAgQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZVJvb3RPYmplY3QgPSBj b3JlRnJhbWUuZG9jdW1lbnQoKS0+YXhPYmplY3RDYWNoZSgpID8gY29yZUZyYW1lLmRvY3VtZW50 KCktPmF4T2JqZWN0Q2FjaGUoKS0+cm9vdE9iamVjdCgpIDogMDsKICAgICBpZiAoIWNvcmVSb290 T2JqZWN0KQogICAgICAgICByZXR1cm4gMDsKIAo= 244973 2015-01-20 00:55:41 -0800 2015-01-21 02:23:57 -0800 Patch bug-140618-20150120095548.patch text/plain 1719 fvallee U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOThhYjlkZjYxYTI3YTFi YmZjYjY4YjA2ZDI3ZmE4ZjI3MTc4YjVmYy4uNWFiZDViYmMyZDU4MWYyYzI2OTRjYmM4YjljNzFi M2RmMzMxOTFmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTE5ICBGYWJp ZW4gVmFsbMOpZSAgPGZ2YWxsZWVAY29ubmVjdGVkLWxhYnMuY29tPgorCisgICAgICAgIEFYOiBj cmFzaCBpbiBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXIgbWV0aG9kIChXZWJQYWdlQWNj ZXNzaWJpbGl0eU9iamVjdEF0ay5jcHApCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDA2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBjaGVjayBpZiBkb2N1bWVudCgpLT5heE9iamVjdENhY2hlKCkgaXMg bnVsbHB0ciB0byBmaXggdGhlIGNyYXNoCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv YXRrL1dlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNwcDoKKyAgICAgICAgKGFjY2Vzc2li aWxpdHlSb290T2JqZWN0V3JhcHBlcik6CisKIDIwMTUtMDEtMTggIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEF0dGVtcHQgdG8gZml4IHRoZSBpT1MgYnVpbGQg YWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE3ODYzMT4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9hdGsvV2ViUGFnZUFjY2Vzc2li aWxpdHlPYmplY3RBdGsuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2F0 ay9XZWJQYWdlQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAKaW5kZXggYTkxZjkzMWUyODIwNzEw Yzc1ZDQ3NmM4YjFkMzZkMjNmMzg4NjY0My4uZjcyY2I5NTQ3MWZkYWExYzg4NjRmNmQxMjUzNDgw NzdmODBhMThjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L2F0ay9XZWJQYWdlQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2F0ay9XZWJQYWdlQWNjZXNzaWJpbGl0eU9iamVjdEF0ay5j cHAKQEAgLTU2LDcgKzU2LDExIEBAIHN0YXRpYyBBdGtPYmplY3QqIGFjY2Vzc2liaWxpdHlSb290 T2JqZWN0V3JhcHBlcihBdGtPYmplY3QqIGF0a09iamVjdCkKICAgICBpZiAoIWNvcmVGcmFtZS5k b2N1bWVudCgpKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIEFjY2Vzc2liaWxpdHlPYmplY3Qq IGNvcmVSb290T2JqZWN0ID0gY29yZUZyYW1lLmRvY3VtZW50KCktPmF4T2JqZWN0Q2FjaGUoKS0+ cm9vdE9iamVjdCgpOworICAgIEFYT2JqZWN0Q2FjaGUqIGNhY2hlID0gY29yZUZyYW1lLmRvY3Vt ZW50KCktPmF4T2JqZWN0Q2FjaGUoKTsKKyAgICBpZiAoIWNhY2hlKQorICAgICAgICByZXR1cm4g bnVsbHB0cjsgCisKKyAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlUm9vdE9iamVjdCA9IGNh Y2hlLT5yb290T2JqZWN0KCk7CiAgICAgaWYgKCFjb3JlUm9vdE9iamVjdCkKICAgICAgICAgcmV0 dXJuIDA7CiAK 245054 2015-01-21 02:24:04 -0800 2015-01-26 01:38:12 -0800 Patch bug-140618-20150121112411.patch text/plain 1986 fvallee U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzNiNmU0ZDE1ZTUwZjk2 MmY4YjE0NDNiMGIwYWVhYWNkY2M4N2FlYi4uYTNhYjY0YjA3MDc0OGVkZjkxOWJlOGJmNDRjYzZh ZWJmNTg1YjQ2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTE5ICBGYWJp ZW4gVmFsbMOpZSAgPGZ2YWxsZWVAY29ubmVjdGVkLWxhYnMuY29tPgorCisgICAgICAgIEFYOiBj cmFzaCBpbiBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXIgbWV0aG9kIChXZWJQYWdlQWNj ZXNzaWJpbGl0eU9iamVjdEF0ay5jcHApCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNjE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGNoZWNrIGlmIGRvY3VtZW50KCktPmF4T2JqZWN0Q2FjaGUoKSBp cyBudWxscHRyIHRvIGZpeCB0aGUgY3Jhc2gKKyAgICAgICAgU2ltaWxhciBwYXRjaCBoYXMgYmVl biBhcHBsaWVkIG9uIG1hYyBwb3J0OgorICAgICAgICA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9j aGFuZ2VzZXQvMTY3MTM2PgorCisgICAgICAgIGNyYXNoIG9jY3VyZWQgb24gPGh0dHA6Ly9pdHYu bWl0LXhwZXJ0cy5jb20vaGJidHZ0ZXN0L2FwcG1hbmFnZXIvPgorICAgICAgICAodGhpcyBwYWdl IG5lZWRzIENFSFRNTCAvIEhiYlRWIGV4dGVuc2lvbnMsIGNvbmRpdGlvbnMgY2Fubm90CisgICAg ICAgICBiZSByZXByb2R1Y2VkIHVzaW5nIHJlZ3Jlc3Npb24gdGVzdHMpCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvYXRrL1dlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNwcDoK KyAgICAgICAgKGFjY2Vzc2liaWxpdHlSb290T2JqZWN0V3JhcHBlcik6CisKIDIwMTUtMDEtMjEg IENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUg RU5BQkxFKElOU1BFQ1RPUikgaWZkZWYgZ3VhcmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvYXRrL1dlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9hdGsvV2ViUGFnZUFjY2Vzc2li aWxpdHlPYmplY3RBdGsuY3BwCmluZGV4IGE5MWY5MzFlMjgyMDcxMGM3NWQ0NzZjOGIxZDM2ZDIz ZjM4ODY2NDMuLjQyMWZiOGRkZGZiZWU1ZDdjYjgzODI1YjZkM2Y4Mzk3OTU4NWIwNTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9hdGsvV2ViUGFnZUFjY2Vz c2liaWxpdHlPYmplY3RBdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9hdGsvV2ViUGFnZUFjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCkBAIC01Niw3ICs1Niwx MSBAQCBzdGF0aWMgQXRrT2JqZWN0KiBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXIoQXRr T2JqZWN0KiBhdGtPYmplY3QpCiAgICAgaWYgKCFjb3JlRnJhbWUuZG9jdW1lbnQoKSkKICAgICAg ICAgcmV0dXJuIDA7CiAKLSAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlUm9vdE9iamVjdCA9 IGNvcmVGcmFtZS5kb2N1bWVudCgpLT5heE9iamVjdENhY2hlKCktPnJvb3RPYmplY3QoKTsKKyAg ICBBWE9iamVjdENhY2hlKiBjYWNoZSA9IGNvcmVGcmFtZS5kb2N1bWVudCgpLT5heE9iamVjdENh Y2hlKCk7CisgICAgaWYgKCFjYWNoZSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICBB Y2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlUm9vdE9iamVjdCA9IGNhY2hlLT5yb290T2JqZWN0KCk7 CiAgICAgaWYgKCFjb3JlUm9vdE9iamVjdCkKICAgICAgICAgcmV0dXJuIDA7CiAK 245333 2015-01-26 01:38:19 -0800 2015-01-26 08:25:12 -0800 Patch bug-140618-20150126103821.patch text/plain 1986 fvallee U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzNiNmU0ZDE1ZTUwZjk2 MmY4YjE0NDNiMGIwYWVhYWNkY2M4N2FlYi4uZjU3OTMzOTEzZmU5NmU1OGJkNTBkNmQyOTRjNWMx ZTY2MjJhM2VhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTE5ICBGYWJp ZW4gVmFsbMOpZSAgPGZ2YWxsZWVAY29ubmVjdGVkLWxhYnMuY29tPgorCisgICAgICAgIEFYOiBj cmFzaCBpbiBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXIgbWV0aG9kIChXZWJQYWdlQWNj ZXNzaWJpbGl0eU9iamVjdEF0ay5jcHApCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNjE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoZWNrIGlmIGRvY3VtZW50KCktPmF4T2JqZWN0Q2FjaGUoKSBp cyBudWxscHRyIHRvIGZpeCB0aGUgY3Jhc2guCisgICAgICAgIFNpbWlsYXIgcGF0Y2ggaGFzIGJl ZW4gYXBwbGllZCBvbiBtYWMgcG9ydDoKKyAgICAgICAgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv Y2hhbmdlc2V0LzE2NzEzNj4KKworICAgICAgICBDcmFzaCBvY2N1cmVkIG9uIDxodHRwOi8vaXR2 Lm1pdC14cGVydHMuY29tL2hiYnR2dGVzdC9hcHBtYW5hZ2VyLz4KKyAgICAgICAgKHRoaXMgcGFn ZSBuZWVkcyBDRUhUTUwgLyBIYmJUViBleHRlbnNpb25zLCBjb25kaXRpb25zIGNhbm5vdAorICAg ICAgICBiZSByZXByb2R1Y2VkIHVzaW5nIHJlZ3Jlc3Npb24gdGVzdHMpCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvYXRrL1dlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNwcDoK KyAgICAgICAgKGFjY2Vzc2liaWxpdHlSb290T2JqZWN0V3JhcHBlcik6CisKIDIwMTUtMDEtMjEg IENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUg RU5BQkxFKElOU1BFQ1RPUikgaWZkZWYgZ3VhcmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvYXRrL1dlYlBhZ2VBY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9hdGsvV2ViUGFnZUFjY2Vzc2li aWxpdHlPYmplY3RBdGsuY3BwCmluZGV4IGE5MWY5MzFlMjgyMDcxMGM3NWQ0NzZjOGIxZDM2ZDIz ZjM4ODY2NDMuLjQyMWZiOGRkZGZiZWU1ZDdjYjgzODI1YjZkM2Y4Mzk3OTU4NWIwNTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9hdGsvV2ViUGFnZUFjY2Vz c2liaWxpdHlPYmplY3RBdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9hdGsvV2ViUGFnZUFjY2Vzc2liaWxpdHlPYmplY3RBdGsuY3BwCkBAIC01Niw3ICs1Niwx MSBAQCBzdGF0aWMgQXRrT2JqZWN0KiBhY2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXIoQXRr T2JqZWN0KiBhdGtPYmplY3QpCiAgICAgaWYgKCFjb3JlRnJhbWUuZG9jdW1lbnQoKSkKICAgICAg ICAgcmV0dXJuIDA7CiAKLSAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlUm9vdE9iamVjdCA9 IGNvcmVGcmFtZS5kb2N1bWVudCgpLT5heE9iamVjdENhY2hlKCktPnJvb3RPYmplY3QoKTsKKyAg ICBBWE9iamVjdENhY2hlKiBjYWNoZSA9IGNvcmVGcmFtZS5kb2N1bWVudCgpLT5heE9iamVjdENh Y2hlKCk7CisgICAgaWYgKCFjYWNoZSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICBB Y2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlUm9vdE9iamVjdCA9IGNhY2hlLT5yb290T2JqZWN0KCk7 CiAgICAgaWYgKCFjb3JlUm9vdE9iamVjdCkKICAgICAgICAgcmV0dXJuIDA7CiAK