140617 2015-01-19 05:37:28 -0800 [GTK] Add an option to create WebKitWebView snapshots with transparent background 2015-01-20 00:29:27 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue csaavedra gustavo mrobinson oldest_to_newest 1062342 0 cgarcia 2015-01-19 05:37:28 -0800 Add WEBKIT_SNAPSHOT_OPTIONS_TRANSPARENT_BACKGROUND flag to not fill with white the background before rendering the snapshot. 1062345 1 244899 cgarcia 2015-01-19 05:44:11 -0800 Created attachment 244899 Patch 1062346 2 commit-queue 2015-01-19 05:46:25 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1062362 3 244899 mrobinson 2015-01-19 08:28:59 -0800 Comment on attachment 244899 Patch Looks good to me. Needs one more reviewer though. 1062509 4 244899 gustavo 2015-01-19 14:40:55 -0800 Comment on attachment 244899 Patch Yep! 1062666 5 cgarcia 2015-01-20 00:29:27 -0800 Committed r178700: <http://trac.webkit.org/changeset/178700> 244899 2015-01-19 05:44:11 -0800 2015-01-19 14:40:55 -0800 Patch wk2-snapshot-transparent-background.diff text/plain 7275 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNmQzMGFlLi5kYmYwZmMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTUtMDEtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIEFkZCBhbiBvcHRpb24gdG8gY3JlYXRlIFdlYktpdFdlYlZpZXcg c25hcHNob3RzIHdpdGggdHJhbnNwYXJlbnQgYmFja2dyb3VuZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNjE3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIFdFQktJVF9TTkFQU0hPVF9PUFRJT05T X1RSQU5TUEFSRU5UX0JBQ0tHUk9VTkQgZmxhZyB0byBub3QKKyAgICAgICAgZmlsbCB3aXRoIHdo aXRlIHRoZSBiYWNrZ3JvdW5kIGJlZm9yZSByZW5kZXJpbmcgdGhlIHNuYXBzaG90LgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJr aXRfd2ViX3ZpZXdfZ2V0X3NuYXBzaG90KTogUGFzcyBhIFRyYW5zcGFyZW50QmFja2dyb3VuZAor ICAgICAgICBib29sZWFuIGFyZ3VtZW50IHRvIHRoZSBXRWJQcm9jZXNzLgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0FQSS9ndGsvV2ViS2l0V2ViUGFnZS5jcHA6CisgICAgICAgICh3ZWJraXRX ZWJQYWdlRGlkUmVjZWl2ZU1lc3NhZ2UpOiBTZXQgdGhlIEZyYW1lVmlldyBiYWNrZ3JvdW5kIGFz CisgICAgICAgIHRyYW5zcGFyZW50IHdoZW4gVHJhbnNwYXJlbnRCYWNrZ3JvdW5kIG9wdGlvbiBp cyBUcnVlIGJlZm9yZQorICAgICAgICByZW5kZXJpbmcgdGhlIHNuYXBzaG90LgorCisyMDE1LTAx LTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAg ICBbR1RLXSBBZGQgQVBJIHRvIGNoYW5nZSB0aGUgV2ViS2l0V2ViVmlldyBiYWNrZ3JvdW5kIGNv bG9yCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA2 MTAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3LmNwcAppbmRleCA3OGI4MmNlLi42NDEyMGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApAQCAtMzQ3NSw2ICszNDc1LDcg QEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3NuYXBzaG90KFdlYktpdFdlYlZpZXcqIHdlYlZp ZXcsIFdlYktpdFNuYXBzaG90UmVnaW9uIHIKICAgICBtZXNzYWdlLnNldChTdHJpbmc6OmZyb21V VEY4KCJTbmFwc2hvdE9wdGlvbnMiKSwgQVBJOjpVSW50NjQ6OmNyZWF0ZShzdGF0aWNfY2FzdDx1 aW50NjRfdD4od2ViS2l0U25hcHNob3RPcHRpb25zVG9TbmFwc2hvdE9wdGlvbnMob3B0aW9ucykp KSk7CiAgICAgbWVzc2FnZS5zZXQoU3RyaW5nOjpmcm9tVVRGOCgiU25hcHNob3RSZWdpb24iKSwg QVBJOjpVSW50NjQ6OmNyZWF0ZShzdGF0aWNfY2FzdDx1aW50NjRfdD4odG9TbmFwc2hvdFJlZ2lv bihyZWdpb24pKSkpOwogICAgIG1lc3NhZ2Uuc2V0KFN0cmluZzo6ZnJvbVVURjgoIkNhbGxiYWNr SUQiKSwgQVBJOjpVSW50NjQ6OmNyZWF0ZShjYWxsYmFja0lEKSk7CisgICAgbWVzc2FnZS5zZXQo U3RyaW5nOjpmcm9tVVRGOCgiVHJhbnNwYXJlbnRCYWNrZ3JvdW5kIiksIEFQSTo6Qm9vbGVhbjo6 Y3JlYXRlKG9wdGlvbnMgJiBXRUJLSVRfU05BUFNIT1RfT1BUSU9OU19UUkFOU1BBUkVOVF9CQUNL R1JPVU5EKSk7CiAKICAgICB3ZWJWaWV3LT5wcml2LT5zbmFwc2hvdFJlc3VsdHNNYXAuc2V0KGNh bGxiYWNrSUQsIGFkb3B0R1JlZihnX3Rhc2tfbmV3KHdlYlZpZXcsIGNhbmNlbGxhYmxlLCBjYWxs YmFjaywgdXNlckRhdGEpKSk7CiAgICAgZ2V0UGFnZSh3ZWJWaWV3KS0+cG9zdE1lc3NhZ2VUb0lu amVjdGVkQnVuZGxlKFN0cmluZzo6ZnJvbVVURjgoIkdldFNuYXBzaG90IiksIEFQSTo6RGljdGlv bmFyeTo6Y3JlYXRlKFdURjo6bW92ZShtZXNzYWdlKSkuZ2V0KCkpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5oCmluZGV4IDNlNmM0OTYuLmE2 MDNkNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFdlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3LmgKQEAgLTE1Niw2ICsxNTYsOCBAQCB0eXBlZGVmIGVudW0gewogICogQFdFQktJVF9T TkFQU0hPVF9PUFRJT05TX05PTkU6IERvIG5vdCBpbmNsdWRlIGFueSBzcGVjaWFsIG9wdGlvbnMu CiAgKiBAV0VCS0lUX1NOQVBTSE9UX09QVElPTlNfSU5DTFVERV9TRUxFQ1RJT05fSElHSExJR0hU SU5HOiBXaGV0aGVyIHRvIGluY2x1ZGUgaW4gdGhlCiAgKiBzbmFwc2hvdCB0aGUgaGlnaGxpZ2h0 IG9mIHRoZSBzZWxlY3RlZCBjb250ZW50LgorICogQFdFQktJVF9TTkFQU0hPVF9PUFRJT05TX1RS QU5TUEFSRU5UX0JBQ0tHUk9VTkQ6IERvIG5vdCBmaWxsIHRoZSBiYWNrZ3JvdW5kIHdpdGggd2hp dGUgYmVmb3JlCisgKiByZW5kZXJpbmcgdGhlIHNuYXBzaG90LiBTaW5jZSAyLjgKICAqCiAgKiBF bnVtIHZhbHVlcyB1c2VkIHRvIHNwZWNpZnkgb3B0aW9ucyB3aGVuIHRha2luZyBhIHNuYXBzaG90 CiAgKiBmcm9tIGEgI1dlYktpdFdlYlZpZXcuCkBAIC0xNjMsNiArMTY1LDcgQEAgdHlwZWRlZiBl bnVtIHsKIHR5cGVkZWYgZW51bSB7CiAgIFdFQktJVF9TTkFQU0hPVF9PUFRJT05TX05PTkUgPSAw LAogICBXRUJLSVRfU05BUFNIT1RfT1BUSU9OU19JTkNMVURFX1NFTEVDVElPTl9ISUdITElHSFRJ TkcgPSAxIDw8IDAsCisgIFdFQktJVF9TTkFQU0hPVF9PUFRJT05TX1RSQU5TUEFSRU5UX0JBQ0tH Uk9VTkQgPSAxIDw8IDEsCiB9IFdlYktpdFNuYXBzaG90T3B0aW9uczsKIAogLyoqCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvV2Vi S2l0V2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl L0FQSS9ndGsvV2ViS2l0V2ViUGFnZS5jcHAKaW5kZXggYmQwOTlkOC4uODJmOGIzOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dl YktpdFdlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL2d0ay9XZWJLaXRXZWJQYWdlLmNwcApAQCAtNDU0LDYgKzQ1NCw3IEBAIHZvaWQg d2Via2l0V2ViUGFnZURpZFJlY2VpdmVNZXNzYWdlKFdlYktpdFdlYlBhZ2UqIHBhZ2UsIGNvbnN0 IFN0cmluZyYgbWVzc2FnZU5hCiAgICAgICAgIFNuYXBzaG90T3B0aW9ucyBzbmFwc2hvdE9wdGlv bnMgPSBzdGF0aWNfY2FzdDxTbmFwc2hvdE9wdGlvbnM+KHN0YXRpY19jYXN0PEFQSTo6VUludDY0 Kj4obWVzc2FnZS5nZXQoIlNuYXBzaG90T3B0aW9ucyIpKS0+dmFsdWUoKSk7CiAgICAgICAgIHVp bnQ2NF90IGNhbGxiYWNrSUQgPSBzdGF0aWNfY2FzdDxBUEk6OlVJbnQ2NCo+KG1lc3NhZ2UuZ2V0 KCJDYWxsYmFja0lEIikpLT52YWx1ZSgpOwogICAgICAgICBTbmFwc2hvdFJlZ2lvbiByZWdpb24g PSBzdGF0aWNfY2FzdDxTbmFwc2hvdFJlZ2lvbj4oc3RhdGljX2Nhc3Q8QVBJOjpVSW50NjQqPiht ZXNzYWdlLmdldCgiU25hcHNob3RSZWdpb24iKSktPnZhbHVlKCkpOworICAgICAgICBib29sIHRy YW5zcGFyZW50QmFja2dyb3VuZCA9IHN0YXRpY19jYXN0PEFQSTo6Qm9vbGVhbio+KG1lc3NhZ2Uu Z2V0KCJUcmFuc3BhcmVudEJhY2tncm91bmQiKSktPnZhbHVlKCk7CiAKICAgICAgICAgUmVmUHRy PFdlYkltYWdlPiBzbmFwc2hvdEltYWdlOwogICAgICAgICBXZWJQYWdlKiB3ZWJQYWdlID0gcGFn ZS0+cHJpdi0+d2ViUGFnZTsKQEAgLTQ2OSw4ICs0NzAsMTYgQEAgdm9pZCB3ZWJraXRXZWJQYWdl RGlkUmVjZWl2ZU1lc3NhZ2UoV2ViS2l0V2ViUGFnZSogcGFnZSwgY29uc3QgU3RyaW5nJiBtZXNz YWdlTmEKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAoIXNuYXBzaG90UmVjdC5p c0VtcHR5KCkpCisgICAgICAgICAgICBpZiAoIXNuYXBzaG90UmVjdC5pc0VtcHR5KCkpIHsKKyAg ICAgICAgICAgICAgICBDb2xvciBzYXZlZEJhY2tncm91bmRDb2xvcjsKKyAgICAgICAgICAgICAg ICBpZiAodHJhbnNwYXJlbnRCYWNrZ3JvdW5kKSB7CisgICAgICAgICAgICAgICAgICAgIHNhdmVk QmFja2dyb3VuZENvbG9yID0gZnJhbWVWaWV3LT5iYXNlQmFja2dyb3VuZENvbG9yKCk7CisgICAg ICAgICAgICAgICAgICAgIGZyYW1lVmlldy0+c2V0QmFzZUJhY2tncm91bmRDb2xvcihDb2xvcjo6 dHJhbnNwYXJlbnQpOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBzbmFwc2hv dEltYWdlID0gd2ViUGFnZS0+c2NhbGVkU25hcHNob3RXaXRoT3B0aW9ucyhzbmFwc2hvdFJlY3Qs IDEsIHNuYXBzaG90T3B0aW9ucyB8IFNuYXBzaG90T3B0aW9uc1NoYXJlYWJsZSk7CisgICAgICAg ICAgICAgICAgaWYgKHRyYW5zcGFyZW50QmFja2dyb3VuZCkKKyAgICAgICAgICAgICAgICAgICAg ZnJhbWVWaWV3LT5zZXRCYXNlQmFja2dyb3VuZENvbG9yKHNhdmVkQmFja2dyb3VuZENvbG9yKTsK KyAgICAgICAgICAgIH0KICAgICAgICAgfQogCiAgICAgICAgIEFQSTo6RGljdGlvbmFyeTo6TWFw VHlwZSBtZXNzYWdlUmVwbHk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggYWNkYWQ5NC4uZmMwM2MzNyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTAxLTE5ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RL XSBBZGQgYW4gb3B0aW9uIHRvIGNyZWF0ZSBXZWJLaXRXZWJWaWV3IHNuYXBzaG90cyB3aXRoIHRy YW5zcGFyZW50IGJhY2tncm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MDYxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRX ZWJWaWV3LmNwcDoKKyAgICAgICAgKHRlc3RXZWJWaWV3U25hcHNob3QpOiBDaGVjayB0aGF0IHRo ZSBzYW1lIHNuYXBzaG90IHdpdGgKKyAgICAgICAgdHJhbnNwYXJlbnQgYmFja2dyb3VuZCBpcyBk aWZmZXJlbnQgdGhhbiB0aGUgZGVmYXVsdCBvbmUgZmlsbGVkCisgICAgICAgIHdpdGggd2hpdGUu CisKKzIwMTUtMDEtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCiAgICAgICAgIFtHVEtdIEFkZCBBUEkgdG8gY2hhbmdlIHRoZSBXZWJLaXRXZWJWaWV3IGJh Y2tncm91bmQgY29sb3IKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MDYxMAogCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDJHdGsvVGVzdFdlYktpdFdlYlZpZXcuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRXZWJWaWV3LmNwcAppbmRleCAzNzBiYmQ0Li4wNWJiODYy IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdFdl YktpdFdlYlZpZXcuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0 ay9UZXN0V2ViS2l0V2ViVmlldy5jcHAKQEAgLTU4MSw2ICs1ODEsMTMgQEAgc3RhdGljIHZvaWQg dGVzdFdlYlZpZXdTbmFwc2hvdChTbmFwc2hvdFdlYlZpZXdUZXN0KiB0ZXN0LCBnY29uc3Rwb2lu dGVyKQogICAgIGdfYXNzZXJ0X2NtcGludChjYWlyb19pbWFnZV9zdXJmYWNlX2dldF93aWR0aChz dXJmYWNlMSksID09LCBjYWlyb19pbWFnZV9zdXJmYWNlX2dldF93aWR0aChzdXJmYWNlMikpOwog ICAgIGdfYXNzZXJ0X2NtcGludChjYWlyb19pbWFnZV9zdXJmYWNlX2dldF9oZWlnaHQoc3VyZmFj ZTEpLCA9PSwgY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfaGVpZ2h0KHN1cmZhY2UyKSk7CiAgICAg Z19hc3NlcnQoIVRlc3Q6OmNhaXJvU3VyZmFjZXNFcXVhbChzdXJmYWNlMSwgc3VyZmFjZTIpKTsK KworICAgIC8vIEdldCBhIHNucGFzaG90IHdpdGggYSB0cmFuc3BhcmVudCBiYWNrZ3JvdW5kLCB0 aGUgcmVzdWx0IG11c3QgYmUgZGlmZmVyZW50LgorICAgIHN1cmZhY2UyID0gdGVzdC0+Z2V0U25h cHNob3RBbmRXYWl0VW50aWxSZWFkeShXRUJLSVRfU05BUFNIT1RfUkVHSU9OX1ZJU0lCTEUsIFdF QktJVF9TTkFQU0hPVF9PUFRJT05TX1RSQU5TUEFSRU5UX0JBQ0tHUk9VTkQpOworICAgIGdfYXNz ZXJ0X2NtcHVpbnQoY2Fpcm9fc3VyZmFjZV9nZXRfdHlwZShzdXJmYWNlMiksID09LCBDQUlST19T VVJGQUNFX1RZUEVfSU1BR0UpOworICAgIGdfYXNzZXJ0X2NtcGludChjYWlyb19pbWFnZV9zdXJm YWNlX2dldF93aWR0aChzdXJmYWNlMSksID09LCBjYWlyb19pbWFnZV9zdXJmYWNlX2dldF93aWR0 aChzdXJmYWNlMikpOworICAgIGdfYXNzZXJ0X2NtcGludChjYWlyb19pbWFnZV9zdXJmYWNlX2dl dF9oZWlnaHQoc3VyZmFjZTEpLCA9PSwgY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfaGVpZ2h0KHN1 cmZhY2UyKSk7CisgICAgZ19hc3NlcnQoIVRlc3Q6OmNhaXJvU3VyZmFjZXNFcXVhbChzdXJmYWNl MSwgc3VyZmFjZTIpKTsKICAgICBjYWlyb19zdXJmYWNlX2Rlc3Ryb3koc3VyZmFjZTEpOwogCiAg ICAgLy8gVGVzdCB0aGF0IGNhbmNlbGxhdGlvbiB3b3Jrcy4K