140616 2015-01-19 04:31:31 -0800 [GTK] Cannot compile 2.7.3 on PowerPC machines 2015-09-04 08:41:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela webkit-unassigned berto cgarcia commit-queue rob.mackinnon spam zan oldest_to_newest 1062330 0 tpopela 2015-01-19 04:31:31 -0800 Compiling GTK port with -DENABLE_JIT=OFF -DENABLE_LLINT_C_LOOP=ON and with -DENABLE_YARR_JIT=0 ends with: /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp: In member function 'WTF::Vector<std::pair<int, int> > JSC::BasicBlockLocation::getExecutedRanges() const': /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:54:20: error: 'INT_MAX' was not declared in this scope Gap minGap(INT_MAX, 0); ^ /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp: In member function 'void JSC::BasicBlockLocation::dumpData() const': /builddir/build/BUILD/webkitgtk-2.7.3/Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:76:117: error: 'dataLogF' was not declared in this scope dataLogF("\tBasicBlock: [%d, %d] hasExecuted: %s\n", gap.first, gap.second, hasExecuted() ? "true" : "false"); It also applies for trunk. 1062332 1 244896 tpopela 2015-01-19 04:34:14 -0800 Created attachment 244896 Patch 1062333 2 commit-queue 2015-01-19 04:36:00 -0800 Attachment 244896 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1062336 3 244897 tpopela 2015-01-19 04:41:58 -0800 Created attachment 244897 Patch 1062338 4 berto 2015-01-19 05:10:57 -0800 lgtm, thanks 1062709 5 244897 ossy 2015-01-20 05:55:07 -0800 Comment on attachment 244897 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244897&action=review > Source/JavaScriptCore/runtime/BasicBlockLocation.cpp:34 > #include "CCallHelpers.h" > > +#include <climits> > + > +#include <wtf/DataLog.h> LGTM, but please remove the blank lines before landing. 1062711 6 244897 ossy 2015-01-20 05:56:10 -0800 Comment on attachment 244897 Patch #include "config.h" #include "BasicBlockLocation.h" #include "CCallHelpers.h" #include <climits> #include <wtf/DataLog.h> 1062714 7 cgarcia 2015-01-20 06:01:36 -0800 Committed r178708: <http://trac.webkit.org/changeset/178708> 1123435 8 mcatanzaro 2015-09-04 08:41:36 -0700 *** Bug 142511 has been marked as a duplicate of this bug. *** 1123437 9 mcatanzaro 2015-09-04 08:41:40 -0700 *** Bug 139588 has been marked as a duplicate of this bug. *** 244896 2015-01-19 04:34:14 -0800 2015-01-19 04:41:51 -0800 Patch bug-140616-20150119133420.patch text/plain 1273 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ODMyM2FjM2I0ZDdkMjYxNjgwM2JlODgzYzUxNDNiMjdlOTNhMjUwLi4wOTBhYjViNTg2ZGJkMDkz MWE5NTYyYjNlYTc1MjBjMDljYzM2YTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wMS0xOSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29t PgorCisgICAgICAgIFtHVEtdIENhbm5vdCBjb21waWxlIDIuNy4zIG9uIFBvd2VyUEMgbWFjaGlu ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDYx NgorCisJSW5jbHVkZSBjbGltaXRzIGZvciBJTlRfTUFYIGFuZCB3dGYvRGF0YUxvZy5oIGZvciBk YXRhTG9nRgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcnVudGltZS9CYXNpY0Jsb2NrTG9jYXRpb24uY3BwOgorCiAyMDE1LTAxLTE3ICBCcmlhbiBK LiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBoaWdobGlnaHQgZGF0YSBmb3Igb3ZlcmxheSBzaG91bGQgdXNlIHByb3RvY29sIHR5cGUgYnVp bGRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Jhc2ljQmxv Y2tMb2NhdGlvbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9CYXNpY0Jsb2Nr TG9jYXRpb24uY3BwCmluZGV4IDE2ZTRkYTNmNWRjMTM5ODA1YWEzMWVkYjY0YjFiMGQ5MWViNWQ2 NjkuLjExMTIxNWM3YTdkOTFjNmMzYTQ1MTA3MjgzYTJmYjEzNGE1ZGUyODQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Jhc2ljQmxvY2tMb2NhdGlvbi5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQmFzaWNCbG9ja0xvY2F0aW9uLmNwcApA QCAtMjksNiArMjksMTAgQEAKIAogI2luY2x1ZGUgIkNDYWxsSGVscGVycy5oIgogCisjaW5jbHVk ZSA8Y2xpbWl0cz4KKworI2luY2x1ZGUgPHd0Zi9EYXRhTG9nLmg+CisKIG5hbWVzcGFjZSBKU0Mg ewogCiBCYXNpY0Jsb2NrTG9jYXRpb246OkJhc2ljQmxvY2tMb2NhdGlvbihpbnQgc3RhcnRPZmZz ZXQsIGludCBlbmRPZmZzZXQpCg== 244897 2015-01-19 04:41:58 -0800 2015-01-20 05:55:07 -0800 Patch bug-140616-20150119134204.patch text/plain 1280 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ODMyM2FjM2I0ZDdkMjYxNjgwM2JlODgzYzUxNDNiMjdlOTNhMjUwLi5kNzU4OGY4OGFkZjNiNTAz NjU2ZjU4YmU5YzMzNjhiMTcwM2I2MGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wMS0xOSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29t PgorCisgICAgICAgIFtHVEtdIENhbm5vdCBjb21waWxlIDIuNy4zIG9uIFBvd2VyUEMgbWFjaGlu ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDYx NgorCisgICAgICAgIEluY2x1ZGUgY2xpbWl0cyBmb3IgSU5UX01BWCBhbmQgd3RmL0RhdGFMb2cu aCBmb3IgZGF0YUxvZ0YKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHJ1bnRpbWUvQmFzaWNCbG9ja0xvY2F0aW9uLmNwcDoKKwogMjAxNS0wMS0xNyAg QnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogaGlnaGxpZ2h0IGRhdGEgZm9yIG92ZXJsYXkgc2hvdWxkIHVzZSBwcm90b2NvbCB0 eXBlIGJ1aWxkZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9C YXNpY0Jsb2NrTG9jYXRpb24uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQmFz aWNCbG9ja0xvY2F0aW9uLmNwcAppbmRleCAxNmU0ZGEzZjVkYzEzOTgwNWFhMzFlZGI2NGIxYjBk OTFlYjVkNjY5Li4xMTEyMTVjN2E3ZDkxYzZjM2E0NTEwNzI4M2EyZmIxMzRhNWRlMjg0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9CYXNpY0Jsb2NrTG9jYXRpb24u Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Jhc2ljQmxvY2tMb2NhdGlv bi5jcHAKQEAgLTI5LDYgKzI5LDEwIEBACiAKICNpbmNsdWRlICJDQ2FsbEhlbHBlcnMuaCIKIAor I2luY2x1ZGUgPGNsaW1pdHM+CisKKyNpbmNsdWRlIDx3dGYvRGF0YUxvZy5oPgorCiBuYW1lc3Bh Y2UgSlNDIHsKIAogQmFzaWNCbG9ja0xvY2F0aW9uOjpCYXNpY0Jsb2NrTG9jYXRpb24oaW50IHN0 YXJ0T2Zmc2V0LCBpbnQgZW5kT2Zmc2V0KQo=