140611 2015-01-19 01:52:51 -0800 REGRESSION(r178486): It broke the !ENABLE(VIDEO) build 2015-01-19 07:27:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 140468 1 ossy ossy commit-queue eric.carlson jer.noble ossy oldest_to_newest 1062299 0 ossy 2015-01-19 01:52:51 -0800 build log: ../../Source/WebCore/testing/Internals.cpp: In member function 'bool WebCore::Internals::elementIsBlockingDisplaySleep(WebCore::Element*) const': ../../Source/WebCore/testing/Internals.cpp:2441:39: error: invalid use of incomplete type 'class WebCore::HTMLMediaElement' In file included from ../../Source/WebCore/dom/Element.h:29:0, from ../../Source/WebCore/loader/cache/CachedResourceRequest.h:29, from ../../Source/WebCore/loader/cache/CachedResourceLoader.h:32, from ../../Source/WebCore/testing/Internals.cpp:35: ../../Source/WebCore/dom/Document.h:112:7: error: forward declaration of 'class WebCore::HTMLMediaElement' In file included from ../../Source/WebCore/dom/Node.h:39:0, from ../../Source/WebCore/dom/ContainerNode.h:28, from ../../Source/WebCore/dom/Position.h:29, from ../../Source/WebCore/editing/VisiblePosition.h:30, from ../../Source/WebCore/accessibility/AccessibilityObject.h:37, from ../../Source/WebCore/accessibility/AXObjectCache.h:29, from ../../Source/WebCore/testing/Internals.cpp:30: ../../Source/WTF/wtf/TypeCasts.h: In instantiation of 'typename std::conditional<std::is_const<Source>::value, const Target*, Target*>::type WTF::downcast(Source*) [with Target = WebCore::HTMLMediaElement; Source = WebCore::Element; typename std::conditional<std::is_const<Source>::value, const Target*, Target*>::type = WebCore::HTMLMediaElement*]': ../../Source/WebCore/testing/Internals.cpp:2440:72: required from here ../../Source/WTF/wtf/TypeCasts.h:81:117: error: invalid static_cast from type 'WebCore::Element*' to type 'std::conditional<false, const WebCore::HTMLMediaElement*, WebCore::HTMLMediaElement*>::type {aka WebCore::HTMLMediaElement*}' ../../Source/WebCore/testing/Internals.cpp:2442:1: error: control reaches end of non-void function [-Werror=return-type] In file included from ../../Source/WebCore/dom/Node.h:39:0, from ../../Source/WebCore/dom/ContainerNode.h:28, from ../../Source/WebCore/dom/Position.h:29, from ../../Source/WebCore/editing/VisiblePosition.h:30, from ../../Source/WebCore/accessibility/AccessibilityObject.h:37, from ../../Source/WebCore/accessibility/AXObjectCache.h:29, from ../../Source/WebCore/testing/Internals.cpp:30: ../../Source/WTF/wtf/TypeCasts.h: In function 'typename std::conditional<std::is_const<Source>::value, const Target*, Target*>::type WTF::downcast(Source*) [with Target = WebCore::HTMLMediaElement; Source = WebCore::Element; typename std::conditional<std::is_const<Source>::value, const Target*, Target*>::type = WebCore::HTMLMediaElement*]': ../../Source/WTF/wtf/TypeCasts.h:82:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors 1062301 1 ossy 2015-01-19 01:54:04 -0800 elementIsBlockingDisplaySleep is guarded in Source/WebCore/testing/Internals.idl: [Conditional=VIDEO] boolean elementIsBlockingDisplaySleep(Element element); We should guard its implementation too. 1062302 2 244884 ossy 2015-01-19 01:55:17 -0800 Created attachment 244884 Patch 1062359 3 244884 commit-queue 2015-01-19 07:27:55 -0800 Comment on attachment 244884 Patch Clearing flags on attachment: 244884 Committed r178646: <http://trac.webkit.org/changeset/178646> 1062360 4 commit-queue 2015-01-19 07:27:59 -0800 All reviewed patches have been landed. Closing bug. 244884 2015-01-19 01:55:17 -0800 2015-01-19 07:27:55 -0800 Patch bug-140611-20150119015522.patch text/plain 2777 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY0NzkyMDBiZjc5ZTMw ODgwOWQ3MDZmNWQwMDU1YTkwMmM2ZTM4MS4uZjAyNjc2ZjYyOWYxNmEwZjczNWZkNGI3YTY2YWYx YzQwNjc5ZGY2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAxLTE5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTc4NDg2KTogSXQgYnJva2UgdGhlICFFTkFCTEUoVklERU8pIGJ1aWxkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA2MTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6ZWxlbWVudElzQmxvY2tpbmdEaXNwbGF5 U2xlZXApOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmg6CisKIDIwMTUtMDEtMTggIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIGJpbmRp bmdzIGdlbmVyYXRpb24gdGVzdCByZXN1bHRzIGFmdGVyIDxodHRwczovL3RyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvMTc4NjMzPi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3Rpbmcv SW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAppbmRl eCBlOWZhZWQwMTZlOTkwZTUxMTA0NzNiZmQ2ZmYxMGNlZTQ1OGZmZmM2Li4wNmJmY2ZmYjkyYzQ3 NjcyZjc2MDJjMjIxZjAyNmVjNThjYzc2ZDkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL0ludGVybmFscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bHMuY3BwCkBAIC0yNDE5LDYgKzI0MTksMTMgQEAgdm9pZCBJbnRlcm5hbHM6OnBvc3RSZW1vdGVD b250cm9sQ29tbWFuZChjb25zdCBTdHJpbmcmIGNvbW1hbmRTdHJpbmcsIEV4Y2VwdGlvbkMKICAg ICAKICAgICBNZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VyKCkuZGlkUmVjZWl2ZVJl bW90ZUNvbnRyb2xDb21tYW5kKGNvbW1hbmQpOwogfQorCitib29sIEludGVybmFsczo6ZWxlbWVu dElzQmxvY2tpbmdEaXNwbGF5U2xlZXAoRWxlbWVudCogZWxlbWVudCkgY29uc3QKK3sKKyAgICBI VE1MTWVkaWFFbGVtZW50KiBtZWRpYUVsZW1lbnQgPSBkb3duY2FzdDxIVE1MTWVkaWFFbGVtZW50 PihlbGVtZW50KTsKKyAgICByZXR1cm4gbWVkaWFFbGVtZW50ID8gbWVkaWFFbGVtZW50LT5pc0Rp c2FibGluZ1NsZWVwKCkgOiBmYWxzZTsKK30KKwogI2VuZGlmIC8vIEVOQUJMRShWSURFTykKIAog dm9pZCBJbnRlcm5hbHM6OnNpbXVsYXRlU3lzdGVtU2xlZXAoKSBjb25zdApAQCAtMjQzNSwxMSAr MjQ0Miw2IEBAIHZvaWQgSW50ZXJuYWxzOjpzaW11bGF0ZVN5c3RlbVdha2UoKSBjb25zdAogI2Vu ZGlmCiB9CiAKLWJvb2wgSW50ZXJuYWxzOjplbGVtZW50SXNCbG9ja2luZ0Rpc3BsYXlTbGVlcChF bGVtZW50KiBlbGVtZW50KSBjb25zdAotewotICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxl bWVudCA9IGRvd25jYXN0PEhUTUxNZWRpYUVsZW1lbnQ+KGVsZW1lbnQpOwotICAgIHJldHVybiBt ZWRpYUVsZW1lbnQgPyBtZWRpYUVsZW1lbnQtPmlzRGlzYWJsaW5nU2xlZXAoKSA6IGZhbHNlOwot fQogCiB2b2lkIEludGVybmFsczo6aW5zdGFsbE1vY2tQYWdlT3ZlcmxheShjb25zdCBTdHJpbmcm IG92ZXJsYXlUeXBlLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFscy5oCmluZGV4IDcwZDdhNzZlMmQzZThlZWJlNDgzNjRhMDBlOWZmZTkxMzkxYzk5YWIuLjMw MDg4ZTgwZGQzNzM4Njg1MzAzYTk4NzIwNzU3MzdjZDU5OWIwZWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbHMuaApAQCAtMzQ3LDExICszNDcsMTEgQEAgcHVibGljOgogICAgIHZvaWQgYXBw bGljYXRpb25XaWxsRW50ZXJCYWNrZ3JvdW5kKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRNZWRpYVNl c3Npb25SZXN0cmljdGlvbnMoY29uc3QgU3RyaW5nJiBtZWRpYVR5cGUsIGNvbnN0IFN0cmluZyYg cmVzdHJpY3Rpb25zLCBFeGNlcHRpb25Db2RlJik7CiAgICAgdm9pZCBwb3N0UmVtb3RlQ29udHJv bENvbW1hbmQoY29uc3QgU3RyaW5nJiwgRXhjZXB0aW9uQ29kZSYpOworICAgIGJvb2wgZWxlbWVu dElzQmxvY2tpbmdEaXNwbGF5U2xlZXAoRWxlbWVudCopIGNvbnN0OwogI2VuZGlmCiAKICAgICB2 b2lkIHNpbXVsYXRlU3lzdGVtU2xlZXAoKSBjb25zdDsKICAgICB2b2lkIHNpbXVsYXRlU3lzdGVt V2FrZSgpIGNvbnN0OwotICAgIGJvb2wgZWxlbWVudElzQmxvY2tpbmdEaXNwbGF5U2xlZXAoRWxl bWVudCopIGNvbnN0OwogCiAgICAgdm9pZCBpbnN0YWxsTW9ja1BhZ2VPdmVybGF5KGNvbnN0IFN0 cmluZyYgb3ZlcmxheVR5cGUsIEV4Y2VwdGlvbkNvZGUmKTsKICAgICBTdHJpbmcgcGFnZU92ZXJs YXlMYXllclRyZWVBc1RleHQoRXhjZXB0aW9uQ29kZSYpIGNvbnN0Owo=