140561 2015-01-16 13:01:17 -0800 Should cancel immediate action sooner in WK2 2015-01-16 13:12:12 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1061924 0 bdakin 2015-01-16 13:01:17 -0800 We should cancel immediate action sooner in WK2. We have the ability to know whether or not the action should be cancelled as soon as the actionMenuHitTest is received. We should cancel it then if need be. rdar://problem/19490114 1061928 1 244795 bdakin 2015-01-16 13:04:49 -0800 Created attachment 244795 Patch 1061935 2 bdakin 2015-01-16 13:12:12 -0800 Thank you! http://trac.webkit.org/changeset/178595 244795 2015-01-16 13:04:49 -0800 2015-01-16 13:09:24 -0800 Patch for-review.txt text/plain 2920 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODU5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAxLTE2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgY2FuY2VsIGltbWVkaWF0 ZSBhY3Rpb24gc29vbmVyIGluIFdLMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQwNTYxCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vMTk0OTAxMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBfY2FuY2VsSW1tZWRpYXRlQWN0aW9uSWZOZWVkZWQgd2lsbCBj YW5jZWwgdGhlIGltbWVkaWF0ZSBhY3Rpb24gaWYgdGhlcmUgaXMgbm8gCisgICAgICAgIGFuaW1h dGlvbiBjb250cm9sbGVyIG9yIGlmIHRoZSBEREFjdGlvbkNvbnRleHQgZG9lc27igJl0IHdhbnQg dG8gdXNlIGl0cyBhY3Rpb25zLgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tJbW1lZGlhdGVB Y3Rpb25Db250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xs ZXIgX2NhbmNlbEltbWVkaWF0ZUFjdGlvbklmTmVlZGVkXSk6CisKKyAgICAgICAgQ2FsbCBfY2Fu Y2VsSW1tZWRpYXRlQWN0aW9uSWZOZWVkZWQgdG8gY2FuY2VsIGVhcmxpZXIuCisgICAgICAgICgt W1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlciBkaWRQZXJmb3JtQWN0aW9uTWVudUhpdFRlc3Q6 dXNlckRhdGE6XSk6CisKKyAgICAgICAgUmUtZmFjdG9yIHRoaXMgY29kZSB0byB1c2UgdGhlIG5l d2x5LWFkZGVkIG1ldGhvZCBfY2FuY2VsSW1tZWRpYXRlQWN0aW9uSWZOZWVkZWQKKyAgICAgICAg KC1bV0tJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyIGltbWVkaWF0ZUFjdGlvblJlY29nbml6ZXJX aWxsQmVnaW5BbmltYXRpb246XSk6CisKIDIwMTUtMDEtMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBMb2cgdW5oYW5kbGVkIG1lc3NhZ2VzIGluIHRo ZSB3ZWIgcHJvY2VzcwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0ltbWVk aWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE3ODU4 MikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tJbW1lZGlhdGVBY3Rpb25Db250 cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC05Myw2ICs5MywxOCBAQCAtICh2b2lkKV9jYW5j ZWxJbW1lZGlhdGVBY3Rpb24KICAgICBbc2VsZiBfY2xlYXJJbW1lZGlhdGVBY3Rpb25TdGF0ZV07 CiB9CiAKKy0gKHZvaWQpX2NhbmNlbEltbWVkaWF0ZUFjdGlvbklmTmVlZGVkCit7CisgICAgaWYg KCFfaW1tZWRpYXRlQWN0aW9uUmVjb2duaXplci5hbmltYXRpb25Db250cm9sbGVyKQorICAgICAg ICBbc2VsZiBfY2FuY2VsSW1tZWRpYXRlQWN0aW9uXTsKKworICAgIGlmIChfY3VycmVudEFjdGlv bkNvbnRleHQpIHsKKyAgICAgICAgX2hhc0FjdGl2YXRlZEFjdGlvbkNvbnRleHQgPSBZRVM7Cisg ICAgICAgIGlmICghW2dldEREQWN0aW9uc01hbmFnZXJDbGFzcygpIHNob3VsZFVzZUFjdGlvbnNX aXRoQ29udGV4dDpfY3VycmVudEFjdGlvbkNvbnRleHQuZ2V0KCldKQorICAgICAgICAgICAgW3Nl bGYgX2NhbmNlbEltbWVkaWF0ZUFjdGlvbl07CisgICAgfQorfQorCiAtICh2b2lkKV9jbGVhcklt bWVkaWF0ZUFjdGlvblN0YXRlCiB7CiAgICAgX3BhZ2UtPmNsZWFyVGV4dEluZGljYXRvcigpOwpA QCAtMTE3LDYgKzEyOSw3IEBAIC0gKHZvaWQpZGlkUGVyZm9ybUFjdGlvbk1lbnVIaXRUZXN0Oihj b24KICAgICBfdXNlckRhdGEgPSB1c2VyRGF0YTsKIAogICAgIFtzZWxmIF91cGRhdGVJbW1lZGlh dGVBY3Rpb25JdGVtXTsKKyAgICBbc2VsZiBfY2FuY2VsSW1tZWRpYXRlQWN0aW9uSWZOZWVkZWRd OwogfQogCiAjcHJhZ21hIG1hcmsgTlNJbW1lZGlhdGVBY3Rpb25HZXN0dXJlUmVjb2duaXplckRl bGVnYXRlCkBAIC0xNTQsMTggKzE2Nyw5IEBAIC0gKHZvaWQpaW1tZWRpYXRlQWN0aW9uUmVjb2du aXplcldpbGxCZWcKICAgICAgICAgfQogICAgIH0KIAotICAgIGlmIChfc3RhdGUgIT0gSW1tZWRp YXRlQWN0aW9uU3RhdGU6OlJlYWR5KQorICAgIGlmIChfc3RhdGUgIT0gSW1tZWRpYXRlQWN0aW9u U3RhdGU6OlJlYWR5KSB7CiAgICAgICAgIFtzZWxmIF91cGRhdGVJbW1lZGlhdGVBY3Rpb25JdGVt XTsKLQotICAgIGlmICghX2ltbWVkaWF0ZUFjdGlvblJlY29nbml6ZXIuYW5pbWF0aW9uQ29udHJv bGxlcikgewotICAgICAgICBbc2VsZiBfY2FuY2VsSW1tZWRpYXRlQWN0aW9uXTsKLSAgICAgICAg cmV0dXJuOwotICAgIH0KLQotICAgIGlmIChfY3VycmVudEFjdGlvbkNvbnRleHQpIHsKLSAgICAg ICAgX2hhc0FjdGl2YXRlZEFjdGlvbkNvbnRleHQgPSBZRVM7Ci0gICAgICAgIGlmICghW2dldERE QWN0aW9uc01hbmFnZXJDbGFzcygpIHNob3VsZFVzZUFjdGlvbnNXaXRoQ29udGV4dDpfY3VycmVu dEFjdGlvbkNvbnRleHQuZ2V0KCldKQotICAgICAgICAgICAgW3NlbGYgX2NhbmNlbEltbWVkaWF0 ZUFjdGlvbl07CisgICAgICAgIFtzZWxmIF9jYW5jZWxJbW1lZGlhdGVBY3Rpb25JZk5lZWRlZF07 CiAgICAgfQogfQogCg==