140547 2015-01-16 10:45:22 -0800 webkit-patch should auto-install the keyring python module 2015-01-16 12:07:18 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue ddkilzer glenn mmaxfield oldest_to_newest 1061845 0 cdumez 2015-01-16 10:45:22 -0800 Every time I run webkit-patch it asks for my username / password. It never asks if it should save my username / password in the keychain. I think the script should ask me if I want to save it and then do a "security add-internet-password ..." to store it in the keychain. Note: I do not have the keyring python module installed. 1061852 1 cdumez 2015-01-16 10:55:47 -0800 Looks like a solution would be to auto-install the keyring module. webkit-patch seems to be working fine for me with the keyring module installed. 1061855 2 244776 cdumez 2015-01-16 11:19:16 -0800 Created attachment 244776 Patch 1061857 3 244776 ddkilzer 2015-01-16 11:21:56 -0800 Comment on attachment 244776 Patch r=me 1061881 4 244776 commit-queue 2015-01-16 12:07:01 -0800 Comment on attachment 244776 Patch Clearing flags on attachment: 244776 Committed r178589: <http://trac.webkit.org/changeset/178589> 1061883 5 commit-queue 2015-01-16 12:07:18 -0800 All reviewed patches have been landed. Closing bug. 244776 2015-01-16 11:19:16 -0800 2015-01-16 12:07:01 -0800 Patch bug-140547-20150116111923.patch text/plain 2992 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NTgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmExYzcxOTk4YmQ2NDdkZGVlYjMwYjM4ZmJjNGZhNjE1 OTY1MGI2YS4uNjgwY2Q5NzcyMWRjY2IxZjBhNmMwMWQyMTZhNmVhMWU3NTM4NTQyMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDE1LTAxLTE2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgd2Via2l0LXBhdGNoIHNob3VsZCBhdXRvLWluc3RhbGwgdGhlIGtleXJpbmcgcHl0aG9uIG1v ZHVsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQw NTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXV0 by1pbnN0YWxsIHRoZSBrZXlyaW5nIHB5dGhvbiBtb2R1bGUuIFRoaXMgaXMgdGhlIG1vZHVsZSB0 aGF0CisgICAgICAgIHdlYmtpdC1wYXRjaCB1c2VzIGZvciBjcm9zcy1wbGF0Zm9ybSBhY2Nlc3Mg dG8gdGhlIGtleXJpbmcKKyAgICAgICAgc2VydmljZS4KKworICAgICAgICBXaXRob3V0IHRoaXMg bW9kdWxlLCBpZiB0aGUgcGFzc3dvcmQgaWYgbm90IGluIHRoZSBrZXljaGFpbiwKKyAgICAgICAg d2Via2l0LXBhdGNoIHdpbGwga2VlcCBhc2tpbmcgZm9yIHlvdXIgdXNlcm5hbWUgLyBwYXNzd29y ZCBhbmQKKyAgICAgICAgbmV2ZXIgcmVtZW1iZXIgdGhlbS4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvY29tbW9uL25ldC9jcmVkZW50aWFscy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHk6CisgICAgICAgIChBdXRvaW5zdGFsbEltcG9y dEhvb2suZmluZF9tb2R1bGUpOgorICAgICAgICAoQXV0b2luc3RhbGxJbXBvcnRIb29rLl9pbnN0 YWxsX2tleXJpbmcpOgorCiAyMDE1LTAxLTE1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIEVOQUJMRShTUUxfREFUQUJBU0UpIGd1YXJkcwpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2NyZWRlbnRpYWxz LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2NyZWRlbnRpYWxzLnB5Cmlu ZGV4IDYyNjkzNGM4MTg4YzgxZTdhZjhiMDkxY2EwMjZjNjYxYzNjM2Y5MTguLjZhNDIxNTU3OWFm NDA4ODhiOTJlNDUyN2YyZTcwYjk3NThlYjQzZTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL25ldC9jcmVkZW50aWFscy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9uZXQvY3JlZGVudGlhbHMucHkKQEAgLTM3LDEzICszNyw3IEBAIGltcG9y dCByZQogZnJvbSB3ZWJraXRweS5jb21tb24uY2hlY2tvdXQuc2NtIGltcG9ydCBHaXQKIGZyb20g d2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IEV4ZWN1dGl2ZSwgU2NyaXB0 RXJyb3IKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS51c2VyIGltcG9ydCBVc2VyCi0KLXRy eToKLSAgICAjIFVzZSBrZXlyaW5nLCBhIGNyb3NzIHBsYXRmb3JtIGtleXJpbmcgaW50ZXJmYWNl LCBhcyBhIGZhbGxiYWNrOgotICAgICMgaHR0cDovL3B5cGkucHl0aG9uLm9yZy9weXBpL2tleXJp bmcKLSAgICBpbXBvcnQga2V5cmluZwotZXhjZXB0IEltcG9ydEVycm9yOgotICAgIGtleXJpbmcg PSBOb25lCitmcm9tIHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZCBpbXBvcnQga2V5 cmluZwogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQppbmRleCA1Nzg4MjExNmQxODUx ZWIxMDg3ZDM0ZTVjNDI5ZjhjZjhkYWM5M2Q4Li43YmYxM2QwZmU2N2U0Mzc0MDYzMmQ1MGUzNGU1 ZmFiYjQxMTY2OGJmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFy dHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19f aW5pdF9fLnB5CkBAIC05MSwxMSArOTEsMTcgQEAgY2xhc3MgQXV0b2luc3RhbGxJbXBvcnRIb29r KG9iamVjdCk6CiAgICAgICAgICAgICBzZWxmLl9pbnN0YWxsX2lyYygpCiAgICAgICAgIGVsaWYg Jy5idWlsZGJvdCcgaW4gZnVsbG5hbWU6CiAgICAgICAgICAgICBzZWxmLl9pbnN0YWxsX2J1aWxk Ym90KCkKKyAgICAgICAgZWxpZiAnLmtleXJpbmcnIGluIGZ1bGxuYW1lOgorICAgICAgICAgICAg c2VsZi5faW5zdGFsbF9rZXlyaW5nKCkKIAogICAgIGRlZiBfaW5zdGFsbF9tZWNoYW5pemUoc2Vs Zik6CiAgICAgICAgIHNlbGYuX2luc3RhbGwoImh0dHA6Ly9weXBpLnB5dGhvbi5vcmcvcGFja2Fn ZXMvc291cmNlL20vbWVjaGFuaXplL21lY2hhbml6ZS0wLjIuNS50YXIuZ3oiLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAibWVjaGFuaXplLTAuMi41L21lY2hhbml6ZSIpCiAKKyAgICBk ZWYgX2luc3RhbGxfa2V5cmluZyhzZWxmKToKKyAgICAgICAgc2VsZi5faW5zdGFsbCgiaHR0cDov L3B5cGkucHl0aG9uLm9yZy9wYWNrYWdlcy9zb3VyY2Uvay9rZXlyaW5nL2tleXJpbmctNC4wLnpp cCIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJrZXlyaW5nIikKKwogICAgIGRlZiBf aW5zdGFsbF9wZXA4KHNlbGYpOgogICAgICAgICBzZWxmLl9pbnN0YWxsKCJodHRwOi8vcHlwaS5w eXRob24ub3JnL3BhY2thZ2VzL3NvdXJjZS9wL3BlcDgvcGVwOC0wLjUuMC50YXIuZ3ojbWQ1PTUx MmE4MThhZjk5NzkyOTBjZDYxOWNjZThlOWMyZTJiIiwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgInBlcDgtMC41LjAvcGVwOC5weSIpCg==