140538 2015-01-15 21:46:21 -0800 Fix build warning in WebKit2/UIProcess module 2015-01-16 00:12:07 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned andersca commit-queue darin gyuyoung.kim kling ossy thorton oldest_to_newest 1061772 0 shiva.jm 2015-01-15 21:46:21 -0800 Got below build warnigns in latest build for efl port. [1804/2283] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/Authentication/AuthenticationChallengeProxy.cpp.o ../../Source/WebKit2/UIProcess/Storage/StorageManager.cpp:488:6: warning: unused parameter ‘webProcessProxy’ [-Wunused-parameter] void StorageManager::processWillOpenConnection(WebProcessProxy& webProcessProxy, IPC::Connection& connection) ^ ../../Source/WebKit2/UIProcess/Storage/StorageManager.cpp:493:6: warning: unused parameter ‘webProcessProxy’ [-Wunused-parameter] void StorageManager::processDidCloseConnection(WebProcessProxy& webProcessProxy, IPC::Connection& connection) [1727/2283] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebCookieManagerProxyClient.cpp.o ../../Source/WebKit2/UIProcess/WebProcessPool.cpp:779:6: warning: unused parameter ‘process’ [-Wunused-parameter] void WebProcessPool::processWillOpenConnection(WebProcessProxy* process) ^ ../../Source/WebKit2/UIProcess/WebProcessPool.cpp:783:6: warning: unused parameter ‘process’ [-Wunused-parameter] void WebProcessPool::processWillCloseConnection(WebProcessProxy* process) 1061773 1 244752 shiva.jm 2015-01-15 21:51:19 -0800 Created attachment 244752 Patch Fix build warnings by removing parameter name from functions. might have casued by: https://bugs.webkit.org/show_bug.cgi?id=140527 and https://bugs.webkit.org/show_bug.cgi?id=140505. 1061788 2 244752 commit-queue 2015-01-16 00:12:00 -0800 Comment on attachment 244752 Patch Clearing flags on attachment: 244752 Committed r178576: <http://trac.webkit.org/changeset/178576> 1061789 3 commit-queue 2015-01-16 00:12:07 -0800 All reviewed patches have been landed. Closing bug. 244752 2015-01-15 21:51:19 -0800 2015-01-16 00:12:00 -0800 Patch bug-140538.patch text/plain 2580 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODU3MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAxLTE1ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViS2l0Mi9VSVByb2Nlc3MgbW9kdWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmdzIGJ5IHJlbW92aW5nIHBh cmFtZXRlciBuYW1lIGZyb20gZnVuY3Rpb25zCisKKyAgICAgICAgKiBVSVByb2Nlc3MvU3RvcmFn ZS9TdG9yYWdlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlN0b3JhZ2VNYW5hZ2VyOjpw cm9jZXNzV2lsbE9wZW5Db25uZWN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6U3RvcmFnZU1hbmFn ZXI6OnByb2Nlc3NEaWRDbG9zZUNvbm5lY3Rpb24pOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ cm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwcm9jZXNz V2lsbE9wZW5Db25uZWN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBy b2Nlc3NXaWxsQ2xvc2VDb25uZWN0aW9uKToKKwogMjAxNS0wMS0xNSAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIGNvbm5lY3Rpb24gcGFyYW1l dGVyIHRvIFN0b3JhZ2VNYW5hZ2VyIHdpbGxPcGVuL2RpZENsb3NlIGZ1bmN0aW9ucwpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCShyZXZpc2lvbiAx Nzg1NzApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC03NzYsMTEgKzc3NiwxMSBAQCBib29sIFdlYlByb2Nlc3NQb29sOjpz aG91bGRUZXJtaW5hdGUoV2ViCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgV2ViUHJvY2Vz c1Bvb2w6OnByb2Nlc3NXaWxsT3BlbkNvbm5lY3Rpb24oV2ViUHJvY2Vzc1Byb3h5KiBwcm9jZXNz KQordm9pZCBXZWJQcm9jZXNzUG9vbDo6cHJvY2Vzc1dpbGxPcGVuQ29ubmVjdGlvbihXZWJQcm9j ZXNzUHJveHkqKQogewogfQogCi12b2lkIFdlYlByb2Nlc3NQb29sOjpwcm9jZXNzV2lsbENsb3Nl Q29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkqIHByb2Nlc3MpCit2b2lkIFdlYlByb2Nlc3NQb29s Ojpwcm9jZXNzV2lsbENsb3NlQ29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkqKQogewogfQogCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1h bmFnZXIuY3BwCShyZXZpc2lvbiAxNzg1NzApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv U3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4NSwxMiArNDg1 LDEyIEBAIHZvaWQgU3RvcmFnZU1hbmFnZXI6OmNsb25lU2Vzc2lvblN0b3JhZ2UKICAgICB9KTsK IH0KIAotdm9pZCBTdG9yYWdlTWFuYWdlcjo6cHJvY2Vzc1dpbGxPcGVuQ29ubmVjdGlvbihXZWJQ cm9jZXNzUHJveHkmIHdlYlByb2Nlc3NQcm94eSwgSVBDOjpDb25uZWN0aW9uJiBjb25uZWN0aW9u KQordm9pZCBTdG9yYWdlTWFuYWdlcjo6cHJvY2Vzc1dpbGxPcGVuQ29ubmVjdGlvbihXZWJQcm9j ZXNzUHJveHkmLCBJUEM6OkNvbm5lY3Rpb24mIGNvbm5lY3Rpb24pCiB7CiAgICAgY29ubmVjdGlv bi5hZGRXb3JrUXVldWVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlN0b3JhZ2VNYW5hZ2VyOjpt ZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1fcXVldWUuZ2V0KCksIHRoaXMpOwogfQogCi12b2lkIFN0 b3JhZ2VNYW5hZ2VyOjpwcm9jZXNzRGlkQ2xvc2VDb25uZWN0aW9uKFdlYlByb2Nlc3NQcm94eSYg d2ViUHJvY2Vzc1Byb3h5LCBJUEM6OkNvbm5lY3Rpb24mIGNvbm5lY3Rpb24pCit2b2lkIFN0b3Jh Z2VNYW5hZ2VyOjpwcm9jZXNzRGlkQ2xvc2VDb25uZWN0aW9uKFdlYlByb2Nlc3NQcm94eSYsIElQ Qzo6Q29ubmVjdGlvbiYgY29ubmVjdGlvbikKIHsKICAgICBjb25uZWN0aW9uLnJlbW92ZVdvcmtR dWV1ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6U3RvcmFnZU1hbmFnZXI6Om1lc3NhZ2VSZWNl aXZlck5hbWUoKSk7CiAK