140524 2015-01-15 16:03:45 -0800 HTMLMediaElement::isPlayingAudio() returns true even when the element is explicitly muted by script 2015-01-19 10:51:29 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan jer.noble oldest_to_newest 1061680 0 adachan 2015-01-15 16:03:45 -0800 If the media element is explicitly muted in the DOM, we should not classify it as "playing audio". For example, there are websites that use a muted video to display an animated background, and that video element should be treated as "not playing audio". <rdar://problem/18644403> 1062028 1 244817 adachan 2015-01-16 16:25:01 -0800 Created attachment 244817 Patch 1062150 2 244817 kling 2015-01-17 18:53:05 -0800 Comment on attachment 244817 Patch r=me 1062408 3 adachan 2015-01-19 10:51:29 -0800 Thanks Andreas! Committed: http://trac.webkit.org/changeset/178655 244817 2015-01-16 16:25:01 -0800 2015-01-17 18:53:05 -0800 Patch 0001-HTMLMediaElement-isPlayingAudio-should-return-false-.patch text/plain 6180 adachan RnJvbSBmODc0NjJlMmJlYTMxOTdkOTU1ZjNkN2UwYWIxOGQ0MmRjYmExMDMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IEZy aSwgMTYgSmFuIDIwMTUgMTY6MjM6NDAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBIVE1MTWVkaWFF bGVtZW50Ojppc1BsYXlpbmdBdWRpbygpIHNob3VsZCByZXR1cm4gZmFsc2UgaWYgdGhlCiBlbGVt ZW50IGlzIGV4cGxpY2l0bHkgbXV0ZWQgYnkgc2NyaXB0LgogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MDUyNAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpT b3VyY2UvV2ViQ29yZToKClRlc3Q6IG1lZGlhL211dGVkLXZpZGVvLWlzLXBsYXlpbmctYXVkaW8u aHRtbAoKKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgooV2ViQ29yZTo6SFRNTE1lZGlhRWxl bWVudDo6c2V0TXV0ZWQpOgpDYWxsIERvY3VtZW50Ojp1cGRhdGVJc1BsYXlpbmdBdWRpbygpIHRv IHJlY2FsY3VsYXRlIHRoZSBvdmVyYWxsIGF1ZGlvIHBsYXlpbmcgc3RhdGUuCihXZWJDb3JlOjpI VE1MTWVkaWFFbGVtZW50Ojppc1BsYXlpbmdBdWRpbyk6CkhUTUxNZWRpYUVsZW1lbnQ6OmlzUGxh eWluZ0F1ZGlvKCkgc2hvdWxkIHJldHVybiBmYWxzZSBpZiB0aGUgbWVkaWEgZWxlbWVudCBpcyBl eHBsaWNpdGx5IG11dGVkLgoKTGF5b3V0VGVzdHM6CgpUaGUgdGVzdCBjb250YWlucyBhIGxvb3Bp bmcgdmlkZW8uIEl0IG1ha2VzIHN1cmUgaW5pdGlhbGx5IFBhZ2U6OmlzUGxheWluZ0F1ZGlvKCkg cmV0dXJucyB0cnVlLgpJdCBzaG91bGQgcmV0dXJuIGZhbHNlIGFmdGVyIHRoZSB2aWRlbyBpcyBt dXRlZCwgYW5kIHRydWUgYWdhaW4gYWZ0ZXIgdGhlIHZpZGVvIGlzIHVubXV0ZWQuCgoqIG1lZGlh L211dGVkLXZpZGVvLWlzLXBsYXlpbmctYXVkaW8tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKiBtZWRp YS9tdXRlZC12aWRlby1pcy1wbGF5aW5nLWF1ZGlvLmh0bWw6IEFkZGVkLgotLS0KIExheW91dFRl c3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKysr CiAuLi4vbXV0ZWQtdmlkZW8taXMtcGxheWluZy1hdWRpby1leHBlY3RlZC50eHQgICAgICB8IDE1 ICsrKysrKysrKysrCiAuLi4vbWVkaWEvbXV0ZWQtdmlkZW8taXMtcGxheWluZy1hdWRpby5odG1s ICAgICAgICB8IDMxICsrKysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTUgKysrKysrKysrKysKIFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgICAgICAgICAgIHwgIDMgKystCiA1IGZp bGVzIGNoYW5nZWQsIDc2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKIGNyZWF0ZSBtb2Rl IDEwMDY0NCBMYXlvdXRUZXN0cy9tZWRpYS9tdXRlZC12aWRlby1pcy1wbGF5aW5nLWF1ZGlvLWV4 cGVjdGVkLnR4dAogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL21lZGlhL211dGVkLXZp ZGVvLWlzLXBsYXlpbmctYXVkaW8uaHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzYTc5ZmNhLi4xZmM0NmVmIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDEtMTYgIEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5j b20+CisKKyAgICAgICAgSFRNTE1lZGlhRWxlbWVudDo6aXNQbGF5aW5nQXVkaW8oKSBzaG91bGQg cmV0dXJuIGZhbHNlIGlmIHRoZSBlbGVtZW50IGlzIGV4cGxpY2l0bHkgbXV0ZWQgYnkgc2NyaXB0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNTI0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRl c3QgY29udGFpbnMgYSBsb29waW5nIHZpZGVvLiBJdCBtYWtlcyBzdXJlIGluaXRpYWxseSBQYWdl Ojppc1BsYXlpbmdBdWRpbygpIHJldHVybnMgdHJ1ZS4KKyAgICAgICAgSXQgc2hvdWxkIHJldHVy biBmYWxzZSBhZnRlciB0aGUgdmlkZW8gaXMgbXV0ZWQsIGFuZCB0cnVlIGFnYWluIGFmdGVyIHRo ZSB2aWRlbyBpcyB1bm11dGVkLgorCisgICAgICAgICogbWVkaWEvbXV0ZWQtdmlkZW8taXMtcGxh eWluZy1hdWRpby1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL211dGVkLXZp ZGVvLWlzLXBsYXlpbmctYXVkaW8uaHRtbDogQWRkZWQuCisKIDIwMTUtMDEtMTQgIEJhcnRsb21p ZWogR2FqZGEgIDxiLmdhamRhQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtNU0VdIEltcGxlbWVu dCBwZXIgVHJhY2tCdWZmZXIgYnVmZmVyZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRp YS9tdXRlZC12aWRlby1pcy1wbGF5aW5nLWF1ZGlvLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L21lZGlhL211dGVkLXZpZGVvLWlzLXBsYXlpbmctYXVkaW8tZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjkwNzkwYWMKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9tZWRpYS9tdXRlZC12aWRlby1pcy1wbGF5aW5nLWF1ZGlvLWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxLDE1IEBACitUZXN0aW5nIHRoYXQgbXV0aW5nIGEgdmlkZW8gZWxlbWVudCBz aG91bGQgcmVzdWx0IGluIHBhZ2UncyBhdWRpbyBwbGF5aW5nIHN0YXRlIHRvIGJlY29tZSBmYWxz ZQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB3aW5kb3cuaW50ZXJuYWxz LmlzUGFnZVBsYXlpbmdBdWRpbygpIGJlY2FtZSB0cnVlCitQQVNTIHdpbmRvdy5pbnRlcm5hbHMu aXNQYWdlUGxheWluZ0F1ZGlvKCkgYmVjYW1lIGZhbHNlCitQQVNTIHdpbmRvdy5pbnRlcm5hbHMu aXNQYWdlUGxheWluZ0F1ZGlvKCkgYmVjYW1lIHRydWUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCitSVU4odmlkZW8ubXV0ZWQgPSB0cnVlKQorUlVO KHZpZGVvLm11dGVkID0gZmFsc2UpCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL211 dGVkLXZpZGVvLWlzLXBsYXlpbmctYXVkaW8uaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL211dGVk LXZpZGVvLWlzLXBsYXlpbmctYXVkaW8uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4zYzA4MTc5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbXV0 ZWQtdmlkZW8taXMtcGxheWluZy1hdWRpby5odG1sCkBAIC0wLDAgKzEsMzEgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzY3JpcHQgc3JjPSIuLi9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4K KyAgICAgICAgPHZpZGVvIHNyYz0iY29udGVudC9hdWRpby10cmFja3MubXA0IiBjb250cm9scyBh dXRvcGxheSBsb29wPjwvdmlkZW8+CisgICAgICAgIDxzY3JpcHQgc3JjPSJtZWRpYS1maWxlLmpz Ij48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9InZpZGVvLXRlc3QuanMiPjwvc2NyaXB0 PgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgZGVzY3JpcHRpb24oIlRlc3RpbmcgdGhh dCBtdXRpbmcgYSB2aWRlbyBlbGVtZW50IHNob3VsZCByZXN1bHQgaW4gcGFnZSdzIGF1ZGlvIHBs YXlpbmcgc3RhdGUgdG8gYmVjb21lIGZhbHNlIik7CisKKyAgICAgICAgICAgIGpzVGVzdElzQXN5 bmMgPSB0cnVlOworCisgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0VW5tdXRpbmdWaWRlbygpCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5tdXRlZCA9IGZhbHNlIik7 CisgICAgICAgICAgICAgICAgc2hvdWxkQmVjb21lRXF1YWwoIndpbmRvdy5pbnRlcm5hbHMuaXNQ YWdlUGxheWluZ0F1ZGlvKCkiLCAidHJ1ZSIsIGZpbmlzaEpTVGVzdCk7CisgICAgICAgICAgICB9 CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHRlc3RNdXRpbmdWaWRlbygpCisgICAgICAgICAgICB7 CisgICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5tdXRlZCA9IHRydWUiKTsKKyAgICAgICAgICAg ICAgICBzaG91bGRCZWNvbWVFcXVhbCgid2luZG93LmludGVybmFscy5pc1BhZ2VQbGF5aW5nQXVk aW8oKSIsICJmYWxzZSIsIHRlc3RVbm11dGluZ1ZpZGVvKTsKKyAgICAgICAgICAgIH0KKworICAg ICAgICAgICAgc2hvdWxkQmVjb21lRXF1YWwoIndpbmRvdy5pbnRlcm5hbHMuaXNQYWdlUGxheWlu Z0F1ZGlvKCkiLCAidHJ1ZSIsIHRlc3RNdXRpbmdWaWRlbyk7CisgICAgICAgIDwvc2NyaXB0Pgor ICAgICAgICA8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3Jp cHQ+CisgICAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGIzZGMzMTQ5Li5mN2E4YjYw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTUtMDEtMTYgIEFkYSBDaGFuICA8YWRh Y2hhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSFRNTE1lZGlhRWxlbWVudDo6aXNQbGF5aW5nQXVk aW8oKSBzaG91bGQgcmV0dXJuIGZhbHNlIGlmIHRoZSBlbGVtZW50IGlzIGV4cGxpY2l0bHkgbXV0 ZWQgYnkgc2NyaXB0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQwNTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGVzdDogbWVkaWEvbXV0ZWQtdmlkZW8taXMtcGxheWluZy1hdWRpby5odG1sCisKKyAg ICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TE1lZGlhRWxlbWVudDo6c2V0TXV0ZWQpOgorICAgICAgICBDYWxsIERvY3VtZW50Ojp1cGRhdGVJ c1BsYXlpbmdBdWRpbygpIHRvIHJlY2FsY3VsYXRlIHRoZSBvdmVyYWxsIGF1ZGlvIHBsYXlpbmcg c3RhdGUuCisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojppc1BsYXlpbmdBdWRp byk6CisgICAgICAgIEhUTUxNZWRpYUVsZW1lbnQ6OmlzUGxheWluZ0F1ZGlvKCkgc2hvdWxkIHJl dHVybiBmYWxzZSBpZiB0aGUgbWVkaWEgZWxlbWVudCBpcyBleHBsaWNpdGx5IG11dGVkLgorCiAy MDE1LTAxLTE0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQnVpbGRmaXggYWZ0ZXIgcjE3ODQzNApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxl bWVudC5jcHAKaW5kZXggOTQ1MDBjMy4uMDljMTIyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0zMDMzLDYgKzMwMzMsNyBAQCB2b2lkIEhUTUxNZWRpYUVs ZW1lbnQ6OnNldE11dGVkKGJvb2wgbXV0ZWQpCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAg ICAgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVzKCkudm9sdW1lY2hhbmdlRXZlbnQpOworICAg ICAgICBkb2N1bWVudCgpLnVwZGF0ZUlzUGxheWluZ0F1ZGlvKCk7CiAgICAgfQogI2VuZGlmCiB9 CkBAIC02MTA3LDcgKzYxMDgsNyBAQCBib29sIEhUTUxNZWRpYUVsZW1lbnQ6Om92ZXJyaWRlQmFj a2dyb3VuZFBsYXliYWNrUmVzdHJpY3Rpb24oKSBjb25zdAogCiBib29sIEhUTUxNZWRpYUVsZW1l bnQ6OmlzUGxheWluZ0F1ZGlvKCkKIHsKLSAgICByZXR1cm4gaXNQbGF5aW5nKCkgJiYgaGFzQXVk aW8oKTsKKyAgICByZXR1cm4gaXNQbGF5aW5nKCkgJiYgaGFzQXVkaW8oKSAmJiAhbXV0ZWQoKTsK IH0KIAogdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpwYWdlTXV0ZWRTdGF0ZURpZENoYW5nZSgpCi0t IAoyLjEuMSAoQXBwbGUgR2l0LTUxKQoK