140517 2015-01-15 15:23:45 -0800 [Win] Debug assertion when attempting to change style on button with multiple style references 2015-05-08 08:14:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham hyungwook.lee commit-queue esprehn+autocc glenn hyungwook.lee kondapallykalyan oldest_to_newest 1061659 0 bfulgham 2015-01-15 15:23:45 -0800 The layout test 'fast/forms/button-first-line-first-letter.html' is failing because of the following assertion: void RenderButton::setupInnerStyle(RenderStyle* innerStyle) { ASSERT(innerStyle->refCount() == 1); The stack trace is as follows: WTF.dll!WTFCrash() Line 321 C++ > WebKit.dll!WebCore::RenderButton::setupInnerStyle(WebCore::RenderStyle * innerStyle) Line 135 C++ WebKit.dll!WebCore::RenderButton::styleDidChange(WebCore::StyleDifference diff, const WebCore::RenderStyle * oldStyle) Line 115 C++ WebKit.dll!WebCore::RenderElement::setStyle(WTF::Ref<WebCore::RenderStyle> && style) Line 443 C++ WebKit.dll!WebCore::RenderElement::setAnimatableStyle(WTF::Ref<WebCore::RenderStyle> && style) Line 296 C++ WebKit.dll!WebCore::Style::resolveLocal(WebCore::Element & current, WebCore::RenderStyle & inheritedStyle, WebCore::Style::RenderTreePosition & renderTreePosition, WebCore::Style::Change inheritedChange) Line 764 C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::RenderStyle & inheritedStyle, WebCore::Style::RenderTreePosition & renderTreePosition, WebCore::Style::Change change) Line 918 C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::RenderStyle & inheritedStyle, WebCore::Style::RenderTreePosition & renderTreePosition, WebCore::Style::Change change) Line 955 C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Element & current, WebCore::RenderStyle & inheritedStyle, WebCore::Style::RenderTreePosition & renderTreePosition, WebCore::Style::Change change) Line 955 C++ WebKit.dll!WebCore::Style::resolveTree(WebCore::Document & document, WebCore::Style::Change change) Line 995 C++ WebKit.dll!WebCore::Document::recalcStyle(WebCore::Style::Change change) Line 1767 C++ WebKit.dll!WebFrame::invalidate() Line 1081 C++ WebKit.dll!WebView::notifyPreferencesChanged(IWebNotification * notification) Line 5065 C++ WebKit.dll!WebView::onNotify(IWebNotification * notification) Line 4705 C++ WebKit.dll!WebNotificationCenter::postNotificationInternal(IWebNotification * notification, wchar_t * notificationName, IUnknown * anObject) Line 131 C++ WebKit.dll!WebNotificationCenter::postNotificationName(wchar_t * notificationName, IUnknown * anObject, IPropertyBag * userInfo) Line 187 C++ WebKit.dll!WebPreferences::postPreferencesChangesNotification() Line 148 C++ WebKit.dll!WebPreferences::setBoolValue(const char * key, int value) Line 420 C++ WebKit.dll!WebPreferences::setDeveloperExtrasEnabled(int enabled) Line 1427 C++ DumpRenderTree.dll!TestRunner::setDeveloperExtrasEnabled(bool enabled) Line 1024 C++ DumpRenderTree.dll!runTest(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & inputLine) Line 1156 C++ DumpRenderTree.dll!main(int argc, const char * * argv) Line 1476 C++ DumpRenderTree.dll!dllLauncherEntryPoint(int argc, const char * * argv) Line 1506 C++ DumpRenderTree.exe!main(int argc, const char * * argv) Line 239 C++ [External Code] 1086758 1 hyungwook.lee 2015-04-20 01:33:08 -0700 I've started look at this issue. 1092573 2 252589 hyungwook.lee 2015-05-07 05:46:44 -0700 Created attachment 252589 patch 1092653 3 bfulgham 2015-05-07 11:18:13 -0700 We should make sure to remove the TestExpectation exception for 'fast/forms/buttons-first-line-first-letter.html' when this lands. Thanks for figuring this out! 1092992 4 252589 gyuyoung.kim 2015-05-07 19:15:27 -0700 Comment on attachment 252589 patch As Brent said, we need to unskip "fast/forms/buttons-first-line-first-letter.html" if it can be passed after landing this patch. 1093045 5 252589 commit-queue 2015-05-07 23:14:25 -0700 Comment on attachment 252589 patch Clearing flags on attachment: 252589 Committed r183981: <http://trac.webkit.org/changeset/183981> 1093046 6 commit-queue 2015-05-07 23:14:30 -0700 All reviewed patches have been landed. Closing bug. 1093119 7 252701 hyungwook.lee 2015-05-08 01:48:27 -0700 Created attachment 252701 patch Patch for unskiping fast/forms/button-first-line-first-letter.html test case in LayoutTests/platform/win/TestExpectations 1093121 8 hyungwook.lee 2015-05-08 01:50:07 -0700 reopen for unskiping fast/forms/button-first-line-first-letter.html test case. 1093167 9 252701 bfulgham 2015-05-08 07:21:03 -0700 Comment on attachment 252701 patch R=me 1093181 10 252701 commit-queue 2015-05-08 08:14:13 -0700 Comment on attachment 252701 patch Clearing flags on attachment: 252701 Committed r183994: <http://trac.webkit.org/changeset/183994> 1093182 11 commit-queue 2015-05-08 08:14:18 -0700 All reviewed patches have been landed. Closing bug. 252589 2015-05-07 05:46:44 -0700 2015-05-07 23:14:25 -0700 patch patch text/plain 1489 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MzkyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTA3ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEFkZCBmaXJz dC1sZXR0ZXIgYXNzZXJ0IGV4Y2VwdGlvbiBpbiBSZW5kZXJCdXR0b246OnNldHVwSW5uZXJTdHls ZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQw NTE3T0IKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT dHlsZVJlc29sdmVyIHJlZmVyZW5jZXMgaW5uZXIgYmxvY2sncyByZW5kZXIgc3R5bGUgdGVtcG9y YXJ5IGluCisgICAgICAgIFJlbmRlckJsb2NrOjpzdHlsZURpZENoYW5nZSgpIHdoZW4gd2UgaGF2 ZSBmaXJzdC1sZXR0ZXIgY3NzIHBzZXVkbworICAgICAgICBlbGVtZW50LgorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCdXR0 b246OnNldHVwSW5uZXJTdHlsZSk6CisKIDIwMTUtMDUtMDcgIFlvYXYgV2Vpc3MgIDx5b2F2QHlv YXYud3M+CiAKICAgICAgICAgRml4IDxzY3JpcHQgc3Jjc2V0PiBiZWluZyBsb2FkZWQgYnkgdGhl IHByZWxvYWRlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24u Y3BwCShyZXZpc2lvbiAxODM5MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QnV0dG9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI3LDcgKzEyNyw3IEBAIHZvaWQgUmVuZGVy QnV0dG9uOjpzdHlsZURpZENoYW5nZShTdHlsZUQKIAogdm9pZCBSZW5kZXJCdXR0b246OnNldHVw SW5uZXJTdHlsZShSZW5kZXJTdHlsZSogaW5uZXJTdHlsZSkgCiB7Ci0gICAgQVNTRVJUKGlubmVy U3R5bGUtPnJlZkNvdW50KCkgPT0gMSk7CisgICAgQVNTRVJUKHN0eWxlKCkuaGFzUHNldWRvU3R5 bGUoRklSU1RfTEVUVEVSKSB8fCBpbm5lclN0eWxlLT5yZWZDb3VudCgpID09IDEpOwogICAgIC8v IFJlbmRlckJsb2NrOjpjcmVhdGVBbm9ueW1vdXNCbG9jayBjcmVhdGVzIGEgbmV3IFJlbmRlclN0 eWxlLCBzbyB0aGlzIGlzCiAgICAgLy8gc2FmZSB0byBtb2RpZnkuCiAgICAgLy8gRklYTUU6IEkg ZG9uJ3Qgc2VlIGhvdyB0aGUgY29tbWVudCBhYm92ZSBpcyBhY2N1cmF0ZSB3aGVuIHRoaXMgaXMg Y2FsbGVkCg== 252701 2015-05-08 01:48:27 -0700 2015-05-08 08:14:13 -0700 patch patch_unskip text/plain 1225 hyungwook.lee SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4Mzk4NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA1LTA4ICBIeXVuZ3dvb2sgTGVlICA8 aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtXaW5dIFVuc2tpcCBwYXNz aW5nIHRlc3QgY2FzZSBhZnRlciByMTgzOTgxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA1MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zOgorCiAy MDE1LTA1LTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVGhy b3R0bGUgUmVxdWVzdEFuaW1hdGlvbkZyYW1lIGluIHN1YmZyYW1lcyB0aGF0IGFyZSBvdXRzaWRl IHRoZSB2aWV3cG9ydApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3Rh dGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3Rh dGlvbnMJKHJldmlzaW9uIDE4Mzk4NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0 RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0yNjgwLDcgKzI2ODAsNiBAQCBmYXN0L2Zp bHRlci1pbWFnZS9maWx0ZXItaW1hZ2UuaHRtbCBbIEltCiAKIGZhc3QvZmxleGJveC8wMDEuaHRt bCBbIFBhc3MgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xNDA1MTcgWyBEZWJ1ZyBdIGZhc3Qv Zm9ybXMvYnV0dG9uLWZpcnN0LWxpbmUtZmlyc3QtbGV0dGVyLmh0bWwgWyBTa2lwIF0gICMgQ3Jh c2hpbmcKIHdlYmtpdC5vcmcvYi8xNDA1MDYgZmFzdC9mb3Jtcy90ZXh0ZmllbGQtbGFzdGNoYW5n ZS13YXMtdXNlcmVkaXQuaHRtbCBbIFNraXAgXSAgIyBDcmFzaGluZwogd2Via2l0Lm9yZy9iLzE0 MDUxOSBbIERlYnVnIF0gZmFzdC9mbGV4Ym94L2ZsZXhpbmctb3ZlcmZsb3ctc2Nyb2xsLWl0ZW0u aHRtbCBbIFNraXAgXSAgIyBDcmFzaGluZwogCg==