140513 2015-01-15 14:14:46 -0800 Web Inspector: Reopening the inspector can selects a sub-frame instead of the Main Frame's DOM 2015-01-15 18:53:11 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev simon.fraser timothy webkit-bug-importer oldest_to_newest 1061632 0 joepeck 2015-01-15 14:14:46 -0800 * SUMMARY Reopening the inspector can selects a sub-frame instead of the Main Frame's DOM. Very annoying! * STEPS TO REPRODUCE 1. Load http://www.nytimes.com/interactive/2015/01/09/sports/el-capitan-2d-image.html 2. Inspect an element on the page 3. Close Inspector 4. Re-open Inspector => sub-frame selected instead of main frame * NOTES - Somewhat related to bug 139593 1061635 1 webkit-bug-importer 2015-01-15 14:15:15 -0800 <rdar://problem/19490093> 1061719 2 244735 joepeck 2015-01-15 17:20:14 -0800 Created attachment 244735 [PATCH] Proposed Fix I think ideally we would have a way to uniquely identify sub-frames, but really we don't have much more information than their URL and maybe frame index (which could change). Specifically identifying the main frame I think is a good compromise, at least that is guaranteed to be unique. 1061730 3 244735 simon.fraser 2015-01-15 18:09:48 -0800 Comment on attachment 244735 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=244735&action=review > Source/WebInspectorUI/ChangeLog:11 > + Specifically identify the main frame, so that any sub-frames with the same > + URL, don't get choosen over the main frame when restoring state from cookie. Why do subframes get the same URL? It seems very unlikely that sites are loading the same url in subframes. 1061733 4 joepeck 2015-01-15 18:18:28 -0800 Thats what I want to investigate in bug 139593. 1061743 5 244735 commit-queue 2015-01-15 18:53:05 -0800 Comment on attachment 244735 [PATCH] Proposed Fix Clearing flags on attachment: 244735 Committed r178569: <http://trac.webkit.org/changeset/178569> 1061744 6 commit-queue 2015-01-15 18:53:11 -0800 All reviewed patches have been landed. Closing bug. 244735 2015-01-15 17:20:14 -0800 2015-01-15 18:53:05 -0800 [PATCH] Proposed Fix better-frame-restoration.patch text/plain 1825 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVhNjE5OGEuLmFmNDA5MDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTAxLTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVvcGVu aW5nIHRoZSBpbnNwZWN0b3IgY2FuIHNlbGVjdHMgYSBzdWItZnJhbWUgaW5zdGVhZCBvZiB0aGUg TWFpbiBGcmFtZSdzIERPTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQwNTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9GcmFtZS5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5GcmFtZS5wcm90b3R5cGUuc2F2ZUlkZW50aXR5VG9Db29raWUpOgorICAgICAgICBT cGVjaWZpY2FsbHkgaWRlbnRpZnkgdGhlIG1haW4gZnJhbWUsIHNvIHRoYXQgYW55IHN1Yi1mcmFt ZXMgd2l0aCB0aGUgc2FtZQorICAgICAgICBVUkwsIGRvbid0IGdldCBjaG9vc2VuIG92ZXIgdGhl IG1haW4gZnJhbWUgd2hlbiByZXN0b3Jpbmcgc3RhdGUgZnJvbSBjb29raWUuCisKKzIwMTUtMDEt MTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIg SW5zcGVjdG9yOiBzZWxlY3RpbmcgUGFpbnQgdGltZWxpbmUgcmVjb3JkcyBmcm9tIHNpZGViYXIg ZG9lcyBub3QgdHJpZ2dlciBwcmV2aWV3IG9mIHBhaW50IHF1YWQKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTE1MQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRnJhbWUuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRnJhbWUuanMKaW5kZXggYTBiYTkz OS4uMDZkMjA0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL0ZyYW1lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL01vZGVscy9GcmFtZS5qcwpAQCAtNzMsNiArNzMsNyBAQCBXZWJJbnNwZWN0b3IuRnJhbWUu RXZlbnQgPSB7CiAKIFdlYkluc3BlY3Rvci5GcmFtZS5UeXBlSWRlbnRpZmllciA9ICJGcmFtZSI7 CiBXZWJJbnNwZWN0b3IuRnJhbWUuTWFpblJlc291cmNlVVJMQ29va2llS2V5ID0gImZyYW1lLW1h aW4tcmVzb3VyY2UtdXJsIjsKK1dlYkluc3BlY3Rvci5GcmFtZS5Jc01haW5GcmFtZUNvb2tpZUtl eSA9ICJmcmFtZS1pcy1tYWluLWZyYW1lIjsKIAogV2ViSW5zcGVjdG9yLkZyYW1lLnByb3RvdHlw ZSA9IHsKICAgICBjb25zdHJ1Y3RvcjogV2ViSW5zcGVjdG9yLkZyYW1lLApAQCAtNDY1LDYgKzQ2 Niw3IEBAIFdlYkluc3BlY3Rvci5GcmFtZS5wcm90b3R5cGUgPSB7CiAgICAgc2F2ZUlkZW50aXR5 VG9Db29raWU6IGZ1bmN0aW9uKGNvb2tpZSkKICAgICB7CiAgICAgICAgIGNvb2tpZVtXZWJJbnNw ZWN0b3IuRnJhbWUuTWFpblJlc291cmNlVVJMQ29va2llS2V5XSA9IHRoaXMubWFpblJlc291cmNl LnVybC5oYXNoOworICAgICAgICBjb29raWVbV2ViSW5zcGVjdG9yLkZyYW1lLklzTWFpbkZyYW1l Q29va2llS2V5XSA9IHRoaXMuX2lzTWFpbkZyYW1lOwogICAgIH0sCiAKICAgICAvLyBQcml2YXRl Cg==