140497 2015-01-15 07:42:49 -0800 [CMAKE] Fix cmake warning 2015-01-19 16:37:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136194 1 gyuyoung.kim gyuyoung.kim gustavo ossy oldest_to_newest 1061546 0 gyuyoung.kim 2015-01-15 07:42:49 -0800 r173155 already tried to fix cmake warning though, the warning is still exist. CMAKE_LINK_INTERFACE_LIBRARIES seems to cause this warning. INTERFACE_LINK_LIBRARIES contains the list of transitive link dependencies, and CMAKE_LINK_INTERFACE_LIBRARIES can override the INTERFACE_LINK_LIBRARIES property when CMP0022 is not set. CMake warns this override. To avoid it, EFL port doesn't set CMAKE_LINK_INTERFACE_LIBRARIES. 1061547 1 244693 gyuyoung.kim 2015-01-15 07:43:46 -0800 Created attachment 244693 Patch 1062324 2 gustavo 2015-01-19 03:03:38 -0800 I think we should probably remove that for all ports. We seem to be settings LINK_INTERFACE_LIBRARIES explicitly on each library anyway (which is probably what leads to the warning?). 1062331 3 244895 gyuyoung.kim 2015-01-19 04:31:43 -0800 Created attachment 244895 Patch 1062334 4 gyuyoung.kim 2015-01-19 04:40:38 -0800 (In reply to comment #2) > I think we should probably remove that for all ports. We seem to be settings > LINK_INTERFACE_LIBRARIES explicitly on each library anyway (which is > probably what leads to the warning?). I didn't check if other ports also have same issue. That's why I only disabled to set it only for EFL port. As mentioned in ChangeLog, INTERFACE_LINK_LIBRARIES variable seems to be already set on each library. It seems CMP0022 policy of cmake warns that CMAKE_LINK_INTERFACE_LIBRARIES can override INTERFACE_LINK_LIBRARIES on some targets. If other ports also have same problem, I think my latest patch looks good. Build warning is as below, CMake Warning (dev) in Source/JavaScriptCore/CMakeLists.txt: Policy CMP0022 is not set: INTERFACE_LINK_LIBRARIES defines the link interface. Run "cmake --help-policy CMP0022" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "JavaScriptCore" has an INTERFACE_LINK_LIBRARIES property which differs from its LINK_INTERFACE_LIBRARIES properties. INTERFACE_LINK_LIBRARIES: WTF;/usr/lib/x86_64-linux-gnu/libicui18n.so LINK_INTERFACE_LIBRARIES: This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) in Source/cmake/gtest/CMakeLists.txt: Policy CMP0022 is not set: INTERFACE_LINK_LIBRARIES defines the link interface. Run "cmake --help-policy CMP0022" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "gtest" has an INTERFACE_LINK_LIBRARIES property which differs from its LINK_INTERFACE_LIBRARIES properties. INTERFACE_LINK_LIBRARIES: WTF;-lpthread LINK_INTERFACE_LIBRARIES: This warning is for project developers. Use -Wno-dev to suppress it. 1062358 5 244903 gyuyoung.kim 2015-01-19 07:21:44 -0800 Created attachment 244903 Patch 1062376 6 244903 gustavo 2015-01-19 09:32:49 -0800 Comment on attachment 244903 Patch Please indicate in the changelog that that is already set for individual library targets, thanks! 1062536 7 244936 gyuyoung.kim 2015-01-19 16:32:11 -0800 Created attachment 244936 Patch for landing 1062539 8 gyuyoung.kim 2015-01-19 16:36:38 -0800 Committed r178682: <http://trac.webkit.org/changeset/178682> 1062540 9 gyuyoung.kim 2015-01-19 16:37:48 -0800 (In reply to comment #6) > Comment on attachment 244903 [details] > Patch > > Please indicate in the changelog that that is already set for individual > library targets, thanks! Done, thanks. 244693 2015-01-15 07:43:46 -0800 2015-01-19 04:31:37 -0800 Patch bug-140497-20150116004351.patch text/plain 1539 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MjU1CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IGRhMTczNmI5ZTU5NzIxNjU2YTM3MDhiZjRhMzQ0ZTUzNTQ2 NzEwMDAuLjNiYjQzZjdjZTNhMGE2ZTEyMzVlODE5YmMxMGMzODJkZjE5YzY2ODQgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0zMyw3ICszMyw5IEBA IGlmIChOT1QgREVGSU5FRCBFTkFCTEVfVE9PTFMgQU5EIEVYSVNUUyAke1RPT0xTX0RJUn0pCiBl bmRpZiAoKQogCiAjIERvIG5vdCBjcmVhdGUgdHJhbnNpdGl2ZSBsaWJyYXJ5IGRlcGVuZGVuY2ll cyBieSBkZWZhdWx0Ci1zZXQoQ01BS0VfTElOS19JTlRFUkZBQ0VfTElCUkFSSUVTICIiKQoraWYg KE5PVCAke19wb3J0fSBTVFJFUVVBTCAiRUZMIikKKyAgICBzZXQoQ01BS0VfTElOS19JTlRFUkZB Q0VfTElCUkFSSUVTICIiKQorZW5kaWYgKCkKIAogaW5jbHVkZShXZWJLaXRNYWNyb3MpCiBpbmNs dWRlKFdlYktpdEZTKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDg3 NjM0M2UwZjc1OWI1YTQxYTE2OWM5NDQzYzdhMjY3Zjc3NDk0OTMuLjkxMTQ0M2ViZWQ4YzA1ZGQ0 YjRiZThlMDZmNjlhYTFhYWZhZDgzZjMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0wMS0xNSAgR3l1eW91bmcgS2ltICA8Z3l1eW91 bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW0NNQUtFXSBGaXggY21ha2Ugd2Fy bmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQw NDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjE3 MzE1NSBhbHJlYWR5IHRyaWVkIHRvIGZpeCBjbWFrZSB3YXJuaW5nIHRob3VnaCwgdGhlIHdhcm5p bmcgaXMgc3RpbGwgZXhpc3QuCisgICAgICAgIENNQUtFX0xJTktfSU5URVJGQUNFX0xJQlJBUklF UyBzZWVtcyB0byBjYXVzZSB0aGlzIHdhcm5pbmcuIElOVEVSRkFDRV9MSU5LX0xJQlJBUklFUwor ICAgICAgICBjb250YWlucyB0aGUgbGlzdCBvZiB0cmFuc2l0aXZlIGxpbmsgZGVwZW5kZW5jaWVz LCBhbmQgQ01BS0VfTElOS19JTlRFUkZBQ0VfTElCUkFSSUVTCisgICAgICAgIGNhbiBvdmVycmlk ZSB0aGUgSU5URVJGQUNFX0xJTktfTElCUkFSSUVTIHByb3BlcnR5IHdoZW4gQ01QMDAyMiBpcyBu b3Qgc2V0LiBDTWFrZSB3YXJucworICAgICAgICB0aGlzIG92ZXJyaWRlLiBUbyBhdm9pZCBpdCwg RUZMIHBvcnQgZG9lc24ndCBzZXQgQ01BS0VfTElOS19JTlRFUkZBQ0VfTElCUkFSSUVTLgorCisg ICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTUtMDEtMTAgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbWGNvZGUsIGlPU10gRmlsZXMgYXJlIHJlY29tcGls ZWQgd2hlbiBhbHRlcm5hdGluZyBiZXR3ZWVuIHVzaW5nIG1ha2UgYW5kIHRoZSBYY29kZSBJREUK 244895 2015-01-19 04:31:43 -0800 2015-01-19 07:21:37 -0800 Patch bug-140497-20150119213150.patch text/plain 1454 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQzCmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IGRhMTczNmI5ZTU5NzIxNjU2YTM3MDhiZjRhMzQ0ZTUzNTQ2 NzEwMDAuLmVmMTdkYzdmOWIxYzM4NjMyMWI3YzI2ZGEzMDg3NjNiNWI0OGMwYTcgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0zMiw5ICszMiw2IEBA IGlmIChOT1QgREVGSU5FRCBFTkFCTEVfVE9PTFMgQU5EIEVYSVNUUyAke1RPT0xTX0RJUn0pCiAg ICAgc2V0KEVOQUJMRV9UT09MUyBPTikKIGVuZGlmICgpCiAKLSMgRG8gbm90IGNyZWF0ZSB0cmFu c2l0aXZlIGxpYnJhcnkgZGVwZW5kZW5jaWVzIGJ5IGRlZmF1bHQKLXNldChDTUFLRV9MSU5LX0lO VEVSRkFDRV9MSUJSQVJJRVMgIiIpCi0KIGluY2x1ZGUoV2ViS2l0TWFjcm9zKQogaW5jbHVkZShX ZWJLaXRGUykKIGluY2x1ZGUoV2ViS2l0SGVscGVycykKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCBlZGYwMzZlNmQyNzA2YTk5ZTI3YjZhZWIzOGYxMTY2Njg2Yzk5Y2I2 Li5hNGE2Zjk1YzBiMzdhMjZjN2Q4NTM0ZjM0NmU2MDZmNzU5YjQyNDAxIDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTUtMDEtMTkgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtD TUFLRV0gRml4IGNtYWtlIHdhcm5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0MDQ5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIHIxNzMxNTUgYWxyZWFkeSB0cmllZCB0byBmaXggY21ha2Ugd2Fybmlu ZyB0aG91Z2gsIHRoZSB3YXJuaW5nIGlzIHN0aWxsIGV4aXN0LgorICAgICAgICBDTUFLRV9MSU5L X0lOVEVSRkFDRV9MSUJSQVJJRVMgc2VlbXMgdG8gY2F1c2UgdGhpcyB3YXJuaW5nLiBJTlRFUkZB Q0VfTElOS19MSUJSQVJJRVMKKyAgICAgICAgY29udGFpbnMgdGhlIGxpc3Qgb2YgdHJhbnNpdGl2 ZSBsaW5rIGRlcGVuZGVuY2llcywgYW5kIENNQUtFX0xJTktfSU5URVJGQUNFX0xJQlJBUklFUwor ICAgICAgICBjYW4gb3ZlcnJpZGUgdGhlIElOVEVSRkFDRV9MSU5LX0xJQlJBUklFUyBwcm9wZXJ0 eSB3aGVuIENNUDAwMjIgaXMgbm90IHNldC4gQ01ha2Ugd2FybnMKKyAgICAgICAgdGhpcyBvdmVy cmlkZS4gVG8gYXZvaWQgaXQsIEVGTCBwb3J0IGRvZXNuJ3Qgc2V0IENNQUtFX0xJTktfSU5URVJG QUNFX0xJQlJBUklFUy4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE1LTAxLTE1 ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3Zl IEVOQUJMRShTUUxfREFUQUJBU0UpIGd1YXJkcwo= 244903 2015-01-19 07:21:44 -0800 2015-01-19 16:32:05 -0800 Patch bug-140497-20150120002150.patch text/plain 1449 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQ1CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IGRhMTczNmI5ZTU5NzIxNjU2YTM3MDhiZjRhMzQ0ZTUzNTQ2 NzEwMDAuLmVmMTdkYzdmOWIxYzM4NjMyMWI3YzI2ZGEzMDg3NjNiNWI0OGMwYTcgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0zMiw5ICszMiw2IEBA IGlmIChOT1QgREVGSU5FRCBFTkFCTEVfVE9PTFMgQU5EIEVYSVNUUyAke1RPT0xTX0RJUn0pCiAg ICAgc2V0KEVOQUJMRV9UT09MUyBPTikKIGVuZGlmICgpCiAKLSMgRG8gbm90IGNyZWF0ZSB0cmFu c2l0aXZlIGxpYnJhcnkgZGVwZW5kZW5jaWVzIGJ5IGRlZmF1bHQKLXNldChDTUFLRV9MSU5LX0lO VEVSRkFDRV9MSUJSQVJJRVMgIiIpCi0KIGluY2x1ZGUoV2ViS2l0TWFjcm9zKQogaW5jbHVkZShX ZWJLaXRGUykKIGluY2x1ZGUoV2ViS2l0SGVscGVycykKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCBlZGYwMzZlNmQyNzA2YTk5ZTI3YjZhZWIzOGYxMTY2Njg2Yzk5Y2I2 Li4yODMyOTA1NDM1MjY3NGZjZmVhZjgyNDdlYzlhNjUwYzg2YjMyMTA4IDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTUtMDEtMTkgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0Vd IEZpeCBjbWFrZSB3YXJuaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDA0OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICByMTczMTU1IGFscmVhZHkgdHJpZWQgdG8gZml4IGNtYWtlIHdhcm5pbmcgdGhv dWdoLCB0aGUgd2FybmluZyBpcyBzdGlsbCBleGlzdC4KKyAgICAgICAgQ01BS0VfTElOS19JTlRF UkZBQ0VfTElCUkFSSUVTIHNlZW1zIHRvIGNhdXNlIHRoaXMgd2FybmluZy4gSU5URVJGQUNFX0xJ TktfTElCUkFSSUVTCisgICAgICAgIGNvbnRhaW5zIHRoZSBsaXN0IG9mIHRyYW5zaXRpdmUgbGlu ayBkZXBlbmRlbmNpZXMsIGFuZCBDTUFLRV9MSU5LX0lOVEVSRkFDRV9MSUJSQVJJRVMKKyAgICAg ICAgY2FuIG92ZXJyaWRlIHRoZSBJTlRFUkZBQ0VfTElOS19MSUJSQVJJRVMgcHJvcGVydHkgd2hl biBDTVAwMDIyIGlzIG5vdCBzZXQuIENNYWtlIHdhcm5zCisgICAgICAgIHRoaXMgb3ZlcnJpZGUu IFRvIGF2b2lkIGl0LCBFRkwgcG9ydCBkb2Vzbid0IHNldCBDTUFLRV9MSU5LX0lOVEVSRkFDRV9M SUJSQVJJRVMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNS0wMS0xNSAgQ3Nh YmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBFTkFC TEUoU1FMX0RBVEFCQVNFKSBndWFyZHMK 244936 2015-01-19 16:32:11 -0800 2015-01-19 16:32:11 -0800 Patch for landing bug-140497-20150120093217.patch text/plain 1519 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NjQ1CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IGRhMTczNmI5ZTU5NzIxNjU2YTM3MDhiZjRhMzQ0ZTUzNTQ2 NzEwMDAuLmVmMTdkYzdmOWIxYzM4NjMyMWI3YzI2ZGEzMDg3NjNiNWI0OGMwYTcgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0zMiw5ICszMiw2IEBA IGlmIChOT1QgREVGSU5FRCBFTkFCTEVfVE9PTFMgQU5EIEVYSVNUUyAke1RPT0xTX0RJUn0pCiAg ICAgc2V0KEVOQUJMRV9UT09MUyBPTikKIGVuZGlmICgpCiAKLSMgRG8gbm90IGNyZWF0ZSB0cmFu c2l0aXZlIGxpYnJhcnkgZGVwZW5kZW5jaWVzIGJ5IGRlZmF1bHQKLXNldChDTUFLRV9MSU5LX0lO VEVSRkFDRV9MSUJSQVJJRVMgIiIpCi0KIGluY2x1ZGUoV2ViS2l0TWFjcm9zKQogaW5jbHVkZShX ZWJLaXRGUykKIGluY2x1ZGUoV2ViS2l0SGVscGVycykKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCBlZGYwMzZlNmQyNzA2YTk5ZTI3YjZhZWIzOGYxMTY2Njg2Yzk5Y2I2 Li40MTZiY2FmNGU5NmZmYjkwMzUwNGI5NTczNjJhZDA5MzJmMWYzMjk5IDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTUtMDEtMTkgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0Vd IEZpeCBjbWFrZSB3YXJuaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDA0OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICByMTczMTU1IGFscmVhZHkgdHJpZWQgdG8gZml4IGNtYWtlIHdhcm5pbmcgdGhv dWdoLCB0aGUgd2FybmluZyBpcyBzdGlsbCBleGlzdC4KKyAgICAgICAgQ01BS0VfTElOS19JTlRF UkZBQ0VfTElCUkFSSUVTIHNlZW1zIHRvIGNhdXNlIHRoaXMgd2FybmluZy4gSW5kaXZpZHVhbCB0 YXJnZXQgaXMKKyAgICAgICAgYWxyZWFkeSBzZXQgZm9yIHRoZWlyIGxpYnJhcmllcyB0aG91Z2gs IElOVEVSRkFDRV9MSU5LX0xJQlJBUklFUyBjb250YWlucyB0aGUgbGlzdAorICAgICAgICBvZiB0 cmFuc2l0aXZlIGxpbmsgZGVwZW5kZW5jaWVzLCBhbmQgQ01BS0VfTElOS19JTlRFUkZBQ0VfTElC UkFSSUVTIGNhbiBvdmVycmlkZQorICAgICAgICB0aGUgSU5URVJGQUNFX0xJTktfTElCUkFSSUVT IHByb3BlcnR5IHdoZW4gQ01QMDAyMiBpcyBub3Qgc2V0LiBDTWFrZSB3YXJucyB0aGlzIG92ZXJy aWRlLgorICAgICAgICBUbyBhdm9pZCBpdCwgRUZMIHBvcnQgZG9lc24ndCBzZXQgQ01BS0VfTElO S19JTlRFUkZBQ0VfTElCUkFSSUVTLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIw MTUtMDEtMTUgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZW1vdmUgRU5BQkxFKFNRTF9EQVRBQkFTRSkgZ3VhcmRzCg==