140495 2015-01-15 06:41:34 -0800 REGRESSION(r177876): Membuster regressed ~4% 2015-01-21 11:33:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue kling mmaxfield oldest_to_newest 1061540 0 koivisto 2015-01-15 06:41:34 -0800 Membuster regressed by the cache clearing patch. 1061541 1 244692 koivisto 2015-01-15 06:46:59 -0800 Created attachment 244692 patch 1061574 2 244692 kling 2015-01-15 10:34:20 -0800 Comment on attachment 244692 patch r=me 1061607 3 koivisto 2015-01-15 12:08:44 -0800 https://trac.webkit.org/r178522 1062799 4 koivisto 2015-01-20 10:46:46 -0800 That didn't fix it. 1062812 5 245002 koivisto 2015-01-20 11:11:35 -0800 Created attachment 245002 patch 1062829 6 245002 kling 2015-01-20 11:47:48 -0800 Comment on attachment 245002 patch View in context: https://bugs.webkit.org/attachment.cgi?id=245002&action=review r=me > Source/WebCore/platform/graphics/FontCascade.cpp:296 > Vector<unsigned, 50> toRemove; > - FontGlyphsCache::iterator end = fontGlyphsCache().end(); > - for (FontGlyphsCache::iterator it = fontGlyphsCache().begin(); it != end; ++it) { > - if (it->value->glyphs.get().hasOneRef()) > - toRemove.append(it->key); > + for (auto& entry : fontGlyphsCache()) { > + if (entry.value->glyphs.get().hasOneRef()) > + toRemove.append(entry.key); > } > for (unsigned i = 0; i < toRemove.size(); ++i) > fontGlyphsCache().remove(toRemove[i]); Jesus man, just use removeIf(), it's not 2014 anymore. 1063114 7 koivisto 2015-01-21 11:33:35 -0800 https://trac.webkit.org/r178853 244692 2015-01-15 06:46:59 -0800 2015-01-20 11:11:35 -0800 patch fontcache-clear.patch text/plain 2060 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODUxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTE1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNzgxMzMp OiBNZW1idXN0ZXIgcmVncmVzc2VkIH40JQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpwdXJnZUluYWN0aXZlRm9udERhdGEpOgorCisgICAg ICAgICAgICBGb250cyBtYXkgcmVmIG90aGVyIGZvbnRzLiBLZWVwIGNsZWFyaW5nIHVudGlsIHRo ZXJlIGFyZSBubyBjaGFuZ2VzLgorCiAyMDE1LTAxLTE1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgRm9udCB0byBGb250Q2FzY2FkZQpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwCShyZXZp c2lvbiAxNzg1MTApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2Fj aGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MzIsMTYgKzQzMiwyMSBAQCB2b2lkIEZvbnRDYWNo ZTo6cHVyZ2VJbmFjdGl2ZUZvbnREYXRhKGluCiAgICAgRm9udExvY2tlciBmb250TG9ja2VyOwog I2VuZGlmCiAKLSAgICBWZWN0b3I8UmVmUHRyPFNpbXBsZUZvbnREYXRhPiwgMjA+IGZvbnRzVG9E ZWxldGU7Ci0gICAgZm9yIChhdXRvJiBmb250IDogY2FjaGVkRm9udHMoKS52YWx1ZXMoKSkgewot ICAgICAgICBpZiAoIWZvbnQtPmhhc09uZVJlZigpKQotICAgICAgICAgICAgY29udGludWU7Ci0g ICAgICAgIGZvbnRzVG9EZWxldGUuYXBwZW5kKFdURjo6bW92ZShmb250KSk7Ci0gICAgICAgIGlm ICghLS1wdXJnZUNvdW50KQorICAgIHdoaWxlIChwdXJnZUNvdW50KSB7CisgICAgICAgIFZlY3Rv cjxSZWZQdHI8U2ltcGxlRm9udERhdGE+LCAyMD4gZm9udHNUb0RlbGV0ZTsKKyAgICAgICAgZm9y IChhdXRvJiBmb250IDogY2FjaGVkRm9udHMoKS52YWx1ZXMoKSkgeworICAgICAgICAgICAgaWYg KCFmb250LT5oYXNPbmVSZWYoKSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAg ICAgIGZvbnRzVG9EZWxldGUuYXBwZW5kKFdURjo6bW92ZShmb250KSk7CisgICAgICAgICAgICBp ZiAoIS0tcHVyZ2VDb3VudCkKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAg ICAgICAvLyBGb250cyBtYXkgcmVmIG90aGVyIGZvbnRzIHNvIHdlIGxvb3AgdW50aWwgdGhlcmUg YXJlIG5vIGNoYW5nZXMuCisgICAgICAgIGlmIChmb250c1RvRGVsZXRlLmlzRW1wdHkoKSkKICAg ICAgICAgICAgIGJyZWFrOwotICAgIH0KLSAgICBmb3IgKGF1dG8mIGZvbnQgOiBmb250c1RvRGVs ZXRlKQotICAgICAgICBjYWNoZWRGb250cygpLnJlbW92ZShmb250LT5wbGF0Zm9ybURhdGEoKSk7 CisgICAgICAgIGZvciAoYXV0byYgZm9udCA6IGZvbnRzVG9EZWxldGUpCisgICAgICAgICAgICBj YWNoZWRGb250cygpLnJlbW92ZShmb250LT5wbGF0Zm9ybURhdGEoKSk7CisgICAgfTsKIAogICAg IFZlY3RvcjxGb250UGxhdGZvcm1EYXRhQ2FjaGVLZXk+IGtleXNUb1JlbW92ZTsKICAgICBrZXlz VG9SZW1vdmUucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShmb250UGxhdGZvcm1EYXRhQ2FjaGUoKS5z aXplKCkpOwo= 245002 2015-01-20 11:11:35 -0800 2015-01-20 11:47:48 -0800 patch system-fallback-clear.patch text/plain 4983 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODcyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE1LTAxLTIwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNzc4NzYp OiBNZW1idXN0ZXIgcmVncmVzc2VkIH40JQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjE3Nzg3NiB3ZSBrZWVwIHN5c3RlbSBmYWxsYmFjayBm b250cyB0aGF0IGFyZSB1c2VkIG9uIGdseXBoIHBhZ2VzIGFsaXZlLgorICAgICAgICBQcmV2aW91 c2x5IHdlIHdvdWxkIHRyYXZlcnNlIHRoZSBnbHlwaCBwYWdlcyBhbmQgcmVtb3ZlIGVudHJpZXMg cmVmZXJlbmNpbmcgc3lzdGVtIGZhbGxiYWNrcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL0ZvbnRDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6OnB1cmdlSW5h Y3RpdmVGb250RGF0YSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJ1bmVVbnJlZmVyZW5jZWRFbnRyaWVzRnJvbUZvbnRH bHlwaHNDYWNoZSk6CisgICAgICAgIChXZWJDb3JlOjpwcnVuZVN5c3RlbUZhbGxiYWNrRm9udHMp OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmg6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvRm9udEdseXBocy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250 R2x5cGhzOjpwcnVuZVN5c3RlbUZhbGxiYWNrcyk6CisKKyAgICAgICAgICAgIFdoZW4gY2xlYXJp bmcgdGhlIGZvbnQgY2FjaGUgYWxzbyByZW1vdmUgdGhlIGNhY2hlZCBnbHlwaCBwYWdlcyB0aGF0 IG1heSBjb250YWluIHN5c3RlbSBmYWxsYmFjayBmb250cworICAgICAgICAgICAgYW5kIHJlbGVh c2UgdGhlIGZhbGxiYWNrcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRHbHlw aHMuaDoKKwogMjAxNS0wMS0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgYSB3YXkgdG8gY29sbGVjdCBzY3JvbGxpbmcgcGVyZm9ybWFuY2Ug ZGF0YSAodmlld3BvcnQgdGlsZSBjb3ZlcmFnZSkgd2l0aCBVSS1zaWRlIGNvbXBvc2l0aW5nCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5jcHAJ KHJldmlzaW9uIDE3ODY3MykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnRDYWNoZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyNyw2ICs0MjcsNyBAQCB2b2lkIEZvbnRD YWNoZTo6cHVyZ2VJbmFjdGl2ZUZvbnREYXRhSWZOCiB2b2lkIEZvbnRDYWNoZTo6cHVyZ2VJbmFj dGl2ZUZvbnREYXRhKGludCBwdXJnZUNvdW50KQogewogICAgIHBydW5lVW5yZWZlcmVuY2VkRW50 cmllc0Zyb21Gb250R2x5cGhzQ2FjaGUoKTsKKyAgICBwcnVuZVN5c3RlbUZhbGxiYWNrRm9udHMo KTsKIAogI2lmIFBMQVRGT1JNKElPUykKICAgICBGb250TG9ja2VyIGZvbnRMb2NrZXI7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUuY3Bw CShyZXZpc2lvbiAxNzg2NTApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G b250Q2FzY2FkZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4OCwxNSArMjg4LDIwIEBAIHN0YXRp YyB1bnNpZ25lZCBjb21wdXRlRm9udEdseXBoc0NhY2hlSGEKIHZvaWQgcHJ1bmVVbnJlZmVyZW5j ZWRFbnRyaWVzRnJvbUZvbnRHbHlwaHNDYWNoZSgpCiB7CiAgICAgVmVjdG9yPHVuc2lnbmVkLCA1 MD4gdG9SZW1vdmU7Ci0gICAgRm9udEdseXBoc0NhY2hlOjppdGVyYXRvciBlbmQgPSBmb250R2x5 cGhzQ2FjaGUoKS5lbmQoKTsKLSAgICBmb3IgKEZvbnRHbHlwaHNDYWNoZTo6aXRlcmF0b3IgaXQg PSBmb250R2x5cGhzQ2FjaGUoKS5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKLSAgICAgICAg aWYgKGl0LT52YWx1ZS0+Z2x5cGhzLmdldCgpLmhhc09uZVJlZigpKQotICAgICAgICAgICAgdG9S ZW1vdmUuYXBwZW5kKGl0LT5rZXkpOworICAgIGZvciAoYXV0byYgZW50cnkgOiBmb250R2x5cGhz Q2FjaGUoKSkgeworICAgICAgICBpZiAoZW50cnkudmFsdWUtPmdseXBocy5nZXQoKS5oYXNPbmVS ZWYoKSkKKyAgICAgICAgICAgIHRvUmVtb3ZlLmFwcGVuZChlbnRyeS5rZXkpOwogICAgIH0KICAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgdG9SZW1vdmUuc2l6ZSgpOyArK2kpCiAgICAgICAg IGZvbnRHbHlwaHNDYWNoZSgpLnJlbW92ZSh0b1JlbW92ZVtpXSk7CiB9CiAKK3ZvaWQgcHJ1bmVT eXN0ZW1GYWxsYmFja0ZvbnRzKCkKK3sKKyAgICBmb3IgKGF1dG8mIGVudHJ5IDogZm9udEdseXBo c0NhY2hlKCkudmFsdWVzKCkpCisgICAgICAgIGVudHJ5LT5nbHlwaHMtPnBydW5lU3lzdGVtRmFs bGJhY2tzKCk7Cit9CisKIHN0YXRpYyBSZWY8Rm9udEdseXBocz4gcmV0cmlldmVPckFkZENhY2hl ZEZvbnRHbHlwaHMoY29uc3QgRm9udERlc2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24sIFBhc3NS ZWZQdHI8Rm9udFNlbGVjdG9yPiBmb250U2VsZWN0b3IpCiB7CiAgICAgRm9udEdseXBoc0NhY2hl S2V5IGtleTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNj YWRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9u dENhc2NhZGUuaAkocmV2aXNpb24gMTc4NjUwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvRm9udENhc2NhZGUuaAkod29ya2luZyBjb3B5KQpAQCAtMzQ1LDYgKzM0NSw3IEBA IHByaXZhdGU6CiAKIHZvaWQgaW52YWxpZGF0ZUZvbnRHbHlwaHNDYWNoZSgpOwogdm9pZCBwcnVu ZVVucmVmZXJlbmNlZEVudHJpZXNGcm9tRm9udEdseXBoc0NhY2hlKCk7Cit2b2lkIHBydW5lU3lz dGVtRmFsbGJhY2tGb250cygpOwogdm9pZCBjbGVhcldpZHRoQ2FjaGVzKCk7CiAKIGlubGluZSBG b250Q2FzY2FkZTo6fkZvbnRDYXNjYWRlKCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ZvbnRHbHlwaHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ZvbnRHbHlwaHMuY3BwCShyZXZpc2lvbiAxNzg2NTApCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250R2x5cGhzLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzkyLDQgKzM5MiwxNyBAQCBHbHlwaERhdGEgRm9udEdseXBoczo6Z2x5cGhEYXRhRm9y Q2hhcmFjCiAgICAgcmV0dXJuIGdseXBoRGF0YTsKIH0KIAordm9pZCBGb250R2x5cGhzOjpwcnVu ZVN5c3RlbUZhbGxiYWNrcygpCit7CisgICAgaWYgKG1fc3lzdGVtRmFsbGJhY2tGb250RGF0YVNl dC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKyAgICAvLyBNdXRhYmxlIGdseXBoIHBhZ2Vz IG1heSByZWZlcmVuY2UgZmFsbGJhY2sgZm9udHMuCisgICAgaWYgKG1fY2FjaGVkUGFnZVplcm8g JiYgIW1fY2FjaGVkUGFnZVplcm8tPmlzSW1tdXRhYmxlKCkpCisgICAgICAgIG1fY2FjaGVkUGFn ZVplcm8gPSBudWxscHRyOworICAgIG1fY2FjaGVkUGFnZXMucmVtb3ZlSWYoW10oSGFzaE1hcDxp bnQsIFJlZlB0cjxHbHlwaFBhZ2U+Pjo6S2V5VmFsdWVQYWlyVHlwZSYga2V5QW5kVmFsdWUpIHsK KyAgICAgICAgcmV0dXJuICFrZXlBbmRWYWx1ZS52YWx1ZS0+aXNJbW11dGFibGUoKTsKKyAgICB9 KTsKKyAgICBtX3N5c3RlbUZhbGxiYWNrRm9udERhdGFTZXQuY2xlYXIoKTsKK30KKwogfQpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEdseXBocy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRHbHlwaHMuaAkocmV2 aXNpb24gMTc4NjUwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEds eXBocy5oCSh3b3JraW5nIGNvcHkpCkBAIC02OSw2ICs2OSw4IEBAIHB1YmxpYzoKICAgICBjb25z dCBTaW1wbGVGb250RGF0YSYgcHJpbWFyeVNpbXBsZUZvbnREYXRhKGNvbnN0IEZvbnREZXNjcmlw dGlvbiYpOwogICAgIFdFQkNPUkVfRVhQT1JUIGNvbnN0IEZvbnRSYW5nZXMmIHJlYWxpemVGYWxs YmFja1Jhbmdlc0F0KGNvbnN0IEZvbnREZXNjcmlwdGlvbiYsIHVuc2lnbmVkIGZhbGxiYWNrSW5k ZXgpOwogCisgICAgdm9pZCBwcnVuZVN5c3RlbUZhbGxiYWNrcygpOworCiBwcml2YXRlOgogICAg IEZvbnRHbHlwaHMoUGFzc1JlZlB0cjxGb250U2VsZWN0b3I+KTsKICAgICBGb250R2x5cGhzKGNv bnN0IEZvbnRQbGF0Zm9ybURhdGEmKTsK