140494 2015-01-15 01:27:41 -0800 REGRESSION(r177075): [GTK] Creating a second web view disables accelerated compositing in existing web view 2015-01-15 05:07:49 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo j.isorce mrobinson yoon zan oldest_to_newest 1061511 0 cgarcia 2015-01-15 01:27:41 -0800 This is very easy to reproduce with epiphany. 1.- Open ephy and load a page with an AC animation (like poster circle) 2.- Create a new tab 3.- Go back to previous tab The animation no longer works because AC has been disabled. The problem is that r177075 moved the creation of the redirected XComposite window to realize method, but leaving the call to webkitWebViewBaseUpdatePreferences() in both places Realize() and CreateWebPage(). webkitWebViewBaseUpdatePreferences() only updates the accelerating compositing setting nowadays, depending on whether the redirected XComposited window could be created or not (something that depends on whether XRender, XComposite and XDamage extensions are available in the current display). So, when the first web view is created, webkitWebViewBaseUpdatePreferences() is called first from CreateWebPage(), and always disabling accelerated compositing because the redirected window hasn't been created yet, and then from Realize() right after the redirected window is created so that accelerated compositing is enabled. When the second web view is created the same happens, but since settings are shared among web views, the first call to webkitWebViewBaseUpdatePreferences() from CreateWebPage() disables accelerated compositing and the web page exists accelerated compositing mode and never enters it again unless the page is reloaded. I guess the web page should enter accelerated compositing mode again when the setting is enabled again from Realize(), but since the setting is global and doesn't depend on every web view, we should never disable it once it has been enabled in any case. 1061512 1 244683 cgarcia 2015-01-15 01:33:56 -0800 Created attachment 244683 Patch We can save the IPC messages to change the setting, and simplify the code, by always enabling AC mode when the native surface handle is set in the web process. 1061513 2 commit-queue 2015-01-15 01:35:32 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1061517 3 244683 gustavo 2015-01-15 02:35:54 -0800 Comment on attachment 244683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244683&action=review > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:691 > + m_webPage.corePage()->settings().setAcceleratedCompositingEnabled(true); Wouldn't it be better to enable this unconditionally in WebKitSettings's constructed? This looks a bit hackish. 1061518 4 cgarcia 2015-01-15 02:46:23 -0800 (In reply to comment #3) > Comment on attachment 244683 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244683&action=review > > > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:691 > > + m_webPage.corePage()->settings().setAcceleratedCompositingEnabled(true); > > Wouldn't it be better to enable this unconditionally in WebKitSettings's > constructed? This looks a bit hackish. That would be a problem if the required X extensions are not present and SetNativeSurfaceHandleForCompositing message is not sent. The web process would enter AC mode but we wouldn't render anything. I think this is the safest approach, the setting is disabled by default, and should only be enabled when the web process has a native surface handle. 1061520 5 244683 gustavo 2015-01-15 03:11:30 -0800 Comment on attachment 244683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244683&action=review >>> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:691 >>> + m_webPage.corePage()->settings().setAcceleratedCompositingEnabled(true); >> >> Wouldn't it be better to enable this unconditionally in WebKitSettings's constructed? This looks a bit hackish. > > That would be a problem if the required X extensions are not present and SetNativeSurfaceHandleForCompositing message is not sent. The web process would enter AC mode but we wouldn't render anything. I think this is the safest approach, the setting is disabled by default, and should only be enabled when the web process has a native surface handle. okidoki 1061532 6 cgarcia 2015-01-15 05:07:49 -0800 Committed r178509: <http://trac.webkit.org/changeset/178509> 244683 2015-01-15 01:33:56 -0800 2015-01-15 02:35:54 -0800 Patch wk2-enable-ac.diff text/plain 7245 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxN2U2MmNiLi4wMTUxYmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDgg QEAKKzIwMTUtMDEtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE3NzA3NSk6IFtHVEtdIENyZWF0aW5nIGEgc2Vjb25k IHdlYiB2aWV3IGRpc2FibGVzIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGluIGV4aXN0aW5nIHdl YiB2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDA0OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgcHJvYmxlbSBpcyB0aGF0IHIxNzcwNzUgbW92ZWQgdGhlIGNyZWF0aW9uIG9mIHRoZSByZWRp cmVjdGVkCisgICAgICAgIFhDb21wb3NpdGUgd2luZG93IHRvIHJlYWxpemUgbWV0aG9kLCBidXQg bGVhdmluZyB0aGUgY2FsbCB0bworICAgICAgICB3ZWJraXRXZWJWaWV3QmFzZVVwZGF0ZVByZWZl cmVuY2VzKCkgaW4gYm90aCBwbGFjZXMgUmVhbGl6ZSgpIGFuZAorICAgICAgICBDcmVhdGVXZWJQ YWdlKCkuIHdlYmtpdFdlYlZpZXdCYXNlVXBkYXRlUHJlZmVyZW5jZXMoKSBvbmx5IHVwZGF0ZXMK KyAgICAgICAgdGhlIGFjY2VsZXJhdGluZyBjb21wb3NpdGluZyBzZXR0aW5nIG5vd2FkYXlzLCBk ZXBlbmRpbmcgb24KKyAgICAgICAgd2hldGhlciB0aGUgcmVkaXJlY3RlZCBYQ29tcG9zaXRlZCB3 aW5kb3cgY291bGQgYmUgY3JlYXRlZCBvciBub3QKKyAgICAgICAgKHNvbWV0aGluZyB0aGF0IGRl cGVuZHMgb24gd2hldGhlciBYUmVuZGVyLCBYQ29tcG9zaXRlIGFuZCBYRGFtYWdlCisgICAgICAg IGV4dGVuc2lvbnMgYXJlIGF2YWlsYWJsZSBpbiB0aGUgY3VycmVudCBkaXNwbGF5KS4gU28sIHdo ZW4gdGhlCisgICAgICAgIGZpcnN0IHdlYiB2aWV3IGlzIGNyZWF0ZWQsIHdlYmtpdFdlYlZpZXdC YXNlVXBkYXRlUHJlZmVyZW5jZXMoKSBpcworICAgICAgICBjYWxsZWQgZmlyc3QgZnJvbSBDcmVh dGVXZWJQYWdlKCksIGFuZCBhbHdheXMgZGlzYWJsaW5nCisgICAgICAgIGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nIGJlY2F1c2UgdGhlIHJlZGlyZWN0ZWQgd2luZG93IGhhc24ndCBiZWVuCisgICAg ICAgIGNyZWF0ZWQgeWV0LCBhbmQgdGhlbiBmcm9tIFJlYWxpemUoKSByaWdodCBhZnRlciB0aGUg cmVkaXJlY3RlZAorICAgICAgICB3aW5kb3cgaXMgY3JlYXRlZCBzbyB0aGF0IGFjY2VsZXJhdGVk IGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQuIFdoZW4KKyAgICAgICAgdGhlIHNlY29uZCB3ZWIgdmll dyBpcyBjcmVhdGVkIHRoZSBzYW1lIGhhcHBlbnMsIGJ1dCBzaW5jZQorICAgICAgICBzZXR0aW5n cyBhcmUgc2hhcmVkIGFtb25nIHdlYiB2aWV3cywgdGhlIGZpcnN0IGNhbGwgdG8KKyAgICAgICAg d2Via2l0V2ViVmlld0Jhc2VVcGRhdGVQcmVmZXJlbmNlcygpIGZyb20gQ3JlYXRlV2ViUGFnZSgp IGRpc2FibGVzCisgICAgICAgIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGFuZCB0aGUgd2ViIHBh Z2UgZXhpc3RzIGFjY2VsZXJhdGVkCisgICAgICAgIGNvbXBvc2l0aW5nIG1vZGUgYW5kIG5ldmVy IGVudGVycyBpdCBhZ2FpbiB1bmxlc3MgdGhlIHBhZ2UgaXMKKyAgICAgICAgcmVsb2FkZWQuIEkg Z3Vlc3MgdGhlIHdlYiBwYWdlIHNob3VsZCBlbnRlciBhY2NlbGVyYXRlZAorICAgICAgICBjb21w b3NpdGluZyBtb2RlIGFnYWluIHdoZW4gdGhlIHNldHRpbmcgaXMgZW5hYmxlZCBhZ2FpbiBmcm9t CisgICAgICAgIFJlYWxpemUoKSwgYnV0IHNpbmNlIHRoZSBzZXR0aW5nIGlzIGdsb2JhbCBhbmQg ZG9lc24ndCBkZXBlbmQgb24KKyAgICAgICAgZXZlcnkgd2ViIHZpZXcsIHdlIHNob3VsZCBuZXZl ciBkaXNhYmxlIGl0IG9uY2UgaXQgaGFzIGJlZW4KKyAgICAgICAgZW5hYmxlZCBpbiBhbnkgY2Fz ZS4KKyAgICAgICAgU2luY2Ugd2Ugd2FudCB0byBlbmFibGUgYWNjZWxlcmF0ZWQgY29tcG9zaXRp bmcgbW9kZSB3aGVuIHRoZQorICAgICAgICByZWRpcmVjdGVkIFhDb21wb3NpdGUgd2luZG93IGhh cyBiZWVuIHN1Y2Nlc3NmdWxseSBjcmVhdGVkLCB3ZSBjYW4KKyAgICAgICAgdXNlIHRoZSBTZXRO YXRpdmVTdXJmYWNlSGFuZGxlRm9yQ29tcG9zaXRpbmcgbWVzc2FnZSB0byBlbmFibGUgdGhlCisg ICAgICAgIHNldHRpbmcgYW5kIHJlbW92ZSB3ZWJraXRXZWJWaWV3QmFzZVVwZGF0ZVByZWZlcmVu Y2VzKCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcDoK KyAgICAgICAgKHdlYmtpdFdlYlZpZXdVcGRhdGVTZXR0aW5ncyk6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmll d0Jhc2VSZWFsaXplKToKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlQ3JlYXRlV2ViUGFnZSk6 CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVVwZGF0ZVByZWZlcmVuY2VzKTogRGVsZXRlZC4K KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaDoK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjpzZXROYXRpdmVTdXJmYWNlSGFuZGxlRm9yQ29t cG9zaXRpbmcpOgorCiAyMDE1LTAxLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR1RLKyBidWlsZCBhZnRlciBy MTc4NDY0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3LmNwcAppbmRleCBjOGI2MjY2Li4xM2JkMzM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApAQCAtNDg2LDggKzQ4Niw2 IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdVcGRhdGVTZXR0aW5ncyhXZWJLaXRXZWJWaWV3 KiB3ZWJWaWV3KQogICAgIHBhZ2UtPnNldENhblJ1bk1vZGFsKHdlYmtpdF9zZXR0aW5nc19nZXRf YWxsb3dfbW9kYWxfZGlhbG9ncyhzZXR0aW5ncykpOwogICAgIHBhZ2UtPnNldEN1c3RvbVVzZXJB Z2VudChTdHJpbmc6OmZyb21VVEY4KHdlYmtpdF9zZXR0aW5nc19nZXRfdXNlcl9hZ2VudChzZXR0 aW5ncykpKTsKIAotICAgIHdlYmtpdFdlYlZpZXdCYXNlVXBkYXRlUHJlZmVyZW5jZXMoV0VCS0lU X1dFQl9WSUVXX0JBU0Uod2ViVmlldykpOwotCiAgICAgZ19zaWduYWxfY29ubmVjdChzZXR0aW5n cywgIm5vdGlmeTo6YWxsb3ctbW9kYWwtZGlhbG9ncyIsIEdfQ0FMTEJBQ0soYWxsb3dNb2RhbERp YWxvZ3NDaGFuZ2VkKSwgd2ViVmlldyk7CiAgICAgZ19zaWduYWxfY29ubmVjdChzZXR0aW5ncywg Im5vdGlmeTo6em9vbS10ZXh0LW9ubHkiLCBHX0NBTExCQUNLKHpvb21UZXh0T25seUNoYW5nZWQp LCB3ZWJWaWV3KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHNldHRpbmdzLCAibm90aWZ5Ojp1c2Vy LWFnZW50IiwgR19DQUxMQkFDSyh1c2VyQWdlbnRDaGFuZ2VkKSwgd2ViVmlldyk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAKaW5kZXggOGE1YWE3Ny4uYmQ1NjgxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMzI4LDcgKzMyOCw2 IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlUmVhbGl6ZShHdGtXaWRnZXQqIHdpZGdl dCkKICAgICAgICAgICAgIERyYXdpbmdBcmVhUHJveHlJbXBsKiBkcmF3aW5nQXJlYSA9IHN0YXRp Y19jYXN0PERyYXdpbmdBcmVhUHJveHlJbXBsKj4ocHJpdi0+cGFnZVByb3h5LT5kcmF3aW5nQXJl YSgpKTsKICAgICAgICAgICAgIGRyYXdpbmdBcmVhLT5zZXROYXRpdmVTdXJmYWNlSGFuZGxlRm9y Q29tcG9zaXRpbmcocHJpdi0+cmVkaXJlY3RlZFdpbmRvdy0+d2luZG93SUQoKSk7CiAgICAgICAg IH0KLSAgICAgICAgd2Via2l0V2ViVmlld0Jhc2VVcGRhdGVQcmVmZXJlbmNlcyh3ZWJWaWV3KTsK ICAgICB9CiAjZW5kaWYKIApAQCAtMTEwNSwxOSArMTEwNCw2IEBAIFdlYlBhZ2VQcm94eSogd2Vi a2l0V2ViVmlld0Jhc2VHZXRQYWdlKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFz ZSkKICAgICByZXR1cm4gd2Via2l0V2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS5nZXQoKTsK IH0KIAotdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVVwZGF0ZVByZWZlcmVuY2VzKFdlYktpdFdlYlZp ZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFzZSkKLXsKLSAgICBXZWJLaXRXZWJWaWV3QmFzZVByaXZh dGUqIHByaXYgPSB3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdjsKLQotI2lmIFVTRShURVhUVVJFX01B UFBFUl9HTCkgJiYgUExBVEZPUk0oWDExKQotICAgIGJvb2wgYWNjZWxlcmF0ZWRDb21wb3NpdGlu Z0VuYWJsZWQgPSBwcml2LT5yZWRpcmVjdGVkV2luZG93ID8gdHJ1ZSA6IGZhbHNlOwotI2Vsc2UK LSAgICBib29sIGFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkID0gZmFsc2U7Ci0jZW5kaWYK LQotICAgIHByaXYtPnBhZ2VQcm94eS0+cHJlZmVyZW5jZXMoKS5zZXRBY2NlbGVyYXRlZENvbXBv c2l0aW5nRW5hYmxlZChhY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCk7Ci19Ci0KICNpZiBI QVZFKEdUS19TQ0FMRV9GQUNUT1IpCiBzdGF0aWMgdm9pZCBkZXZpY2VTY2FsZUZhY3RvckNoYW5n ZWQoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlKQogewpAQCAtMTE0NCw4ICsx MTMwLDYgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUNyZWF0ZVdlYlBhZ2UoV2ViS2l0V2ViVmll d0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNlLCBXZWJQcm8KICAgICBwcml2LT5wYWdlUHJveHktPnNl dEludHJpbnNpY0RldmljZVNjYWxlRmFjdG9yKGd0a193aWRnZXRfZ2V0X3NjYWxlX2ZhY3RvcihH VEtfV0lER0VUKHdlYmtpdFdlYlZpZXdCYXNlKSkpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2Vi a2l0V2ViVmlld0Jhc2UsICJub3RpZnk6OnNjYWxlLWZhY3RvciIsIEdfQ0FMTEJBQ0soZGV2aWNl U2NhbGVGYWN0b3JDaGFuZ2VkKSwgbnVsbHB0cik7CiAjZW5kaWYKLQotICAgIHdlYmtpdFdlYlZp ZXdCYXNlVXBkYXRlUHJlZmVyZW5jZXMod2Via2l0V2ViVmlld0Jhc2UpOwogfQogCiB2b2lkIHdl YmtpdFdlYlZpZXdCYXNlU2V0VG9vbHRpcFRleHQoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdC YXNlLCBjb25zdCBjaGFyKiB0b29sdGlwKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaAppbmRleCA2NTVh MGJlLi4wOTliM2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaApAQCAtNTMsMTEgKzUzLDYgQEAg V2ViS2l0OjpXZWJDb250ZXh0TWVudVByb3h5R3RrKiB3ZWJraXRXZWJWaWV3QmFzZUdldEFjdGl2 ZUNvbnRleHRNZW51UHJveHkoV2ViS2kKIEdka0V2ZW50KiB3ZWJraXRXZWJWaWV3QmFzZVRha2VD b250ZXh0TWVudUV2ZW50KFdlYktpdFdlYlZpZXdCYXNlKik7CiB2b2lkIHdlYmtpdFdlYlZpZXdC YXNlU2V0SW5wdXRNZXRob2RTdGF0ZShXZWJLaXRXZWJWaWV3QmFzZSosIGJvb2wgZW5hYmxlZCk7 CiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlVXBkYXRlVGV4dElucHV0U3RhdGUoV2ViS2l0V2ViVmll d0Jhc2UqKTsKLXZvaWQgd2Via2l0V2ViVmlld0Jhc2VVcGRhdGVQcmVmZXJlbmNlcyhXZWJLaXRX ZWJWaWV3QmFzZSopOwotCi0jaWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKQotdm9pZCB3ZWJraXRX ZWJWaWV3QmFzZVF1ZXVlRHJhd09mQWNjZWxlcmF0ZWRDb21wb3NpdGluZ1Jlc3VsdHMoV2ViS2l0 V2ViVmlld0Jhc2UqKTsKLSNlbmRpZgogCiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlU2V0Rm9jdXMo V2ViS2l0V2ViVmlld0Jhc2UqLCBib29sIGZvY3VzZWQpOwogYm9vbCB3ZWJraXRXZWJWaWV3QmFz ZUlzSW5XaW5kb3dBY3RpdmUoV2ViS2l0V2ViVmlld0Jhc2UqKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKaW5kZXggZjcx MTgyYy4uMzY5MzIwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKQEAgLTY4OCw2ICs2ODgsNyBAQCB2b2lkIERyYXdp bmdBcmVhSW1wbDo6YXR0YWNoVmlld092ZXJsYXlHcmFwaGljc0xheWVyKFdlYkNvcmU6OkZyYW1l KiBmcmFtZSwgV2ViQwogdm9pZCBEcmF3aW5nQXJlYUltcGw6OnNldE5hdGl2ZVN1cmZhY2VIYW5k bGVGb3JDb21wb3NpdGluZyh1aW50NjRfdCBoYW5kbGUpCiB7CiAgICAgbV9uYXRpdmVTdXJmYWNl SGFuZGxlRm9yQ29tcG9zaXRpbmcgPSBoYW5kbGU7CisgICAgbV93ZWJQYWdlLmNvcmVQYWdlKCkt PnNldHRpbmdzKCkuc2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQodHJ1ZSk7CiAKICNp ZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1NfVEhSRUFERUQpCiAgICAgaWYgKG1fbGF5ZXJUcmVl SG9zdCkK