140477 2015-01-14 16:23:47 -0800 RenderLayerCompositor: Strange comparison of opacity to boolean. 2015-01-15 18:18:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 138448 1 bfulgham bfulgham bfulgham commit-queue dino esprehn+autocc glenn kondapallykalyan simon.fraser thorton oldest_to_newest 1061393 0 bfulgham 2015-01-14 16:23:47 -0800 I receive the following warning when I build. Reviewing the line in question reveals that we are comparing a boolean (the return value of "ancestorBacking->graphicsLayer->drawsContents()") to the float returned by the style's opacity property. This seems very strange. At the very least, we should do some casting here to make it clear that this is intentional (if it is). if (newStyle.opacity() != ancestorBacking->graphicsLayer()->drawsContent()) return true; Where: opacity is a float drawsContent is a boolean. 1061397 1 bfulgham 2015-01-14 16:28:12 -0800 Based on Bug 138448, it looks like this was an intentional comparison, but I think a cast would make it clear that this is desired behavior. 1061401 2 simon.fraser 2015-01-14 16:35:57 -0800 Agreed it's odd. Would be fine to clarify. 1061405 3 bfulgham 2015-01-14 16:40:54 -0800 I neglected to include the compiler error: 18>c:\projects\webkit\opensource\source\webcore\rendering\RenderLayerCompositor.cpp(888): warning C4805: '!=' : unsafe mix of type 'float' and type 'bool' in operation (..\rendering\RenderingAllInOne.cpp) 1061549 4 bfulgham 2015-01-15 08:40:08 -0800 This code is checking for non-zero opacity. 1061651 5 244716 bfulgham 2015-01-15 14:56:37 -0800 Created attachment 244716 Patch 1061734 6 bfulgham 2015-01-15 18:18:37 -0800 Committed r178568: <http://trac.webkit.org/changeset/178568> 244716 2015-01-15 14:56:37 -0800 2015-01-15 15:39:12 -0800 Patch bug-140477-20150115150352.patch text/plain 1595 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODUzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAxLTE1ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJlbmRlckxheWVyQ29tcG9z aXRvcjogU3RyYW5nZSBjb21wYXJpc29uIG9mIG9wYWNpdHkgKGZsb2F0KSB0byBib29sZWFuLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwNDc3Lgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzdHlsZUNo YW5nZVJlcXVpcmVzTGF5ZXJSZWJ1aWxkKTogQWRkIGEgY2FzdCB0byBtYWtlIHRoZSBtZWFuaW5n IG9mIHRoaXMKKyAgICAgICAgY29kZSBjbGVhcmVyLgorCiAyMDE1LTAxLTE1ICBEaGkgQXVycmFo bWFuICA8ZGlvcmFobWFuQHJvY2t5YmFycy5jb20+CiAKICAgICAgICAgQ2Fub25pY2FsaXphdGlv biBvZiA6bGFuZygpIHNob3VsZCBwcmVzZXJ2ZSB0aGUgOmxhbmcoKSdzIGFyZ3VtZW50cyByZXBy ZXNlbnRhdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckNvbXBvc2l0b3IuY3BwCShyZXZpc2lvbiAxNzg1MjkpCisrKyBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAt ODg1LDcgKzg4NSw3IEBAIHN0YXRpYyBib29sIHN0eWxlQ2hhbmdlUmVxdWlyZXNMYXllclJlYnUK ICAgICBpZiAoIW9sZFN0eWxlLm9wYWNpdHkoKSAhPSAhbmV3U3R5bGUub3BhY2l0eSgpKSB7CiAg ICAgICAgIFJlbmRlckxheWVyTW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIgPSBsYXllci5y ZW5kZXJlcigpLmNvbnRhaW5lckZvclJlcGFpbnQoKTsKICAgICAgICAgaWYgKFJlbmRlckxheWVy QmFja2luZyogYW5jZXN0b3JCYWNraW5nID0gcmVwYWludENvbnRhaW5lciA/IHJlcGFpbnRDb250 YWluZXItPmxheWVyKCktPmJhY2tpbmcoKSA6IG51bGxwdHIpIHsKLSAgICAgICAgICAgIGlmIChu ZXdTdHlsZS5vcGFjaXR5KCkgIT0gYW5jZXN0b3JCYWNraW5nLT5ncmFwaGljc0xheWVyKCktPmRy YXdzQ29udGVudCgpKQorICAgICAgICAgICAgaWYgKHN0YXRpY19jYXN0PGJvb2w+KG5ld1N0eWxl Lm9wYWNpdHkoKSkgIT0gYW5jZXN0b3JCYWNraW5nLT5ncmFwaGljc0xheWVyKCktPmRyYXdzQ29u dGVudCgpKQogICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CiAgICAgfQo=