140470 2015-01-14 15:16:19 -0800 Web pages fail to load using public iOS WebKit; ASSERT(!isMainThread()) in -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:] 2015-01-16 16:12:50 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) iPhone / iPad iOS 8.1 RESOLVED FIXED P2 Normal --- 1 dbates dbates ap ddkilzer psolanki oldest_to_newest 1061341 0 244648 dbates 2015-01-14 15:16:19 -0800 Created attachment 244648 Backtrace When I load apple.com in the iOS Simulator using a debug build of iOS WebKit built with the public iOS SDK the assertion ASSERT(!isMainThread()) fails in -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]. I'm using OpenSource r178229 and the public iOS 8.1 SDK with Xcode Version 6.1.1 (6A2008a) on OS X 10.10.1 (14B25). 1061352 1 psolanki 2015-01-14 15:28:27 -0800 Does this get fixed if you comment out the following line? CFURLRequestSetShouldStartSynchronously(request, 1); in ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp 1062014 2 244815 dbates 2015-01-16 16:00:09 -0800 Created attachment 244815 Patch 1062020 3 dbates 2015-01-16 16:06:29 -0800 (In reply to comment #1) > Does this get fixed if you comment out the following line? > > CFURLRequestSetShouldStartSynchronously(request, 1); > > in ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp No, the issue reproduced even after commenting out the analogous line in ResourceHandleMac.mm: <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm?rev=176949#L222>. 1062023 4 dbates 2015-01-16 16:10:22 -0800 Pratik and I looked at this issue together today (01/16). Pratik noticed that we were incorrectly scheduling the NSURLConnection callbacks in WebKit2 with the NetworkProcess. Looking at this case, we want to schedule such callbacks to an NSOperationsQueue queue when using WebKit2 with the NetworkProcess. 1062025 5 244815 dbates 2015-01-16 16:12:46 -0800 Comment on attachment 244815 Patch Clearing flags on attachment: 244815 Committed r178612: <http://trac.webkit.org/changeset/178612> 1062026 6 dbates 2015-01-16 16:12:50 -0800 All reviewed patches have been landed. Closing bug. 244648 2015-01-14 15:16:19 -0800 2015-01-14 15:16:19 -0800 Backtrace backtrace.txt text/plain 7312 dbates IzAJMHgwMDAwMDAwMTA3ZTM1YTFhIGluIFdURkNyYXNoIGF0IC9Vc2Vycy9kYmF0ZXMvRGVza3Rv cC9XZWJLaXQvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHA6MzIxCiMxCTB4MDAwMDAwMDEw YmE0NzQ3NSBpbiAtW1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzT3BlcmF0aW9uUXVldWVEZWxlZ2F0 ZSBjb25uZWN0aW9uOndpbGxTZW5kUmVxdWVzdDpyZWRpcmVjdFJlc3BvbnNlOl0gYXQgL1VzZXJz L2RiYXRlcy9EZXNrdG9wL1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21h Yy9XZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUubW06MTAzCiMy CTB4MDAwMDAwMDEwMTgzY2JhNSBpbiBfX19aTDMxX05TVVJMQ29ubmVjdGlvbldpbGxTZW5kUmVx dWVzdFAxNl9DRlVSTENvbm5lY3Rpb25QSzEzX0NGVVJMUmVxdWVzdFAxNF9DRlVSTFJlc3BvbnNl UEt2X2Jsb2NrX2ludm9rZSAoKQojMwkweDAwMDAwMDAxMDE4NTBiOGMgaW4gX182NS1bTlNVUkxD b25uZWN0aW9uSW50ZXJuYWwgX3dpdGhDb25uZWN0aW9uQW5kRGVsZWdhdGU6b25seUFjdGl2ZTpd X2Jsb2NrX2ludm9rZSAoKQojNAkweDAwMDAwMDAxMDE4NTBiMzAgaW4gLVtOU1VSTENvbm5lY3Rp b25JbnRlcm5hbCBfd2l0aENvbm5lY3Rpb25BbmREZWxlZ2F0ZTpvbmx5QWN0aXZlOl0gKCkKIzUJ MHgwMDAwMDAwMTAxODUwYzk3IGluIC1bTlNVUkxDb25uZWN0aW9uSW50ZXJuYWwgX3dpdGhBY3Rp dmVDb25uZWN0aW9uQW5kRGVsZWdhdGU6XSAoKQojNgkweDAwMDAwMDAxMDE4M2IwMmIgaW4gX05T VVJMQ29ubmVjdGlvbldpbGxTZW5kUmVxdWVzdChfQ0ZVUkxDb25uZWN0aW9uKiwgX0NGVVJMUmVx dWVzdCBjb25zdCosIF9DRlVSTFJlc3BvbnNlKiwgdm9pZCBjb25zdCopICgpCiM3CTB4MDAwMDAw MDEwMTdmMzdiNiBpbiBVUkxDb25uZWN0aW9uQ2xpZW50X0NsYXNzaWM6Ol9jb25uZWN0aW9uQ2xp ZW50SW50ZXJmYWNlX3ByZWNhbm9uaWNhbGl6ZUZvclN5bmNocm9ub3VzU3RhcnQoKSAoKQojOAkw eDAwMDAwMDAxMDE3MDhjYmMgaW4gQ2xhc3NpY1VSTENvbm5lY3Rpb246OnN0YXJ0KCkgKCkKIzkJ MHgwMDAwMDAwMTAxNzA4YmMzIGluIENGVVJMQ29ubmVjdGlvblN0YXJ0ICgpCiMxMAkweDAwMDAw MDAxMDE4M2JjNjQgaW4gLVtOU1VSTENvbm5lY3Rpb25JbnRlcm5hbENvbm5lY3Rpb24gc3RhcnRd ICgpCiMxMQkweDAwMDAwMDAxMGI0ODM2ZDggaW4gV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnN0 YXJ0KCkgYXQgL1VzZXJzL2RiYXRlcy9EZXNrdG9wL1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbToyNjUKIzEyCTB4MDAwMDAwMDEw YjQ3YjNmYSBpbiBXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6Y3JlYXRlKFdlYkNvcmU6Ok5ldHdv cmtpbmdDb250ZXh0KiwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0IGNvbnN0JiwgV2ViQ29yZTo6 UmVzb3VyY2VIYW5kbGVDbGllbnQqLCBib29sLCBib29sKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0 b3AvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGUu Y3BwOjk5CiMxMwkweDAwMDAwMDAxMDJlZjkyM2YgaW4gV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VM b2FkZXI6OnN0YXJ0TmV0d29ya0xvYWQoKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0 L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHA6 MTgzCiMxNAkweDAwMDAwMDAxMDJlZjhmZDAgaW4gV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2Fk ZXI6OnN0YXJ0KCkgYXQgL1VzZXJzL2RiYXRlcy9EZXNrdG9wL1dlYktpdC9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwOjE2NAojMTUJMHgwMDAw MDAwMTAyZjA4YWVlIGluIFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZFNjaGVkdWxlcjo6c2No ZWR1bGVMb2FkZXIoV1RGOjpQYXNzUmVmUHRyPFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVy PikgYXQgL1VzZXJzL2RiYXRlcy9EZXNrdG9wL1dlYktpdC9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcDo0MAojMTYJMHgwMDAwMDAw MTAyZWNiNDcwIGluIFdlYktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNjaGVk dWxlUmVzb3VyY2VMb2FkKFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZFBhcmFtZXRlcnMgY29u c3QmKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1NvdXJjZS9XZWJLaXQyL05ldHdv cmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoxMjEKIzE3CTB4MDAw MDAwMDEwMmVkYWI2ZiBpbiB2b2lkIElQQzo6Y2FsbE1lbWJlckZ1bmN0aW9uSW1wbDxXZWJLaXQ6 Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLCB2b2lkIChXZWJLaXQ6Ok5ldHdvcmtDb25u ZWN0aW9uVG9XZWJQcm9jZXNzOjoqKShXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJjZUxvYWRQYXJhbWV0 ZXJzIGNvbnN0JiksIHN0ZDo6X18xOjp0dXBsZTxXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJjZUxvYWRQ YXJhbWV0ZXJzPiwgMHVsPihXZWJLaXQ6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzKiwg dm9pZCAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6KikoV2ViS2l0OjpO ZXR3b3JrUmVzb3VyY2VMb2FkUGFyYW1ldGVycyBjb25zdCYpLCBzdGQ6Ol9fMTo6dHVwbGU8V2Vi S2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkUGFyYW1ldGVycz4mJiwgc3RkOjppbmRleF9zZXF1ZW5j ZTwwdWw+KSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0lQQy9IYW5kbGVNZXNzYWdlLmg6MTYKIzE4CTB4MDAwMDAwMDEwMmVkYWFjOCBpbiB2 b2lkIElQQzo6Y2FsbE1lbWJlckZ1bmN0aW9uPFdlYktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dl YlByb2Nlc3MsIHZvaWQgKFdlYktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6Oiop KFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZFBhcmFtZXRlcnMgY29uc3QmKSwgc3RkOjpfXzE6 OnR1cGxlPFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZFBhcmFtZXRlcnM+LCBzdGQ6Om1ha2Vf aW5kZXhfc2VxdWVuY2U8MXVsPiA+KHN0ZDo6X18xOjp0dXBsZTxXZWJLaXQ6Ok5ldHdvcmtSZXNv dXJjZUxvYWRQYXJhbWV0ZXJzPiYmLCBXZWJLaXQ6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9j ZXNzKiwgdm9pZCAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6KikoV2Vi S2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkUGFyYW1ldGVycyBjb25zdCYpKSBhdCAvVXNlcnMvZGJh dGVzL0Rlc2t0b3AvV2ViS2l0L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9IYW5kbGVNZXNz YWdlLmg6MjIKIzE5CTB4MDAwMDAwMDEwMmVkMjQ4NSBpbiB2b2lkIElQQzo6aGFuZGxlTWVzc2Fn ZTxNZXNzYWdlczo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OlNjaGVkdWxlUmVzb3Vy Y2VMb2FkLCBXZWJLaXQ6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLCB2b2lkIChXZWJL aXQ6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjoqKShXZWJLaXQ6Ok5ldHdvcmtSZXNv dXJjZUxvYWRQYXJhbWV0ZXJzIGNvbnN0Jik+KElQQzo6TWVzc2FnZURlY29kZXImLCBXZWJLaXQ6 Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzKiwgdm9pZCAoV2ViS2l0OjpOZXR3b3JrQ29u bmVjdGlvblRvV2ViUHJvY2Vzczo6KikoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkUGFyYW1l dGVycyBjb25zdCYpKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtL0lQQy9IYW5kbGVNZXNzYWdlLmg6OTIKIzIwCTB4MDAwMDAwMDEwMmVkMTcw NSBpbiBXZWJLaXQ6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpkaWRSZWNlaXZlTmV0 d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3NNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYsIElQQzo6 TWVzc2FnZURlY29kZXImKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1dlYktpdEJ1 aWxkL0RlYnVnLWlwaG9uZXNpbXVsYXRvci9EZXJpdmVkU291cmNlcy9XZWJLaXQyL05ldHdvcmtD b25uZWN0aW9uVG9XZWJQcm9jZXNzTWVzc2FnZVJlY2VpdmVyLmNwcDo4MwojMjEJMHgwMDAwMDAw MTAyZWNhZWZlIGluIFdlYktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmRpZFJl Y2VpdmVNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYsIElQQzo6TWVzc2FnZURlY29kZXImKSBhdCAv VXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDo3NQojMjIJMHgwMDAwMDAwMTAyZDdm YjgzIGluIElQQzo6Q29ubmVjdGlvbjo6ZGlzcGF0Y2hNZXNzYWdlKElQQzo6TWVzc2FnZURlY29k ZXImKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL0lQQy9Db25uZWN0aW9uLmNwcDo4MTQKIzIzCTB4MDAwMDAwMDEwMmQ3NWI3MCBpbiBJUEM6 OkNvbm5lY3Rpb246OmRpc3BhdGNoTWVzc2FnZShzdGQ6Ol9fMTo6dW5pcXVlX3B0cjxJUEM6Ok1l c3NhZ2VEZWNvZGVyLCBzdGQ6Ol9fMTo6ZGVmYXVsdF9kZWxldGU8SVBDOjpNZXNzYWdlRGVjb2Rl cj4gPikgYXQgL1VzZXJzL2RiYXRlcy9EZXNrdG9wL1dlYktpdC9Tb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHA6ODMzCiMyNAkweDAwMDAwMDAxMDJkN2Y3MzEgaW4gSVBD OjpDb25uZWN0aW9uOjpkaXNwYXRjaE9uZU1lc3NhZ2UoKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0 b3AvV2ViS2l0L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcDo4NjEK IzI1CTB4MDAwMDAwMDEwMmQ5M2U5MiBpbiBXVEY6OkZ1bmN0aW9uV3JhcHBlcjx2b2lkIChJUEM6 OkNvbm5lY3Rpb246OiopKCk+OjpvcGVyYXRvcigpKElQQzo6Q29ubmVjdGlvbiopIGF0IC9Vc2Vy cy9kYmF0ZXMvRGVza3RvcC9XZWJLaXQvV2ViS2l0QnVpbGQvRGVidWctaXBob25lc2ltdWxhdG9y L3Vzci9sb2NhbC9pbmNsdWRlL3d0Zi9GdW5jdGlvbmFsLmg6MjE4CiMyNgkweDAwMDAwMDAxMDJk OTNlMTUgaW4gV1RGOjpCb3VuZEZ1bmN0aW9uSW1wbDxXVEY6OkZ1bmN0aW9uV3JhcHBlcjx2b2lk IChJUEM6OkNvbm5lY3Rpb246OiopKCk+LCB2b2lkIChJUEM6OkNvbm5lY3Rpb24qKT46Om9wZXJh dG9yKCkoKSBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1dlYktpdEJ1aWxkL0RlYnVn LWlwaG9uZXNpbXVsYXRvci91c3IvbG9jYWwvaW5jbHVkZS93dGYvRnVuY3Rpb25hbC5oOjQ5Ngoj MjcJMHgwMDAwMDAwMTAyZDkzMmIyIGluIFdURjo6RnVuY3Rpb248dm9pZCAoKT46Om9wZXJhdG9y KCkoKSBjb25zdCBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1dlYktpdEJ1aWxkL0Rl YnVnLWlwaG9uZXNpbXVsYXRvci91c3IvbG9jYWwvaW5jbHVkZS93dGYvRnVuY3Rpb25hbC5oOjcw NAojMjgJMHgwMDAwMDAwMTAyZDkzMjJjIGluIGRlY2x0eXBlKHN0ZDo6X18xOjpmb3J3YXJkPFdU Rjo6RnVuY3Rpb248dm9pZCAoKT4mPihmcCkoc3RkOjpfXzE6OmZvcndhcmQ8PihmcDApKSkgc3Rk OjpfXzE6Ol9faW52b2tlPFdURjo6RnVuY3Rpb248dm9pZCAoKT4mPihXVEY6OkZ1bmN0aW9uPHZv aWQgKCk+JiYmKSBbaW5saW5lZF0gYXQgL0FwcGxpY2F0aW9ucy9YY29kZS5hcHAvQ29udGVudHMv RGV2ZWxvcGVyL1Rvb2xjaGFpbnMvWGNvZGVEZWZhdWx0LnhjdG9vbGNoYWluL3Vzci9iaW4vLi4v aW5jbHVkZS9jKysvdjEvX19mdW5jdGlvbmFsX2Jhc2U6NDEzCiMyOQkweDAwMDAwMDAxMDJkOTMy MWIgaW4gc3RkOjpfXzE6Ol9fZnVuY3Rpb246Ol9fZnVuYzxXVEY6OkZ1bmN0aW9uPHZvaWQgKCk+ LCBzdGQ6Ol9fMTo6YWxsb2NhdG9yPFdURjo6RnVuY3Rpb248dm9pZCAoKT4gPiwgdm9pZCAoKT46 Om9wZXJhdG9yKCkoKSBhdCAvQXBwbGljYXRpb25zL1hjb2RlLmFwcC9Db250ZW50cy9EZXZlbG9w ZXIvVG9vbGNoYWlucy9YY29kZURlZmF1bHQueGN0b29sY2hhaW4vdXNyL2Jpbi8uLi9pbmNsdWRl L2MrKy92MS9mdW5jdGlvbmFsOjEzNzAKIzMwCTB4MDAwMDAwMDEwN2RkYzFjZCBpbiBzdGQ6Ol9f MTo6ZnVuY3Rpb248dm9pZCAoKT46Om9wZXJhdG9yKCkoKSBjb25zdCBhdCAvQXBwbGljYXRpb25z L1hjb2RlLmFwcC9Db250ZW50cy9EZXZlbG9wZXIvVG9vbGNoYWlucy9YY29kZURlZmF1bHQueGN0 b29sY2hhaW4vdXNyL2Jpbi8uLi9pbmNsdWRlL2MrKy92MS9mdW5jdGlvbmFsOjE3NTUKIzMxCTB4 MDAwMDAwMDEwN2U3M2UyMSBpbiBXVEY6OlJ1bkxvb3A6OnBlcmZvcm1Xb3JrKCkgYXQgL1VzZXJz L2RiYXRlcy9EZXNrdG9wL1dlYktpdC9Tb3VyY2UvV1RGL3d0Zi9SdW5Mb29wLmNwcDoxMDQKIzMy CTB4MDAwMDAwMDEwN2U3NTM2ZSBpbiBXVEY6OlJ1bkxvb3A6OnBlcmZvcm1Xb3JrKHZvaWQqKSBh dCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2ViS2l0L1NvdXJjZS9XVEYvd3RmL2NmL1J1bkxvb3BD Ri5jcHA6MzgKIzMzCTB4MDAwMDAwMDEwMTI0ZjU1MSBpbiBfX0NGUlVOTE9PUF9JU19DQUxMSU5H X09VVF9UT19BX1NPVVJDRTBfUEVSRk9STV9GVU5DVElPTl9fICgpCiMzNAkweDAwMDAwMDAxMDEy NDU0MWQgaW4gX19DRlJ1bkxvb3BEb1NvdXJjZXMwICgpCiMzNQkweDAwMDAwMDAxMDEyNDRhNTQg aW4gX19DRlJ1bkxvb3BSdW4gKCkKIzM2CTB4MDAwMDAwMDEwMTI0NDQ4NiBpbiBDRlJ1bkxvb3BS dW5TcGVjaWZpYyAoKQojMzcJMHgwMDAwMDAwMTAwNDk4YjQyIGluIC1bTlNSdW5Mb29wKE5TUnVu TG9vcCkgcnVuTW9kZTpiZWZvcmVEYXRlOl0gKCkKIzM4CTB4MDAwMDAwMDEwMDUyNGIxMCBpbiAt W05TUnVuTG9vcChOU1J1bkxvb3ApIHJ1bl0gKCkKIzM5CTB4MDAwMDAwMDEwMjFjYmIxZCBpbiBf eHBjX29iamNfbWFpbiAoKQojNDAJMHgwMDAwMDAwMTAyMWNkZWUwIGluIHhwY19tYWluICgpCiM0 MQkweDAwMDAwMDAxMDAzYzdlMDUgaW4gbWFpbiBhdCAvVXNlcnMvZGJhdGVzL0Rlc2t0b3AvV2Vi S2l0L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL21hYy9YUENTZXJ2 aWNlL1hQQ1NlcnZpY2VNYWluLkRldmVsb3BtZW50Lm1tOjE2NwojNDIJMHgwMDAwMDAwMTAxZjAx MTQ1IGluIHN0YXJ0ICgpCg== 244815 2015-01-16 16:00:09 -0800 2015-01-16 16:12:46 -0800 Patch bug-140470-20150116160016.patch text/plain 4411 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQzYWEwY2ZkOGZjOGJl N2RjYjU3ODVmMzNmM2Y1NjVhYTE2NWIwNi4uMDk1YmY4NjAxZTliM2ViZjUxMTY3NzcyM2RkZjlj YTkxYTlmNWEyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE1LTAxLTE2ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgcGFnZXMgZmFp bCB0byBsb2FkIHVzaW5nIHB1YmxpYyBpT1MgV2ViS2l0OyBBU1NFUlQoIWlzTWFpblRocmVhZCgp KSBpbgorICAgICAgICAtW1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzT3BlcmF0aW9uUXVldWVEZWxl Z2F0ZSBjb25uZWN0aW9uOndpbGxTZW5kUmVxdWVzdDpyZWRpcmVjdFJlc3BvbnNlOl0KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDQ3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIGFuIGlzc3Vl IHdoZXJlIGEgd2ViIHBhZ2Ugd291bGQgZmFpbCB0byBsb2FkIGluIGlPUyBXZWJLaXQyIGJ1aWx0 IHdpdGggdGhlIHB1YmxpYyBpT1MgU0RLCisgICAgICAgIGJlY2F1c2UgTlNVUkxDb25uZWN0aW9u IGNhbGxiYWNrcyB3ZXJlIGFsd2F5cyBiZWluZyBzY2hlZHVsZWQgb24gdGhlIG1haW4gdGhyZWFk LgorCisgICAgICAgIEN1cnJlbnRseSB3ZSBhbHdheXMgc2NoZWR1bGUgTlNVUkxDb25uZWN0aW9u IGNhbGxiYWNrcyB0byBvY2N1ciBvbiB0aGUgV2ViVGhyZWFkIG9yIHRoZSBtYWluCisgICAgICAg IHRocmVhZCBkZXBlbmRpbmcgb24gd2hldGhlciB0aGUgV2ViVGhyZWFkIHdhcyBzdGFydGVkLiBJ biBpT1MgV2ViS2l0MiwgdGhlIGNhbGxiYWNrcyB3ZXJlCisgICAgICAgIGFsd2F5cyBiZWluZyBz Y2hlZHVsZWQgb24gdGhlIG1haW4gdGhyZWFkIHJlZ2FyZGxlc3Mgb2Ygd2hldGhlciB3ZSB3ZXJl IHVzaW5nIHRoZSBOZXR3b3JrUHJvY2VzcworICAgICAgICAoc2luY2UgdGhlIFdlYlRocmVhZCBp cyBvbmx5IHN0YXJ0ZWQgd2hlbiB1c2luZyBXZWJLaXQxKS4gVGhpcyBsZWQgdG8gYW4gYXNzZXJ0 aW9uIGZhaWx1cmUuCisgICAgICAgIEluc3RlYWQgd2Ugd2FudCB0byBzY2hlZHVsZSBjYWxsYmFj a3MgdG8gYW4gTlNPcGVyYXRpb25zUXVldWUgcXVldWUgd2hlbiB1c2luZyBXZWJLaXQyIHdpdGgg dGhlCisgICAgICAgIE5ldHdvcmtQcm9jZXNzIChpLmUuIFJlc291cmNlSGFuZGxlQ2xpZW50Ojp1 c2VzQXN5bmNDYWxsYmFja3MoKSBpcyB0cnVlKSwgb24gdGhlIG1haW4gdGhyZWFkIHdoZW4KKyAg ICAgICAgdXNpbmcgV2ViS2l0MiB3aXRob3V0IHRoZSBOZXR3b3JrUHJvY2VzcyBhbmQgb24gdGhl IFdlYlRocmVhZCB3aGVuIHVzaW5nIFdlYktpdDEuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdGlv blF1ZXVlRm9yQXN5bmNDbGllbnRzKTogUmVtb3ZlIFBMQVRGT1JNKElPUyktZ3VhcmRzIGFzIHdl IHdhbnQgdG8gbWFrZSB1c2UKKyAgICAgICAgb2YgdGhpcyBjb2RlIGZvciBpT1MgV2ViS2l0MiB3 aXRoIHRoZSBOZXR3b3JrUHJvY2Vzcy4KKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxl OjpzdGFydCk6IE1vZGlmaWVkIHRvIHVzZSB0aGUgZXhpc3RpbmcgTWFjIGNvZGUgcGF0aCB0byBj b25kaXRpb25hbGx5CisgICAgICAgIHNjaGVkdWxlIE5TVVJMQ29ubmVjdGlvbiBjYWxsYmFja3Mg dG8gYW4gb3BlcmF0aW9uIHF1ZXVlIHdoZW4gUmVzb3VyY2VIYW5kbGVDbGllbnQ6OnVzZXNBc3lu Y0NhbGxiYWNrcygpCisgICAgICAgIGlzIHRydWUuIE90aGVyd2lzZSwgc2NoZWR1bGUgdGhlIGNh bGxiYWNrcyBvbiB0aGUgcnVuIGxvb3AgcmV0dXJuZWQgYnkgV2ViVGhyZWFkTlNSdW5Mb29wKCks CisgICAgICAgIHdoaWNoIGlzIGVpdGhlciB0aGUgV2ViVGhyZWFkIG9yIHRoZSBtYWluIHRocmVh ZCBydW4gbG9vcCB3aGVuIHVzaW5nIFdlYktpdDEgYW5kIFdlYktpdDIgd2l0aG91dAorICAgICAg ICB0aGUgTmV0d29ya1Byb2Nlc3MsIHJlc3BlY3RpdmVseS4KKwogMjAxNS0wMS0xNiAgQW50dGkg S29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQ29ycmVjdCBuYW1pbmcgZm9y IEZvbnRDYXNjYWRlIGltcGxlbWVudGF0aW9uIGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbSBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCmluZGV4IDRl YjgxYjJmNjQwMTRhNWViM2RkM2ViNmQzZjA0OTQ4N2ViYTMyN2QuLmJjYmU1NGVmMzU1NzU1NTQx MjdlYWQ3ZDA0NjRmOWVlYmQ0YzViZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCkBAIC0xMDUsNyArMTA1 LDYgQEAgc3RhdGljIHZvaWQgYXBwbHlCYXNpY0F1dGhvcml6YXRpb25IZWFkZXIoUmVzb3VyY2VS ZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBDcmVkZW4KICAgICByZXF1ZXN0LnNldEhUVFBIZWFkZXJG aWVsZChIVFRQSGVhZGVyTmFtZTo6QXV0aG9yaXphdGlvbiwgYXV0aGVudGljYXRpb25IZWFkZXIp OwogfQogCi0jaWYgIVBMQVRGT1JNKElPUykKIHN0YXRpYyBOU09wZXJhdGlvblF1ZXVlICpvcGVy YXRpb25RdWV1ZUZvckFzeW5jQ2xpZW50cygpCiB7CiAgICAgc3RhdGljIE5TT3BlcmF0aW9uUXVl dWUgKnF1ZXVlOwpAQCAtMTE2LDcgKzExNSw2IEBAIHN0YXRpYyBOU09wZXJhdGlvblF1ZXVlICpv cGVyYXRpb25RdWV1ZUZvckFzeW5jQ2xpZW50cygpCiAgICAgfQogICAgIHJldHVybiBxdWV1ZTsK IH0KLSNlbmRpZgogCiBSZXNvdXJjZUhhbmRsZUludGVybmFsOjp+UmVzb3VyY2VIYW5kbGVJbnRl cm5hbCgpCiB7CkBAIC0yNTksMTEgKzI1Nyw2IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0 KCkKICAgICAgICAgKE5TRGljdGlvbmFyeSAqKWNsaWVudCgpLT5jb25uZWN0aW9uUHJvcGVydGll cyh0aGlzKS5nZXQoKSk7CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKElPUykKLSAgICBOU1VSTENv bm5lY3Rpb24gKnVybENvbm5lY3Rpb24gPSBjb25uZWN0aW9uKCk7Ci0gICAgW3VybENvbm5lY3Rp b24gc2NoZWR1bGVJblJ1bkxvb3A6V2ViVGhyZWFkTlNSdW5Mb29wKCkgZm9yTW9kZTpOU0RlZmF1 bHRSdW5Mb29wTW9kZV07Ci0gICAgW3VybENvbm5lY3Rpb24gc3RhcnRdOwotI2Vsc2UKICAgICBi b29sIHNjaGVkdWxlZCA9IGZhbHNlOwogICAgIGlmIChTY2hlZHVsZVBhaXJIYXNoU2V0KiBzY2hl ZHVsZWRQYWlycyA9IGQtPm1fY29udGV4dC0+c2NoZWR1bGVkUnVuTG9vcFBhaXJzKCkpIHsKICAg ICAgICAgU2NoZWR1bGVQYWlySGFzaFNldDo6aXRlcmF0b3IgZW5kID0gc2NoZWR1bGVkUGFpcnMt PmVuZCgpOwpAQCAtMjgwLDYgKzI3MywxMiBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFydCgp CiAgICAgICAgIFtjb25uZWN0aW9uKCkgc2V0RGVsZWdhdGVRdWV1ZTpvcGVyYXRpb25RdWV1ZUZv ckFzeW5jQ2xpZW50cygpXTsKICAgICAgICAgc2NoZWR1bGVkID0gdHJ1ZTsKICAgICB9CisjaWYg UExBVEZPUk0oSU9TKQorICAgIGVsc2UgeworICAgICAgICBbY29ubmVjdGlvbigpIHNjaGVkdWxl SW5SdW5Mb29wOldlYlRocmVhZE5TUnVuTG9vcCgpIGZvck1vZGU6TlNEZWZhdWx0UnVuTG9vcE1v ZGVdOworICAgICAgICBzY2hlZHVsZWQgPSB0cnVlOworICAgIH0KKyNlbmRpZgogCiAgICAgLy8g U3RhcnQgdGhlIGNvbm5lY3Rpb24gaWYgd2UgZGlkIHNjaGVkdWxlIHdpdGggYXQgbGVhc3Qgb25l IHJ1bmxvb3AuCiAgICAgLy8gV2UgY2FuJ3Qgc3RhcnQgdGhlIGNvbm5lY3Rpb24gdW50aWwgd2Ug aGF2ZSBvbmUgcnVubG9vcCBzY2hlZHVsZWQuCkBAIC0yODcsNyArMjg2LDYgQEAgYm9vbCBSZXNv dXJjZUhhbmRsZTo6c3RhcnQoKQogICAgICAgICBbY29ubmVjdGlvbigpIHN0YXJ0XTsKICAgICBl bHNlCiAgICAgICAgIGQtPm1fc3RhcnRXaGVuU2NoZWR1bGVkID0gdHJ1ZTsKLSNlbmRpZgogCiAg ICAgTE9HKE5ldHdvcmssICJIYW5kbGUgJXAgc3RhcnRpbmcgY29ubmVjdGlvbiAlcCBmb3IgJUAi LCB0aGlzLCBjb25uZWN0aW9uKCksIGZpcnN0UmVxdWVzdCgpLm5zVVJMUmVxdWVzdChEb05vdFVw ZGF0ZUhUVFBCb2R5KSk7CiAgICAgCg==