140429 2015-01-13 22:31:16 -0800 [GTK] Fix build after r178385 2015-01-14 02:22:06 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140414 1 hs85.jeong hs85.jeong berto cdumez cgarcia clopez commit-queue gustavo mitz mrobinson ossy sam yoon oldest_to_newest 1061082 0 hs85.jeong 2015-01-13 22:31:16 -0800 ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:44:10: error: ‘void LoaderClient::didStartProvisionalLoadForFrame(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, uint64_t, API::Object*)’ marked override, but does not override void didStartProvisionalLoadForFrame(WebPageProxy&, WebFrameProxy& frame, uint64_t /* navigationID */, API::Object* /* userData */) override ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:51:10: error: ‘void LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, uint64_t, API::Object*)’ marked override, but does not override void didReceiveServerRedirectForProvisionalLoadForFrame(WebPageProxy&, WebFrameProxy& frame, uint64_t /* navigationID */, API::Object* /* userData */) override ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:58:10: error: ‘void LoaderClient::didFailProvisionalLoadWithErrorForFrame(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, uint64_t, const WebCore::ResourceError&, API::Object*)’ marked override, but does not override void didFailProvisionalLoadWithErrorForFrame(WebPageProxy&, WebFrameProxy& frame, uint64_t /* navigationID */, const ResourceError& resourceError, API::Object* /* userData */) override ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:71:10: error: ‘void LoaderClient::didCommitLoadForFrame(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, uint64_t, API::Object*)’ marked override, but does not override void didCommitLoadForFrame(WebPageProxy&, WebFrameProxy& frame, uint64_t /* navigationID */, API::Object* /* userData */) override ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:78:10: error: ‘void LoaderClient::didFinishLoadForFrame(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, uint64_t, API::Object*)’ marked override, but does not override void didFinishLoadForFrame(WebPageProxy&, WebFrameProxy& frame, uint64_t /* navigationID */, API::Object* /* userData */) override ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:85:10: error: ‘void LoaderClient::didFailLoadWithErrorForFrame(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, uint64_t, const WebCore::ResourceError&, API::Object*)’ marked override, but does not override void didFailLoadWithErrorForFrame(WebPageProxy&, WebFrameProxy& frame, uint64_t /* navigationID */, const ResourceError& resourceError, API::Object* /* userData */) override ^ 1061083 1 244582 hs85.jeong 2015-01-13 22:33:56 -0800 Created attachment 244582 Patch 1061084 2 commit-queue 2015-01-13 22:35:15 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1061085 3 hs85.jeong 2015-01-13 22:40:23 -0800 It is a wrong patch,, I have to look more,, 1061086 4 cdumez 2015-01-13 22:50:36 -0800 I have just landed a speculative fix for this one. 1061089 5 cdumez 2015-01-13 22:59:44 -0800 I haven't fixed this one though: Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/WebKitUserContentManager.cpp.o -c ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp: In constructor ‘_WebKitUserContentManagerPrivate::_WebKitUserContentManagerPrivate()’: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp:37:33: error: ‘create’ is not a member of ‘WebKit::WebUserContentControllerProxy’ : userContentController(WebUserContentControllerProxy::create()) ^ This was broken by https://bugs.webkit.org/show_bug.cgi?id=140414. I'll let you take a look at it as I don't have a GTK build. 1061090 6 cdumez 2015-01-13 23:02:15 -0800 For reference, here are my speculative GTK build fixes: https://trac.webkit.org/r178395 https://trac.webkit.org/r178408 https://trac.webkit.org/r178409 1061095 7 244585 hs85.jeong 2015-01-13 23:43:52 -0800 Created attachment 244585 Patch 1061097 8 244585 ossy 2015-01-14 00:03:10 -0800 Comment on attachment 244585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244585&action=review > Source/WebKit2/ChangeLog:3 > + [GTK] Fix build after r178375 do you mean r178385? 1061100 9 244585 ossy 2015-01-14 00:06:10 -0800 Comment on attachment 244585 Patch rs=me with fixing the changelog 1061107 10 hs85.jeong 2015-01-14 00:09:31 -0800 (In reply to comment #8) > Comment on attachment 244585 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244585&action=review > > > Source/WebKit2/ChangeLog:3 > > + [GTK] Fix build after r178375 > > do you mean r178385? Oops,, Yes , I mean r178385. Thanks, 1061110 11 244587 hs85.jeong 2015-01-14 00:19:51 -0800 Created attachment 244587 Patch 1061111 12 ossy 2015-01-14 00:48:06 -0800 Somebody else fixed by http://trac.webkit.org/changeset/178412 1061113 13 ossy 2015-01-14 00:51:25 -0800 Could you coordinate in the future to avoid parallel working? The simplest way is to add the new bug url to the original bug. 1061115 14 yoon 2015-01-14 00:56:29 -0800 Sorry for duplicated work. I didn't know that build fix was in progress. 1061117 15 cgarcia 2015-01-14 00:59:23 -0800 Thank you all for the build fixes. 1061120 16 yoon 2015-01-14 01:29:35 -0800 (In reply to comment #11) > Created attachment 244587 [details] > Patch Could you re-apply this patch to the trunk? I mis-readed the code. APIObject is refcounted, so it is correct to use adoptRef for WebUserContentManager. 1061124 17 cgarcia 2015-01-14 01:48:51 -0800 (In reply to comment #16) > (In reply to comment #11) > > Created attachment 244587 [details] > > Patch > > Could you re-apply this patch to the trunk? > I mis-readed the code. APIObject is refcounted, so it is correct to use > adoptRef for WebUserContentManager. Shouldn't we add the create method again instead? I think it was removed only because mac no uses a different way to allocate the object but we still need it 1061132 18 cgarcia 2015-01-14 02:15:51 -0800 Reopening to land the right fix 1061135 19 244587 commit-queue 2015-01-14 02:18:39 -0800 Comment on attachment 244587 Patch Rejecting attachment 244587 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 244587, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: orce']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp Hunk #1 FAILED at 34. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/gtk/WebKitUserContentManager.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4847328368263168 1061136 20 cgarcia 2015-01-14 02:22:06 -0800 Committed r178417: <http://trac.webkit.org/changeset/178417> 244582 2015-01-13 22:33:56 -0800 2015-01-13 23:43:44 -0800 Patch bug-140429-20150114153404.patch text/plain 5652 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjNlYTU1ZWQ4Mzc0Yjk3 ODk5ZGMwZjQ1MTMzYmY1NzBjMTQwN2FjMS4uZGM0N2M1MDFlMGU4MjU0NmI0MTNmNmQ2NjU5NzRm YjBiZWQ4M2Y1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAxLTEzICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBGaXgg YnVpbGQgYWZ0ZXIgcjE3ODM3NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQwNDI5IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcDoK KwogMjAxNS0wMS0xMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZpeCBhZnRlciByMTc4Mzc1LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAKaW5k ZXggYTFjZTRhNjhlYjA2MjU1Yjg1NjhmYWQ2NDJhODA3ZmE3NTM0MjAzZi4uZTlkMjk1MTUwMThi NTBkY2ZlNzIyYTllYTIwZjk1OWE4YWE3NGFkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwCkBAIC00MSwyMSAr NDEsMjEgQEAgcHVibGljOgogICAgIH0KIAogcHJpdmF0ZToKLSAgICB2b2lkIGRpZFN0YXJ0UHJv dmlzaW9uYWxMb2FkRm9yRnJhbWUoV2ViUGFnZVByb3h5JiwgV2ViRnJhbWVQcm94eSYgZnJhbWUs IHVpbnQ2NF90IC8qIG5hdmlnYXRpb25JRCAqLywgQVBJOjpPYmplY3QqIC8qIHVzZXJEYXRhICov KSBvdmVycmlkZQorICAgIHZpcnR1YWwgdm9pZCBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZy YW1lKFdlYlBhZ2VQcm94eSYsIFdlYkZyYW1lUHJveHkmIGZyYW1lLCB1aW50NjRfdCAvKiBuYXZp Z2F0aW9uSUQgKi8sIEFQSTo6T2JqZWN0KiAvKiB1c2VyRGF0YSAqLykgb3ZlcnJpZGUKICAgICB7 CiAgICAgICAgIGlmICghZnJhbWUuaXNNYWluRnJhbWUoKSkKICAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgd2Via2l0V2ViVmlld0xvYWRDaGFuZ2VkKG1fd2ViVmlldywgV0VCS0lUX0xPQURf U1RBUlRFRCk7CiAgICAgfQogCi0gICAgdm9pZCBkaWRSZWNlaXZlU2VydmVyUmVkaXJlY3RGb3JQ cm92aXNpb25hbExvYWRGb3JGcmFtZShXZWJQYWdlUHJveHkmLCBXZWJGcmFtZVByb3h5JiBmcmFt ZSwgdWludDY0X3QgLyogbmF2aWdhdGlvbklEICovLCBBUEk6Ok9iamVjdCogLyogdXNlckRhdGEg Ki8pIG92ZXJyaWRlCisgICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVTZXJ2ZXJSZWRpcmVjdEZv clByb3Zpc2lvbmFsTG9hZEZvckZyYW1lKFdlYlBhZ2VQcm94eSYsIFdlYkZyYW1lUHJveHkmIGZy YW1lLCB1aW50NjRfdCAvKiBuYXZpZ2F0aW9uSUQgKi8sIEFQSTo6T2JqZWN0KiAvKiB1c2VyRGF0 YSAqLykgb3ZlcnJpZGUKICAgICB7CiAgICAgICAgIGlmICghZnJhbWUuaXNNYWluRnJhbWUoKSkK ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgd2Via2l0V2ViVmlld0xvYWRDaGFuZ2VkKG1f d2ViVmlldywgV0VCS0lUX0xPQURfUkVESVJFQ1RFRCk7CiAgICAgfQogCi0gICAgdm9pZCBkaWRG YWlsUHJvdmlzaW9uYWxMb2FkV2l0aEVycm9yRm9yRnJhbWUoV2ViUGFnZVByb3h5JiwgV2ViRnJh bWVQcm94eSYgZnJhbWUsIHVpbnQ2NF90IC8qIG5hdmlnYXRpb25JRCAqLywgY29uc3QgUmVzb3Vy Y2VFcnJvciYgcmVzb3VyY2VFcnJvciwgQVBJOjpPYmplY3QqIC8qIHVzZXJEYXRhICovKSBvdmVy cmlkZQorICAgIHZpcnR1YWwgdm9pZCBkaWRGYWlsUHJvdmlzaW9uYWxMb2FkV2l0aEVycm9yRm9y RnJhbWUoV2ViUGFnZVByb3h5JiwgV2ViRnJhbWVQcm94eSYgZnJhbWUsIHVpbnQ2NF90IC8qIG5h dmlnYXRpb25JRCAqLywgY29uc3QgUmVzb3VyY2VFcnJvciYgcmVzb3VyY2VFcnJvciwgQVBJOjpP YmplY3QqIC8qIHVzZXJEYXRhICovKSBvdmVycmlkZQogICAgIHsKICAgICAgICAgaWYgKCFmcmFt ZS5pc01haW5GcmFtZSgpKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtNjgsMjEgKzY4LDIxIEBA IHByaXZhdGU6CiAgICAgICAgICAgICB3ZWJraXRXZWJWaWV3TG9hZEZhaWxlZChtX3dlYlZpZXcs IFdFQktJVF9MT0FEX1NUQVJURUQsIHJlc291cmNlRXJyb3IuZmFpbGluZ1VSTCgpLnV0ZjgoKS5k YXRhKCksIGVycm9yLmdldCgpKTsKICAgICB9CiAKLSAgICB2b2lkIGRpZENvbW1pdExvYWRGb3JG cmFtZShXZWJQYWdlUHJveHkmLCBXZWJGcmFtZVByb3h5JiBmcmFtZSwgdWludDY0X3QgLyogbmF2 aWdhdGlvbklEICovLCBBUEk6Ok9iamVjdCogLyogdXNlckRhdGEgKi8pIG92ZXJyaWRlCisgICAg dmlydHVhbCB2b2lkIGRpZENvbW1pdExvYWRGb3JGcmFtZShXZWJQYWdlUHJveHkmLCBXZWJGcmFt ZVByb3h5JiBmcmFtZSwgdWludDY0X3QgLyogbmF2aWdhdGlvbklEICovLCBBUEk6Ok9iamVjdCog LyogdXNlckRhdGEgKi8pIG92ZXJyaWRlCiAgICAgewogICAgICAgICBpZiAoIWZyYW1lLmlzTWFp bkZyYW1lKCkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIHdlYmtpdFdlYlZpZXdMb2Fk Q2hhbmdlZChtX3dlYlZpZXcsIFdFQktJVF9MT0FEX0NPTU1JVFRFRCk7CiAgICAgfQogCi0gICAg dm9pZCBkaWRGaW5pc2hMb2FkRm9yRnJhbWUoV2ViUGFnZVByb3h5JiwgV2ViRnJhbWVQcm94eSYg ZnJhbWUsIHVpbnQ2NF90IC8qIG5hdmlnYXRpb25JRCAqLywgQVBJOjpPYmplY3QqIC8qIHVzZXJE YXRhICovKSBvdmVycmlkZQorICAgIHZpcnR1YWwgdm9pZCBkaWRGaW5pc2hMb2FkRm9yRnJhbWUo V2ViUGFnZVByb3h5JiwgV2ViRnJhbWVQcm94eSYgZnJhbWUsIHVpbnQ2NF90IC8qIG5hdmlnYXRp b25JRCAqLywgQVBJOjpPYmplY3QqIC8qIHVzZXJEYXRhICovKSBvdmVycmlkZQogICAgIHsKICAg ICAgICAgaWYgKCFmcmFtZS5pc01haW5GcmFtZSgpKQogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB3ZWJraXRXZWJWaWV3TG9hZENoYW5nZWQobV93ZWJWaWV3LCBXRUJLSVRfTE9BRF9GSU5J U0hFRCk7CiAgICAgfQogCi0gICAgdm9pZCBkaWRGYWlsTG9hZFdpdGhFcnJvckZvckZyYW1lKFdl YlBhZ2VQcm94eSYsIFdlYkZyYW1lUHJveHkmIGZyYW1lLCB1aW50NjRfdCAvKiBuYXZpZ2F0aW9u SUQgKi8sIGNvbnN0IFJlc291cmNlRXJyb3ImIHJlc291cmNlRXJyb3IsIEFQSTo6T2JqZWN0KiAv KiB1c2VyRGF0YSAqLykgb3ZlcnJpZGUKKyAgICB2aXJ0dWFsIHZvaWQgZGlkRmFpbExvYWRXaXRo RXJyb3JGb3JGcmFtZShXZWJQYWdlUHJveHkmLCBXZWJGcmFtZVByb3h5JiBmcmFtZSwgdWludDY0 X3QgLyogbmF2aWdhdGlvbklEICovLCBjb25zdCBSZXNvdXJjZUVycm9yJiByZXNvdXJjZUVycm9y LCBBUEk6Ok9iamVjdCogLyogdXNlckRhdGEgKi8pIG92ZXJyaWRlCiAgICAgewogICAgICAgICBp ZiAoIWZyYW1lLmlzTWFpbkZyYW1lKCkpCiAgICAgICAgICAgICByZXR1cm47CkBAIC05MSwyNyAr OTEsMjcgQEAgcHJpdmF0ZToKICAgICAgICAgd2Via2l0V2ViVmlld0xvYWRGYWlsZWQobV93ZWJW aWV3LCBXRUJLSVRfTE9BRF9DT01NSVRURUQsIHJlc291cmNlRXJyb3IuZmFpbGluZ1VSTCgpLnV0 ZjgoKS5kYXRhKCksIGVycm9yLmdldCgpKTsKICAgICB9CiAKLSAgICB2b2lkIGRpZERpc3BsYXlJ bnNlY3VyZUNvbnRlbnRGb3JGcmFtZShXZWJQYWdlUHJveHkmLCBXZWJGcmFtZVByb3h5JiwgQVBJ OjpPYmplY3QqIC8qIHVzZXJEYXRhICovKSBvdmVycmlkZQorICAgIHZpcnR1YWwgdm9pZCBkaWRE aXNwbGF5SW5zZWN1cmVDb250ZW50Rm9yRnJhbWUoV2ViUGFnZVByb3h5JiwgV2ViRnJhbWVQcm94 eSYsIEFQSTo6T2JqZWN0KiAvKiB1c2VyRGF0YSAqLykgb3ZlcnJpZGUKICAgICB7CiAgICAgICAg IHdlYmtpdFdlYlZpZXdJbnNlY3VyZUNvbnRlbnREZXRlY3RlZChtX3dlYlZpZXcsIFdFQktJVF9J TlNFQ1VSRV9DT05URU5UX0RJU1BMQVlFRCk7CiAgICAgfQogCi0gICAgdm9pZCBkaWRSdW5JbnNl Y3VyZUNvbnRlbnRGb3JGcmFtZShXZWJQYWdlUHJveHkmLCBXZWJGcmFtZVByb3h5JiwgQVBJOjpP YmplY3QqIC8qIHVzZXJEYXRhICovKSBvdmVycmlkZQorICAgIHZpcnR1YWwgdm9pZCBkaWRSdW5J bnNlY3VyZUNvbnRlbnRGb3JGcmFtZShXZWJQYWdlUHJveHkmLCBXZWJGcmFtZVByb3h5JiwgQVBJ OjpPYmplY3QqIC8qIHVzZXJEYXRhICovKSBvdmVycmlkZQogICAgIHsKICAgICAgICAgd2Via2l0 V2ViVmlld0luc2VjdXJlQ29udGVudERldGVjdGVkKG1fd2ViVmlldywgV0VCS0lUX0lOU0VDVVJF X0NPTlRFTlRfUlVOKTsKICAgICB9CiAKLSAgICB2b2lkIGRpZENoYW5nZUJhY2tGb3J3YXJkTGlz dChXZWJQYWdlUHJveHkmLCBXZWJCYWNrRm9yd2FyZExpc3RJdGVtKiBhZGRlZEl0ZW0sIFZlY3Rv cjxSZWZQdHI8V2ViQmFja0ZvcndhcmRMaXN0SXRlbT4+IHJlbW92ZWRJdGVtcykgb3ZlcnJpZGUK KyAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlQmFja0ZvcndhcmRMaXN0KFdlYlBhZ2VQcm94eSYs IFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIGFkZGVkSXRlbSwgVmVjdG9yPFJlZlB0cjxXZWJCYWNr Rm9yd2FyZExpc3RJdGVtPj4gcmVtb3ZlZEl0ZW1zKSBvdmVycmlkZQogICAgIHsKICAgICAgICAg d2Via2l0QmFja0ZvcndhcmRMaXN0Q2hhbmdlZCh3ZWJraXRfd2ViX3ZpZXdfZ2V0X2JhY2tfZm9y d2FyZF9saXN0KG1fd2ViVmlldyksIGFkZGVkSXRlbSwgcmVtb3ZlZEl0ZW1zKTsKICAgICB9CiAK LSAgICB2b2lkIGRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZUluRnJhbWUoV2ViUGFn ZVByb3h5JiwgV2ViRnJhbWVQcm94eSYsIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlUHJveHkqIGF1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKSBvdmVycmlkZQorICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNl aXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2VJbkZyYW1lKFdlYlBhZ2VQcm94eSYsIFdlYkZyYW1l UHJveHkmLCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5KiBhdXRoZW50aWNhdGlvbkNoYWxs ZW5nZSkgb3ZlcnJpZGUKICAgICB7CiAgICAgICAgIHdlYmtpdFdlYlZpZXdIYW5kbGVBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZShtX3dlYlZpZXcsIGF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKTsKICAg ICB9CiAKLSAgICB2b2lkIHByb2Nlc3NEaWRDcmFzaChXZWJQYWdlUHJveHkmKSBvdmVycmlkZQor ICAgIHZpcnR1YWwgdm9pZCBwcm9jZXNzRGlkQ3Jhc2goV2ViUGFnZVByb3h5Jikgb3ZlcnJpZGUK ICAgICB7CiAgICAgICAgIHdlYmtpdFdlYlZpZXdXZWJQcm9jZXNzQ3Jhc2hlZChtX3dlYlZpZXcp OwogICAgIH0K 244585 2015-01-13 23:43:52 -0800 2015-01-14 00:19:41 -0800 Patch bug-140429-20150114164400.patch text/plain 1363 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjUxZjg5OTcwYmE1Y2Ri MDJkYzZiMmE3NzU0YjE1ZjUzOGQ3MjExNy4uYzhhM2Q4ZGU2NDRmZDczNWRhNTNlMGIxYjJiODEz OGZjOTNmMDE1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAxLTEzICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBGaXgg YnVpbGQgYWZ0ZXIgcjE3ODM3NSAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDA0MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVzZXJDb250ZW50TWFuYWdl ci5jcHA6CisgICAgICAgIChfV2ViS2l0VXNlckNvbnRlbnRNYW5hZ2VyUHJpdmF0ZTo6X1dlYktp dFVzZXJDb250ZW50TWFuYWdlclByaXZhdGUpOgorCiAyMDE1LTAxLTEzICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgYnVpbGQgZml4IGFm dGVyIHIxNzgzNzUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRVc2VyQ29udGVudE1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0VXNlckNvbnRlbnRNYW5hZ2VyLmNwcAppbmRleCBkMDk0NzRmZTM3NGM0 OTRjYWU3NDczMGE5NWM1ZWE1MWI0Y2VkZjZiLi4yNzU5OTQ5ZTQyZGViZjRkMzZmNGQ3NDQ3MjFj NTA4Yzc5Yjg2NjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRVc2VyQ29udGVudE1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFVzZXJDb250ZW50TWFuYWdlci5jcHAKQEAgLTM0LDcgKzM0LDcg QEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAogc3RydWN0IF9XZWJLaXRVc2VyQ29udGVudE1h bmFnZXJQcml2YXRlIHsKICAgICBfV2ViS2l0VXNlckNvbnRlbnRNYW5hZ2VyUHJpdmF0ZSgpCi0g ICAgICAgIDogdXNlckNvbnRlbnRDb250cm9sbGVyKFdlYlVzZXJDb250ZW50Q29udHJvbGxlclBy b3h5OjpjcmVhdGUoKSkKKyAgICAgICAgOiB1c2VyQ29udGVudENvbnRyb2xsZXIoYWRvcHRSZWYo bmV3IFdlYlVzZXJDb250ZW50Q29udHJvbGxlclByb3h5KSkKICAgICB7CiAgICAgfQogCg== 244587 2015-01-14 00:19:51 -0800 2015-01-14 02:18:39 -0800 Patch bug-140429-20150114171959.patch text/plain 1367 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4NDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjUxZjg5OTcwYmE1Y2Ri MDJkYzZiMmE3NzU0YjE1ZjUzOGQ3MjExNy4uMThlYzliYTMxMWJlMzg1YTNmN2FhMWViZWUyMmRi YTVmOWJjYjY2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAxLTE0ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBGaXgg YnVpbGQgYWZ0ZXIgcjE3ODM4NSAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDA0MjkKKworICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9n b27DoWMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVc2VyQ29udGVudE1h bmFnZXIuY3BwOgorICAgICAgICAoX1dlYktpdFVzZXJDb250ZW50TWFuYWdlclByaXZhdGU6Ol9X ZWJLaXRVc2VyQ29udGVudE1hbmFnZXJQcml2YXRlKToKKwogMjAxNS0wMS0xMyAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZp eCBhZnRlciByMTc4Mzc1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0VXNlckNvbnRlbnRNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFVzZXJDb250ZW50TWFuYWdlci5jcHAKaW5kZXggZDA5NDc0ZmUz NzRjNDk0Y2FlNzQ3MzBhOTVjNWVhNTFiNGNlZGY2Yi4uMjc1OTk0OWU0MmRlYmY0ZDM2ZjRkNzQ0 NzIxYzUwOGM3OWI4NjYyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0VXNlckNvbnRlbnRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVc2VyQ29udGVudE1hbmFnZXIuY3BwCkBAIC0zNCw3ICsz NCw3IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKIHN0cnVjdCBfV2ViS2l0VXNlckNvbnRl bnRNYW5hZ2VyUHJpdmF0ZSB7CiAgICAgX1dlYktpdFVzZXJDb250ZW50TWFuYWdlclByaXZhdGUo KQotICAgICAgICA6IHVzZXJDb250ZW50Q29udHJvbGxlcihXZWJVc2VyQ29udGVudENvbnRyb2xs ZXJQcm94eTo6Y3JlYXRlKCkpCisgICAgICAgIDogdXNlckNvbnRlbnRDb250cm9sbGVyKGFkb3B0 UmVmKG5ldyBXZWJVc2VyQ29udGVudENvbnRyb2xsZXJQcm94eSkpCiAgICAgewogICAgIH0KIAo=