140425 2015-01-13 20:27:41 -0800 [Win] Layout Test fast/css/crash-on-custom-cursor-when-loading.html is failing 2015-01-14 10:25:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue oldest_to_newest 1061050 0 bfulgham 2015-01-13 20:27:41 -0800 The following layout test is failing on Windows. fast/css/crash-on-custom-cursor-when-loading.html Probable cause: Windows is refusing to create a DIB for the 'empty' icon during the initial load phase. This is returning a null value, which is then used in later API calls that assert that the arguments are non-null. Solution is: 1. If the DIB cannot be created by the operating system based on the icon description, return a nullptr. 2. If the 'createSharedCursor' call returns nullptr, fall back to the default icon case so that we have something that can be used during early layout until the load finishes. 1061052 1 244574 bfulgham 2015-01-13 20:30:07 -0800 Created attachment 244574 Patch 1061213 2 244574 commit-queue 2015-01-14 10:25:44 -0800 Comment on attachment 244574 Patch Clearing flags on attachment: 244574 Committed r178424: <http://trac.webkit.org/changeset/178424> 1061214 3 commit-queue 2015-01-14 10:25:47 -0800 All reviewed patches have been landed. Closing bug. 244574 2015-01-13 20:30:07 -0800 2015-01-14 10:25:44 -0800 Patch bug-140425-20150113203711.patch text/plain 2699 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODQwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTEzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIExheW91dCBUZXN0 IGZhc3QvY3NzL2NyYXNoLW9uLWN1c3RvbS1jdXJzb3Itd2hlbi1sb2FkaW5nLmh0bWwgaXMgZmFp bGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQw NDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS93aW4vQ3Vyc29yV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZVNoYXJl ZEN1cnNvcik6IFJldHVybiBudWxscHRyIHdoZW4gb3BlcmF0aW5nIHN5c3RlbQorICAgICAgICBj YW5ub3Qgc3VwcG9ydCB0aGUgcmVxdWVzdGVkIGljb24gc3BlY2lmaWNhdGlvbi4KKyAgICAgICAg KFdlYkNvcmU6OkN1cnNvcjo6ZW5zdXJlUGxhdGZvcm1DdXJzb3IpOiBDaGVjayBmb3IgJ2NyZWF0 ZVNoYXJlZEN1cnNvcicKKyAgICAgICAgcmV0dXJuaW5nIG51bGxwdHIsIGFuZCBmYWxsIGJhY2sg dG8gdGhlIGRlZmF1bHQgaWNvbiBjb25zdHJ1Y3Rpb24uCisKIDIwMTUtMDEtMTMgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxNzg0MDAuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ3Vy c29yV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ3Vy c29yV2luLmNwcAkocmV2aXNpb24gMTc4MzY0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v d2luL0N1cnNvcldpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDggKzUzLDkgQEAgc3RhdGlj IFBhc3NSZWZQdHI8U2hhcmVkQ3Vyc29yPiBjcmVhdGVTaAogICAgIEhXbmREQyBkYygwKTsKICAg ICBhdXRvIHdvcmtpbmdEQyA9IGFkb3B0R0RJT2JqZWN0KDo6Q3JlYXRlQ29tcGF0aWJsZURDKGRj KSk7CiAgICAgaWYgKGRvQWxwaGEpIHsKLSAgICAgICAgYXV0byBoQ3Vyc29yID0gYWRvcHRHRElP YmplY3QoOjpDcmVhdGVESUJTZWN0aW9uKGRjLCAoQklUTUFQSU5GTyAqKSZjdXJzb3JJbWFnZSwg RElCX1JHQl9DT0xPUlMsIDAsIDAsIDApKTsKLSAgICAgICAgQVNTRVJUKGhDdXJzb3IpOworICAg ICAgICBhdXRvIGhDdXJzb3IgPSBhZG9wdEdESU9iamVjdCg6OkNyZWF0ZURJQlNlY3Rpb24oZGMs ICZjdXJzb3JJbWFnZSwgRElCX1JHQl9DT0xPUlMsIG51bGxwdHIsIDAsIDApKTsKKyAgICAgICAg aWYgKCFoQ3Vyc29yKQorICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICAgICAgaW1n LT5nZXRIQklUTUFQKGhDdXJzb3IuZ2V0KCkpOyAKICAgICAgICAgSEJJVE1BUCBoT2xkQml0bWFw ID0gKEhCSVRNQVApU2VsZWN0T2JqZWN0KHdvcmtpbmdEQy5nZXQoKSwgaEN1cnNvci5nZXQoKSk7 CkBAIC03OCw4ICs3OSwxMCBAQCBzdGF0aWMgUGFzc1JlZlB0cjxTaGFyZWRDdXJzb3I+IGNyZWF0 ZVNoCiAgICAgICAgIC8vIHRvIGNyZWF0ZSB0aGUgbWFzayBtYW51YWxseQogICAgICAgICBhdXRv IGFuZE1hc2tEQyA9IGFkb3B0R0RJT2JqZWN0KDo6Q3JlYXRlQ29tcGF0aWJsZURDKGRjKSk7CiAg ICAgICAgIGF1dG8geG9yTWFza0RDID0gYWRvcHRHRElPYmplY3QoOjpDcmVhdGVDb21wYXRpYmxl REMoZGMpKTsKLSAgICAgICAgYXV0byBoQ3Vyc29yID0gYWRvcHRHRElPYmplY3QoOjpDcmVhdGVE SUJTZWN0aW9uKGRjLCAmY3Vyc29ySW1hZ2UsIERJQl9SR0JfQ09MT1JTLCAwLCAwLCAwKSk7Ci0g ICAgICAgIEFTU0VSVChoQ3Vyc29yKTsKKyAgICAgICAgYXV0byBoQ3Vyc29yID0gYWRvcHRHRElP YmplY3QoOjpDcmVhdGVESUJTZWN0aW9uKGRjLCAmY3Vyc29ySW1hZ2UsIERJQl9SR0JfQ09MT1JT LCBudWxscHRyLCAwLCAwKSk7CisgICAgICAgIGlmICghaEN1cnNvcikKKyAgICAgICAgICAgIHJl dHVybiBudWxscHRyOworCiAgICAgICAgIGltZy0+Z2V0SEJJVE1BUChoQ3Vyc29yLmdldCgpKTsg CiAgICAgICAgIEJJVE1BUCBjdXJzb3I7CiAgICAgICAgIEdldE9iamVjdChoQ3Vyc29yLmdldCgp LCBzaXplb2YoQklUTUFQKSwgJmN1cnNvcik7CkBAIC0yNTAsNiArMjUzLDggQEAgdm9pZCBDdXJz b3I6OmVuc3VyZVBsYXRmb3JtQ3Vyc29yKCkgY29ucwogICAgICAgICBicmVhazsKICAgICBjYXNl IEN1cnNvcjo6Q3VzdG9tOgogICAgICAgICBtX3BsYXRmb3JtQ3Vyc29yID0gY3JlYXRlU2hhcmVk Q3Vyc29yKG1faW1hZ2UuZ2V0KCksIG1faG90U3BvdCk7CisgICAgICAgIGlmICghbV9wbGF0Zm9y bUN1cnNvcikKKyAgICAgICAgICAgIG1fcGxhdGZvcm1DdXJzb3IgPSBsb2FkU2hhcmVkQ3Vyc29y KDAsIElEQ19BUlJPVyk7CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwo=