<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>140423</bug_id>
          
          <creation_ts>2015-01-13 19:08:07 -0800</creation_ts>
          <short_desc>r178390 breaks many webgl tests</short_desc>
          <delta_ts>2015-01-14 00:07:12 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>140431</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>140431</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Roger Fong">roger_fong</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1061031</commentid>
    <comment_count>0</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2015-01-13 19:08:07 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/178390 broke a lot of WebGL tests
Skipping for now while I fix them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1061096</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2015-01-13 23:55:58 -0800</bug_when>
    <thetext>Also js/dom/global-constructors-attributes.html broke in a way that doesn&apos;t seem expected - we lost existing properties, and we got a seemingly wrong &quot;WebGLRenderingContextBase&quot;.

I don&apos;t think that it&apos;s OK to skip all WebGL tests, and also js/dom/global-constructors-attributes.html too. I&apos;m going to roll out.

@@ -1883,6 +1883,16 @@
 PASS Object.getOwnPropertyDescriptor(global, &apos;WaveShaperNode&apos;).hasOwnProperty(&apos;set&apos;) is false
 PASS Object.getOwnPropertyDescriptor(global, &apos;WaveShaperNode&apos;).enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, &apos;WaveShaperNode&apos;).configurable is true
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL1RenderingContext&apos;).value is WebGL1RenderingContext
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL1RenderingContext&apos;).hasOwnProperty(&apos;get&apos;) is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL1RenderingContext&apos;).hasOwnProperty(&apos;set&apos;) is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL1RenderingContext&apos;).enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL1RenderingContext&apos;).configurable is true
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL2RenderingContext&apos;).value is WebGL2RenderingContext
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL2RenderingContext&apos;).hasOwnProperty(&apos;get&apos;) is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL2RenderingContext&apos;).hasOwnProperty(&apos;set&apos;) is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL2RenderingContext&apos;).enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGL2RenderingContext&apos;).configurable is true
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLActiveInfo&apos;).value is WebGLActiveInfo
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLActiveInfo&apos;).hasOwnProperty(&apos;get&apos;) is false
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLActiveInfo&apos;).hasOwnProperty(&apos;set&apos;) is false
@@ -1913,11 +1923,11 @@
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderbuffer&apos;).hasOwnProperty(&apos;set&apos;) is false
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderbuffer&apos;).enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderbuffer&apos;).configurable is true
-PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContext&apos;).value is WebGLRenderingContext
-PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContext&apos;).hasOwnProperty(&apos;get&apos;) is false
-PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContext&apos;).hasOwnProperty(&apos;set&apos;) is false
-PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContext&apos;).enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContext&apos;).configurable is true
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContextBase&apos;).value is WebGLRenderingContextBase
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContextBase&apos;).hasOwnProperty(&apos;get&apos;) is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContextBase&apos;).hasOwnProperty(&apos;set&apos;) is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContextBase&apos;).enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLRenderingContextBase&apos;).configurable is true
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLShader&apos;).value is WebGLShader
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLShader&apos;).hasOwnProperty(&apos;get&apos;) is false
 PASS Object.getOwnPropertyDescriptor(global, &apos;WebGLShader&apos;).hasOwnProperty(&apos;set&apos;) is false</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1061105</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2015-01-14 00:07:12 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 140431 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>