140405 2015-01-13 13:47:49 -0800 Should disable immediate actions for iTunes 2015-01-13 14:34:30 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned oldest_to_newest 1060913 0 bdakin 2015-01-13 13:47:49 -0800 Should disable immediate actions for iTunes rdar://problem/19274499 1060916 1 244541 bdakin 2015-01-13 13:50:18 -0800 Created attachment 244541 Patch 1060922 2 244543 bdakin 2015-01-13 14:00:33 -0800 Created attachment 244543 Patch 1060927 3 244543 thorton 2015-01-13 14:09:53 -0800 Comment on attachment 244543 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244543&action=review > Source/WebKit/mac/WebView/WebImmediateActionController.mm:228 > + if (customClientAnimationController == [NSNull null] || applicationIsITunes()) { I think we should avoid doing all of this work and just not install the GR if we're in iTunes. 1060945 4 bdakin 2015-01-13 14:34:30 -0800 (In reply to comment #3) > Comment on attachment 244543 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244543&action=review > > > Source/WebKit/mac/WebView/WebImmediateActionController.mm:228 > > + if (customClientAnimationController == [NSNull null] || applicationIsITunes()) { > > I think we should avoid doing all of this work and just not install the GR > if we're in iTunes. Tim and I talked about this in person. We went back and forth a few times, but ultimately decided to keep it as-is to match the SPI. http://trac.webkit.org/changeset/178378 244541 2015-01-13 13:50:18 -0800 2015-01-13 14:00:33 -0800 Patch for-review.txt text/plain 2067 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODM3MykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAxLTEz ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgZGlzYWJs ZSBpbW1lZGlhdGUgYWN0aW9ucyBmb3IgaVR1bmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDA0MDUKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5n LQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xOTQ2MTM1OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJJbW1lZGlhdGVBY3Rpb25D b250cm9sbGVyLm1tOgorICAgICAgICAoLVtXZWJJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyIGlz aVR1bmVzXSk6CisgICAgICAgICgtW1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIgX3VwZGF0 ZUltbWVkaWF0ZUFjdGlvbkl0ZW1dKToKKwogMjAxNS0wMS0xMSAgU2FtIFdlaW5pZyAgPHNhbUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBzdXBwb3J0IGZvciBTaGFyZWRXb3JrZXJzCklu ZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xs ZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJJbW1lZGlh dGVBY3Rpb25Db250cm9sbGVyLm1tCShyZXZpc2lvbiAxNzgyOTUpCisrKyBTb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29w eSkKQEAgLTU2LDYgKzU2LDggQEAKICNpbXBvcnQgPG9iamMvb2JqYy1jbGFzcy5oPgogI2ltcG9y dCA8b2JqYy9vYmpjLmg+CiAKKyNkZWZpbmUgaVR1bmVzSWRlbnRpZmllciAiY29tLmFwcGxlLmlU dW5lcyIKKwogU09GVF9MSU5LX0ZSQU1FV09SS19JTl9VTUJSRUxMQShRdWFydHosIFF1aWNrTG9v a1VJKQogU09GVF9MSU5LX0NMQVNTKFF1aWNrTG9va1VJLCBRTFByZXZpZXdNZW51SXRlbSkKIApA QCAtMjEwLDYgKzIxMiwxMSBAQCAtIChpZCA8TlNJbW1lZGlhdGVBY3Rpb25BbmltYXRpb25Db250 cm9sCiAgICAgcmV0dXJuIG5pbDsKIH0KIAorLSAoQk9PTClpc2lUdW5lcworeworICAgIHJldHVy biBbW1tOU0J1bmRsZSBtYWluQnVuZGxlXSBidW5kbGVJZGVudGlmaWVyXSBpc0VxdWFsVG9TdHJp bmc6QGlUdW5lc0lkZW50aWZpZXJdOworfQorCiAtICh2b2lkKV91cGRhdGVJbW1lZGlhdGVBY3Rp b25JdGVtCiB7CiAgICAgX3R5cGUgPSBXZWJJbW1lZGlhdGVBY3Rpb25Ob25lOwpAQCAtMjIzLDcg KzIzMCw4IEBAIC0gKHZvaWQpX3VwZGF0ZUltbWVkaWF0ZUFjdGlvbkl0ZW0KICAgICAgICAgY3Vz dG9tQ2xpZW50QW5pbWF0aW9uQ29udHJvbGxlciA9IFsoaWQpW193ZWJWaWV3IFVJRGVsZWdhdGVd IF93ZWJWaWV3Ol93ZWJWaWV3IGltbWVkaWF0ZUFjdGlvbkFuaW1hdGlvbkNvbnRyb2xsZXJGb3JI aXRUZXN0UmVzdWx0OndlYkhpdFRlc3RSZXN1bHQuZ2V0KCkgd2l0aFR5cGU6X3R5cGVdOwogICAg IH0KIAotICAgIGlmIChjdXN0b21DbGllbnRBbmltYXRpb25Db250cm9sbGVyID09IFtOU051bGwg bnVsbF0pIHsKKyAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIG5vdCBwZXJtYW5lbnRseSBkaXNhYmxl IHRoaXMgZm9yIGlUdW5lcy4gcmRhcjovL3Byb2JsZW0vMTk0NjEzNTgKKyAgICBpZiAoY3VzdG9t Q2xpZW50QW5pbWF0aW9uQ29udHJvbGxlciA9PSBbTlNOdWxsIG51bGxdIHx8IFtzZWxmIGlzaVR1 bmVzXSkgewogICAgICAgICBbc2VsZiBfY2FuY2VsSW1tZWRpYXRlQWN0aW9uXTsKICAgICAgICAg cmV0dXJuOwogICAgIH0K 244543 2015-01-13 14:00:33 -0800 2015-01-13 14:09:53 -0800 Patch for-review-2.txt text/plain 3029 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODM3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAxLTEzICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgZGlzYWJsZSBpbW1lZGlh dGUgYWN0aW9ucyBmb3IgaVR1bmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDA0MDUKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAg ICByZGFyOi8vcHJvYmxlbS8xOTQ2MTM1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisKIDIwMTUtMDEtMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgdW51c2VkIFJlc2l6ZUltYWdlIGFuZCBEZWNvZGVJbWFnZURhdGEgdGltZWxpbmUg ZXZlbnRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgkocmV2aXNpb24gMTc4Mjk1KQorKysgU291 cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTg2NSw2ICs4NjUs NyBAQCBfX1pON1dlYkNvcmUxOVRleHRSZXNvdXJjZURlY29kZXI1Zmx1c2hFCiBfX1pON1dlYkNv cmUxOVRleHRSZXNvdXJjZURlY29kZXI2ZGVjb2RlRVBLY20KIF9fWk43V2ViQ29yZTE5VGV4dFJl c291cmNlRGVjb2RlckMxRVJLTjNXVEY2U3RyaW5nRVJLTlNfMTJUZXh0RW5jb2RpbmdFYgogX19a TjdXZWJDb3JlMTlUZXh0UmVzb3VyY2VEZWNvZGVyRDFFdgorX19aTjdXZWJDb3JlMTlhcHBsaWNh dGlvbklzSVR1bmVzRXYKIF9fWk43V2ViQ29yZTE5ZW5jbG9zaW5nTGF5b3V0UmVjdEVSS05TXzlG bG9hdFJlY3RFCiBfX1pON1dlYkNvcmUxOWZsb2F0VmFsdWVGb3JMZW5ndGhFUktOU182TGVuZ3Ro RWYKIF9fWk43V2ViQ29yZTE5Z2V0RmlsZUNyZWF0aW9uVGltZUVSS04zV1RGNlN0cmluZ0VSbApJ bmRleDogU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2aXNpb24gMTc4MzczKQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDEtMTMg IEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFNob3VsZCBkaXNhYmxl IGltbWVkaWF0ZSBhY3Rpb25zIGZvciBpVHVuZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDQwNQorICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmct CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE5NDYxMzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNv bnRyb2xsZXIubW06CisgICAgICAgICgtW1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIgX3Vw ZGF0ZUltbWVkaWF0ZUFjdGlvbkl0ZW1dKToKKwogMjAxNS0wMS0xMSAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBzdXBwb3J0IGZvciBTaGFyZWRXb3JrZXJz CkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRy b2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJJbW1l ZGlhdGVBY3Rpb25Db250cm9sbGVyLm1tCShyZXZpc2lvbiAxNzgyOTUpCisrKyBTb3VyY2UvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0JKHdvcmtpbmcg Y29weSkKQEAgLTUxLDYgKzUxLDcgQEAKICNpbXBvcnQgPFdlYkNvcmUvUGFnZS5oPgogI2ltcG9y dCA8V2ViQ29yZS9SZW5kZXJFbGVtZW50Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL1JlbmRlck9iamVj dC5oPgorI2ltcG9ydCA8V2ViQ29yZS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaD4KICNpbXBv cnQgPFdlYkNvcmUvU29mdExpbmtpbmcuaD4KICNpbXBvcnQgPFdlYkNvcmUvVGV4dEluZGljYXRv ci5oPgogI2ltcG9ydCA8b2JqYy9vYmpjLWNsYXNzLmg+CkBAIC0yMjMsNyArMjI0LDggQEAgLSAo dm9pZClfdXBkYXRlSW1tZWRpYXRlQWN0aW9uSXRlbQogICAgICAgICBjdXN0b21DbGllbnRBbmlt YXRpb25Db250cm9sbGVyID0gWyhpZClbX3dlYlZpZXcgVUlEZWxlZ2F0ZV0gX3dlYlZpZXc6X3dl YlZpZXcgaW1tZWRpYXRlQWN0aW9uQW5pbWF0aW9uQ29udHJvbGxlckZvckhpdFRlc3RSZXN1bHQ6 d2ViSGl0VGVzdFJlc3VsdC5nZXQoKSB3aXRoVHlwZTpfdHlwZV07CiAgICAgfQogCi0gICAgaWYg KGN1c3RvbUNsaWVudEFuaW1hdGlvbkNvbnRyb2xsZXIgPT0gW05TTnVsbCBudWxsXSkgeworICAg IC8vIEZJWE1FOiBXZSBzaG91bGQgbm90IHBlcm1hbmVudGx5IGRpc2FibGUgdGhpcyBmb3IgaVR1 bmVzLiByZGFyOi8vcHJvYmxlbS8xOTQ2MTM1OAorICAgIGlmIChjdXN0b21DbGllbnRBbmltYXRp b25Db250cm9sbGVyID09IFtOU051bGwgbnVsbF0gfHwgYXBwbGljYXRpb25Jc0lUdW5lcygpKSB7 CiAgICAgICAgIFtzZWxmIF9jYW5jZWxJbW1lZGlhdGVBY3Rpb25dOwogICAgICAgICByZXR1cm47 CiAgICAgfQo=