140383 2015-01-12 23:00:24 -0800 Fix Debug Build Error in Webcore module 2015-01-13 05:19:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned changseok commit-queue gyuyoung.kim ossy svillar oldest_to_newest 1060771 0 shiva.jm 2015-01-12 23:00:24 -0800 Got below debug build error for 32-bit efl port: CMakeFiles/WebCore.dir/platform/linux/MemoryPressureHandlerLinux.cpp.o -c ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp In file included from ../../Source/WTF/wtf/PossiblyNull.h:29:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:27: ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp: In member function ‘void WebCore::MemoryPressureHandler::ReliefLogger::platformLog()’: ../../Source/WTF/wtf/Assertions.h:346:105: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘ssize_t {aka int}’ [-Werror=format=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:212:9: note: in expansion of macro ‘LOG’ LOG(MemoryPressure, "Pressure relief: %s: -dirty %ld bytes (from %ld to %ld)", m_logString, (memoryDiff * -1), m_initialMemory, currentMemory); ^ ../../Source/WTF/wtf/Assertions.h:346:105: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Werror=format=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:212:9: note: in expansion of macro ‘LOG’ LOG(MemoryPressure, "Pressure relief: %s: -dirty %ld bytes (from %ld to %ld)", m_logString, (memoryDiff * -1), m_initialMemory, currentMemory); ^ ../../Source/WTF/wtf/Assertions.h:346:105: error: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘size_t {aka unsigned int}’ [-Werror=format=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:212:9: note: in expansion of macro ‘LOG’ LOG(MemoryPressure, "Pressure relief: %s: -dirty %ld bytes (from %ld to %ld)", m_logString, (memoryDiff * -1), m_initialMemory, currentMemory); ^ ../../Source/WTF/wtf/Assertions.h:346:105: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘ssize_t {aka int}’ [-Werror=format=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:214:9: note: in expansion of macro ‘LOG’ LOG(MemoryPressure, "Pressure relief: %s: +dirty %ld bytes (from %ld to %ld)", m_logString, memoryDiff, m_initialMemory, currentMemory); ^ ../../Source/WTF/wtf/Assertions.h:346:105: error: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Werror=format=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:214:9: note: in expansion of macro ‘LOG’ LOG(MemoryPressure, "Pressure relief: %s: +dirty %ld bytes (from %ld to %ld)", m_logString, memoryDiff, m_initialMemory, currentMemory); ^ ../../Source/WTF/wtf/Assertions.h:346:105: error: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘size_t {aka unsigned int}’ [-Werror=format=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:214:9: note: in expansion of macro ‘LOG’ LOG(MemoryPressure, "Pressure relief: %s: +dirty %ld bytes (from %ld to %ld)", m_logString, memoryDiff, m_initialMemory, currentMemory); ^ ../../Source/WTF/wtf/Assertions.h:346:105: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘size_t {aka unsigned int}’ [-Werror=format=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:216:9: note: in expansion of macro ‘LOG’ LOG(MemoryPressure, "Pressure relief: %s: =dirty (at %ld bytes)", m_logString, currentMemory); ^ cc1plus: all warnings being treated as errors ninja: build stopped: subcommand failed. 1060772 1 244498 shiva.jm 2015-01-12 23:04:27 -0800 Created attachment 244498 Patch Fixed 32 bit debug build error by using proper format specifier. 1060777 2 shiva.jm 2015-01-13 00:45:41 -0800 Fixed 32 bit debug build error by using proper format specifier in LOG(), we can also use type cast to static_cast<long int> to fix the error. 1060781 3 244498 ossy 2015-01-13 01:30:02 -0800 Comment on attachment 244498 Patch LGTM, r=me 1060782 4 244498 ossy 2015-01-13 01:33:19 -0800 Comment on attachment 244498 Patch no, it won't be good, because it would break 64 bit build. 1060785 5 ossy 2015-01-13 01:36:43 -0800 size_t is unsigned int on 32 bit and long unsigned int on 64 bit. So it should be casted to long unsigned int unconditionally. 1060788 6 244502 shiva.jm 2015-01-13 02:03:44 -0800 Created attachment 244502 Patch-Updated-Review1 Updated the patch to use %lu and apply static_cast<unsigned long> for printing logs. 1060791 7 244502 commit-queue 2015-01-13 02:53:42 -0800 Comment on attachment 244502 Patch-Updated-Review1 Clearing flags on attachment: 244502 Committed r178349: <http://trac.webkit.org/changeset/178349> 1060792 8 commit-queue 2015-01-13 02:53:46 -0800 All reviewed patches have been landed. Closing bug. 1060808 9 changseok 2015-01-13 05:19:19 -0800 Thanks for the fix. =) I didn't think 32-bit machine support. 244498 2015-01-12 23:04:27 -0800 2015-01-13 02:03:44 -0800 Patch bug-140383.patch text/plain 2052 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODMxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTEyICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IERlYnVnIEJ1aWxk IEVycm9yIGluIFdlYmNvcmUgbW9kdWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gdmlzaWJs ZSBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9saW51eC9NZW1vcnlQcmVz c3VyZUhhbmRsZXJMaW51eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZW1vcnlQcmVzc3VyZUhh bmRsZXI6OlJlbGllZkxvZ2dlcjo6cGxhdGZvcm1Mb2cpOgorCiAyMDE1LTAxLTEyICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggYSB0eXBvIGlu IHIxNzgzMTMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xpbnV4L01lbW9yeVByZXNz dXJlSGFuZGxlckxpbnV4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9saW51eC9NZW1vcnlQcmVzc3VyZUhhbmRsZXJMaW51eC5jcHAJKHJldmlzaW9uIDE3ODMxNikK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xpbnV4L01lbW9yeVByZXNzdXJlSGFuZGxlckxp bnV4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA5LDExICsyMDksMTEgQEAgdm9pZCBNZW1vcnlQ cmVzc3VyZUhhbmRsZXI6OlJlbGllZkxvZ2dlcgogCiAgICAgc3NpemVfdCBtZW1vcnlEaWZmID0g Y3VycmVudE1lbW9yeSAtIG1faW5pdGlhbE1lbW9yeTsKICAgICBpZiAobWVtb3J5RGlmZiA8IDAp Ci0gICAgICAgIExPRyhNZW1vcnlQcmVzc3VyZSwgIlByZXNzdXJlIHJlbGllZjogJXM6IC1kaXJ0 eSAlbGQgYnl0ZXMgKGZyb20gJWxkIHRvICVsZCkiLCBtX2xvZ1N0cmluZywgKG1lbW9yeURpZmYg KiAtMSksIG1faW5pdGlhbE1lbW9yeSwgY3VycmVudE1lbW9yeSk7CisgICAgICAgIExPRyhNZW1v cnlQcmVzc3VyZSwgIlByZXNzdXJlIHJlbGllZjogJXM6IC1kaXJ0eSAlZCBieXRlcyAoZnJvbSAl ZCB0byAlZCkiLCBtX2xvZ1N0cmluZywgKG1lbW9yeURpZmYgKiAtMSksIG1faW5pdGlhbE1lbW9y eSwgY3VycmVudE1lbW9yeSk7CiAgICAgZWxzZSBpZiAobWVtb3J5RGlmZiA+IDApCi0gICAgICAg IExPRyhNZW1vcnlQcmVzc3VyZSwgIlByZXNzdXJlIHJlbGllZjogJXM6ICtkaXJ0eSAlbGQgYnl0 ZXMgKGZyb20gJWxkIHRvICVsZCkiLCBtX2xvZ1N0cmluZywgbWVtb3J5RGlmZiwgbV9pbml0aWFs TWVtb3J5LCBjdXJyZW50TWVtb3J5KTsKKyAgICAgICAgTE9HKE1lbW9yeVByZXNzdXJlLCAiUHJl c3N1cmUgcmVsaWVmOiAlczogK2RpcnR5ICVkIGJ5dGVzIChmcm9tICVkIHRvICVkKSIsIG1fbG9n U3RyaW5nLCBtZW1vcnlEaWZmLCBtX2luaXRpYWxNZW1vcnksIGN1cnJlbnRNZW1vcnkpOwogICAg IGVsc2UKLSAgICAgICAgTE9HKE1lbW9yeVByZXNzdXJlLCAiUHJlc3N1cmUgcmVsaWVmOiAlczog PWRpcnR5IChhdCAlbGQgYnl0ZXMpIiwgbV9sb2dTdHJpbmcsIGN1cnJlbnRNZW1vcnkpOworICAg ICAgICBMT0coTWVtb3J5UHJlc3N1cmUsICJQcmVzc3VyZSByZWxpZWY6ICVzOiA9ZGlydHkgKGF0 ICVkIGJ5dGVzKSIsIG1fbG9nU3RyaW5nLCBjdXJyZW50TWVtb3J5KTsKIH0KIAogc2l6ZV90IE1l bW9yeVByZXNzdXJlSGFuZGxlcjo6UmVsaWVmTG9nZ2VyOjpwbGF0Zm9ybU1lbW9yeVVzYWdlKCkK 244502 2015-01-13 02:03:44 -0800 2015-01-13 02:53:42 -0800 Patch-Updated-Review1 bug-140383-updated.patch text/plain 2253 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3ODMxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTEyICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IERlYnVnIEJ1aWxk IEVycm9yIGluIFdlYmNvcmUgbW9kdWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gdmlzaWJs ZSBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9saW51eC9NZW1vcnlQcmVz c3VyZUhhbmRsZXJMaW51eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZW1vcnlQcmVzc3VyZUhh bmRsZXI6OlJlbGllZkxvZ2dlcjo6cGxhdGZvcm1Mb2cpOgorCiAyMDE1LTAxLTEyICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggYSB0eXBvIGlu IHIxNzgzMTMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xpbnV4L01lbW9yeVByZXNz dXJlSGFuZGxlckxpbnV4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9saW51eC9NZW1vcnlQcmVzc3VyZUhhbmRsZXJMaW51eC5jcHAJKHJldmlzaW9uIDE3ODMxNikK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2xpbnV4L01lbW9yeVByZXNzdXJlSGFuZGxlckxp bnV4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA5LDExICsyMDksMTEgQEAgdm9pZCBNZW1vcnlQ cmVzc3VyZUhhbmRsZXI6OlJlbGllZkxvZ2dlcgogCiAgICAgc3NpemVfdCBtZW1vcnlEaWZmID0g Y3VycmVudE1lbW9yeSAtIG1faW5pdGlhbE1lbW9yeTsKICAgICBpZiAobWVtb3J5RGlmZiA8IDAp Ci0gICAgICAgIExPRyhNZW1vcnlQcmVzc3VyZSwgIlByZXNzdXJlIHJlbGllZjogJXM6IC1kaXJ0 eSAlbGQgYnl0ZXMgKGZyb20gJWxkIHRvICVsZCkiLCBtX2xvZ1N0cmluZywgKG1lbW9yeURpZmYg KiAtMSksIG1faW5pdGlhbE1lbW9yeSwgY3VycmVudE1lbW9yeSk7CisgICAgICAgIExPRyhNZW1v cnlQcmVzc3VyZSwgIlByZXNzdXJlIHJlbGllZjogJXM6IC1kaXJ0eSAlbHUgYnl0ZXMgKGZyb20g JWx1IHRvICVsdSkiLCBtX2xvZ1N0cmluZywgc3RhdGljX2Nhc3Q8dW5zaWduZWQgbG9uZz4obWVt b3J5RGlmZiAqIC0xKSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgbG9uZz4obV9pbml0aWFsTWVtb3J5 KSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgbG9uZz4oY3VycmVudE1lbW9yeSkpOwogICAgIGVsc2Ug aWYgKG1lbW9yeURpZmYgPiAwKQotICAgICAgICBMT0coTWVtb3J5UHJlc3N1cmUsICJQcmVzc3Vy ZSByZWxpZWY6ICVzOiArZGlydHkgJWxkIGJ5dGVzIChmcm9tICVsZCB0byAlbGQpIiwgbV9sb2dT dHJpbmcsIG1lbW9yeURpZmYsIG1faW5pdGlhbE1lbW9yeSwgY3VycmVudE1lbW9yeSk7CisgICAg ICAgIExPRyhNZW1vcnlQcmVzc3VyZSwgIlByZXNzdXJlIHJlbGllZjogJXM6ICtkaXJ0eSAlbHUg Ynl0ZXMgKGZyb20gJWx1IHRvICVsdSkiLCBtX2xvZ1N0cmluZywgc3RhdGljX2Nhc3Q8dW5zaWdu ZWQgbG9uZz4obWVtb3J5RGlmZiksIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxvbmc+KG1faW5pdGlh bE1lbW9yeSksIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxvbmc+KGN1cnJlbnRNZW1vcnkpKTsKICAg ICBlbHNlCi0gICAgICAgIExPRyhNZW1vcnlQcmVzc3VyZSwgIlByZXNzdXJlIHJlbGllZjogJXM6 ID1kaXJ0eSAoYXQgJWxkIGJ5dGVzKSIsIG1fbG9nU3RyaW5nLCBjdXJyZW50TWVtb3J5KTsKKyAg ICAgICAgTE9HKE1lbW9yeVByZXNzdXJlLCAiUHJlc3N1cmUgcmVsaWVmOiAlczogPWRpcnR5IChh dCAlbHUgYnl0ZXMpIiwgbV9sb2dTdHJpbmcsIHN0YXRpY19jYXN0PHVuc2lnbmVkIGxvbmc+KGN1 cnJlbnRNZW1vcnkpKTsKIH0KIAogc2l6ZV90IE1lbW9yeVByZXNzdXJlSGFuZGxlcjo6UmVsaWVm TG9nZ2VyOjpwbGF0Zm9ybU1lbW9yeVVzYWdlKCkK