140382 2015-01-12 21:52:45 -0800 Perf dashboard always assigns the result of A/B testing with build request 1 2015-01-23 16:24:31 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa benjamin kling oldest_to_newest 1060764 0 rniwa 2015-01-12 21:52:45 -0800 There's a subtle bug in report-processor.php that results in all A/B testing results being associated with the build request with id=1. 1060766 1 244495 rniwa 2015-01-12 22:00:29 -0800 Created attachment 244495 Fixes the bug 1063802 2 rniwa 2015-01-23 16:22:28 -0800 Thanks for the review! 1063803 3 244495 rniwa 2015-01-23 16:24:27 -0800 Comment on attachment 244495 Fixes the bug Clearing flags on attachment: 244495 Committed r179037: <http://trac.webkit.org/changeset/179037> 1063804 4 rniwa 2015-01-23 16:24:31 -0800 All reviewed patches have been landed. Closing bug. 244495 2015-01-12 22:00:29 -0800 2015-01-23 16:24:27 -0800 Fixes the bug bug-140382-20150112220034.patch text/plain 3404 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MzE1CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA3MWVlYTc2NDkwYjg5MTNiMmU0YzA0NmVlN2Y4ODZiM2U0NWJlYzBmLi4zNmNmMDRmY2Jj MzRlOGQ5ZWY1ZmUyOTY2OTEzMTAwODNjOWY5MGVhIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxNS0wMS0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBQZXJmIGRhc2hib2FyZCBhbHdheXMgYXNzaWducyB0aGUg cmVzdWx0IG9mIEEvQiB0ZXN0aW5nIHdpdGggYnVpbGQgcmVxdWVzdCAxCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDAzODIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkg dGhlIGV4cHJlc3Npb24gYXJyYXlfZ2V0KCRyZXBvcnQsICdqb2JJZCcpIG9yIGFycmF5X2dldCgk cmVwb3J0LCAnYnVpbGRSZXF1ZXN0JykKKyAgICAgICAgd2hpY2ggYWx3YXlzIGV2YWx1YXRlZCB0 byAxIHdoZW4gdGhlIHJlcG9ydCBjb250YWluZWQgam9iSWQuIEZpeGVkIHRoZSBidWcgYnkgY2Fz Y2FkaW5nIGFycmF5X2dldCBpbnN0ZWFkLgorCisgICAgICAgIEFsc28gZml4ZWQgYSB0eXBvIGFz IHdlbGwgYXMgYSBidWcgdGhhdCByZXBvcnRzIHdlcmUgbmV2ZXIgYXNzb2NpYXRlZCB3aXRoIGJ1 aWxkcy4KKworICAgICAgICAqIHB1YmxpYy9pbmNsdWRlL3JlcG9ydC1wcm9jZXNzb3IucGhwOgor ICAgICAgICAoUmVwb3J0UHJvY2Vzc29yOjpwcm9jZXNzKTogRG9uJ3QgdXNlICJvciIgdG8gZmlu ZCB0aGUgbm9uLW51bGwgdmFsdWUgc2luY2UgdGhhdCBhbHdheXMgZXZhbHVhdGVzIHRvIDEKKyAg ICAgICAgaW5zdGVhZCBvZiB0aGUgZmlyc3Qgbm9uLW51bGwgdmFsdWUuCisgICAgICAgIChSZXBv cnRQcm9jZXNzb3I6OnJlc29sdmVfYnVpbGRfaWQpOiBGaXhlZCB0aGUgdHlwbyBieSBhZGRpbmcg dGhlIG1pc3NpbmcgIiR0aGlzLT4iLgorICAgICAgICAoUmVwb3J0UHJvY2Vzc29yOjpjb21taXQp OiBBc3NvY2lhdGUgdGhlIHJlcG9ydCB3aXRoIHRoZSBjb3JyZXNwb25kaW5nIGJ1aWxkIGFzIGlu dGVuZGVkLgorCiAyMDE1LTAxLTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LiBSZW1vdmVkIHRoZSBzdGFsZSBjb2RlLgpk aWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRlL3JlcG9y dC1wcm9jZXNzb3IucGhwIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRl L3JlcG9ydC1wcm9jZXNzb3IucGhwCmluZGV4IDUyZTM1YTgzMWI4NmQ0ODYxMjc3ZmI3NTU3Nzk1 ZDQ4Y2RjNjMyZDUuLmQxZDNhNmEzZDIyMTUxMDUwYmUzM2ExNzg3YzUyYTJkNzFmYTA2OGUgMTAw NjQ0Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9yZXBvcnQt cHJvY2Vzc29yLnBocAorKysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1 ZGUvcmVwb3J0LXByb2Nlc3Nvci5waHAKQEAgLTkwLDcgKzkwLDcgQEAgY2xhc3MgUmVwb3J0UHJv Y2Vzc29yIHsKIAogICAgICAgICAvLyBGSVhNRTogRGVwcmVjYXRlIGFuZCB1bnN1cHBvcnQgImpv YklkIi4KICAgICAgICAgJGJ1aWxkX2lkID0gJHRoaXMtPnJlc29sdmVfYnVpbGRfaWQoJGJ1aWxk X2RhdGEsIGFycmF5X2dldCgkcmVwb3J0LCAncmV2aXNpb25zJywgYXJyYXkoKSksCi0gICAgICAg ICAgICBhcnJheV9nZXQoJHJlcG9ydCwgJ2pvYklkJykgb3IgYXJyYXlfZ2V0KCRyZXBvcnQsICdi dWlsZFJlcXVlc3QnKSk7CisgICAgICAgICAgICBhcnJheV9nZXQoJHJlcG9ydCwgJ2pvYklkJywg YXJyYXlfZ2V0KCRyZXBvcnQsICdidWlsZFJlcXVlc3QnKSkpOwogCiAgICAgICAgICR0aGlzLT5y dW5zLT5jb21taXQoJHBsYXRmb3JtX2lkLCAkYnVpbGRfaWQpOwogICAgIH0KQEAgLTEyOSw3ICsx MjksNyBAQCBjbGFzcyBSZXBvcnRQcm9jZXNzb3IgewogICAgICAgICAgICAgJHRoaXMtPmV4aXRf d2l0aF9lcnJvcignRmFpbGVkVG9JbnNlcnRCdWlsZCcsICRidWlsZF9kYXRhKTsKIAogICAgICAg ICBpZiAoJGJ1aWxkX3JlcXVlc3RfaWQpIHsKLSAgICAgICAgICAgIGlmICgkZGItPnVwZGF0ZV9y b3coJ2J1aWxkX3JlcXVlc3RzJywgJ3JlcXVlc3QnLCBhcnJheSgnaWQnID0+ICRidWlsZF9yZXF1 ZXN0X2lkKSwgYXJyYXkoJ3N0YXR1cycgPT4gJ2NvbXBsZXRlZCcsICdidWlsZCcgPT4gJGJ1aWxk X2lkKSkKKyAgICAgICAgICAgIGlmICgkdGhpcy0+ZGItPnVwZGF0ZV9yb3coJ2J1aWxkX3JlcXVl c3RzJywgJ3JlcXVlc3QnLCBhcnJheSgnaWQnID0+ICRidWlsZF9yZXF1ZXN0X2lkKSwgYXJyYXko J3N0YXR1cycgPT4gJ2NvbXBsZXRlZCcsICdidWlsZCcgPT4gJGJ1aWxkX2lkKSkKICAgICAgICAg ICAgICAgICAhPSAkYnVpbGRfcmVxdWVzdF9pZCkKICAgICAgICAgICAgICAgICAkdGhpcy0+ZXhp dF93aXRoX2Vycm9yKCdGYWlsZWRUb1VwZGF0ZUJ1aWxkUmVxdWVzdCcsIGFycmF5KCdidWlsZFJl cXVlc3QnID0+ICRidWlsZF9yZXF1ZXN0X2lkLCAnYnVpbGQnID0+ICRidWlsZF9pZCkpOwogICAg ICAgICB9CkBAIC00MzksOCArNDM5LDkgQEAgY2xhc3MgVGVzdFJ1bnNHZW5lcmF0b3IgewogICAg ICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgJHRoaXMtPmRiLT5xdWVyeV9hbmRfZ2V0 X2FmZmVjdGVkX3Jvd3MoIlVQREFURSByZXBvcnRzIFNFVCByZXBvcnRfY29tbWl0dGVkX2F0ID0g Q1VSUkVOVF9USU1FU1RBTVAgQVQgVElNRSBaT05FICdVVEMnCi0gICAgICAgICAgICBXSEVSRSBy ZXBvcnRfaWQgPSAkMSIsIGFycmF5KCR0aGlzLT5yZXBvcnRfaWQpKTsKKyAgICAgICAgJHRoaXMt PmRiLT5xdWVyeV9hbmRfZ2V0X2FmZmVjdGVkX3Jvd3MoIlVQREFURSByZXBvcnRzCisgICAgICAg ICAgICBTRVQgKHJlcG9ydF9jb21taXR0ZWRfYXQsIHJlcG9ydF9idWlsZCkgPSAoQ1VSUkVOVF9U SU1FU1RBTVAgQVQgVElNRSBaT05FICdVVEMnLCAkMikKKyAgICAgICAgICAgIFdIRVJFIHJlcG9y dF9pZCA9ICQxIiwgYXJyYXkoJHRoaXMtPnJlcG9ydF9pZCwgJGJ1aWxkX2lkKSk7CiAKICAgICAg ICAgJHRoaXMtPmRiLT5jb21taXRfdHJhbnNhY3Rpb24oKSBvciAkdGhpcy0+ZXhpdF93aXRoX2Vy cm9yKCdGYWlsZWRUb0NvbW1pdFRyYW5zYWN0aW9uJyk7CiAgICAgfQo=