140367 2015-01-12 12:12:50 -0800 Web Inspector: ASSERT under WebCore::InspectorResourceAgent::loadResource 2015-01-12 14:03:01 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck burg burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1060617 0 joepeck 2015-01-12 12:12:50 -0800 * SUMMARY Seeing reports of an assertion in Network.loadRequest (used to load SourceMap resources). ASSERTION FAILED: m_ptr Ref.h(92) : T *WTF::Ref<Inspector::InspectorNetworkBackendDispatcherHandler::LoadResourceCallback>::operator->() [T = Inspector::InspectorNetworkBackendDispatcherHandler::LoadResourceCallback] 1 0x10dadfb40 WTFCrash 2 0x10fdd3bc5 WTF::Ref<Inspector::InspectorNetworkBackendDispatcherHandler::LoadResourceCallback>::operator->() 3 0x10fdd18f1 WebCore::InspectorResourceAgent::loadResource(WTF::String&, WTF::String const&, WTF::String const&, WTF::Ref<Inspector::InspectorNetworkBackendDispatcherHandler::LoadResourceCallback>&&) 4 0x10fdd1ad7 non-virtual thunk to WebCore::InspectorResourceAgent::loadResource(WTF::String&, WTF::String const&, WTF::String const&, WTF::Ref<Inspector::InspectorNetworkBackendDispatcherHandler::LoadResourceCallback>&&) 5 0x10d6c8b57 Inspector::InspectorNetworkBackendDispatcher::loadResource(long, Inspector::InspectorObject const&) 6 0x10d6c7580 Inspector::InspectorNetworkBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) 7 0x10d688e99 Inspector::InspectorBackendDispatcher::dispatch(WTF::String const&) 8 0x10fd13901 WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 9 0x10ac01661 WebKit::WebInspector::sendMessageToBackend(WTF::String const&) 10 0x10ac0c21f void IPC::callMemberFunctionImpl<WebKit::WebInspector, void (WebKit::WebInspector::*)(WTF::String const&), std::__1::tuple<WTF::String>, 0ul>(WebKit::WebInspector*, void (WebKit::WebInspector::*)(WTF::String const&), std::__1::tuple<WTF::String>&&, std::index_sequence<0ul>) 11 0x10ac0c178 void IPC::callMemberFunction<WebKit::WebInspector, void (WebKit::WebInspector::*)(WTF::String const&), std::__1::tuple<WTF::String>, std::make_index_sequence<1ul> >(std::__1::tuple<WTF::String>&&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(WTF::String const&)) * NOTES Possible reason for the crash, using a Ref after WTF::move: void InspectorResourceAgent::loadResource(ErrorString& errorString, const String& frameId, const String& urlString, Ref<LoadResourceCallback>&& callback) { ... InspectorThreadableLoaderClient* inspectorThreadableLoaderClient = new InspectorThreadableLoaderClient(WTF::move(callback)); ... if (!callback->isActive()) return; ... } 1060618 1 joepeck 2015-01-12 12:13:05 -0800 <rdar://problem/19444300> 1060641 2 244460 burg 2015-01-12 12:58:54 -0800 Created attachment 244460 Patch 1060642 3 244460 kling 2015-01-12 13:02:08 -0800 Comment on attachment 244460 Patch r=me 1060667 4 244460 commit-queue 2015-01-12 14:02:56 -0800 Comment on attachment 244460 Patch Clearing flags on attachment: 244460 Committed r178297: <http://trac.webkit.org/changeset/178297> 1060668 5 commit-queue 2015-01-12 14:03:01 -0800 All reviewed patches have been landed. Closing bug. 244460 2015-01-12 12:58:54 -0800 2015-01-12 14:02:56 -0800 Patch bug-140367-20150112125834.patch text/plain 1847 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y5OGI2MjkyYzdlYjI2 MWYzMjBmYWU1NDQ5NThjOWI0MTgxYjEwYi4uMTVmMjM2YTZhY2U5MGYwNDRjYmQxNDIyMjU3NzM3 M2Q0Y2RjOTFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAxLTEyICBCcmlh biBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBBU1NFUlQgdW5kZXIgV2ViQ29yZTo6SW5zcGVjdG9yUmVzb3VyY2VBZ2VudDo6bG9hZFJl c291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDAzNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGluc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvclJlc291cmNlQWdlbnQ6OmxvYWRSZXNvdXJjZSk6IHVzZSBjb3B5UmVmKCkgaW5z dGVhZCBvZiBtb3ZlKCksCisgICAgICAgIHNpbmNlIHdlIGNoZWNrIHRoZSBjYWxsYmFjayBhZnRl ciBnaXZpbmcgaXQgdG8gdGhlIGxvYWRlciBjbGllbnQuCisKIDIwMTUtMDEtMTIgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIENsZWFuIHVwIEZyYW1lVHJl ZTo6dHJhdmVyc2VOZXh0KCkgdHJhdmVyc2FscyBvZiBtYWluIGZyYW1lcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwCmluZGV4IGIw MDIyNmVhMTE3ZjlhM2NmYjdkMzlhN2I3ZjY4YTk2ZGVkNDMxY2EuLjRjZWZlNGFmN2E3YTFmNzk2 MDkyMDZhN2FkMmIzMTk5YWJiNmY4NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHAKQEAgLTc3MCw3ICs3NzAsNyBAQCB2b2lk IEluc3BlY3RvclJlc291cmNlQWdlbnQ6OmxvYWRSZXNvdXJjZShFcnJvclN0cmluZyYgZXJyb3JT dHJpbmcsIGNvbnN0IFN0cmluZwogICAgIG9wdGlvbnMuY3Jvc3NPcmlnaW5SZXF1ZXN0UG9saWN5 ID0gQWxsb3dDcm9zc09yaWdpblJlcXVlc3RzOwogCiAgICAgLy8gSW5zcGVjdG9yVGhyZWFkYWJs ZUxvYWRlckNsaWVudCBkZWxldGVzIGl0c2VsZiB3aGVuIHRoZSBsb2FkIGNvbXBsZXRlcy4KLSAg ICBJbnNwZWN0b3JUaHJlYWRhYmxlTG9hZGVyQ2xpZW50KiBpbnNwZWN0b3JUaHJlYWRhYmxlTG9h ZGVyQ2xpZW50ID0gbmV3IEluc3BlY3RvclRocmVhZGFibGVMb2FkZXJDbGllbnQoV1RGOjptb3Zl KGNhbGxiYWNrKSk7CisgICAgSW5zcGVjdG9yVGhyZWFkYWJsZUxvYWRlckNsaWVudCogaW5zcGVj dG9yVGhyZWFkYWJsZUxvYWRlckNsaWVudCA9IG5ldyBJbnNwZWN0b3JUaHJlYWRhYmxlTG9hZGVy Q2xpZW50KGNhbGxiYWNrLmNvcHlSZWYoKSk7CiAKICAgICBSZWZQdHI8RG9jdW1lbnRUaHJlYWRh YmxlTG9hZGVyPiBsb2FkZXIgPSBEb2N1bWVudFRocmVhZGFibGVMb2FkZXI6OmNyZWF0ZSgqZG9j dW1lbnQsICppbnNwZWN0b3JUaHJlYWRhYmxlTG9hZGVyQ2xpZW50LCByZXF1ZXN0LCBvcHRpb25z KTsKICAgICBpZiAoIWxvYWRlcikgewo=