140354 2015-01-12 03:05:31 -0800 [GTK] Do not schedule a redraw for the redirected XComposite window when not in accelerated compositing mode 2015-01-14 01:03:44 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 140352 1 cgarcia webkit-unassigned gustavo mrobinson zan oldest_to_newest 1060537 0 cgarcia 2015-01-12 03:05:31 -0800 The RedirectedXCompositeWindow uses XDamage to be notified when the XWindow has been modified. Since the redirected window is created unconditionally we always receive a XDamage notify when the window is mapped, and we schedule a redraw in the web view even when the web view is not in accelerated compositing mode. 1060538 1 244439 cgarcia 2015-01-12 03:08:22 -0800 Created attachment 244439 Patch This applies on top of patch attached to bug #140352 1060571 2 244439 mrobinson 2015-01-12 09:08:47 -0800 Comment on attachment 244439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244439&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:326 > + DrawingAreaProxyImpl* drawingArea = static_cast<DrawingAreaProxyImpl*>(webView->priv->pageProxy->drawingArea()); Loosk like you could use priv here? 1060593 3 244439 cgarcia 2015-01-12 10:32:14 -0800 Comment on attachment 244439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244439&action=review Thanks for the review! >> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:326 >> + DrawingAreaProxyImpl* drawingArea = static_cast<DrawingAreaProxyImpl*>(webView->priv->pageProxy->drawingArea()); > > Loosk like you could use priv here? No, priv is not captured. 1060595 4 244439 mrobinson 2015-01-12 10:38:27 -0800 Comment on attachment 244439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244439&action=review >>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:326 >>> + DrawingAreaProxyImpl* drawingArea = static_cast<DrawingAreaProxyImpl*>(webView->priv->pageProxy->drawingArea()); >> >> Loosk like you could use priv here? > > No, priv is not captured. Could you could capture priv here instead? 1060596 5 mrobinson 2015-01-12 10:38:56 -0800 (In reply to comment #4) > Comment on attachment 244439 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244439&action=review > > >>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:326 > >>> + DrawingAreaProxyImpl* drawingArea = static_cast<DrawingAreaProxyImpl*>(webView->priv->pageProxy->drawingArea()); > >> > >> Loosk like you could use priv here? > > > > No, priv is not captured. > > Could you could capture priv here instead? Or, I suppose capture both priv and webView. 1060598 6 cgarcia 2015-01-12 10:45:21 -0800 (In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 244439 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=244439&action=review > > > > >>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:326 > > >>> + DrawingAreaProxyImpl* drawingArea = static_cast<DrawingAreaProxyImpl*>(webView->priv->pageProxy->drawingArea()); > > >> > > >> Loosk like you could use priv here? > > > > > > No, priv is not captured. > > > > Could you could capture priv here instead? > > Or, I suppose capture both priv and webView. I need the webview to call gtk_widget_queue_draw. I could capture the priv, but I don't think it's worth it, since priv is already part of web view (so capturing a single pointer is enough), and the only benefit would be saving 7 characters inside the lambda to add 9 more to the capture []. 1061119 7 cgarcia 2015-01-14 01:03:44 -0800 Committed r178415: <http://trac.webkit.org/changeset/178415> 244439 2015-01-12 03:08:22 -0800 2015-01-12 09:08:47 -0800 Patch wk2-no-redraw-for-ac.diff text/plain 3767 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyZjk2Y2E4Li41MDc5NDExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTUtMDEtMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIERvIG5vdCBzY2hlZHVsZSBhIHJlZHJhdyBmb3IgdGhlIHJlZGly ZWN0ZWQgWENvbXBvc2l0ZSB3aW5kb3cgd2hlbiBub3QgaW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRp bmcgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQwMzU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93IHVzZXMgWERhbWFnZSB0byBiZSBub3RpZmll ZCB3aGVuCisgICAgICAgIHRoZSBYV2luZG93IGhhcyBiZWVuIG1vZGlmaWVkLiBTaW5jZSB0aGUg cmVkaXJlY3RlZCB3aW5kb3cgaXMKKyAgICAgICAgY3JlYXRlZCB1bmNvbmRpdGlvbmFsbHkgd2Ug YWx3YXlzIHJlY2VpdmUgYSBYRGFtYWdlIG5vdGlmeSB3aGVuCisgICAgICAgIHRoZSB3aW5kb3cg aXMgbWFwcGVkLCBhbmQgd2Ugc2NoZWR1bGUgYSByZWRyYXcgaW4gdGhlIHdlYiB2aWV3CisgICAg ICAgIGV2ZW4gd2hlbiB0aGUgd2ViIHZpZXcgaXMgbm90IGluIGFjY2VsZXJhdGVkIGNvbXBvc2l0 aW5nIG1vZGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUpOiBPbmx5IGNhbGwgZ3Rr X3dpZGdldF9xdWV1ZV9kcmF3KCkgd2hlbgorICAgICAgICBpbiBhY2NlbGVyYXRlZCBjb21wb3Np dGluZyBtb2RlLgorCisyMDE1LTAxLTEyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBEbyBub3QgcmVzaXplIHRoZSByZWRpcmVjdGVk IFhDb21wb3NpdGUgd2luZG93IHdoZW4gbm90IGluIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1v ZGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MDM1 MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3QmFzZS5jcHAKaW5kZXggMTNjNzQ3MS4uMDNiNjdiMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAt MzExLDI0ICszMTEsMjcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VTZXRUb3BsZXZl bE9uU2NyZWVuV2luZG93KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWUKIAogc3RhdGljIHZvaWQg d2Via2l0V2ViVmlld0Jhc2VSZWFsaXplKEd0a1dpZGdldCogd2lkZ2V0KQogeworICAgIFdlYktp dFdlYlZpZXdCYXNlKiB3ZWJWaWV3ID0gV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2lkZ2V0KTsKKyAg ICBXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJWaWV3LT5wcml2OworCiAjaWYg VVNFKFRFWFRVUkVfTUFQUEVSX0dMKSAmJiBQTEFURk9STShYMTEpCiAgICAgR2RrRGlzcGxheSog ZGlzcGxheSA9IGdka19kaXNwbGF5X21hbmFnZXJfZ2V0X2RlZmF1bHRfZGlzcGxheShnZGtfZGlz cGxheV9tYW5hZ2VyX2dldCgpKTsKICAgICBpZiAoR0RLX0lTX1gxMV9ESVNQTEFZKGRpc3BsYXkp KSB7Ci0gICAgICAgIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJpdiA9IFdFQktJVF9XRUJf VklFV19CQVNFKHdpZGdldCktPnByaXY7Ci0gICAgICAgIEdka1dpbmRvdyogcGFyZW50V2luZG93 ID0gZ3RrX3dpZGdldF9nZXRfcGFyZW50X3dpbmRvdyh3aWRnZXQpOwotICAgICAgICBHZGtWaXN1 YWwqIHZpc3VhbCA9IGdka193aW5kb3dfZ2V0X3Zpc3VhbChwYXJlbnRXaW5kb3cpOworICAgICAg ICBHZGtWaXN1YWwqIHZpc3VhbCA9IGdka193aW5kb3dfZ2V0X3Zpc3VhbChndGtfd2lkZ2V0X2dl dF9wYXJlbnRfd2luZG93KHdpZGdldCkpOwogICAgICAgICBwcml2LT5yZWRpcmVjdGVkV2luZG93 ID0gUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OmNyZWF0ZSgKICAgICAgICAgICAgIEdES19E SVNQTEFZX1hESVNQTEFZKGRpc3BsYXkpLAogICAgICAgICAgICAgR0RLX1ZJU1VBTF9YVklTVUFM KHZpc3VhbCksCiAgICAgICAgICAgICBnZGtfdmlzdWFsX2dldF9kZXB0aCh2aXN1YWwpLAotICAg ICAgICAgICAgW3dpZGdldF0gewotICAgICAgICAgICAgICAgIGd0a193aWRnZXRfcXVldWVfZHJh dyh3aWRnZXQpOworICAgICAgICAgICAgW3dlYlZpZXddIHsKKyAgICAgICAgICAgICAgICBEcmF3 aW5nQXJlYVByb3h5SW1wbCogZHJhd2luZ0FyZWEgPSBzdGF0aWNfY2FzdDxEcmF3aW5nQXJlYVBy b3h5SW1wbCo+KHdlYlZpZXctPnByaXYtPnBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKSk7CisgICAg ICAgICAgICAgICAgaWYgKGRyYXdpbmdBcmVhICYmIGRyYXdpbmdBcmVhLT5pc0luQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGUoKSkKKyAgICAgICAgICAgICAgICAgICAgZ3RrX3dpZGdldF9xdWV1 ZV9kcmF3KEdUS19XSURHRVQod2ViVmlldykpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIGlm IChwcml2LT5yZWRpcmVjdGVkV2luZG93KSB7CiAgICAgICAgICAgICBEcmF3aW5nQXJlYVByb3h5 SW1wbCogZHJhd2luZ0FyZWEgPSBzdGF0aWNfY2FzdDxEcmF3aW5nQXJlYVByb3h5SW1wbCo+KHBy aXYtPnBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKSk7CiAgICAgICAgICAgICBkcmF3aW5nQXJlYS0+ c2V0TmF0aXZlU3VyZmFjZUhhbmRsZUZvckNvbXBvc2l0aW5nKHByaXYtPnJlZGlyZWN0ZWRXaW5k b3ctPndpbmRvd0lEKCkpOwogICAgICAgICB9Ci0gICAgICAgIHdlYmtpdFdlYlZpZXdCYXNlVXBk YXRlUHJlZmVyZW5jZXMoV0VCS0lUX1dFQl9WSUVXX0JBU0Uod2lkZ2V0KSk7CisgICAgICAgIHdl YmtpdFdlYlZpZXdCYXNlVXBkYXRlUHJlZmVyZW5jZXMod2ViVmlldyk7CiAgICAgfQogI2VuZGlm CiAKQEAgLTM2OCw4ICszNzEsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVJlYWxp emUoR3RrV2lkZ2V0KiB3aWRnZXQpCiAKICAgICBndGtfc3R5bGVfY29udGV4dF9zZXRfYmFja2dy b3VuZChndGtfd2lkZ2V0X2dldF9zdHlsZV9jb250ZXh0KHdpZGdldCksIHdpbmRvdyk7CiAKLSAg ICBXZWJLaXRXZWJWaWV3QmFzZSogd2ViVmlldyA9IFdFQktJVF9XRUJfVklFV19CQVNFKHdpZGdl dCk7Ci0gICAgZ3RrX2ltX2NvbnRleHRfc2V0X2NsaWVudF93aW5kb3cod2ViVmlldy0+cHJpdi0+ aW5wdXRNZXRob2RGaWx0ZXIuY29udGV4dCgpLCB3aW5kb3cpOworICAgIGd0a19pbV9jb250ZXh0 X3NldF9jbGllbnRfd2luZG93KHByaXYtPmlucHV0TWV0aG9kRmlsdGVyLmNvbnRleHQoKSwgd2lu ZG93KTsKIAogICAgIEd0a1dpZGdldCogdG9wbGV2ZWwgPSBndGtfd2lkZ2V0X2dldF90b3BsZXZl bCh3aWRnZXQpOwogICAgIGlmICh3aWRnZXRJc09uc2NyZWVuVG9wbGV2ZWxXaW5kb3codG9wbGV2 ZWwpKQo=