140353 2015-01-12 02:40:09 -0800 [GTK] Do not resize the redirected XComposite window when not in accelerated compositing mode 2015-01-14 01:00:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson zan oldest_to_newest 1060532 0 cgarcia 2015-01-12 02:40:09 -0800 We create the redirected XComposite window unconditionally, but with a size of 1x1 to save memory. However, we are always resizing it, so in the end we always end up with a XWindow allocated for the same size of the web view, even for web views that never enter in AC mode. 1060535 1 244438 cgarcia 2015-01-12 02:46:24 -0800 Created attachment 244438 Patch Before this patch a MiniBrowser opened with the default size and URL required 11.2MB, and with the patch it requires 9.5MB. 1060536 2 commit-queue 2015-01-12 02:48:50 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1061118 3 cgarcia 2015-01-14 01:00:21 -0800 Committed r178414: <http://trac.webkit.org/changeset/178414> 244438 2015-01-12 02:46:24 -0800 2015-01-12 07:46:30 -0800 Patch wk2-keep-redirected-window-size.diff text/plain 4170 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZDc5OTU4Li4yZjk2Y2E4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTUtMDEtMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIERvIG5vdCByZXNpemUgdGhlIHJlZGlyZWN0ZWQgWENvbXBvc2l0 ZSB3aW5kb3cgd2hlbiBub3QgaW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9kZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMzUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY3JlYXRlIHRoZSBy ZWRpcmVjdGVkIFhDb21wb3NpdGUgd2luZG93IHVuY29uZGl0aW9uYWxseSwgYnV0CisgICAgICAg IHdpdGggYSBzaXplIG9mIDF4MSB0byBzYXZlIG1lbW9yeS4gSG93ZXZlciwgd2UgYXJlIGFsd2F5 cyByZXNpemluZworICAgICAgICBpdCwgc28gaW4gdGhlIGVuZCB3ZSBhbHdheXMgZW5kIHVwIHdp dGggYSBYV2luZG93IGFsbG9jYXRlZCBmb3IKKyAgICAgICAgdGhlIHNhbWUgc2l6ZSBvZiB0aGUg d2ViIHZpZXcsIGV2ZW4gZm9yIHdlYiB2aWV3cyB0aGF0IG5ldmVyIGVudGVyCisgICAgICAgIGlu IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1vZGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3UmVuZGVy QWNjZWxlcmF0ZWRDb21wb3NpdGluZ1Jlc3VsdHMpOiBSZXNpemUgdGhlCisgICAgICAgIFJlZGly ZWN0ZWRYQ29tcG9zaXRlV2luZG93IHRvIHRoZSBjdXJyZW50IHdlYiB2aWV3IHNpemUgdG8gZW5z dXJlCisgICAgICAgIHRoZSBzaXplcyBtYXRjaCBiZWZvcmUgZHJhd2luZy4KKyAgICAgICAgKHJl c2l6ZVdlYktpdFdlYlZpZXdCYXNlRnJvbUFsbG9jYXRpb24pOiBPbmx5IHJlc2l6ZSB0aGUKKyAg ICAgICAgUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cgd2hlbiBpbiBhY2NlbGVyYXRlZCBjb21w b3NpdGluZyBtb2RlLgorICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvUmVkaXJlY3RlZFhDb21wb3Np dGVXaW5kb3cuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRv dzo6cmVzaXplKTogUmV0dXJuIGVhcmx5IGlmIHRoZQorICAgICAgICBnaXZlbiBzaXplIGlzIHRo ZSBjdXJyZW50IHNpemUuCisKKzIwMTUtMDEtMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJFR1JFU1NJT04ocjE3NzA3NSk6IEZsaWNrZXJp bmcgd2hlbiB0aGUgV2ViVmlldyBpcyByZWFsaXplZAogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQwMzUyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCBlNDBlZjc4 Li4xM2M3NDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC01MTAsNiArNTEwLDggQEAgc3RhdGljIHZvaWQg d2Via2l0V2ViVmlld0Jhc2VDb25zdHJ1Y3RlZChHT2JqZWN0KiBvYmplY3QpCiAjaWYgVVNFKFRF WFRVUkVfTUFQUEVSX0dMKQogc3RhdGljIGJvb2wgd2Via2l0V2ViVmlld1JlbmRlckFjY2VsZXJh dGVkQ29tcG9zaXRpbmdSZXN1bHRzKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgRHJh d2luZ0FyZWFQcm94eUltcGwqIGRyYXdpbmdBcmVhLCBjYWlyb190KiBjciwgR2RrUmVjdGFuZ2xl KiBjbGlwUmVjdCkKIHsKKyAgICBBU1NFUlQoZHJhd2luZ0FyZWEpOworCiAgICAgaWYgKCFkcmF3 aW5nQXJlYS0+aXNJbkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIApAQCAtNTIwLDYgKzUyMiw4IEBAIHN0YXRpYyBib29sIHdlYmtpdFdlYlZpZXdS ZW5kZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nUmVzdWx0cyhXZWJLaXRXZWJWaWV3QmFzZSoKICAg ICBpZiAoIXByaXYtPnJlZGlyZWN0ZWRXaW5kb3cpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAor ICAgIHByaXYtPnJlZGlyZWN0ZWRXaW5kb3ctPnJlc2l6ZShkcmF3aW5nQXJlYS0+c2l6ZSgpKTsK KwogICAgIGlmIChjYWlyb19zdXJmYWNlX3QqIHN1cmZhY2UgPSBwcml2LT5yZWRpcmVjdGVkV2lu ZG93LT5zdXJmYWNlKCkpIHsKICAgICAgICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCBjbGlwUmVjdC0+ eCwgY2xpcFJlY3QtPnksIGNsaXBSZWN0LT53aWR0aCwgY2xpcFJlY3QtPmhlaWdodCk7CiAgICAg ICAgIGNhaXJvX3NldF9zb3VyY2Vfc3VyZmFjZShjciwgc3VyZmFjZSwgMCwgMCk7CkBAIC02MjIs MTMgKzYyNiwxNSBAQCBzdGF0aWMgdm9pZCByZXNpemVXZWJLaXRXZWJWaWV3QmFzZUZyb21BbGxv Y2F0aW9uKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZQogICAgICAgICBndGtfd2lkZ2V0 X3NpemVfYWxsb2NhdGUocHJpdi0+YXV0aGVudGljYXRpb25EaWFsb2csICZjaGlsZEFsbG9jYXRp b24pOwogICAgIH0KIAorICAgIERyYXdpbmdBcmVhUHJveHlJbXBsKiBkcmF3aW5nQXJlYSA9IHN0 YXRpY19jYXN0PERyYXdpbmdBcmVhUHJveHlJbXBsKj4ocHJpdi0+cGFnZVByb3h5LT5kcmF3aW5n QXJlYSgpKTsKKwogI2lmIFVTRShURVhUVVJFX01BUFBFUl9HTCkgJiYgUExBVEZPUk0oWDExKQot ICAgIGlmIChzaXplQ2hhbmdlZCAmJiB3ZWJWaWV3QmFzZS0+cHJpdi0+cmVkaXJlY3RlZFdpbmRv dykKLSAgICAgICAgd2ViVmlld0Jhc2UtPnByaXYtPnJlZGlyZWN0ZWRXaW5kb3ctPnJlc2l6ZSh2 aWV3UmVjdC5zaXplKCkpOworICAgIGlmIChzaXplQ2hhbmdlZCAmJiBwcml2LT5yZWRpcmVjdGVk V2luZG93ICYmIGRyYXdpbmdBcmVhICYmIGRyYXdpbmdBcmVhLT5pc0luQWNjZWxlcmF0ZWRDb21w b3NpdGluZ01vZGUoKSkKKyAgICAgICAgcHJpdi0+cmVkaXJlY3RlZFdpbmRvdy0+cmVzaXplKHZp ZXdSZWN0LnNpemUoKSk7CiAjZW5kaWYKIAotICAgIGlmIChwcml2LT5wYWdlUHJveHktPmRyYXdp bmdBcmVhKCkpCi0gICAgICAgIHByaXYtPnBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKS0+c2V0U2l6 ZSh2aWV3UmVjdC5zaXplKCksIEludFNpemUoKSwgSW50U2l6ZSgpKTsKKyAgICBpZiAoZHJhd2lu Z0FyZWEpCisgICAgICAgIGRyYXdpbmdBcmVhLT5zZXRTaXplKHZpZXdSZWN0LnNpemUoKSwgSW50 U2l6ZSgpLCBJbnRTaXplKCkpOwogCiAjaWYgIUdUS19DSEVDS19WRVJTSU9OKDMsIDEzLCA0KQog ICAgIHdlYmtpdFdlYlZpZXdCYXNlTm90aWZ5UmVzaXplclNpemUod2ViVmlld0Jhc2UpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0 ZVdpbmRvdy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1JlZGlyZWN0ZWRYQ29t cG9zaXRlV2luZG93LmNwcAppbmRleCAyOWY5MDcyYS4uOTUyNTBkMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdp bmRvdy5jcHAKQEAgLTIwNSw2ICsyMDUsOSBAQCBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6 flJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93KCkKIAogdm9pZCBSZWRpcmVjdGVkWENvbXBvc2l0 ZVdpbmRvdzo6cmVzaXplKGNvbnN0IEludFNpemUmIHNpemUpCiB7CisgICAgaWYgKHNpemUgPT0g bV9zaXplKQorICAgICAgICByZXR1cm47CisKICAgICBYUmVzaXplV2luZG93KG1fZGlzcGxheSwg bV93aW5kb3csIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSk7CiAgICAgWEZsdXNoKG1fZGlz cGxheSk7CiAK