<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>140346</bug_id>
          
          <creation_ts>2015-01-11 19:22:17 -0800</creation_ts>
          <short_desc>Enable Vector bounds checking for ElementDescendantIterator.</short_desc>
          <delta_ts>2016-02-19 15:04:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=154477</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andreas Kling">kling</reporter>
          <assigned_to name="Andreas Kling">kling</assigned_to>
          <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>kangil.han</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1060506</commentid>
    <comment_count>0</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-01-11 19:22:17 -0800</bug_when>
    <thetext>I had originally disabled Vector bounds checking for ElementDescendantIterator&apos;s internal ancestor stack, but upon re-running performance benchmarks, it appears to have little-to-no measurable benefit.

Let&apos;s add it back.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1060507</commentid>
    <comment_count>1</comment_count>
      <attachid>244430</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-01-11 19:24:10 -0800</bug_when>
    <thetext>Created attachment 244430
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1060509</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2015-01-11 20:12:49 -0800</bug_when>
    <thetext>Thank you!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1060510</commentid>
    <comment_count>3</comment_count>
      <attachid>244430</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-01-11 20:33:38 -0800</bug_when>
    <thetext>Comment on attachment 244430
Patch

Clearing flags on attachment: 244430

Committed r178253: &lt;http://trac.webkit.org/changeset/178253&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1060511</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-01-11 20:33:43 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>244430</attachid>
            <date>2015-01-11 19:24:10 -0800</date>
            <delta_ts>2015-01-11 20:33:38 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-140346.diff</filename>
            <type>text/plain</type>
            <size>1339</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBlMjljMGVkLi44YTMxMGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg
QEAKKzIwMTUtMDEtMTEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg
ICAgIEVuYWJsZSBWZWN0b3IgYm91bmRzIGNoZWNraW5nIGZvciBFbGVtZW50RGVzY2VuZGFudEl0
ZXJhdG9yLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQwMzQ2PgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgaGFkIG9yaWdpbmFsbHkg
ZGlzYWJsZWQgVmVjdG9yIGJvdW5kcyBjaGVja2luZyBmb3IKKyAgICAgICAgRWxlbWVudERlc2Nl
bmRhbnRJdGVyYXRvcidzIGludGVybmFsIGFuY2VzdG9yIHN0YWNrLCBidXQgdXBvbgorICAgICAg
ICByZS1ydW5uaW5nIHBlcmZvcm1hbmNlIGJlbmNobWFya3MsIGl0IGFwcGVhcnMgdG8gaGF2ZSBs
aXR0bGUtdG8tbm8KKyAgICAgICAgbWVhc3VyYWJsZSBiZW5lZml0LgorCisgICAgICAgIFRoaXMg
Y2hhbmdlIGFkZHMgYmFjayB0aGUgYm91bmRzIGNoZWNraW5nLgorCisgICAgICAgICogZG9tL0Vs
ZW1lbnREZXNjZW5kYW50SXRlcmF0b3IuaDoKKwogMjAxNS0wMS0xMCAgQ3NhYmEgT3N6dHJvZ29u
w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGRmaXggZm9y
ICFFTkFCTEUoSU5TUEVDVE9SKSBidWlsZHMgYWZ0ZXIgcjE3ODIwMS4KZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50RGVzY2VuZGFudEl0ZXJhdG9yLmggYi9Tb3VyY2UvV2Vi
Q29yZS9kb20vRWxlbWVudERlc2NlbmRhbnRJdGVyYXRvci5oCmluZGV4IGJkNzAzY2EuLjc1OGU0
MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50RGVzY2VuZGFudEl0ZXJh
dG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnREZXNjZW5kYW50SXRlcmF0b3Iu
aApAQCAtNDksNyArNDksNyBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgRWxlbWVudCogbV9j
dXJyZW50OwotICAgIFZlY3RvcjxFbGVtZW50KiwgMTYsIFVuc2FmZVZlY3Rvck92ZXJmbG93PiBt
X2FuY2VzdG9yU2libGluZ1N0YWNrOworICAgIFZlY3RvcjxFbGVtZW50KiwgMTY+IG1fYW5jZXN0
b3JTaWJsaW5nU3RhY2s7CiAKICNpZiAhQVNTRVJUX0RJU0FCTEVECiAgICAgRWxlbWVudEl0ZXJh
dG9yQXNzZXJ0aW9ucyBtX2Fzc2VydGlvbnM7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>