140330 2015-01-09 18:52:20 -0800 CTTE: GeolocationController always has a client. 2015-01-09 19:53:59 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling benjamin commit-queue oldest_to_newest 1060371 0 kling 2015-01-09 18:52:20 -0800 Patch forthcoming. 1060372 1 244399 kling 2015-01-09 18:53:12 -0800 Created attachment 244399 Patch 1060376 2 244399 commit-queue 2015-01-09 19:53:55 -0800 Comment on attachment 244399 Patch Clearing flags on attachment: 244399 Committed r178233: <http://trac.webkit.org/changeset/178233> 1060377 3 commit-queue 2015-01-09 19:53:59 -0800 All reviewed patches have been landed. Closing bug. 244399 2015-01-09 18:53:12 -0800 2015-01-09 19:53:55 -0800 Patch bug-140330.diff text/plain 6697 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzOGUwMTQxYS4uZGY1YTg4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDE1LTAxLTA5ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAg ICAgICBDVFRFOiBHZW9sb2NhdGlvbkNvbnRyb2xsZXIgYWx3YXlzIGhhcyBhIGNsaWVudC4KKyAg ICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0MDMzMD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgR2VvbG9jYXRpb25Db250cm9sbGVy OjptX2NsaWVudCB0byBiZSBhIHJlZmVyZW5jZSBhbmQgcmVtb3ZlCisgICAgICAgIGEgd2hvbGUg YnVuY2ggb2YgdW5uZWNlc3NhcnkgbnVsbCBjaGVja3MuCisKKyAgICAgICAgKiBNb2R1bGVzL2dl b2xvY2F0aW9uL0dlb2xvY2F0aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH ZW9sb2NhdGlvbkNvbnRyb2xsZXI6Okdlb2xvY2F0aW9uQ29udHJvbGxlcik6CisgICAgICAgIChX ZWJDb3JlOjpHZW9sb2NhdGlvbkNvbnRyb2xsZXI6On5HZW9sb2NhdGlvbkNvbnRyb2xsZXIpOgor ICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb25Db250cm9sbGVyOjphZGRPYnNlcnZlcik6Cisg ICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbkNvbnRyb2xsZXI6OnJlbW92ZU9ic2VydmVyKToK KyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0aW9uQ29udHJvbGxlcjo6cmVxdWVzdFBlcm1pc3Np b24pOgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb25Db250cm9sbGVyOjpjYW5jZWxQZXJt aXNzaW9uUmVxdWVzdCk6CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbkNvbnRyb2xsZXI6 Omxhc3RQb3NpdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbkNvbnRyb2xsZXI6 OnZpZXdTdGF0ZURpZENoYW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpwcm92aWRlR2VvbG9jYXRp b25Ubyk6CisgICAgICAgICogTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbkNvbnRyb2xs ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0aW9uQ29udHJvbGxlcjo6Y2xpZW50KToK KwogMjAxNS0wMS0wOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBtb3JlIHdvcmtlciBkYXRhYmFzZSBjb2RlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xvY2F0aW9uQ29udHJvbGxlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xvY2F0aW9uQ29udHJvbGxl ci5jcHAKaW5kZXggZjY5OTI2Yi4uYzZlYzJlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9jYXRpb25Db250cm9sbGVyLmNwcApA QCAtMzQsNyArMzQsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLUdlb2xvY2F0aW9uQ29u dHJvbGxlcjo6R2VvbG9jYXRpb25Db250cm9sbGVyKFBhZ2UmIHBhZ2UsIEdlb2xvY2F0aW9uQ2xp ZW50KiBjbGllbnQpCitHZW9sb2NhdGlvbkNvbnRyb2xsZXI6Okdlb2xvY2F0aW9uQ29udHJvbGxl cihQYWdlJiBwYWdlLCBHZW9sb2NhdGlvbkNsaWVudCYgY2xpZW50KQogICAgIDogbV9wYWdlKHBh Z2UpCiAgICAgLCBtX2NsaWVudChjbGllbnQpCiB7CkBAIC00OSw4ICs0OSw3IEBAIEdlb2xvY2F0 aW9uQ29udHJvbGxlcjo6fkdlb2xvY2F0aW9uQ29udHJvbGxlcigpCiAgICAgLy8gd2UgYXJlIHN1 cHBsZW1lbnQgb2YgdGhlIFBhZ2UsIGFuZCBvdXIgZGVzdHJ1Y3RvciBnZXR0aW5nIGNhbGxlZCBt ZWFucyB0aGUgcGFnZSBpcyBiZWluZwogICAgIC8vIHRvcm4gZG93bi4KIAotICAgIGlmIChtX2Ns aWVudCkKLSAgICAgICAgbV9jbGllbnQtPmdlb2xvY2F0aW9uRGVzdHJveWVkKCk7CisgICAgbV9j bGllbnQuZ2VvbG9jYXRpb25EZXN0cm95ZWQoKTsKIH0KIAogdm9pZCBHZW9sb2NhdGlvbkNvbnRy b2xsZXI6OmFkZE9ic2VydmVyKEdlb2xvY2F0aW9uKiBvYnNlcnZlciwgYm9vbCBlbmFibGVIaWdo QWNjdXJhY3kpCkBAIC02MiwxMiArNjEsMTAgQEAgdm9pZCBHZW9sb2NhdGlvbkNvbnRyb2xsZXI6 OmFkZE9ic2VydmVyKEdlb2xvY2F0aW9uKiBvYnNlcnZlciwgYm9vbCBlbmFibGVIaWdoQWMKICAg ICBpZiAoZW5hYmxlSGlnaEFjY3VyYWN5KQogICAgICAgICBtX2hpZ2hBY2N1cmFjeU9ic2VydmVy cy5hZGQob2JzZXJ2ZXIpOwogCi0gICAgaWYgKG1fY2xpZW50KSB7ICAgICAgICAKLSAgICAgICAg aWYgKGVuYWJsZUhpZ2hBY2N1cmFjeSkKLSAgICAgICAgICAgIG1fY2xpZW50LT5zZXRFbmFibGVI aWdoQWNjdXJhY3kodHJ1ZSk7Ci0gICAgICAgIGlmICh3YXNFbXB0eSkKLSAgICAgICAgICAgIG1f Y2xpZW50LT5zdGFydFVwZGF0aW5nKCk7Ci0gICAgfQorICAgIGlmIChlbmFibGVIaWdoQWNjdXJh Y3kpCisgICAgICAgIG1fY2xpZW50LnNldEVuYWJsZUhpZ2hBY2N1cmFjeSh0cnVlKTsKKyAgICBp ZiAod2FzRW1wdHkpCisgICAgICAgIG1fY2xpZW50LnN0YXJ0VXBkYXRpbmcoKTsKIH0KIAogdm9p ZCBHZW9sb2NhdGlvbkNvbnRyb2xsZXI6OnJlbW92ZU9ic2VydmVyKEdlb2xvY2F0aW9uKiBvYnNl cnZlcikKQEAgLTc4LDEyICs3NSwxMCBAQCB2b2lkIEdlb2xvY2F0aW9uQ29udHJvbGxlcjo6cmVt b3ZlT2JzZXJ2ZXIoR2VvbG9jYXRpb24qIG9ic2VydmVyKQogICAgIG1fb2JzZXJ2ZXJzLnJlbW92 ZShvYnNlcnZlcik7CiAgICAgbV9oaWdoQWNjdXJhY3lPYnNlcnZlcnMucmVtb3ZlKG9ic2VydmVy KTsKIAotICAgIGlmIChtX2NsaWVudCkgewotICAgICAgICBpZiAobV9vYnNlcnZlcnMuaXNFbXB0 eSgpKQotICAgICAgICAgICAgbV9jbGllbnQtPnN0b3BVcGRhdGluZygpOwotICAgICAgICBlbHNl IGlmIChtX2hpZ2hBY2N1cmFjeU9ic2VydmVycy5pc0VtcHR5KCkpCi0gICAgICAgICAgICBtX2Ns aWVudC0+c2V0RW5hYmxlSGlnaEFjY3VyYWN5KGZhbHNlKTsKLSAgICB9CisgICAgaWYgKG1fb2Jz ZXJ2ZXJzLmlzRW1wdHkoKSkKKyAgICAgICAgbV9jbGllbnQuc3RvcFVwZGF0aW5nKCk7CisgICAg ZWxzZSBpZiAobV9oaWdoQWNjdXJhY3lPYnNlcnZlcnMuaXNFbXB0eSgpKQorICAgICAgICBtX2Ns aWVudC5zZXRFbmFibGVIaWdoQWNjdXJhY3koZmFsc2UpOwogfQogCiB2b2lkIEdlb2xvY2F0aW9u Q29udHJvbGxlcjo6cmVxdWVzdFBlcm1pc3Npb24oR2VvbG9jYXRpb24qIGdlb2xvY2F0aW9uKQpA QCAtOTMsOCArODgsNyBAQCB2b2lkIEdlb2xvY2F0aW9uQ29udHJvbGxlcjo6cmVxdWVzdFBlcm1p c3Npb24oR2VvbG9jYXRpb24qIGdlb2xvY2F0aW9uKQogICAgICAgICByZXR1cm47CiAgICAgfQog Ci0gICAgaWYgKG1fY2xpZW50KQotICAgICAgICBtX2NsaWVudC0+cmVxdWVzdFBlcm1pc3Npb24o Z2VvbG9jYXRpb24pOworICAgIG1fY2xpZW50LnJlcXVlc3RQZXJtaXNzaW9uKGdlb2xvY2F0aW9u KTsKIH0KIAogdm9pZCBHZW9sb2NhdGlvbkNvbnRyb2xsZXI6OmNhbmNlbFBlcm1pc3Npb25SZXF1 ZXN0KEdlb2xvY2F0aW9uKiBnZW9sb2NhdGlvbikKQEAgLTEwMiw4ICs5Niw3IEBAIHZvaWQgR2Vv bG9jYXRpb25Db250cm9sbGVyOjpjYW5jZWxQZXJtaXNzaW9uUmVxdWVzdChHZW9sb2NhdGlvbiog Z2VvbG9jYXRpb24pCiAgICAgaWYgKG1fcGVuZGVkUGVybWlzc2lvblJlcXVlc3QucmVtb3ZlKGdl b2xvY2F0aW9uKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG1fY2xpZW50KQotICAgICAg ICBtX2NsaWVudC0+Y2FuY2VsUGVybWlzc2lvblJlcXVlc3QoZ2VvbG9jYXRpb24pOworICAgIG1f Y2xpZW50LmNhbmNlbFBlcm1pc3Npb25SZXF1ZXN0KGdlb2xvY2F0aW9uKTsKIH0KIAogdm9pZCBH ZW9sb2NhdGlvbkNvbnRyb2xsZXI6OnBvc2l0aW9uQ2hhbmdlZChHZW9sb2NhdGlvblBvc2l0aW9u KiBwb3NpdGlvbikKQEAgLTEyOCwxMCArMTIxLDcgQEAgR2VvbG9jYXRpb25Qb3NpdGlvbiogR2Vv bG9jYXRpb25Db250cm9sbGVyOjpsYXN0UG9zaXRpb24oKQogICAgIGlmIChtX2xhc3RQb3NpdGlv bi5nZXQoKSkKICAgICAgICAgcmV0dXJuIG1fbGFzdFBvc2l0aW9uLmdldCgpOwogCi0gICAgaWYg KCFtX2NsaWVudCkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICByZXR1cm4gbV9jbGllbnQtPmxh c3RQb3NpdGlvbigpOworICAgIHJldHVybiBtX2NsaWVudC5sYXN0UG9zaXRpb24oKTsKIH0KIAog dm9pZCBHZW9sb2NhdGlvbkNvbnRyb2xsZXI6OnZpZXdTdGF0ZURpZENoYW5nZShWaWV3U3RhdGU6 OkZsYWdzLCBWaWV3U3RhdGU6OkZsYWdzKQpAQCAtMTQxLDcgKzEzMSw3IEBAIHZvaWQgR2VvbG9j YXRpb25Db250cm9sbGVyOjp2aWV3U3RhdGVEaWRDaGFuZ2UoVmlld1N0YXRlOjpGbGFncywgVmll d1N0YXRlOjpGbGFnCiAKICAgICBIYXNoU2V0PFJlZlB0cjxHZW9sb2NhdGlvbj4+IHBlbmRlZFBl cm1pc3Npb25SZXF1ZXN0cyA9IFdURjo6bW92ZShtX3BlbmRlZFBlcm1pc3Npb25SZXF1ZXN0KTsK ICAgICBmb3IgKGF1dG8mIHBlcm1pc3Npb25SZXF1ZXN0IDogcGVuZGVkUGVybWlzc2lvblJlcXVl c3RzKQotICAgICAgICBtX2NsaWVudC0+cmVxdWVzdFBlcm1pc3Npb24ocGVybWlzc2lvblJlcXVl c3QuZ2V0KCkpOworICAgICAgICBtX2NsaWVudC5yZXF1ZXN0UGVybWlzc2lvbihwZXJtaXNzaW9u UmVxdWVzdC5nZXQoKSk7CiB9CiAKIGNvbnN0IGNoYXIqIEdlb2xvY2F0aW9uQ29udHJvbGxlcjo6 c3VwcGxlbWVudE5hbWUoKQpAQCAtMTUxLDcgKzE0MSw5IEBAIGNvbnN0IGNoYXIqIEdlb2xvY2F0 aW9uQ29udHJvbGxlcjo6c3VwcGxlbWVudE5hbWUoKQogCiB2b2lkIHByb3ZpZGVHZW9sb2NhdGlv blRvKFBhZ2UqIHBhZ2UsIEdlb2xvY2F0aW9uQ2xpZW50KiBjbGllbnQpCiB7Ci0gICAgU3VwcGxl bWVudDxQYWdlPjo6cHJvdmlkZVRvKHBhZ2UsIEdlb2xvY2F0aW9uQ29udHJvbGxlcjo6c3VwcGxl bWVudE5hbWUoKSwgc3RkOjptYWtlX3VuaXF1ZTxHZW9sb2NhdGlvbkNvbnRyb2xsZXI+KCpwYWdl LCBjbGllbnQpKTsKKyAgICBBU1NFUlQocGFnZSk7CisgICAgQVNTRVJUKGNsaWVudCk7CisgICAg U3VwcGxlbWVudDxQYWdlPjo6cHJvdmlkZVRvKHBhZ2UsIEdlb2xvY2F0aW9uQ29udHJvbGxlcjo6 c3VwcGxlbWVudE5hbWUoKSwgc3RkOjptYWtlX3VuaXF1ZTxHZW9sb2NhdGlvbkNvbnRyb2xsZXI+ KCpwYWdlLCAqY2xpZW50KSk7CiB9CiAgICAgCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xvY2F0aW9uQ29u dHJvbGxlci5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlv bkNvbnRyb2xsZXIuaAppbmRleCAyNDZlODkyLi41NjQwNzU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xvY2F0aW9uQ29udHJvbGxlci5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9jYXRpb25Db250cm9sbGVy LmgKQEAgLTQ1LDcgKzQ1LDcgQEAgY2xhc3MgUGFnZTsKIGNsYXNzIEdlb2xvY2F0aW9uQ29udHJv bGxlciA6IHB1YmxpYyBTdXBwbGVtZW50PFBhZ2U+LCBwcml2YXRlIFZpZXdTdGF0ZUNoYW5nZU9i c2VydmVyIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShHZW9sb2NhdGlvbkNvbnRyb2xsZXIp OwogcHVibGljOgotICAgIGV4cGxpY2l0IEdlb2xvY2F0aW9uQ29udHJvbGxlcihQYWdlJiwgR2Vv bG9jYXRpb25DbGllbnQqKTsKKyAgICBHZW9sb2NhdGlvbkNvbnRyb2xsZXIoUGFnZSYsIEdlb2xv Y2F0aW9uQ2xpZW50Jik7CiAgICAgfkdlb2xvY2F0aW9uQ29udHJvbGxlcigpOwogCiAgICAgdm9p ZCBhZGRPYnNlcnZlcihHZW9sb2NhdGlvbiosIGJvb2wgZW5hYmxlSGlnaEFjY3VyYWN5KTsKQEAg LTU5LDE0ICs1OSwxNCBAQCBwdWJsaWM6CiAKICAgICBHZW9sb2NhdGlvblBvc2l0aW9uKiBsYXN0 UG9zaXRpb24oKTsKIAotICAgIEdlb2xvY2F0aW9uQ2xpZW50KiBjbGllbnQoKSB7IHJldHVybiBt X2NsaWVudDsgfQorICAgIEdlb2xvY2F0aW9uQ2xpZW50JiBjbGllbnQoKSB7IHJldHVybiBtX2Ns aWVudDsgfQogCiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIGNvbnN0IGNoYXIqIHN1cHBsZW1l bnROYW1lKCk7CiAgICAgc3RhdGljIEdlb2xvY2F0aW9uQ29udHJvbGxlciogZnJvbShQYWdlKiBw YWdlKSB7IHJldHVybiBzdGF0aWNfY2FzdDxHZW9sb2NhdGlvbkNvbnRyb2xsZXIqPihTdXBwbGVt ZW50PFBhZ2U+Ojpmcm9tKHBhZ2UsIHN1cHBsZW1lbnROYW1lKCkpKTsgfQogCiBwcml2YXRlOgog ICAgIFBhZ2UmIG1fcGFnZTsKLSAgICBHZW9sb2NhdGlvbkNsaWVudCogbV9jbGllbnQ7CisgICAg R2VvbG9jYXRpb25DbGllbnQmIG1fY2xpZW50OwogCiAgICAgdmlydHVhbCB2b2lkIHZpZXdTdGF0 ZURpZENoYW5nZShWaWV3U3RhdGU6OkZsYWdzIG9sZFZpZXdTdGF0ZSwgVmlld1N0YXRlOjpGbGFn cyBuZXdWaWV3U3RhdGUpIG92ZXJyaWRlOwogCg==